From 710028d3a4400d1ab24a5b8a08cafdb0359dbafc Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Thu, 7 Apr 2011 13:03:06 -0400 Subject: [PATCH] codereview: drop Author: line on self-clpatch Right now if a Go developer makes a patch on one machine and then clpatches it onto another machine, changes subsequently made to the description are kept only locally, under the assumption that you are running clpatch because someone else wrote the CL, so you don't have permission to update the web. This change makes clpatch discard the "this was a clpatch" information from the metadata when you clpatch your own CLs from one machine to another. This should eliminate some confusion (for example in CL 4314054) but will no doubt introduce other confusion. R=golang-dev, r2 CC=golang-dev https://golang.org/cl/4387041 --- lib/codereview/codereview.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index efb1a617737..bd9a179f82e 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -1787,8 +1787,10 @@ def DownloadCL(ui, repo, clname): email = match.group(1) # Print warning if email is not in CONTRIBUTORS file. - FindContributor(ui, repo, email) - cl.copied_from = email + him = FindContributor(ui, repo, email) + me = FindContributor(ui, repo, None) + if him != me: + cl.copied_from = email return cl, diffdata, ""