qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-16 21:34:52 -07:00
Code Releases Activity

runtime: disable windowed Smhasher test on 32-bit systems

Browse Source 
This test tends to be flaky on 32-bit systems.
There's not enough bits in the hash output, so we
expect a nontrivial number of collisions, and it is
often quite a bit higher than expected.

Fixes #43130

Change-Id: If35413b7c45eed778a08b834dacf98009ceca840
Reviewed-on: https://go-review.googlesource.com/c/go/+/402456
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Keith Randall <khr@google.com>
This commit is contained in:
Keith Randall 2022-04-26 16:32:07 -07:00 committed by Keith Randall
parent d29f5247b8
commit 68b655f2b9
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/runtime/hash_test.go
View File

@ -525,6 +525,13 @@ func windowed(t *testing.T, k Key) {
if GOARCH == "wasm" { if GOARCH == "wasm" {
t.Skip("Too slow on wasm") t.Skip("Too slow on wasm")
} }
if PtrSize == 4 {
// This test tends to be flaky on 32-bit systems.
// There's not enough bits in the hash output, so we
// expect a nontrivial number of collisions, and it is
// often quite a bit higher than expected. See issue 43130.
t.Skip("Flaky on 32-bit systems")
}
if testing.Short() { if testing.Short() {
t.Skip("Skipping in short mode") t.Skip("Skipping in short mode")
} }