From 68b655f2b91c4407ccd781271039857e0d332989 Mon Sep 17 00:00:00 2001 From: Keith Randall Date: Tue, 26 Apr 2022 16:32:07 -0700 Subject: [PATCH] runtime: disable windowed Smhasher test on 32-bit systems This test tends to be flaky on 32-bit systems. There's not enough bits in the hash output, so we expect a nontrivial number of collisions, and it is often quite a bit higher than expected. Fixes #43130 Change-Id: If35413b7c45eed778a08b834dacf98009ceca840 Reviewed-on: https://go-review.googlesource.com/c/go/+/402456 Run-TryBot: Keith Randall TryBot-Result: Gopher Robot Reviewed-by: Ian Lance Taylor Reviewed-by: Keith Randall --- src/runtime/hash_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/runtime/hash_test.go b/src/runtime/hash_test.go index cf56c57a5fd..e72600641f2 100644 --- a/src/runtime/hash_test.go +++ b/src/runtime/hash_test.go @@ -525,6 +525,13 @@ func windowed(t *testing.T, k Key) { if GOARCH == "wasm" { t.Skip("Too slow on wasm") } + if PtrSize == 4 { + // This test tends to be flaky on 32-bit systems. + // There's not enough bits in the hash output, so we + // expect a nontrivial number of collisions, and it is + // often quite a bit higher than expected. See issue 43130. + t.Skip("Flaky on 32-bit systems") + } if testing.Short() { t.Skip("Skipping in short mode") }