qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 18:34:51 -07:00
Code Releases Activity

codereview: warn about 'hg upload' not uploading

Browse Source 
This seems to be what causes the 'chunk mismatch' errors.
I don't know why the server tells us there's nothing to upload,
but at the least we can warn that it did, so that the user
will try again.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/62840043
This commit is contained in:
Russ Cox 2014-02-13 05:06:46 +00:00
parent 37bf90024b
commit 673917f878
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/codereview/codereview.py
View File

@ -367,6 +367,8 @@ class CL(object):
msg = lines[0] msg = lines[0]
patchset = lines[1].strip() patchset = lines[1].strip()
patches = [x.split(" ", 1) for x in lines[2:]] patches = [x.split(" ", 1) for x in lines[2:]]
else:
print >>sys.stderr, "Server says there is nothing to upload (probably wrong):\n" + msg
if response_body.startswith("Issue updated.") and quiet: if response_body.startswith("Issue updated.") and quiet:
pass pass
else: else: