From 673917f87879e32e81e55b3cc5fa027a5c8fce0a Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Thu, 13 Feb 2014 05:06:46 +0000 Subject: [PATCH] codereview: warn about 'hg upload' not uploading This seems to be what causes the 'chunk mismatch' errors. I don't know why the server tells us there's nothing to upload, but at the least we can warn that it did, so that the user will try again. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/62840043 --- lib/codereview/codereview.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index d171ef3e991..18ecc141d2c 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -367,6 +367,8 @@ class CL(object): msg = lines[0] patchset = lines[1].strip() patches = [x.split(" ", 1) for x in lines[2:]] + else: + print >>sys.stderr, "Server says there is nothing to upload (probably wrong):\n" + msg if response_body.startswith("Issue updated.") and quiet: pass else: