mirror of
https://github.com/golang/go
synced 2024-09-30 10:18:32 -06:00
cmd/compile: fix debug info generation for loads from Phis
Apparently a LoadReg can take a Phi as its argument. The Phi has names in the NamedValue table, so just read the Load's names from the Phi. The example given, XORKeyStream in chacha20, is pretty complicated so I didn't try to actually debug it and verify that the results are right. But the debug logging looks reasonable, with the right names in the right registers at the right times. Fixes #25404 Change-Id: I2c3183dcfb033948556d6805bd66c22c0b45625c Reviewed-on: https://go-review.googlesource.com/114008 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com>
This commit is contained in:
parent
391a963bba
commit
65c365bf0f
@ -469,7 +469,7 @@ func (state *debugState) liveness() []*BlockDebug {
|
||||
source = v.Args[0]
|
||||
case OpLoadReg:
|
||||
switch a := v.Args[0]; a.Op {
|
||||
case OpArg:
|
||||
case OpArg, OpPhi:
|
||||
source = a
|
||||
case OpStoreReg:
|
||||
source = a.Args[0]
|
||||
|
Loading…
Reference in New Issue
Block a user