qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-27 02:01:23 -07:00
Code Releases Activity

cmd/dist: disable misc/cgo/testsanitizers on ppc64le

Browse Source 
A while back in this release the sanitizer tests were enabled
for ppc64le, where previously they were never run. This
uncovered some errors in these tests on ppc64le. One linker
fix was made but there are still bugs in how tsan is made to
work within the code, especially in how signals are enabled
with cgo.

Some attempts were made to make this work but intermittent
failures continue to happen with the Trybots so I am just
going to disable this test for ppc64le within cmd/dist.

Updates #45040

Change-Id: I5392368ccecd4079ef568d0c645c9f7c94016d99
Reviewed-on: https://go-review.googlesource.com/c/go/+/315430
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Cherry Zhang <cherryyz@google.com>
This commit is contained in:
Lynn Boger 2021-04-30 10:21:18 -05:00
parent 2c9f5a1da8
commit 30674ae91b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/cmd/dist/test.go vendored
View File

@ -749,8 +749,9 @@ func (t *tester) registerTests() {
if gohostos == "linux" && goarch == "amd64" { if gohostos == "linux" && goarch == "amd64" {
t.registerTest("testasan", "../misc/cgo/testasan", "go", "run", ".") t.registerTest("testasan", "../misc/cgo/testasan", "go", "run", ".")
} }
if goos == "linux" { if goos == "linux" && goarch != "ppc64le" {
// because syscall.SysProcAttri struct used in misc/cgo/testsanitizers is only built on linux. // because syscall.SysProcAttri struct used in misc/cgo/testsanitizers is only built on linux.
// Some inconsistent failures happen on ppc64le so disable for now.
t.registerHostTest("testsanitizers", "../misc/cgo/testsanitizers", "misc/cgo/testsanitizers", ".") t.registerHostTest("testsanitizers", "../misc/cgo/testsanitizers", "misc/cgo/testsanitizers", ".")
} }
if t.hasBash() && goos != "android" && !t.iOS() && gohostos != "windows" { if t.hasBash() && goos != "android" && !t.iOS() && gohostos != "windows" {