From 30674ae91b7fa20b9f68e1e79d8d7cd8ead495cd Mon Sep 17 00:00:00 2001 From: Lynn Boger Date: Fri, 30 Apr 2021 10:21:18 -0500 Subject: [PATCH] cmd/dist: disable misc/cgo/testsanitizers on ppc64le A while back in this release the sanitizer tests were enabled for ppc64le, where previously they were never run. This uncovered some errors in these tests on ppc64le. One linker fix was made but there are still bugs in how tsan is made to work within the code, especially in how signals are enabled with cgo. Some attempts were made to make this work but intermittent failures continue to happen with the Trybots so I am just going to disable this test for ppc64le within cmd/dist. Updates #45040 Change-Id: I5392368ccecd4079ef568d0c645c9f7c94016d99 Reviewed-on: https://go-review.googlesource.com/c/go/+/315430 Run-TryBot: Lynn Boger TryBot-Result: Go Bot Reviewed-by: Ian Lance Taylor Trust: Cherry Zhang --- src/cmd/dist/test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 8b1ec458ed8..33fabd35541 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -749,8 +749,9 @@ func (t *tester) registerTests() { if gohostos == "linux" && goarch == "amd64" { t.registerTest("testasan", "../misc/cgo/testasan", "go", "run", ".") } - if goos == "linux" { + if goos == "linux" && goarch != "ppc64le" { // because syscall.SysProcAttri struct used in misc/cgo/testsanitizers is only built on linux. + // Some inconsistent failures happen on ppc64le so disable for now. t.registerHostTest("testsanitizers", "../misc/cgo/testsanitizers", "misc/cgo/testsanitizers", ".") } if t.hasBash() && goos != "android" && !t.iOS() && gohostos != "windows" {