qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 03:04:44 -07:00
Code Releases Activity

cmd/link/internal/ld: ensure mach-o debug symbols are visible to App Store

Browse Source 
Passing test that shows Apple's symbols utility can now read
DWARF data in go.o, after the fix in CL174538

Updates #31022 #22716 #31459

Change-Id: I56c3517ad6d0a9f39537182f63cef56bb198aa83
Reviewed-on: https://go-review.googlesource.com/c/go/+/170451
Reviewed-by: Than McIntosh <thanm@google.com>
This commit is contained in:
Aman Gupta 2019-04-03 01:49:24 -07:00 committed by Than McIntosh
parent a0c96a9261
commit 2ae793ed48
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/link/dwarf_test.go
View File

@ -98,6 +98,8 @@ func testDWARF(t *testing.T, buildmode string, expectDWARF bool, env ...string)
if bytes.HasPrefix(out, []byte("Unable to find file")) {
// This failure will cause the App Store to reject our binaries.
t.Fatalf("symbols %v: failed to parse file", filepath.Base(exe))
} else if bytes.Contains(out, []byte(", Empty]")) {
t.Fatalf("symbols %v: parsed as empty", filepath.Base(exe))
}
}
}