From 2ae793ed48eaef584e3cdcd7820d5bb891ab1a5f Mon Sep 17 00:00:00 2001 From: Aman Gupta Date: Wed, 3 Apr 2019 01:49:24 -0700 Subject: [PATCH] cmd/link/internal/ld: ensure mach-o debug symbols are visible to App Store Passing test that shows Apple's symbols utility can now read DWARF data in go.o, after the fix in CL174538 Updates #31022 #22716 #31459 Change-Id: I56c3517ad6d0a9f39537182f63cef56bb198aa83 Reviewed-on: https://go-review.googlesource.com/c/go/+/170451 Reviewed-by: Than McIntosh --- src/cmd/link/dwarf_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cmd/link/dwarf_test.go b/src/cmd/link/dwarf_test.go index 9c411ff1b83..897b2fc8817 100644 --- a/src/cmd/link/dwarf_test.go +++ b/src/cmd/link/dwarf_test.go @@ -98,6 +98,8 @@ func testDWARF(t *testing.T, buildmode string, expectDWARF bool, env ...string) if bytes.HasPrefix(out, []byte("Unable to find file")) { // This failure will cause the App Store to reject our binaries. t.Fatalf("symbols %v: failed to parse file", filepath.Base(exe)) + } else if bytes.Contains(out, []byte(", Empty]")) { + t.Fatalf("symbols %v: parsed as empty", filepath.Base(exe)) } } }