2018-11-07 13:21:31 -07:00
|
|
|
// Copyright 2018 The Go Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
2018-11-05 19:23:02 -07:00
|
|
|
package lsp
|
|
|
|
|
|
|
|
import (
|
2019-04-04 17:33:08 -06:00
|
|
|
"context"
|
2018-11-20 14:05:10 -07:00
|
|
|
"fmt"
|
2018-11-07 18:57:08 -07:00
|
|
|
"sort"
|
2018-11-05 19:23:02 -07:00
|
|
|
|
|
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
|
|
"golang.org/x/tools/internal/lsp/source"
|
2019-04-04 17:33:08 -06:00
|
|
|
"golang.org/x/tools/internal/span"
|
2019-08-13 13:07:39 -06:00
|
|
|
"golang.org/x/tools/internal/telemetry/log"
|
|
|
|
"golang.org/x/tools/internal/telemetry/tag"
|
2018-11-05 19:23:02 -07:00
|
|
|
)
|
|
|
|
|
2019-04-04 17:33:08 -06:00
|
|
|
func (s *Server) completion(ctx context.Context, params *protocol.CompletionParams) (*protocol.CompletionList, error) {
|
|
|
|
uri := span.NewURI(params.TextDocument.URI)
|
2019-05-15 10:24:49 -06:00
|
|
|
view := s.session.ViewOf(uri)
|
2019-08-16 11:49:17 -06:00
|
|
|
f, err := getGoFile(ctx, view, uri)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
2019-08-16 15:05:40 -06:00
|
|
|
candidates, surrounding, err := source.Completion(ctx, view, f, params.Position, source.CompletionOptions{
|
2019-08-27 17:41:48 -06:00
|
|
|
WantDeepCompletion: !s.disableDeepCompletion,
|
|
|
|
WantFuzzyMatching: !s.disableFuzzyMatching,
|
2019-08-29 00:43:58 -06:00
|
|
|
NoDocumentation: !s.wantCompletionDocumentation,
|
2019-08-15 09:35:00 -06:00
|
|
|
WantFullDocumentation: s.hoverKind == fullDocumentation,
|
2019-08-14 15:25:47 -06:00
|
|
|
WantUnimported: s.wantUnimportedCompletions,
|
2019-06-27 11:50:01 -06:00
|
|
|
})
|
2019-04-04 17:33:08 -06:00
|
|
|
if err != nil {
|
2019-08-16 15:05:40 -06:00
|
|
|
log.Print(ctx, "no completions found", tag.Of("At", params.Position), tag.Of("Failure", err))
|
|
|
|
}
|
|
|
|
if candidates == nil {
|
|
|
|
return &protocol.CompletionList{
|
|
|
|
Items: []protocol.CompletionItem{},
|
|
|
|
}, nil
|
2019-05-13 14:49:29 -06:00
|
|
|
}
|
2019-08-16 15:05:40 -06:00
|
|
|
// We might need to adjust the position to account for the prefix.
|
|
|
|
rng, err := surrounding.Range()
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
// Sort the candidates by score, since that is not supported by LSP yet.
|
|
|
|
sort.SliceStable(candidates, func(i, j int) bool {
|
|
|
|
return candidates[i].Score > candidates[j].Score
|
|
|
|
})
|
2019-04-04 17:33:08 -06:00
|
|
|
return &protocol.CompletionList{
|
internal/lsp: add fuzzy completion matching
Make use of the existing fuzzy matcher to perform server side fuzzy
completion matching. Previously the server did exact prefix matching
for completion candidates and left fancy filtering to the
client. Having the server do fuzzy matching has two main benefits:
- Deep completions now update as you type. The completion candidates
returned to the client are marked "incomplete", causing the client
to refresh the candidates after every keystroke. This lets the
server pick the most relevant set of deep completion candidates.
- All editors get fuzzy matching for free. VSCode has fuzzy matching
out of the box, but some editors either don't provide it, or it can
be difficult to set up.
I modified the fuzzy matcher to allow matches where the input doesn't
match the final segment of the candidate. For example, previously "ab"
would not match "abc.def" because the "b" in "ab" did not match the
final segment "def". I can see how this is useful when the text
matching happens in a vacuum and candidate's final segment is the most
specific part. But, in our case, we have various other methods to
order candidates, so we don't want to exclude them just because the
final segment doesn't match. For example, if we know our candidate
needs to be type "context.Context" and "foo.ctx" is of the right type,
we want to suggest "foo.ctx" as soon as the user starts inputting
"foo", even though "foo" doesn't match "ctx" at all.
Note that fuzzy matching is behind the "useDeepCompletions" config
flag for the time being.
Change-Id: Ic7674f0cf885af770c30daef472f2e3c5ac4db78
Reviewed-on: https://go-review.googlesource.com/c/tools/+/190099
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-08-13 14:45:19 -06:00
|
|
|
// When using deep completions/fuzzy matching, report results as incomplete so
|
|
|
|
// client fetches updated completions after every key stroke.
|
2019-08-27 17:41:48 -06:00
|
|
|
IsIncomplete: !s.disableDeepCompletion,
|
2019-08-16 15:05:40 -06:00
|
|
|
Items: s.toProtocolCompletionItems(candidates, rng),
|
2019-04-04 17:33:08 -06:00
|
|
|
}, nil
|
|
|
|
}
|
|
|
|
|
2019-08-16 15:05:40 -06:00
|
|
|
func (s *Server) toProtocolCompletionItems(candidates []source.CompletionItem, rng protocol.Range) []protocol.CompletionItem {
|
internal/lsp: add fuzzy completion matching
Make use of the existing fuzzy matcher to perform server side fuzzy
completion matching. Previously the server did exact prefix matching
for completion candidates and left fancy filtering to the
client. Having the server do fuzzy matching has two main benefits:
- Deep completions now update as you type. The completion candidates
returned to the client are marked "incomplete", causing the client
to refresh the candidates after every keystroke. This lets the
server pick the most relevant set of deep completion candidates.
- All editors get fuzzy matching for free. VSCode has fuzzy matching
out of the box, but some editors either don't provide it, or it can
be difficult to set up.
I modified the fuzzy matcher to allow matches where the input doesn't
match the final segment of the candidate. For example, previously "ab"
would not match "abc.def" because the "b" in "ab" did not match the
final segment "def". I can see how this is useful when the text
matching happens in a vacuum and candidate's final segment is the most
specific part. But, in our case, we have various other methods to
order candidates, so we don't want to exclude them just because the
final segment doesn't match. For example, if we know our candidate
needs to be type "context.Context" and "foo.ctx" is of the right type,
we want to suggest "foo.ctx" as soon as the user starts inputting
"foo", even though "foo" doesn't match "ctx" at all.
Note that fuzzy matching is behind the "useDeepCompletions" config
flag for the time being.
Change-Id: Ic7674f0cf885af770c30daef472f2e3c5ac4db78
Reviewed-on: https://go-review.googlesource.com/c/tools/+/190099
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-08-13 14:45:19 -06:00
|
|
|
var (
|
|
|
|
items = make([]protocol.CompletionItem, 0, len(candidates))
|
|
|
|
numDeepCompletionsSeen int
|
|
|
|
)
|
2018-12-10 22:52:31 -07:00
|
|
|
for i, candidate := range candidates {
|
2019-06-27 11:50:01 -06:00
|
|
|
// Limit the number of deep completions to not overwhelm the user in cases
|
|
|
|
// with dozens of deep completion matches.
|
|
|
|
if candidate.Depth > 0 {
|
2019-08-27 17:41:48 -06:00
|
|
|
if s.disableDeepCompletion {
|
2019-06-27 11:50:01 -06:00
|
|
|
continue
|
|
|
|
}
|
2019-08-16 10:45:09 -06:00
|
|
|
if numDeepCompletionsSeen >= source.MaxDeepCompletions {
|
2019-06-27 11:50:01 -06:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
numDeepCompletionsSeen++
|
|
|
|
}
|
2019-04-29 17:47:54 -06:00
|
|
|
insertText := candidate.InsertText
|
2019-07-02 15:31:31 -06:00
|
|
|
if s.insertTextFormat == protocol.SnippetTextFormat {
|
|
|
|
insertText = candidate.Snippet(s.usePlaceholders)
|
2019-04-28 21:19:54 -06:00
|
|
|
}
|
2018-12-10 22:52:31 -07:00
|
|
|
item := protocol.CompletionItem{
|
2019-03-13 12:25:56 -06:00
|
|
|
Label: candidate.Label,
|
|
|
|
Detail: candidate.Detail,
|
|
|
|
Kind: toProtocolCompletionItemKind(candidate.Kind),
|
2018-11-21 21:51:01 -07:00
|
|
|
TextEdit: &protocol.TextEdit{
|
|
|
|
NewText: insertText,
|
2019-08-16 15:05:40 -06:00
|
|
|
Range: rng,
|
2018-11-21 21:51:01 -07:00
|
|
|
},
|
2019-08-14 15:25:47 -06:00
|
|
|
InsertTextFormat: s.insertTextFormat,
|
2019-08-16 15:05:40 -06:00
|
|
|
AdditionalTextEdits: candidate.AdditionalTextEdits,
|
2018-11-21 21:51:01 -07:00
|
|
|
// This is a hack so that the client sorts completion results in the order
|
|
|
|
// according to their score. This can be removed upon the resolution of
|
|
|
|
// https://github.com/Microsoft/language-server-protocol/issues/348.
|
2019-07-02 15:31:31 -06:00
|
|
|
SortText: fmt.Sprintf("%05d", i),
|
|
|
|
FilterText: candidate.InsertText,
|
|
|
|
Preselect: i == 0,
|
|
|
|
Documentation: candidate.Documentation,
|
2018-11-20 16:18:33 -07:00
|
|
|
}
|
2019-04-17 12:31:17 -06:00
|
|
|
// Trigger signature help for any function or method completion.
|
|
|
|
// This is helpful even if a function does not have parameters,
|
|
|
|
// since we show return types as well.
|
|
|
|
switch item.Kind {
|
|
|
|
case protocol.FunctionCompletion, protocol.MethodCompletion:
|
|
|
|
item.Command = &protocol.Command{
|
|
|
|
Command: "editor.action.triggerParameterHints",
|
|
|
|
}
|
|
|
|
}
|
2018-12-10 22:52:31 -07:00
|
|
|
items = append(items, item)
|
2018-11-07 18:57:08 -07:00
|
|
|
}
|
2018-12-10 22:52:31 -07:00
|
|
|
return items
|
2018-11-07 18:57:08 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
func toProtocolCompletionItemKind(kind source.CompletionItemKind) protocol.CompletionItemKind {
|
|
|
|
switch kind {
|
|
|
|
case source.InterfaceCompletionItem:
|
|
|
|
return protocol.InterfaceCompletion
|
|
|
|
case source.StructCompletionItem:
|
|
|
|
return protocol.StructCompletion
|
|
|
|
case source.TypeCompletionItem:
|
|
|
|
return protocol.TypeParameterCompletion // ??
|
|
|
|
case source.ConstantCompletionItem:
|
|
|
|
return protocol.ConstantCompletion
|
|
|
|
case source.FieldCompletionItem:
|
|
|
|
return protocol.FieldCompletion
|
|
|
|
case source.ParameterCompletionItem, source.VariableCompletionItem:
|
|
|
|
return protocol.VariableCompletion
|
|
|
|
case source.FunctionCompletionItem:
|
|
|
|
return protocol.FunctionCompletion
|
|
|
|
case source.MethodCompletionItem:
|
|
|
|
return protocol.MethodCompletion
|
|
|
|
case source.PackageCompletionItem:
|
|
|
|
return protocol.ModuleCompletion // ??
|
2018-11-05 19:23:02 -07:00
|
|
|
default:
|
2018-11-07 18:57:08 -07:00
|
|
|
return protocol.TextCompletion
|
2018-11-05 19:23:02 -07:00
|
|
|
}
|
2018-11-20 14:05:10 -07:00
|
|
|
}
|