qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-06 12:26:11 -07:00
Code Releases Activity
9d5940d493
go/gopls/integration/govim/Dockerfile

21 lines
1005 B
Docker
Raw Normal View History

gopls/integration: add a first cut of govim integration tests Govim has integration tests that we can leverage to help guard gopls against regressions. Changes have been submitted upstream to facilitate running these tests against a locally built gopls binary (https://github.com/govim/govim/pull/629) This CL adds a Dockerfile to build an image that has a version of govim available and ready for testing. This is then used to create a custom build step in a separate Cloud Build configuration, that builds gopls from source and runs the govim integration tests. A script (run_local.sh) is also added to facilitate running these tests locally. Change-Id: If68eabf9863a1689e29d9d744ff953d94a2b7681 Reviewed-on: https://go-review.googlesource.com/c/tools/+/212018 Reviewed-by: Paul Jolly <paul@myitcv.org.uk> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-12-18 12:55:07 -07:00
# Copyright 2019 The Go Authors. All rights reserved.
# Use of this source code is governed by a BSD-style
# license that can be found in the LICENSE file.
# govim requires a more recent version of vim than is available in most
# distros, so we build from their base image.
gopls/integration/govim: improvements/fixes for run_local.sh With the update to go1.14, run_local.sh runs into the ubuntu mlock issue. Fix this by setting memlock=unlimited. Also make it possible to run docker with sudo, and run -short tests. Change-Id: I8c9e44cd16f0a2a0d77bf28133ad4f111058b5cf Reviewed-on: https://go-review.googlesource.com/c/tools/+/225520 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-03-25 14:14:43 -06:00
FROM govim/govim:latest-vim
gopls/integration: add a first cut of govim integration tests Govim has integration tests that we can leverage to help guard gopls against regressions. Changes have been submitted upstream to facilitate running these tests against a locally built gopls binary (https://github.com/govim/govim/pull/629) This CL adds a Dockerfile to build an image that has a version of govim available and ready for testing. This is then used to create a custom build step in a separate Cloud Build configuration, that builds gopls from source and runs the govim integration tests. A script (run_local.sh) is also added to facilitate running these tests locally. Change-Id: If68eabf9863a1689e29d9d744ff953d94a2b7681 Reviewed-on: https://go-review.googlesource.com/c/tools/+/212018 Reviewed-by: Paul Jolly <paul@myitcv.org.uk> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-12-18 12:55:07 -07:00
gopls/integration/govim: update build steps to capture artifacts Govim integration tests generate a number of artifacts, including both the govim and gopls logs, that can be useful in debugging failures. This change updates our cloud build configuration to capture these artifacts, along with several other minor improvements. Notably artifacts are uploaded to GCS as a separate build step, so that we have the potential to use its granular permission model for sharing these artifacts. Right now, this requires temporarily swallowing the exit code of `go test` so that the build can proceed. Also: - Update govim to a newer version; we still can't use latest as there isn't a tagged version that contains the requisite flag change. - Alter the test harness to run tests from the github.com/govim/govim module root. - Switch use a major version label when referring to the test harness build step, to allow for breaking changes (such as the one made here). - Add a missing copyright header to run_local.sh. - Update run_local.sh to work with the modified harness. - Update documentation accordingly. Change-Id: Ie5ddaf54e775371a36163f98c1beb90c217be931 Reviewed-on: https://go-review.googlesource.com/c/tools/+/214577 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-13 13:22:19 -07:00
# We use a pinned version of govim so that this build is repeatable, and so
# that we're not sensitive to test breakages in govim.
gopls/integration: add a first cut of govim integration tests Govim has integration tests that we can leverage to help guard gopls against regressions. Changes have been submitted upstream to facilitate running these tests against a locally built gopls binary (https://github.com/govim/govim/pull/629) This CL adds a Dockerfile to build an image that has a version of govim available and ready for testing. This is then used to create a custom build step in a separate Cloud Build configuration, that builds gopls from source and runs the govim integration tests. A script (run_local.sh) is also added to facilitate running these tests locally. Change-Id: If68eabf9863a1689e29d9d744ff953d94a2b7681 Reviewed-on: https://go-review.googlesource.com/c/tools/+/212018 Reviewed-by: Paul Jolly <paul@myitcv.org.uk> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-12-18 12:55:07 -07:00
# TODO(findleyr): Once a version of govim has been tagged containing
# https://github.com/govim/govim/pull/629, switch this to @latest.
gopls/integration/govim: switch to latest, and improve artifacts Now that there is a tagged version of govim containing the `-gopls` test flag, we can just use latest to pick up a relatively stable govim, and not have to maintain the govim version. Doing this required changing the way we fetch govim into our test harness: there is now the assumption that /src/govim is a git repository, so we clone using git. Along the way, clean up some unnecessary artifacts and add a script for downloading artifacts from GCS. Change-Id: I6ef4dd468d6b9baf66d3adae3f1fb80c12ac9578 Reviewed-on: https://go-review.googlesource.com/c/tools/+/217730 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-02-04 18:14:12 -07:00
ENV GOPROXY=https://proxy.golang.org GOPATH=/go VIM_FLAVOR=vim
gopls/integration/govim: update build steps to capture artifacts Govim integration tests generate a number of artifacts, including both the govim and gopls logs, that can be useful in debugging failures. This change updates our cloud build configuration to capture these artifacts, along with several other minor improvements. Notably artifacts are uploaded to GCS as a separate build step, so that we have the potential to use its granular permission model for sharing these artifacts. Right now, this requires temporarily swallowing the exit code of `go test` so that the build can proceed. Also: - Update govim to a newer version; we still can't use latest as there isn't a tagged version that contains the requisite flag change. - Alter the test harness to run tests from the github.com/govim/govim module root. - Switch use a major version label when referring to the test harness build step, to allow for breaking changes (such as the one made here). - Add a missing copyright header to run_local.sh. - Update run_local.sh to work with the modified harness. - Update documentation accordingly. Change-Id: Ie5ddaf54e775371a36163f98c1beb90c217be931 Reviewed-on: https://go-review.googlesource.com/c/tools/+/214577 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-13 13:22:19 -07:00
WORKDIR /src
gopls/integration/govim: switch to latest, and improve artifacts Now that there is a tagged version of govim containing the `-gopls` test flag, we can just use latest to pick up a relatively stable govim, and not have to maintain the govim version. Doing this required changing the way we fetch govim into our test harness: there is now the assumption that /src/govim is a git repository, so we clone using git. Along the way, clean up some unnecessary artifacts and add a script for downloading artifacts from GCS. Change-Id: I6ef4dd468d6b9baf66d3adae3f1fb80c12ac9578 Reviewed-on: https://go-review.googlesource.com/c/tools/+/217730 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-02-04 18:14:12 -07:00
# Clone govim. In order to use the go command for resolving latest, we download
# a redundant copy of govim to the build cache using `go mod download`.
RUN GOVIM_VERSION=$(go mod download -json github.com/govim/govim@latest | jq -r .Version) && \
git clone https://github.com/govim/govim /src/govim && cd /src/govim && \
gopls/integration/govim: revert back to using the latest govim A new version of govim with the fix for the original issue has been released. Change-Id: Iaea2eff7387f352cae1657949c5e364a66337f68 Reviewed-on: https://go-review.googlesource.com/c/tools/+/226557 Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-30 20:51:42 -06:00
git checkout $GOVIM_VERSION
Copy Permalink