qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-06 05:36:13 -07:00
Code Releases Activity
67a4523381
go/gopls/integration/govim/Dockerfile

25 lines
1.2 KiB
Docker
Raw Normal View History

gopls/integration: add a first cut of govim integration tests Govim has integration tests that we can leverage to help guard gopls against regressions. Changes have been submitted upstream to facilitate running these tests against a locally built gopls binary (https://github.com/govim/govim/pull/629) This CL adds a Dockerfile to build an image that has a version of govim available and ready for testing. This is then used to create a custom build step in a separate Cloud Build configuration, that builds gopls from source and runs the govim integration tests. A script (run_local.sh) is also added to facilitate running these tests locally. Change-Id: If68eabf9863a1689e29d9d744ff953d94a2b7681 Reviewed-on: https://go-review.googlesource.com/c/tools/+/212018 Reviewed-by: Paul Jolly <paul@myitcv.org.uk> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-12-18 12:55:07 -07:00
# Copyright 2019 The Go Authors. All rights reserved.
# Use of this source code is governed by a BSD-style
# license that can be found in the LICENSE file.
# govim requires a more recent version of vim than is available in most
# distros, so we build from their base image.
FROM govim/govim:go1.13.5_vim_v8.1.2414_v1
gopls/integration/govim: update build steps to capture artifacts Govim integration tests generate a number of artifacts, including both the govim and gopls logs, that can be useful in debugging failures. This change updates our cloud build configuration to capture these artifacts, along with several other minor improvements. Notably artifacts are uploaded to GCS as a separate build step, so that we have the potential to use its granular permission model for sharing these artifacts. Right now, this requires temporarily swallowing the exit code of `go test` so that the build can proceed. Also: - Update govim to a newer version; we still can't use latest as there isn't a tagged version that contains the requisite flag change. - Alter the test harness to run tests from the github.com/govim/govim module root. - Switch use a major version label when referring to the test harness build step, to allow for breaking changes (such as the one made here). - Add a missing copyright header to run_local.sh. - Update run_local.sh to work with the modified harness. - Update documentation accordingly. Change-Id: Ie5ddaf54e775371a36163f98c1beb90c217be931 Reviewed-on: https://go-review.googlesource.com/c/tools/+/214577 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-13 13:22:19 -07:00
# We use a pinned version of govim so that this build is repeatable, and so
# that we're not sensitive to test breakages in govim.
gopls/integration: add a first cut of govim integration tests Govim has integration tests that we can leverage to help guard gopls against regressions. Changes have been submitted upstream to facilitate running these tests against a locally built gopls binary (https://github.com/govim/govim/pull/629) This CL adds a Dockerfile to build an image that has a version of govim available and ready for testing. This is then used to create a custom build step in a separate Cloud Build configuration, that builds gopls from source and runs the govim integration tests. A script (run_local.sh) is also added to facilitate running these tests locally. Change-Id: If68eabf9863a1689e29d9d744ff953d94a2b7681 Reviewed-on: https://go-review.googlesource.com/c/tools/+/212018 Reviewed-by: Paul Jolly <paul@myitcv.org.uk> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-12-18 12:55:07 -07:00
# TODO(findleyr): Once a version of govim has been tagged containing
# https://github.com/govim/govim/pull/629, switch this to @latest.
gopls/integration/govim: update build steps to capture artifacts Govim integration tests generate a number of artifacts, including both the govim and gopls logs, that can be useful in debugging failures. This change updates our cloud build configuration to capture these artifacts, along with several other minor improvements. Notably artifacts are uploaded to GCS as a separate build step, so that we have the potential to use its granular permission model for sharing these artifacts. Right now, this requires temporarily swallowing the exit code of `go test` so that the build can proceed. Also: - Update govim to a newer version; we still can't use latest as there isn't a tagged version that contains the requisite flag change. - Alter the test harness to run tests from the github.com/govim/govim module root. - Switch use a major version label when referring to the test harness build step, to allow for breaking changes (such as the one made here). - Add a missing copyright header to run_local.sh. - Update run_local.sh to work with the modified harness. - Update documentation accordingly. Change-Id: Ie5ddaf54e775371a36163f98c1beb90c217be931 Reviewed-on: https://go-review.googlesource.com/c/tools/+/214577 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-13 13:22:19 -07:00
ENV GOPROXY=https://proxy.golang.org GOPATH=/go VIM_FLAVOR=vim \
gopls/integration/govim: update to latest govim Govim integration tests are now passing at govim HEAD + gopls HEAD, so we should be able to start actively investigating any regressions on the gopls side after this change. Change-Id: Ibf50d7e42e19cfc80779691e2c42f643028b2e39 Reviewed-on: https://go-review.googlesource.com/c/tools/+/215897 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-22 12:44:22 -07:00
GOVIM_VERSION=v0.0.27-0.20200122085353-96e61d22452d
gopls/integration/govim: update build steps to capture artifacts Govim integration tests generate a number of artifacts, including both the govim and gopls logs, that can be useful in debugging failures. This change updates our cloud build configuration to capture these artifacts, along with several other minor improvements. Notably artifacts are uploaded to GCS as a separate build step, so that we have the potential to use its granular permission model for sharing these artifacts. Right now, this requires temporarily swallowing the exit code of `go test` so that the build can proceed. Also: - Update govim to a newer version; we still can't use latest as there isn't a tagged version that contains the requisite flag change. - Alter the test harness to run tests from the github.com/govim/govim module root. - Switch use a major version label when referring to the test harness build step, to allow for breaking changes (such as the one made here). - Add a missing copyright header to run_local.sh. - Update run_local.sh to work with the modified harness. - Update documentation accordingly. Change-Id: Ie5ddaf54e775371a36163f98c1beb90c217be931 Reviewed-on: https://go-review.googlesource.com/c/tools/+/214577 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-13 13:22:19 -07:00
WORKDIR /src
# Get govim, as well as all dependencies for the ./cmd/govim tests. In order to
# use the go command's module version resolution, we use `go mod download` for
# this rather than git. Another approach would be to use a temporary module and
# `go get -t -u github.com/govim/govim`, but that may cause test dependencies
# to be upgraded.
RUN GOVIM_DIR=$(go mod download -json github.com/govim/govim@$GOVIM_VERSION | jq -r .Dir) && \
cp -r $GOVIM_DIR /src/govim && cd /src/govim && \
go list -test -deps ./cmd/govim
Copy Permalink