qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 02:14:43 -07:00
Code Releases Activity
6f24f261da
go/internal/lsp/testdata/summary.txt.golden

25 lines
517 B
Plaintext
Raw Normal View History

use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
-- summary --
internal/lsp/source: fix some invalid literal candidates We were marking all literal candidates as addressable so we were getting invalid candidates like "&int()". Fix it to only mark literal struct, array, slice and map types as addressable. I also fixed the unnamed literal candidate to pass the dereferenced expected type. For example, if the expected type was "*[]int" we were passing a literal type of "*[]int" which wasn't working anymore. Now we pass "[]int" and take its address as "&[]int{}". Change-Id: I5d0ee074d3cc91c39dd881630583e31be5a05579 Reviewed-on: https://go-review.googlesource.com/c/tools/+/212677 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-26 22:31:56 -07:00
CompletionsCount = 225
internal/lsp/source: support dereferencing for completion In cases like: var j *int var i int = <> We will now provide "*j" as a completion candidate. Change-Id: I1d35c2dca4864f13f7534e15b17450d784985557 Reviewed-on: https://go-review.googlesource.com/c/tools/+/215358 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-18 14:33:26 -07:00
CompletionSnippetCount = 66
internal/imports: load test exports of package under test x_tests can access exports from the test variant of the package under test. Change loadExportsFromFiles to understand that mode, and use it where appropriate. I didn't want to come up with a cache key for for the test variant, so for now we bypass the cache in these situations. Fixes golang/go#29979. Change-Id: I9959a08da97bbee64c5bcd56e06f548486693156 Reviewed-on: https://go-review.googlesource.com/c/tools/+/213221 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-03 16:01:15 -07:00
UnimportedCompletionsCount = 9
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
DeepCompletionsCount = 5
internal/lsp: support taking address for completion candidates We now support taking the address of objects to make better completion candidates. For example: i := 123 var p *int = <> // now you get a candidate for "&i" This required that we track addressability better, particularly when searching for deep candidates. Now each candidate knows if it is addressable, and the deep search propagates addressability to child candidates appropriately. The basic propagation logic is: - In-scope *types.Var candidates are addressable. This handles your basic "foo" variable whose address if "&foo". - Surrounding selector is addressable based on type checker info. This knows "foo.bar.<>" is addressable but "foo.bar().<>" isn't - When evaluating deep completions, fields after a function call lose addressability, but fields after a pointer regain addressability. For example, "foo.bar()" isn't addressable, but "foo.bar().baz" is addressable if "bar()" returns a pointer. Fixes golang/go#36132. Change-Id: I6a8659eb8c203262aedf86844ac39a2d1e81ecc4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/212399 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-22 10:58:14 -07:00
FuzzyCompletionsCount = 8
internal/lsp/source: improve completion for "make()" args Fix type inference to expect a type name for the first "make()" parameter and an integer for later parameters. For example: // Previously we expected "[]int{}", now we expect "[]int". var _ []int = make(<>) Note that we don't currently support actually completing to unnamed type names like "[]int", but this improvement at least eliminates nonsensical completion suggestions. // Previously we had no expectation, now we expect an int. var _ []int = make([]int, <>) Change-Id: Ifd349767662ab6902d3a3ea9e52de7df70cb37c7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/217310 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ingo Oeser <nightlyone@googlemail.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-02-01 22:45:01 -07:00
RankedCompletionsCount = 68
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
CaseSensitiveCompletionsCount = 4
internal/lsp: don't show list errors unless necessary The go/packages workaround to hide errors for overlay packages doesn't seem to work well. It's easier to just hide list errors in gopls diagnostics unless the package genuinely failed to type-check. Check if the package has missing dependencies as an approximation of if it is well-typed. This required some additional special casing for the import cycle error detection, which now causes them to have duplicate diagnostics. It's a rare enough case that this doesn't concern me, but we should clean this up at some point. Fixes golang/go#36754. Change-Id: If12c92fb9a0e0b69b711ae9a509ecb1b2a32255c Reviewed-on: https://go-review.googlesource.com/c/tools/+/216310 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-01-25 17:58:28 -07:00
DiagnosticsCount = 37
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
FoldingRangesCount = 2
FormatCount = 6
internal/lsp/source: start import diffs at byte 0 I assumed that f.Pos() would be the first byte of the file, but it's the position of the package declaration. This kills the file. Just use 0. Fixes golang/go#35458. Change-Id: Ic77c93344c71435ef8e5624c2f2defb619139a15 Reviewed-on: https://go-review.googlesource.com/c/tools/+/206145 Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-11-08 11:43:54 -07:00
ImportCount = 7
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
SuggestedFixCount = 1
internal/lsp: show comments for grouped variable declarations Fixes golang/go#36139 Change-Id: I8aaf1a5d65b8d66ea7bb350439cc960c7505307d Reviewed-on: https://go-review.googlesource.com/c/tools/+/211637 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
2019-12-16 22:32:08 -07:00
DefinitionsCount = 43
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
TypeDefinitionsCount = 2
internal/lsp: add highlighting for import statement This change adds highlights for imports when the cursor is over the use of that import. It also adds it for the opposite direction when the cursor is on the import, it will highlight uses of that import. Fixes golang/go#36590 Change-Id: Ifd04d81ec9b4fdf2be1b763f31b44d0ef7d92f47 Reviewed-on: https://go-review.googlesource.com/c/tools/+/215258 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rohan Challa <rohan@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-01-17 08:54:55 -07:00
HighlightsCount = 52
internal/lsp: refactor find-references and rename The main goal is to push the package variant logic from internal/lsp into internal/lsp/source so all users of internal/lsp/source benefit. "references" and "rename" now have top-level source.References() and source.Rename() entry points (as opposed to hanging off source.Identifier()). I expanded objectsAtProtocolPos() to know about implicit objects (type switch and import spec), and to handle *ast.ImportSpec generically. This gets rid of special case handling of *types.PkgName in various places. The biggest practical benefit, though, is that "references" no longer needs to compute the objectpath for every types.Object comparison it does, instead using direct types.Object equality. This speeds up "references" and "rename" a lot. Two other notable improvements that fell out of not using source.Identifier()'s logic: - Finding references on an embedded field now shows references to the field, not the type being embedded. - Finding references on an imported object now works correctly (previously it searched the importing package's dependents rather than the imported package's dependents). Finally, I refactored findIdentifier() to use pathEnclosingObjNode() instead of astutil.PathEnclosingInterval. Now we only need a single call to get the path because pathEnclosingObjNode() has the "try pos || try pos-1" logic built in. Change-Id: I667be9bed6ad83912404b90257c5c1485b3a7025 Reviewed-on: https://go-review.googlesource.com/c/tools/+/211999 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-17 22:06:31 -07:00
ReferencesCount = 8
internal/lsp: permit renaming symbols declared in other packages Also, add a test for it. Fixes golang/go#36743 Change-Id: I750ea36189a4ec5c9dc8553e4739b0238c2b29c8 Reviewed-on: https://go-review.googlesource.com/c/tools/+/216306 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-01-25 10:59:22 -07:00
RenamesCount = 23
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
PrepareRenamesCount = 8
SymbolsCount = 1
internal/lsp: fix active parameter for incomplete parentheses I had originally thought I might be able to use exprAtPos for this, which is why I ended up eliminating that function when I saw it only had one use. One test also had to change in order to fit better with the spec. Specifically: "If [the active parameter is] omitted or the value lies outside the range of `signatures[activeSignature].parameters` it defaults to 0 if the active signature has parameters." Fixes golang/go#36766. Change-Id: I400d5b2db2985bfaa5efbcd91225151ca8b5f46a Reviewed-on: https://go-review.googlesource.com/c/tools/+/216309 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-01-25 16:22:03 -07:00
SignaturesCount = 23
internal/lsp: create links for golang/go#1234-style strings This change treats text of the format golang/go#1234 as a link to the Go issue tracker. This will improve the readability of TODOs that include a link to an issue, since it doesn't have to be an actual link. Change-Id: I27606ceb9cbb15bc6bfb1d7aa660d3f4fdd08739 Reviewed-on: https://go-review.googlesource.com/c/tools/+/212518 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
2019-12-24 13:58:48 -07:00
LinksCount = 8
internal/lsp: fix find-implementation for promoted methods We weren't returning promoted methods as implementations when the promoted method was defined in a different package than the type implementing the interface. Fix by properly mapping the implementer types.Object to its containing source.Package. I generalized the implementations() result to just contain the implementer objects and their containing package. This allowed me to get rid of some result prep code in Implementation(). Fixes golang/go#35972. Change-Id: I867f2114c34e2ad39515ee3c8b6354c1cd35f7af Reviewed-on: https://go-review.googlesource.com/c/tools/+/210280 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-05 22:34:17 -07:00
ImplementationsCount = 5
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
Copy Permalink