qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 06:54:39 -07:00
Code Releases Activity
316d2f2484
go/internal/lsp/testdata/summary.txt.golden

25 lines
517 B
Plaintext
Raw Normal View History

use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
-- summary --
internal/lsp: support taking address for completion candidates We now support taking the address of objects to make better completion candidates. For example: i := 123 var p *int = <> // now you get a candidate for "&i" This required that we track addressability better, particularly when searching for deep candidates. Now each candidate knows if it is addressable, and the deep search propagates addressability to child candidates appropriately. The basic propagation logic is: - In-scope *types.Var candidates are addressable. This handles your basic "foo" variable whose address if "&foo". - Surrounding selector is addressable based on type checker info. This knows "foo.bar.<>" is addressable but "foo.bar().<>" isn't - When evaluating deep completions, fields after a function call lose addressability, but fields after a pointer regain addressability. For example, "foo.bar()" isn't addressable, but "foo.bar().baz" is addressable if "bar()" returns a pointer. Fixes golang/go#36132. Change-Id: I6a8659eb8c203262aedf86844ac39a2d1e81ecc4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/212399 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-22 10:58:14 -07:00
CompletionsCount = 223
CompletionSnippetCount = 61
internal/lsp/source: cap number of unimported completions Building unimported completions requires re-parsing and formatting at least some of the file for each one, which adds up. Limit it to 20; I expect people will just type more rather than scroll through a giant list. Updates golang/go#36001. Change-Id: Ib41232b91c327d4b824e6176e30306abf356f5b4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/210198 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-05 16:08:19 -07:00
UnimportedCompletionsCount = 4
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
DeepCompletionsCount = 5
internal/lsp: support taking address for completion candidates We now support taking the address of objects to make better completion candidates. For example: i := 123 var p *int = <> // now you get a candidate for "&i" This required that we track addressability better, particularly when searching for deep candidates. Now each candidate knows if it is addressable, and the deep search propagates addressability to child candidates appropriately. The basic propagation logic is: - In-scope *types.Var candidates are addressable. This handles your basic "foo" variable whose address if "&foo". - Surrounding selector is addressable based on type checker info. This knows "foo.bar.<>" is addressable but "foo.bar().<>" isn't - When evaluating deep completions, fields after a function call lose addressability, but fields after a pointer regain addressability. For example, "foo.bar()" isn't addressable, but "foo.bar().baz" is addressable if "bar()" returns a pointer. Fixes golang/go#36132. Change-Id: I6a8659eb8c203262aedf86844ac39a2d1e81ecc4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/212399 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-22 10:58:14 -07:00
FuzzyCompletionsCount = 8
internal/lsp/source: don't downrank builtin constant completions We downrank untyped constant candidates so that we prefer candidates whose type matches exactly. However, this was causing builtin constants like "true" to be outranked by candidates that fuzzily match "true". Fix by not downranking builtin constants. Fixes golang/go#36363. Change-Id: I14801688c96efdbb7ff9fee69f66028530df984c Reviewed-on: https://go-review.googlesource.com/c/tools/+/213137 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-01-02 14:26:21 -07:00
RankedCompletionsCount = 33
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
CaseSensitiveCompletionsCount = 4
internal/lsp: add diagnostic on import causing import cycle After the addition of golang/go#35964, the import cycle error now has the import stack attached in the message. This CL parses that stack and attached the import cycle diagnostic to the import versus just adding it to the first character of the .go file. Fixes golang/go#33085 Change-Id: I6f5f067c338879b898829951236f816aa63d9dfa Reviewed-on: https://go-review.googlesource.com/c/tools/+/210942 Run-TryBot: Rohan Challa <rohan@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-11 12:30:48 -07:00
DiagnosticsCount = 35
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
FoldingRangesCount = 2
FormatCount = 6
internal/lsp/source: start import diffs at byte 0 I assumed that f.Pos() would be the first byte of the file, but it's the position of the package declaration. This kills the file. Just use 0. Fixes golang/go#35458. Change-Id: Ic77c93344c71435ef8e5624c2f2defb619139a15 Reviewed-on: https://go-review.googlesource.com/c/tools/+/206145 Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-11-08 11:43:54 -07:00
ImportCount = 7
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
SuggestedFixCount = 1
internal/lsp: show comments for grouped variable declarations Fixes golang/go#36139 Change-Id: I8aaf1a5d65b8d66ea7bb350439cc960c7505307d Reviewed-on: https://go-review.googlesource.com/c/tools/+/211637 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
2019-12-16 22:32:08 -07:00
DefinitionsCount = 43
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
TypeDefinitionsCount = 2
internal/lsp: fix highlighting of inexact matches when highlighting from the right There is an issue when highlighting a single character identifier if the cursor is on the right of it. This problem is a result of an assumption made in astutil.PathEnclosingInterval relating to the arguments passed in. Specifically, if start==end, the 1-char interval following start is used instead. As a result, we might not get an exact match so we should check the 1-char interval to the left of the passed in position to see if that is an exact match. Updates golang/go#34496 Change-Id: If689fdf695df6ec1bc1935088e50d3de055bd5db Reviewed-on: https://go-review.googlesource.com/c/tools/+/212137 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rohan Challa <rohan@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-12-16 15:42:56 -07:00
HighlightsCount = 45
internal/lsp/source: add support for references in the same workspace When looking for references, look in the entire workspace rather than the same package. This makes the references query more expensive because it needs to look at every package in the workspace, but hopefully it shouln't be user-noticable. This can be made more efficient by only checking packages that are transitive reverse dependencies. I don't think a mechanism to get all transitive reverse dependencies exists yet. One of the references test have been changed: it looked up references of the builtin int type, but now there are so many refererences that the test too slow and doesn't make sense any more. Instead look up references of the type "i" in that file. Change-Id: I93b3bd3795386f06ce488e76e6c7c8c1b1074e22 Reviewed-on: https://go-review.googlesource.com/c/tools/+/206883 Run-TryBot: Michael Matloob <matloob@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-11-12 18:16:00 -07:00
ReferencesCount = 7
internal/lsp/testadata/rename: add a test case for renames across packages Renames across packages works as of https://golang.org/cl/206883. Add a test for it. Fixes golang/go#32877 Change-Id: I234fafe95a1060c0ca8d03462bf7b2c241d59e4a Reviewed-on: https://go-review.googlesource.com/c/tools/+/207264 Run-TryBot: Michael Matloob <matloob@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-11-14 13:40:29 -07:00
RenamesCount = 22
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
PrepareRenamesCount = 8
SymbolsCount = 1
internal/lsp: use AST to construct placeholders Type aliases don't work well with types.TypeString. Work around that by using the AST to build this information. Follow up from CL 201677. Fixes golang/go#33500 Change-Id: I8b2d4ea238eb5d284a419f2b0bbf9655e69d434d Reviewed-on: https://go-review.googlesource.com/c/tools/+/208497 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
2019-11-22 12:49:12 -07:00
SignaturesCount = 22
internal/lsp: create links for golang/go#1234-style strings This change treats text of the format golang/go#1234 as a link to the Go issue tracker. This will improve the readability of TODOs that include a link to an issue, since it doesn't have to be an actual link. Change-Id: I27606ceb9cbb15bc6bfb1d7aa660d3f4fdd08739 Reviewed-on: https://go-review.googlesource.com/c/tools/+/212518 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
2019-12-24 13:58:48 -07:00
LinksCount = 8
internal/lsp: fix find-implementation for promoted methods We weren't returning promoted methods as implementations when the promoted method was defined in a different package than the type implementing the interface. Fix by properly mapping the implementer types.Object to its containing source.Package. I generalized the implementations() result to just contain the implementer objects and their containing package. This allowed me to get rid of some result prep code in Implementation(). Fixes golang/go#35972. Change-Id: I867f2114c34e2ad39515ee3c8b6354c1cd35f7af Reviewed-on: https://go-review.googlesource.com/c/tools/+/210280 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-05 22:34:17 -07:00
ImplementationsCount = 5
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
Copy Permalink