2018-11-05 12:48:08 -07:00
// Copyright 2018 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
2018-10-19 14:03:29 -06:00
package lsp
import (
2018-12-05 15:00:36 -07:00
"context"
2020-05-28 19:21:29 -06:00
"fmt"
2019-05-17 11:45:50 -06:00
"strings"
2020-01-31 15:27:08 -07:00
"sync"
2018-11-13 09:13:53 -07:00
2020-04-17 07:32:56 -06:00
"golang.org/x/tools/internal/event"
2020-03-10 21:09:39 -06:00
"golang.org/x/tools/internal/lsp/debug/tag"
2019-12-17 14:13:33 -07:00
"golang.org/x/tools/internal/lsp/mod"
2018-10-19 14:03:29 -06:00
"golang.org/x/tools/internal/lsp/protocol"
2018-11-02 14:15:31 -06:00
"golang.org/x/tools/internal/lsp/source"
2020-01-11 21:59:57 -07:00
"golang.org/x/tools/internal/xcontext"
2018-10-19 14:03:29 -06:00
)
2020-01-31 15:27:08 -07:00
type diagnosticKey struct {
id source . FileIdentity
withAnalysis bool
}
2020-01-11 21:59:57 -07:00
func ( s * Server ) diagnoseDetached ( snapshot source . Snapshot ) {
ctx := snapshot . View ( ) . BackgroundContext ( )
ctx = xcontext . Detach ( ctx )
2020-04-29 11:33:43 -06:00
reports , shows := s . diagnose ( ctx , snapshot , false )
if shows != nil {
internal/lsp: handle unknown revision in go.mod file
This change ensures that, when the initial workspace load fails, we
re-run it if the go.mod file changes. Previously, if a user opened a
workspace with a corrupt go.mod file, we never recovered.
To reinitialize the workspace on-demand, we use the initializeOnce field
as an indicator of whether or not we should reinitialize. Every call to
awaitInitialized (which is called by all functions that need the IWL),
passes through the initialization code. If a retry isn't necessary,
this is a no-op, but if it is, we will call the initialization logic.
Only the first attempt uses a detached context; subsequent attempts can
be canceled by their contexts.
To indicate that we should reinitialize, we call maybeReinitialize.
Right now, we only call this when the go.mod file changes. In the
future, we may need it in other cases.
Fixes golang/go#38232
Change-Id: I77eefebb0ac38fbd0fe2c7da09c864eba45b075f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/242159
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-07-11 23:52:22 -06:00
// If a view has been created or the configuration changed, warn the user.
2020-04-29 11:33:43 -06:00
s . client . ShowMessage ( ctx , shows )
}
2020-01-31 15:27:08 -07:00
s . publishReports ( ctx , snapshot , reports )
2019-11-15 12:47:29 -07:00
}
2020-01-11 21:59:57 -07:00
func ( s * Server ) diagnoseSnapshot ( snapshot source . Snapshot ) {
2019-11-20 12:26:02 -07:00
ctx := snapshot . View ( ) . BackgroundContext ( )
internal/lsp: handle unknown revision in go.mod file
This change ensures that, when the initial workspace load fails, we
re-run it if the go.mod file changes. Previously, if a user opened a
workspace with a corrupt go.mod file, we never recovered.
To reinitialize the workspace on-demand, we use the initializeOnce field
as an indicator of whether or not we should reinitialize. Every call to
awaitInitialized (which is called by all functions that need the IWL),
passes through the initialization code. If a retry isn't necessary,
this is a no-op, but if it is, we will call the initialization logic.
Only the first attempt uses a detached context; subsequent attempts can
be canceled by their contexts.
To indicate that we should reinitialize, we call maybeReinitialize.
Right now, we only call this when the go.mod file changes. In the
future, we may need it in other cases.
Fixes golang/go#38232
Change-Id: I77eefebb0ac38fbd0fe2c7da09c864eba45b075f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/242159
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-07-11 23:52:22 -06:00
// Ignore possible workspace configuration warnings in the normal flow.
2020-04-29 11:33:43 -06:00
reports , _ := s . diagnose ( ctx , snapshot , false )
2020-01-31 15:27:08 -07:00
s . publishReports ( ctx , snapshot , reports )
2019-11-20 12:26:02 -07:00
}
2019-03-14 15:19:01 -06:00
2020-01-11 21:59:57 -07:00
// diagnose is a helper function for running diagnostics with a given context.
// Do not call it directly.
2020-04-29 11:33:43 -06:00
func ( s * Server ) diagnose ( ctx context . Context , snapshot source . Snapshot , alwaysAnalyze bool ) ( map [ diagnosticKey ] [ ] * source . Diagnostic , * protocol . ShowMessageParams ) {
2020-04-20 10:14:12 -06:00
ctx , done := event . Start ( ctx , "lsp:background-worker" )
2019-12-17 14:13:33 -07:00
defer done ( )
2020-02-18 14:44:12 -07:00
// Wait for a free diagnostics slot.
select {
case <- ctx . Done ( ) :
2020-04-29 11:33:43 -06:00
return nil , nil
2020-02-18 14:44:12 -07:00
case s . diagnosticsSema <- struct { } { } :
}
defer func ( ) { <- s . diagnosticsSema } ( )
2020-03-31 21:53:42 -06:00
allReports := make ( map [ diagnosticKey ] [ ] * source . Diagnostic )
2020-01-31 15:27:08 -07:00
var reportsMu sync . Mutex
var wg sync . WaitGroup
2020-01-24 08:14:25 -07:00
// Diagnose the go.mod file.
2020-07-14 22:19:10 -06:00
reports , err := mod . Diagnostics ( ctx , snapshot )
2020-01-24 08:14:25 -07:00
if err != nil {
2020-03-27 11:11:41 -06:00
event . Error ( ctx , "warning: diagnose go.mod" , err , tag . Directory . Of ( snapshot . View ( ) . Folder ( ) . Filename ( ) ) )
2020-01-24 08:14:25 -07:00
}
2020-03-30 10:45:15 -06:00
if ctx . Err ( ) != nil {
2020-04-29 11:33:43 -06:00
return nil , nil
2020-03-30 10:45:15 -06:00
}
2020-01-31 15:27:08 -07:00
for id , diags := range reports {
2020-06-19 14:31:22 -06:00
if id . URI == "" {
event . Error ( ctx , "missing URI for module diagnostics" , fmt . Errorf ( "empty URI" ) , tag . Directory . Of ( snapshot . View ( ) . Folder ( ) . Filename ( ) ) )
continue
}
2020-01-31 15:27:08 -07:00
key := diagnosticKey {
2020-07-14 22:19:10 -06:00
id : id ,
withAnalysis : true , // treat go.mod diagnostics like analyses
2020-01-31 15:27:08 -07:00
}
allReports [ key ] = diags
2020-01-24 08:14:25 -07:00
}
2020-01-11 21:59:57 -07:00
// Diagnose all of the packages in the workspace.
2020-01-31 15:27:08 -07:00
wsPackages , err := snapshot . WorkspacePackages ( ctx )
internal/lsp: handle unknown revision in go.mod file
This change ensures that, when the initial workspace load fails, we
re-run it if the go.mod file changes. Previously, if a user opened a
workspace with a corrupt go.mod file, we never recovered.
To reinitialize the workspace on-demand, we use the initializeOnce field
as an indicator of whether or not we should reinitialize. Every call to
awaitInitialized (which is called by all functions that need the IWL),
passes through the initialization code. If a retry isn't necessary,
this is a no-op, but if it is, we will call the initialization logic.
Only the first attempt uses a detached context; subsequent attempts can
be canceled by their contexts.
To indicate that we should reinitialize, we call maybeReinitialize.
Right now, we only call this when the go.mod file changes. In the
future, we may need it in other cases.
Fixes golang/go#38232
Change-Id: I77eefebb0ac38fbd0fe2c7da09c864eba45b075f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/242159
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-07-11 23:52:22 -06:00
if err != nil {
s . handleFatalErrors ( ctx , snapshot , err )
2020-04-29 11:33:43 -06:00
return nil , nil
2020-01-31 15:27:08 -07:00
}
2020-04-29 11:33:43 -06:00
var shows * protocol . ShowMessageParams
2020-01-31 15:27:08 -07:00
for _ , ph := range wsPackages {
wg . Add ( 1 )
go func ( ph source . PackageHandle ) {
defer wg . Done ( )
// Only run analyses for packages with open files.
withAnalyses := alwaysAnalyze
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
for _ , pgh := range ph . CompiledGoFiles ( ) {
if snapshot . IsOpen ( pgh . File ( ) . URI ( ) ) {
2020-01-31 15:27:08 -07:00
withAnalyses = true
2020-01-11 21:59:57 -07:00
}
2020-01-31 15:27:08 -07:00
}
2020-07-14 22:19:10 -06:00
reports , warn , err := source . Diagnostics ( ctx , snapshot , ph , withAnalyses )
2020-01-31 15:27:08 -07:00
// Check if might want to warn the user about their build configuration.
2020-04-29 11:33:43 -06:00
// Our caller decides whether to send the message.
2020-01-31 15:27:08 -07:00
if warn && ! snapshot . View ( ) . ValidBuildConfiguration ( ) {
2020-04-29 11:33:43 -06:00
shows = & protocol . ShowMessageParams {
2020-03-08 09:38:04 -06:00
Type : protocol . Warning ,
Message : ` You are neither in a module nor in your GOPATH. If you are using modules, please open your editor at the directory containing the go.mod. If you believe this warning is incorrect, please file an issue: https://github.com/golang/go/issues/new. ` ,
2020-04-29 11:33:43 -06:00
}
2020-01-31 15:27:08 -07:00
}
if err != nil {
2020-03-24 16:29:27 -06:00
event . Error ( ctx , "warning: diagnose package" , err , tag . Snapshot . Of ( snapshot . ID ( ) ) , tag . Package . Of ( ph . ID ( ) ) )
2020-01-31 15:27:08 -07:00
return
}
reportsMu . Lock ( )
for id , diags := range reports {
key := diagnosticKey {
id : id ,
withAnalysis : withAnalyses ,
2020-01-11 21:59:57 -07:00
}
2020-07-14 22:19:10 -06:00
allReports [ key ] = append ( allReports [ key ] , diags ... )
2020-01-31 15:27:08 -07:00
}
reportsMu . Unlock ( )
} ( ph )
}
wg . Wait ( )
2020-04-29 11:33:43 -06:00
return allReports , shows
2019-12-17 14:13:33 -07:00
}
2020-03-31 21:53:42 -06:00
func ( s * Server ) publishReports ( ctx context . Context , snapshot source . Snapshot , reports map [ diagnosticKey ] [ ] * source . Diagnostic ) {
2019-12-05 14:37:47 -07:00
// Check for context cancellation before publishing diagnostics.
if ctx . Err ( ) != nil {
return
}
2019-11-20 23:24:43 -07:00
s . deliveredMu . Lock ( )
defer s . deliveredMu . Unlock ( )
2020-01-31 15:27:08 -07:00
for key , diagnostics := range reports {
2019-12-05 14:37:47 -07:00
// Don't deliver diagnostics if the context has already been canceled.
if ctx . Err ( ) != nil {
break
}
2019-11-20 23:24:43 -07:00
// Pre-sort diagnostics to avoid extra work when we compare them.
source . SortDiagnostics ( diagnostics )
toSend := sentDiagnostics {
2020-01-31 15:27:08 -07:00
version : key . id . Version ,
identifier : key . id . Identifier ,
2020-01-13 18:41:03 -07:00
sorted : diagnostics ,
2020-01-31 15:27:08 -07:00
withAnalysis : key . withAnalysis ,
2020-01-13 18:41:03 -07:00
snapshotID : snapshot . ID ( ) ,
2019-11-20 23:24:43 -07:00
}
2020-01-17 11:12:00 -07:00
2020-01-10 10:29:37 -07:00
// We use the zero values if this is an unknown file.
2020-01-31 15:27:08 -07:00
delivered := s . delivered [ key . id . URI ]
2020-01-13 18:41:03 -07:00
2020-01-17 11:12:00 -07:00
// Snapshot IDs are always increasing, so we use them instead of file
// versions to create the correct order for diagnostics.
// If we've already delivered diagnostics for a future snapshot for this file,
// do not deliver them.
if delivered . snapshotID > toSend . snapshotID {
// Do not update the delivered map since it already contains newer diagnostics.
continue
}
// Check if we should reuse the cached diagnostics.
if equalDiagnostics ( delivered . sorted , diagnostics ) {
// Make sure to update the delivered map.
2020-01-31 15:27:08 -07:00
s . delivered [ key . id . URI ] = toSend
2020-01-08 11:53:50 -07:00
continue
}
2020-01-17 11:12:00 -07:00
// If we've already delivered diagnostics for this file, at this
// snapshot, with analyses, do not send diagnostics without analyses.
2020-01-10 10:29:37 -07:00
if delivered . snapshotID == toSend . snapshotID && delivered . version == toSend . version &&
delivered . withAnalysis && ! toSend . withAnalysis {
2020-01-17 11:12:00 -07:00
// Do not update the delivered map since it already contains better diagnostics.
2020-01-10 10:29:37 -07:00
continue
2019-11-20 23:24:43 -07:00
}
2019-12-05 14:37:47 -07:00
if err := s . client . PublishDiagnostics ( ctx , & protocol . PublishDiagnosticsParams {
2020-01-10 10:29:37 -07:00
Diagnostics : toProtocolDiagnostics ( diagnostics ) ,
2020-02-12 14:36:46 -07:00
URI : protocol . URIFromSpanURI ( key . id . URI ) ,
2020-01-31 15:27:08 -07:00
Version : key . id . Version ,
2019-12-05 14:37:47 -07:00
} ) ; err != nil {
2020-03-30 10:45:15 -06:00
event . Error ( ctx , "publishReports: failed to deliver diagnostic" , err , tag . URI . Of ( key . id . URI ) )
2019-05-01 20:46:07 -06:00
continue
2019-03-14 15:19:01 -06:00
}
2019-11-20 23:24:43 -07:00
// Update the delivered map.
2020-01-31 15:27:08 -07:00
s . delivered [ key . id . URI ] = toSend
2019-11-20 23:24:43 -07:00
}
}
// equalDiagnostics returns true if the 2 lists of diagnostics are equal.
// It assumes that both a and b are already sorted.
2020-03-31 21:53:42 -06:00
func equalDiagnostics ( a , b [ ] * source . Diagnostic ) bool {
2019-11-20 23:24:43 -07:00
if len ( a ) != len ( b ) {
return false
}
for i := 0 ; i < len ( a ) ; i ++ {
if source . CompareDiagnostic ( a [ i ] , b [ i ] ) != 0 {
return false
}
2019-05-01 20:46:07 -06:00
}
2019-11-20 23:24:43 -07:00
return true
2018-12-18 14:18:03 -07:00
}
2020-03-31 21:53:42 -06:00
func toProtocolDiagnostics ( diagnostics [ ] * source . Diagnostic ) [ ] protocol . Diagnostic {
2018-11-12 12:15:47 -07:00
reports := [ ] protocol . Diagnostic { }
for _ , diag := range diagnostics {
2019-10-11 03:39:09 -06:00
related := make ( [ ] protocol . DiagnosticRelatedInformation , 0 , len ( diag . Related ) )
for _ , rel := range diag . Related {
related = append ( related , protocol . DiagnosticRelatedInformation {
Location : protocol . Location {
2020-02-12 14:36:46 -07:00
URI : protocol . URIFromSpanURI ( rel . URI ) ,
2019-10-11 03:39:09 -06:00
Range : rel . Range ,
} ,
Message : rel . Message ,
} )
}
2019-09-24 22:46:57 -06:00
reports = append ( reports , protocol . Diagnostic {
2019-10-11 03:39:09 -06:00
Message : strings . TrimSpace ( diag . Message ) , // go list returns errors prefixed by newline
Range : diag . Range ,
Severity : diag . Severity ,
Source : diag . Source ,
Tags : diag . Tags ,
RelatedInformation : related ,
2019-09-24 22:46:57 -06:00
} )
2018-11-12 12:15:47 -07:00
}
2019-09-24 14:28:59 -06:00
return reports
2018-10-29 16:12:41 -06:00
}
internal/lsp: handle unknown revision in go.mod file
This change ensures that, when the initial workspace load fails, we
re-run it if the go.mod file changes. Previously, if a user opened a
workspace with a corrupt go.mod file, we never recovered.
To reinitialize the workspace on-demand, we use the initializeOnce field
as an indicator of whether or not we should reinitialize. Every call to
awaitInitialized (which is called by all functions that need the IWL),
passes through the initialization code. If a retry isn't necessary,
this is a no-op, but if it is, we will call the initialization logic.
Only the first attempt uses a detached context; subsequent attempts can
be canceled by their contexts.
To indicate that we should reinitialize, we call maybeReinitialize.
Right now, we only call this when the go.mod file changes. In the
future, we may need it in other cases.
Fixes golang/go#38232
Change-Id: I77eefebb0ac38fbd0fe2c7da09c864eba45b075f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/242159
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-07-11 23:52:22 -06:00
func ( s * Server ) handleFatalErrors ( ctx context . Context , snapshot source . Snapshot , err error ) {
switch err {
case source . InconsistentVendoring :
item , err := s . client . ShowMessageRequest ( ctx , & protocol . ShowMessageRequestParams {
Type : protocol . Error ,
Message : ` Inconsistent vendoring detected . Please re - run "go mod vendor" .
See https : //github.com/golang/go/issues/39164 for more detail on this issue.`,
Actions : [ ] protocol . MessageActionItem {
{ Title : "go mod vendor" } ,
} ,
} )
if item == nil || err != nil {
event . Error ( ctx , "go mod vendor ShowMessageRequest failed" , err , tag . Directory . Of ( snapshot . View ( ) . Folder ( ) ) )
return
}
modURI := snapshot . View ( ) . ModFile ( )
if err := s . directGoModCommand ( ctx , protocol . URIFromSpanURI ( modURI ) , "mod" , [ ] string { "vendor" } ... ) ; err != nil {
if err := s . client . ShowMessage ( ctx , & protocol . ShowMessageParams {
Type : protocol . Error ,
Message : fmt . Sprintf ( ` "go mod vendor" failed with %v ` , err ) ,
} ) ; err != nil {
event . Error ( ctx , "ShowMessage failed" , err )
}
}
default :
msg := "failed to load workspace packages, skipping diagnostics"
event . Error ( ctx , msg , err , tag . Snapshot . Of ( snapshot . ID ( ) ) , tag . Directory . Of ( snapshot . View ( ) . Folder ( ) ) )
if err := s . client . ShowMessage ( ctx , & protocol . ShowMessageParams {
Type : protocol . Error ,
Message : fmt . Sprintf ( "%s: %v" , msg , err ) ,
} ) ; err != nil {
event . Error ( ctx , "ShowMessage failed" , err , tag . Directory . Of ( snapshot . View ( ) . Folder ( ) ) )
}
}
}