1
0
mirror of https://github.com/golang/go synced 2024-11-18 10:04:43 -07:00
go/internal/lsp
Rebecca Stambler 0a5cd10191 internal/lsp: handle unknown revision in go.mod file
This change ensures that, when the initial workspace load fails, we
re-run it if the go.mod file changes. Previously, if a user opened a
workspace with a corrupt go.mod file, we never recovered.

To reinitialize the workspace on-demand, we use the initializeOnce field
as an indicator of whether or not we should reinitialize. Every call to
awaitInitialized (which is called by all functions that need the IWL),
passes through the initialization code. If a retry isn't necessary,
this is a no-op, but if it is, we will call the initialization logic.
Only the first attempt uses a detached context; subsequent attempts can
be canceled by their contexts.

To indicate that we should reinitialize, we call maybeReinitialize.
Right now, we only call this when the go.mod file changes. In the
future, we may need it in other cases.

Fixes golang/go#38232

Change-Id: I77eefebb0ac38fbd0fe2c7da09c864eba45b075f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/242159
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-07-21 21:40:18 +00:00
..
analysis internal/lsp: move fillstruct suggested fixes out of analysis 2020-07-20 20:42:44 +00:00
browser
cache internal/lsp: handle unknown revision in go.mod file 2020-07-21 21:40:18 +00:00
cmd internal/lsp: support extract function 2020-07-20 18:55:41 +00:00
debug internal/lsp/lsprpc: improvements to daemon logging 2020-07-16 19:33:22 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp/lsprpc: improvements to daemon logging 2020-07-16 19:33:22 +00:00
mod internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
protocol internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
regtest internal/lsp: handle unknown revision in go.mod file 2020-07-21 21:40:18 +00:00
snippet
source internal/lsp: handle on-disk file deletions for opened files 2020-07-21 21:30:00 +00:00
testdata internal/lsp: move fillstruct suggested fixes out of analysis 2020-07-20 20:42:44 +00:00
tests internal/lsp: support extract function 2020-07-20 18:55:41 +00:00
code_action.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
code_lens.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
command.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
completion_test.go internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
completion.go internal/lsp: remove VS Code-specific completion hack 2020-06-30 15:48:51 +00:00
definition.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
diagnostics.go internal/lsp: handle unknown revision in go.mod file 2020-07-21 21:40:18 +00:00
folding_range.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
format.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
general.go internal/lsp: watch go.{mod,sum} files, as well as Go files 2020-07-13 01:13:07 +00:00
highlight.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
hover.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
implementation.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
link.go internal/lsp: add an importShortcut configuration 2020-07-15 23:00:36 +00:00
lsp_test.go internal/lsp: move fillstruct suggested fixes out of analysis 2020-07-20 20:42:44 +00:00
progress.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
references.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
rename.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
reset_golden.sh
server_gen.go x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
server.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
signature_help.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
symbols.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
text_synchronization.go internal/lsp: don't keep track of closed overlays 2020-07-16 17:49:00 +00:00
workspace_symbol.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00
workspace.go gopls, internal/lsp: support an extra formatting hook for gofumpt 2020-07-13 21:42:47 +00:00