Copyright © 1997-2008,2009 by Thomas E. Dickey
Contents
This file contains a list of the changes that I have made for xterm,
from the notes that I add when submitting a patch.
You should note that other changes have been made as well, by other people,
to fix bugs and correct ifdef's for portability.
Most of these are summarized in the XFree86 CHANGELOG
(found in the unbundled tree, xc/programs/Xserver/hw/xfree86).
Here
is the latest version of this file.
- revert change to default for
allowTcapOps
(request by
Bram Moolenaar).
- reallocate result returned by
xtermEnvLocale()
to
avoid reference to freed memory after handling
menuLocale
resource.
- fix an old (X11R5) bug in tek4014 for switching fontsizes.
- add resource
defaultString
to make configurable the
use of "#" when pastes of UTF-8 text fail due to limitations in
the current locale settings.
- make the set of selection target Atom's configurable by two new
resources
eightBitSelectTypes
and
utf8SelectTypes
, e.g., to use the TEXT
Atom in preference to UTF8_STRING
(discussion with
Stanislav Sedov regarding koi8rxterm and the FreeBSD port).
- modify handling of
TARGETS
Atom by making it return
exactly the set of targets as those which xterm is currently
providing.
- set
MANPAGER
and PAGER
explicitly to
/bin/cat in minstall.sh
to work around /etc/man.conf's
with those variables already set
(report by Марьясин
Семён).
- improve error-checking of tcap-query parser.
- add check for keyboard
tcap
), which ensures that
terminal descriptions containing the same string for
shifted/unshifted keys will be seen by tcap-query as only the
unshifted key. (This would only happen with an incorrect terminal
description).
- fix conversion for input event-state to modifier-parameter which
made tcap-query feature not work with
tcapFunctionKeys
(keyboard type tcap
).
- add "DEF_ALLOW_XXX" definitions to main.h to allow
overriding the default compiled-in values for
"allowxxx" resources.
- remove check on bell-percentage added in
patch #242,
which disallowed zero/negative values (Redhat Bugzilla #487829).
- improve checks for missing bitmap fonts, fallback to "fixed" as
needed to work around broken font-packages (report by Jacek
Luczak).
- fix breakage from patch #240 changes for
xtermAddInput()
(patches by Jeff Chua, Julien Cristau).
- use
plink.sh
for linking xterm (suggested by Larry
Doolittle).
- add resource descriptions for input method to xterm manpage.
- update configure script; consistently append to $CFLAGS rather
than prepend.
- add
install-scripts
rule to makefile, to allow
koi8rxterm and uxterm scripts to be altered independently of
install-bin
- add
-maximized
command-line option and corresponding
resource (prompted by alt.os.linux newsgroup comment).
- modify translations of scrollbar widget using
xtermAddInput()
(see patch #181) to accept the actions
that the vt100 widget accepts, such as shift-insert to perform
a paste operation (request by Martin Zwickel).
- change default for
allowTcapsOps
resource to false,
since it causes unexpected behavior for vim users with
AltGr
.
- update config.guess, config.sub
- correct a cast in input.c, which broke translation of numeric
keypad codes to pageup, pagedown, etc., on 64-bit platform
(Debian #511138, report by Larry Doolittle).
- update configure macro CF_XOPEN_SOURCE for AIX 6.x and Mint
platforms.
- reset the screen wrapping-flag at the end of
ClearRight
to fix an occasional case where the last
character of a scrolled and wrapped line would be cleared (patch by
Joe Peterson).
- modify to use POSIX coding for comparing resource settings such
as
locale
, to work with locales such as Turkish
(report by M Vefa Bicakci).
- turn on configure
paste64
feature by default
(request by Jean-Philippe Bernardy).
It is runtime enabled/disabled with allowWindowOps
.
- turn on configure
tcap-query
feature by default,
add resource allowTcapOps
to make this runtime enabled/disabled.
- make
OSC 3
(change X property, from
patch #110)
subject to allowWindowOps
resource.
- make VT220
DSR
responses inactive in VT100-mode.
- make
DECUDK
feature inactive in VT100-mode.
- respond to incorrectly formatted
DECRQSS
with a
cancel.
- add
allowFontOps
resource to allow the fontsize-switching and font query/set
control sequences to be enabled/disabled
(prompted by Debian #510030).
- some code cleanup based on gcc 4.x
-Wconversion
warnings in button.c and charproc.c
- modify
tcap-query
feature to not return data for
shifted cursor-keys when the keyboard type is set to vt220,
since returning the same string for shifted/unshifted keys may
confuse some applications (GenToo #212546).
- improve usability of TrueType fonts by making the font-size
switching for shifted keypad plus/minus use the
faceSize
resources to determine the order of fonts
(when TrueType fonts are used) rather than the bitmap fonts, since
their sizes may not be in the same order (report by H Merijn
Brand)
- remove an optimization of
ConfigureNotify
events
from patch #236
which seems to interfere with passing SIGWINCH
to
applications (GenToo #233836).
- modify handling of
altSendsEscape
to reset the
eightBitInput
mode, like metaSendsEscape
(patch by Ted Phelps).
- add feature to show the text-cursor as an underline rather than a
box, plus command-line options
-uc
and
+uc
and resource cursorUnderLine
to
control the feature (patch by Paul Lampert).
- update config.guess, config.sub
- correct memory reallocation when handling a paste of UTF-8 text
from patch #225 changes
(report/patch by Max Mikhanosha).
- correct allocation of temporary buffer in
xtermFindShell
in case the user's $PATH
contains no ":" (report/analysis by Victor Stinner,
Freedesktop.Org Bugzilla #16790).
- modify CF_XOPEN_SOURCE to add case for DragonFly BSD, to fix
new compile problem exposed by fix for fd_mask (patch by
Hasso Tepper).
- add configure-check for ncurses
use_extended_names
,
(report by Martin Mokrejs).
- correct computation for toolbar height; layout manager already
takes into account
borderWidth
resource.
- implement VT320-style SCS (select character set) for ISO Latin-1
supplemental.
- fixes for vt100-style character sets in UTF-8 mode (Ubuntu #230919).
- fix to make
luit
work with xterm's -ls
option (report/patch by Marius Tolzmann).
- update config.guess, config.sub
- add control sequences for some of the recent resource/menu
settings:
altSendsEscape
(private mode 1039)
keepSelection
(private mode 1040)
selectToClipboard
(private mode 1041)
bellIsUrgent
(private mode 1042)
popOnBell
(private mode 1043)
- add resource
formatOtherKeys
to provide an alternate
escape sequence format for the modifyOtherKeys
resource (request by Paul LeoNerd Evans).
- adjust saved-cursor position if the window is resized while
displaying the alternate screen (Novell #196880, Debian #383384).
- improve pointer-checks to fix a bug exposed by resizing during
initialization under StumpWM window manager
(Fedora Bugzilla #437928).
- modify
unselectwindow()
to ensure that the mouse
pointer is not hidden after xterm loses focus (report by Jeremy
Huddleston).
- add special check for fd_mask on Mac OS X (report by Jeremy
Huddleston).
- add
dylib
to autoconf's suffix list used for checking
the result from xmkmf
, to work with Mac OS X (report
by Jeremy Huddleston).
- correct initialization of bold- and wide-, wide-bold fonts which
may be set via the
utf8Fonts
subresource (Debian
#347790).
- modify
sinstall.sh
to use POSIX locale to
bypass GNU ls changes to date-format.
- improved/refined changes for closing bitmap font (patch by
Andrea Odetti).
- improve resize computation for situations where the negotiation
fails, by invoking the xterm widget's core-class resize method
(Debian #365602, patch by Jim Paris).
- restore initialization of terminal's
VMIN
and
VTIME
settings,
from patch #232 changes
(patch by Matthieu Herrb).
- add configure check for
ttydefaults.h
, include if
needed, e.g., for systems where defining
_POSIX_C_SOURCE
, etc.,
prevents it from being included via
termios.h
(prompted by comments by Robert Delius Royar
and Jeremy Huddleston).
- patches from Alan Coopersmith. These correspond
to bug-ids on bugs.opensolaris.org
- 4029911
- fix a typo in manpage
- 4045962
- xterm doesn't properly set ut_syslen
- 4192572
- left-left-right misinterpreted as triple click
- minor optimization to tab-initialization (patch by
Németh Márton).
- fix a case where an incorrect font was freed during initialization
from patch #232 changes (patch by
Andrea Odetti).
- improve comparison used in
SameFont
function for
GC-caching (Julien Cristau).
- correct macro name used for default
CKILL
definition
to work with Mac OS X (report by Jeremy Huddleston).
- corrected logic in a font-cache used for reverse-video (Debian
#404079).
- add control sequence to alter
pointerMode
at runtime.
- add limit-checks for rectangle operation parameters (report by
Martin Pirker).
- modify
minstall.sh
to suppress $MANPAGER
and $PAGER
environment variables, which may interfere
with redirecting output of man
to a shell variable
(report/patch by Zdenek Sekera).
- do not try to hide mouse pointer in the tek4014 window, fixes
broken "-t" option at startup from
patch #230 changes
(report by Robert K. Nelson).
- correct datatype used when drawing tek4014 data using xterm
compiled for wide-characters, on big-endian machines (reports
by Jeremy Huddleston, Harald Hanche-Olsen, Martin Costabel, Merle
Reinhart).
- modify to cache the font-names along with the bitmap font data,
to improve comparison of fonts.
- modify to allow building with configure options
--disable-ansi-color
and
--disable-leaks
(Debian #459817, report/patch by Németh Márton).
- modify to allow building with configure options
--enable-wide-chars
and
--disable-c1-print
(Debian #459816, report/patch by Németh Márton).
- add
pointerMode
resource to control whether and
when the pointer cursor is hidden as the user types.
- simplify initialization of ttyMode- and related characters using
a table.
- modify initialization-logic for stty values that correspond to
ltchars structure and the BSD TIOCSLTC ioctl (susp, dsusp, rprnt
flush, werase, lnext). These were reset to constants for both
termios and legacy interfaces immediately after asking the system
for the existing values since X11R6.1, rather than using them to
provide inherited values. While the legacy interface has some
constraints, e.g., on HPUX, the POSIX or termios interface should
not. Your shell may reset these anyway
(prompted by patch by Ed Schouten).
- improve logic for hiding/displaying pointer-cursor (report by
Mark Brukhartz).
- add limit-checks to tabs.c, increase maximum column for setting
tab-stops from 320 to 1024 (report by Németh Márton).
- correct length, i.e., number of types of selection targets,
computed by
ConvertSelection()
when not handling
wide characters for the XA_TARGETS()
case.
This leaves an extra Atom on the end of the list which is
not handled by
Java applications.
The problem was introduced in patch #151
(report by David Wood).
- undo change to
getXtermCell()
from patch #230
using PACK_PAIR
macro (Debian #459014, analysis by
Caetano Jimenez Carezzato).
- minor documentation fixes (patch by Slava Semushin)
- add makefile actions to install KOI8RXTerm app-defaults file
(patch by Julien Cristau).
- add
quietGrab
resource, which when true, suppresses
cursor repainting when NotifyGrab
and
NotifyUngrab
event types are received during
change of focus (request by Nicolas George).
- do not treat Unicode BIDI control characters as combining
characters (Debian #457634).
- add
koi8rxterm
, from Debian.
- add manpage for
uxterm
, from Debian (Ubuntu #128136,
Debian #438645)
- remove ".xpm" suffixes from Icon filenames in desktop files since
it confuses some lookups following the
Icon Theme Specification
(report by Slava Semushin)
- correct width-calculation used for adjusting proportional fonts,
to work with wide-characters (Debian #441354).
- fixes/improvements for double-size characters:
- correct old clipping calculation which used total height of
glyphs where ascent was needed.
- if bold font is unavailable, fall back to normal font
- adjust to "work" with Xft (which does not support double-width
single-height characters).
- restore reset of doublesize for a line when it is cleared,
broken in patch #228.
- modify logic for
forceBoxChars
resource when using
TrueType fonts to be consistent with bitmap fonts
- modify logic for
forceBoxChars
resource to make the
"Line-Drawing Characters" menu entry use xterm's line-drawing
characters even asked to draw wide line-drawing characters which
are available in the font.
- modify rectangle-support functions to preserve colors when
filling/erasing (request by Enzo Toscano, to match WRQ Reflection
behavior).
- add getopt-parsing to tcapquery.pl, including feature to test the
extended cursor/editing keys.
- make missing double-width glyphs display as double-width
(Debian #456236).
- change
tcap-fkeys
and rectangles
configure options to enable them by default.
- hide the mouse pointer while user is typing (request by Rodolfo
Borges).
- extend configure options
--enable-tcap-query
and
--enable-tcap-fkeys
to
send cursor- and editing-keypad keys modified according to the
keyboard (or termcap) selection for shift, alt, control, meta.
- modify
kdch1
in termcap, e.g., xterm-r6
to match the terminfo file.
- add
-hm
option to turn highlightColorMode
on or off.
- add
highlightColorMode
resource to separate the
new (since patch #225) highlighting with both text- and
background-colors (prompted by report/example by Thomas Wolff).
- add Keep Selection menu entry to turn the
keepSelection
resource on/off at runtime.
- add
keepSelection
resource, which when enabled,
tells xterm to retain the X selection even after it stops
highlighting it (patch by Sergey Vlasov).
- extend the
CSI > n
sequence to allow
disabling all types of modified-keys that the
CSI > m
sequence affects.
- move include for
<xtermcap.h>
in
resize.c
to avoid redefinition of termios
structure on OpenSolaris (report by Rahul Gopinathan Nair).
- extend terminfo building blocks for modified editing keys to
include all six keys.
- synchronize terminfo with ncurses (report by Stephane Chazelas):
- equate
xterm-xfree86
and xterm-xf86-v44
.
- add ncurses extensions OTbs, AX, for termcap conversions.
- make old/legacy entries such as
xterm-24
, xterm-65
and aliases xterms
, vs100
inherit from xterm-old
.
- make
xterm-r5
and xterm-r6
the
same, ignoring historical errors in X Consortium's version.
- fix an ifdef in logic for selecting regular
expressions while in a narrow-character locale (Debian #449227).
- override locale in minstall.sh;
change in patch #226
does not work in UTF-8 locale (report by Zdenek Sekera).
- undo an incorrect fix for a memory leak
in patch #209 (Debian #435858).
- modify configure script to permit combining
--with-utempter
and --enable-setuid
, e.g., for using xterm with
the utempter library on FreeBSD (report by Andriy Gapon).
- modify "Quit" menu entry to override the
-hold
command-line option.
- add a check in the startup error-reporting to avoid writing to
pipe when it has not been opened. In that case, report errors
directly to the standard error.
- add OPT_READLINE definition to xtermcfg.hin, overlooked in
patch #205
(report by Kalle Olavi Niemitalo).
- modify
88colors2.pl
and 256colors2.pl
,
adding -r
option to reverse the palettes for the extended colors.
- check for partial overwrite or deletion of multi-column characters
in several cases, e.g., insert-character, delete-character,
etc.,
and fill the remainder of the cells used by the multi-column
characters affected with blanks.
- correct character-class codes in wide-character mode for characters
215, 247 (see also patch #165).
- fix missing assignment for UTF-8 parsing in widget initialization
(Debian #403360).
- correct index expression used to set line-wrapping flag, making
selection from scrollback work consistently (Debian #430121,
report by Vincent Lefevre).
- amend changes to handshake in
patch #226
to accommodate Solaris, which relies on the extra setting of
the terminal size after I/O initialization.
Do this by adding new resource
ptySttySize
,
which is false for Linux and MacOS X, i.e., true for
for Solaris and other SVR4 platforms, as well as FreeBSD
(reports by David Wood, Renato Botelho).
- check for X events after cursor-left, and carriage return,
consistent with indexing operations
(comments by Vegard Nossum and Ingo Molnar on a mailing-list).
- initialize the
.keyboard
structure,
needed for some platforms (such as Solaris) after
patch #227 fixes for keysyms
(patch by David Wood).
- update config.guess, config.sub
- exclude the Intel compiler from the extra gcc warning options
added in
patch #226.
- modify change for Debian #422521
from patch #226
to work with configurations where the X server does not
recognize
the
XF86Paste
or SunPaste
keysyms (report by Paolo Pumilia).
- fix incorrect free in fix for "Selection" menu entry in
patch #226.
- add configure check to use
-Wno-unknown-pragmas
for
Solaris, and a few other new gcc warning options to address
regressions in its warning options.
- add sample desktop and icon files, along with configure options for
manipulating them.
- fix an infinite loop when showing a 2-column character in a
1-column screen (Debian #426863).
- add
XF86Paste
and SunPaste
to the
default translations (Debian #422521, patch by Bernhard R Link).
- update wcwidth.c (partly based on/prompted by mailing list
comment).
- update/improve keysym2ucs.c based on Unicode 5.0.1d3 and Xorg
7.1 keysymdef.h file.
- improve
gen-pc-fkeys.pl
, making it show all of the
building-block terminfo entries used by xterm.
- correct strings used for modifiers applied to F1-F4 in xterm+pcf1
terminfo entry.
- improve session management by adding the ICE connection number
to the
select
call rather than waking up once per
second (patch by Miroslav Lichvar).
- add environment variable
$XTERM_LOCALE
to help
with shell initialization, e.g., to set a specific locale for
xterm on systems where a global locale is set in the shell
startup scripts.
- add resource settings
mkSampleSize
and
mkSamplePass
to modify the mkWidth
added
in patch #201.
In patch #202,
xterm would also check if the system's
wcwidth
matched its built-in tables
"well enough" to be used when mkWidth
was false,
and if not would use the built-in tables anyway.
These resources allow the user to customize the decision
(prompted by comments by Emanuele Giaquinta)
- modify logic which resets/updates the screensize on the child
process side of the pseudo-terminal to do this only if a
successful handshake was received, e.g., as determined by
the
waitForMap
resource (prompted by reports
by Emanuele Giaquinta and Bernhard R Link, but see also
patch #177 and
patch #159.
- improve permissions logic when closing pseudo-terminal
(Debian #12261,
patch by Nathanael Nerode,
analysis by Richard Braakman).
- add resource
highlightReverse
which controls whether
xterm will allow selection highlighting to hide reverse-video
or use the older behavior which inverts the foreground and
background colors when selected text with reverse-video attribute
(report by Adam M Costello, comments by Victor Vaile).
- restore a special case for cursor-color in
ReverseVideo()
lost in rewrite for patch #224
(report by Adam Sulmicki).
- correct initialization for menu entry for
bellIsUrgent
(patch by Emanuele Giaquinta).
- correct length of underlining for double-width Xft fonts
(report by Shidai Liu "Leo").
- correct clipping for double-width Xft fonts
(report by Shidai Liu "Leo").
- modify initialization for
italicULMode
to avoid
XftPatternBuild
reusing bold attributes
(report by Shidai Liu "Leo").
- add a check in case someone tries to call the
popup-menu()
action on a menu which is not initialized
(Debian #426364).
- improve CF_IMAKE_CFLAGS to work with Solaris sed (report by Peter
Bray).
- improve guess for X's manpage section in
minstall.sh
,
(prompted by comment by Miroslav Lichvar).
- modify
minstall.sh
to handle manpage patch with more
than one dot (patch by Miroslav Lichvar).
- fix configure message for --disable-setgid option (patch by
Miroslav Lichvar).
- add
allowTitleOps
resource to allow users to prevent
the title- and icon-names from changing (request by John Bashinski).
- fix "spawn-new-terminal" action, for the case where no parameter
is passed to the action (patch by Daniel Colascione).
- fix error-checking on internal font switching for "Selection"
menu entry (Debian #421523).
- amend select/paste change from
patch #225
by limiting it to non-UTF-8/non-KOI8-R encoding (Debian #420974).
- add workaround for groff ".URL" codes which are not present in
some commonly-used bitmap fonts (Debian #418324).
- add
useClipping
resource to allow clipping to be
disabled.
- use
XftDrawSetClipRectangles
to work around Xft pixel-trash (report by Reuben Thomas).
- add configure option
--enable-tcap-fkeys
, and
resource tcapFunctionKeys
, which can be used
to tell xterm to use function-key definitions from the termcap
(or terminfo) which it uses to set $TERM on startup.
- add resources
altIsNotMeta
and
altSendsEscape
to allow one to use Alt-keys like the
meta-key even if they are bound to different keycodes (prompted by
discussion with Daniel Jacobowitz).
- revert a change from patch #216
that unnecessarily made the meta modifier override
the
eightBitInput
resource if the alt- and
meta-modifiers happened to overlap
(report/patch by Daniel Jacobowitz).
- correct associated font for active icon for colored text
(broken in patch #224).
- correct ifdef's for Darwin (patch by Emanuele Giaquinta).
- add
highlightTextColor
resource, and options
-selfg
, -selbg
like xwsh
(adapted from patch by Victor Vaile).
- revise
find_closest_color()
function to address
concern about borrowing from Tcl/Tk
(request by Dan McNichol).
- add "spawn-new-terminal" action, which can be assigned to key
translation, allowing one to spawn a new copy of xterm using
the current process' working directory (adapted from patch
by Daniel Colascione).
- improve select/paste between UTF-8 and Latin1 xterms by adapting
the translations from patch #185.
Extend that to include Unicode fullwidth forms FF00-FF5E.
Also modify select/paste of DEC line-drawing characters in
Latin1 mode to use ASCII characters.
- add "Enable Bell Urgency" to VT Options menu, removed "Enable
Margin Bell".
- add
bellIsUrgent
resource to control whether the
Urgency hint is set/reset.
- modify to set Urgency window manager hint on bell, reset it on
Focus-In event (patch by Emanuele Giaquinta).
- add
--disable-setgid
configure option (request by
Miroslav Lichvar).
- fix a possible infinite loop in last change to
dabbrev-expand()
(patch by Emanuele Giaquinta).
- modify initialization to set the pty erase value if the
erase
is set in the ttyModes
resource.
This overrides the ptyInitialErase
setting (request by
Lluís Batlle i Rossell).
- add
initialFont
resource to xterm widget, like
tek-widget (Debian #299669).
- amend change to
boldMode
from
patch #223 for Debian #347790.
As noted in Debian #412599, that made xterm
no longer match the documented behavior.
Add new resource alwaysBoldMode
to allow overriding the comparison
between normal/bold fonts when deciding whether to use overstriking
to simulate bold fonts.
- restore background color in ClearCurBackground(), omitted in
changes for patch #223 (report by
Miroslav Lichvar).
- correct logic for repainting double-width TrueType characters
(prompted by test-case for Novell #246573).
- add a check to avoid trying to repeat a multibyte character
(report by Sami Farin).
- modify parameter to
XftNameParse()
to select wide
face-name as needed, to make -fd
option work (patch by
Mike Fabian, Novell #246573).
- correct logic for mouse highlight tracking's abort sequence,
broken in a restructuring modification from
patch #224
(report by Thomas Wolff).
- revert the simplification of blinking cursor, since that broke
the xor'ing introduced in patch #193
(report by Thomas Wolff).
- simplify code for set/reset mode for blinking cursor
(patch by Emanuele Giaquinta).
- modify
dabbrev-expand()
to restart after the last
match (patch by Emanuele Giaquinta).
- add control sequences for enabling/disabling focus in/out event
reporting (request by Bram Moolenaar).
- improve startup performance of menus by adding resource setting
menuLocale
which can be set to override X's
lengthy initialization of fontsets - which are seldom used
for the Xaw
popup menus (adapted from patch by
Dave Coffin).
- modify do_precomposition() function and make-compose.sh to handle
21-bit codes vs the 16-bit codes those were written for, and
fix a few mis-sorted codes
(patch by Thomas Wolff).
- handle special case in
-cjk_width
which unexpectedly caused a character's width to change when
a combining character
(patch by Thomas Wolff)
- fix build for GNU/KFreeBSD (Debian #40111).
- consolidate GC creation/updating into a single module to reduce GC
manipulation (prompted by Debian #389476, though a complete fix
would involve optimizing the scrolling behavior).
- fix ifdef of xtermCellWidth(), which broke for a case without
TrueType and without wide-character support (report by Martin
Pirker).
- undo a comparison in
handle_translated_exposure
which
did not work due to X server optimization. That caused the
inner border to be repainted with unexpected colors when handling
a repaint, e.g., after switching to/from another workspace
(Debian #401726, Redhat Bugzilla #223027).
- allow
-cr
option to override cursor color when
-ah
option is used (Debian #406502).
- add a note in xterm's manpage explaining that the
-bw
(or -w
) option is only used by the window manager,
if at all (Debian #405043).
- make
Selection
of VT Fonts
work with
selectToClipboard
resource.
- correct length calculation for
Selection
entry of
VT Fonts
menu, broken since it ignored the
actual selection length since X11R4.
- fixes for fontsize changes with
-fa
option (Redhat
Bugzilla #222340).
- add
--enable-rectangles
configure option (request by
Martin Pirker).
- correct default value for
--with-symlink
configure
option.
- fixes configure script macros that use
$X_EXTRA_LIBS
.
- modify configure script to provide support for pre-package config
versions of Xft (FreeType).
- add the Xaw scrollbar translations resource to the xterm manpage,
add an example showing how to change the mouse button assignments
(Debian #382225).
- amend a change from patch #216,
which omitted modifiers for control, meta, etc., if they were
mixed with any other modifiers. The intent of the change was
to avoid confusion with
XK_Mode_switch
and XK_ISO_Level3_Shift
;
the check is now done explicitly (report by Daniel Jacobowitz).
- interpret a negative value for
modifyCursorKeys
or modifyFunctionKeys
resources to disable the
respective features (prompted by Novell #220728).
- amend cell-width computation for FreeType from
patch #217, which did not work
for VT100 line-drawing characters (Debian #399638, GenToo #147111).
- amend a change from patch #216,
which made alt-modifier on a cursor-key send a modifier parameter
(Novell #220728).
- correct an off-by-one that made DECCRA not work (report/patch by
Martin Pirker).
- revert an optimization in SGR_Foreground() and SGR_Background
from patch #209 (Debian #347722,
analysis by Pierre Lombard).
- fix for
boldMode
(Debian #347790, patch by Tim Pope).
- amend fix for
-iconic
in
patch #208,
which broke the positioning part of -geom
with toolbar
configuration.
- fix to prevent indexing error in regular expressions (patch
by Dennis Schneider).
- fixes to make the internalBorder area not change color due to
reverseVideo and/or related exposure events. The latter was a very
old bug exposed in patch #196 (report by
Neil Hoggarth, also Debian #397624).
- minor optimization for recoloring cursor via dynamic colors.
- fix a bug caused by restructuring of tek4014 widget (report by Paul
Schenkeveld)
- fix for regular expressions: the code which converted the column
offset within a line did not check properly for the end of a line,
and if allowed to match the whole line, would select the beginning
of the following line. If the following line were empty, in turn
it would select from the next, etc. (report by Sean
Reifschneider).
- minor optimization of color allocation to avoid repainting the
screen if the corresponding color had not been allocated.
- fixes for vttests/256colors.pl (report by Egmont Koblinger).
- add terminfo building block entries for modifiers of the 6-key
editing keypad.
- fix for initialization of tek4014 which broke on QNX 6.1
- make "xterm -t -iconic" work as expected, i.e., start in tek4014
mode, but iconified.
- some internal restructuring to separate data for vt100 and tek4014
widgets.
- fix a few cases where form-events would be seen by the vt100
widget when built with the toolbar configuration.
- change behavior when encountering an illegal character in a title
string. Rather than reject the string, translate illegal
characters into "?" and use the string (requested by Thomas Wolff).
- improve checks for nonprinting characters in title strings
(report by Samuel Thibault).
- correct typo in menu labels, changing
print-redirect
to print-redir
, making it follow the manpage and
match the usage for the actions table (report by Samuel Thibault).
- correct a typo that prevents building with some older systems such
as Solaris 2.6 (report by Julian Bridle).
- minor improvements to FreeType font layout and drawing.
- add a check in the ptyInitialErase logic to ensure that the
termcap was read (Redhat Bugzilla #201246).
- limit changes for reverse-video from
patch #216 to cases where the
reverse-video command-line option is used
(report by Zdenek Sekera).
- correct bitmap-derived pointsizes for TrueType fonts; they should
be proportional to the square root of the area of the bitmap
fonts.
- add resources to specify pointsize of TrueType fonts (request
by Reuben Thomas).
- improve install of terminfo by filtering out harmless messages
related to extended capabilities. At the same time, use ncurses
tic to compile the extended capabilities if possible
(report by Zdenek Sekera).
- update "xterm+pcfkeys" terminfo entry to correspond to
patch #216.
- improve handling of
ConfigureNotify
events by checking
if there are further events in the queue which obsolete the current
one (adapted from rxvt 2.7.5). Only the normal normal
(non-toolbar) configuration is addressed in this patch.
- several changes to terminfo:
- incorporate some minor changes from ncurses to help keep these
synchronized:
- 2005-02-26
- modify sgr/sgr0 in xterm-new to improve tgetent's derived "me".
- 2006-02-18
- remove ncv flag from xterm-16color
- 2006-06-24
- improve xterm-256color by combining the 16-color
setaf/setab strings with SGR 48,
and cancelling the setf/setb strings.
- use extended function-key definitions for xterm-sun, xterm-sco
entries.
- add terminfo building-blocks corresponding to the
modifyFunctionKeys
and modifyCursorKeys
resources.
- ifdef'd Sun function-key feature to make it optional, like HP and
SCO.
- extend table for termcap-query feature through F63, and updated
tcapquery.pl to match.
- modify logic for function-key input processing to allow function
key numbers which are constructed by control- and shift-modifiers
to extend beyond X's hardcoded limit of 35.
- add control sequence to set or reset the
eightBitInput
resource.
- change default resource
modifyFunctionKeys
to 2
to avoid sending SS3 with parameters (report by Kalle Olavi Niemitalo).
- add control sequences for setting and resetting the values of the
modifyCursorKeys
,
modifyFunctionKeys
and
modifyOtherKeys
resources.
- add
modifyFunctionKeys
resource like
modifyCursorKeys
.
Setting this to zero allows one to use the control- and
shift-modifiers to construct function key strings,
for terminals using many function keys,
e.g., for xterm-sun
or xterm-sco
.
- modify screen responses and function-key logic to reduce the
number of writes made, to make it less likely that an application
would read only part of a function-key in a read operation
(suggested by John E Urbanczyk).
- add
combiningChars
resource, which allows the user to
specify the maximum number of combining characters that xterm will
store for each cell in wide-character mode (prompted by request by
Markus Kuhn to increase the limit from 2).
- improve logic in
metaSendsEscape
in case the Alt-
and Meta-keys are mapped to different modifiers. That allows one
to use the Alt-key for shifting in the eightBitInput
and use a Meta-key modifier to prefix the result with an
<ESC>
.
- improve
modifyCursorKeys
logic to prevent it from
modifying codes where eightBitInput
or
metaSendsEscape
are set
(request by Dan Nicolaescu).
- improve
modifyCursorKeys
logic to prevent it from
changing the user input when other modifiers such as AltGr are used
(report by Thomas Wolff).
- extend
modifyCursorKeys
to include the numeric keypad
when in application mode.
- improve
-reverse
(-rv
) option
(patch by Jason Vas Dias, Redhat #189161).
- workaround for color resources on Fedora-5 which made the toolbar
colors inconsistent.
- corrected calls used for
--disable-setuid
option,
add debugging traces to help diagnose this area.
- modify configure script to ensure that
USE_UTMP_SETGID
is defined only if the check for POSIX saved-ids succeeds, or
corresponds to one of the BSD systems known to have a workable
setegid
function.
- extend configure check for POSIX saved-ids to include BSD systems
- modify CF_SYSV configure macro to work with gcc on HPUX 10.20,
whose broken
<term.h>
relies on including
<termios.h>
.
- change order of setuid/setgid ifdef checks in Imakefile to make
it simpler to produce a setgid install, allowing the latter to
override the former (prompted by an XFree86 commit).
- adapt a fix for setgid support from subsequent XFree86 changes
(patch by Emanuele Giaquinta).
- further improve setgid support (patches by Emanuele Giaquinta).
- improve setgid support by exploiting the saved-ids feature on which
it relies (patch by Emanuele Giaquinta).
- make the
modifyOtherKeys
resource disabled by default
since the intermediate setting altered some common bindings
(report by Emanuele Giaquinta).
- modify makefile rule for ctlseqs.txt to strip backspace/overstrikes,
and add a copy of ctlseqs.txt to the source tarballs (requests by
Bram Moolenaar, Emanuele Giaquinta).
- add
modifyOtherKeys
resource, analogous to the
modifyCursorKeys
resource. This applies to keys that
normally would transmit nothing when a given modifier is applied
(request by Dan Nicolaescu).
- add
default
to the acceptable values for the
keyboardType
resource, allowing the -kt
command-line option to override app-defaults resource settings of
sunKeyboard
, etc.
- correct ifdef's for
XkbBell()
which used the header
file but not the corresponding function in
patch #175
(report by Zach Beane).
- add xterm manpage to the
--with-symlink
logic.
- regenerated configure script to omit some debugging artifacts of
the SIGWINCH test.
- fix
install-man
rule in Makefile.in
to
avoid including the $(DESTDIR)
value in substitutions
made on the manpages (patch by Emanuele Giaquinta).
- improved fix for cursor deallocation
(Redhat #186935, patch by Jason Vas Dias).
- improve checks for setuid/setgid operation to accommodate limited
resource management in some kernels (GenToo #193238).
- update config.guess, config.sub
- minor optimization to cell layout; will use that to simplify some
logic and allow for more than two combining characters in another
patch.
- add
utf8Latin1
resource to make optional the
feature from patch #209 which
allowed ISO-8859-1 fonts to be used in cases
where a wide font was given. This would only
work for the special case where the user normally used Latin-1
and wanted some wide characters (report by Rostislav Krasny).
- add
utf8Title
resource to manpage (Novell #52655).
- fix typo in table entry for
utf8Title
resource which
made it treated as an integer rather than boolean (patch by Mike
Fabian, Novell #52655).
- improve description of
forceBoxChars
in manpage
(discussion with Joe Wells).
- set checkmark for "Select To Clipboard" menu entry on startup,
from resource setting.
- update manpage to note that
*customization:color
is
not needed, though it is useful (Redhat #188034).
- add underscore to sample pattern for URL in
XTerm.ad
(Redhat #188037).
- modify install rule for manpage to use the configured app-defaults
directory (Redhat #188031).
- add checks in
releaseCursorGCs()
to ensure GC's are
distinct, needed since memory leak changes for
patch #208
(Redhat #186935, patch by Jason Vas Dias).
- modify
Imakefile
definitions to allow
imake
to set InstallXtermSetGID
.
Add symbol InstGidFlags
.
- add configure script check to ensure that SIGWINCH if defined even
when headers undefine this as a side-effect of
_POSIX_C_SOURCE
, etc.
- resync with XFree86 CVS:
- ifdef-out chmod of terminal device for OS/2 (XFree86 #1663,
Frank Giessler).
- move new
Imakefile
chunk which defines
$(CSGIDFLAGS)
before DEFINES,
e.g., for IRIX64 (Marc La France).
- modify prefix/suffix transformation in makefile to make
uxterm
install properly on Cygwin.
- restore the sizeof-comparison for
struct lastlog
added in patch #208,
rendered (mostly) obsolete in patch #210,
since an imake configuration can still turn that code on
(prompted by comment by David Dawes).
- remove feature for
FreeBSDArchitecture
from
Imakefile
which would install xterm using the
utmp
group since a standard FreeBSD system has no such
group, though it would support this configuration. FreeBSD
packager uses the configure
script, which can make the
appropriate check (prompted by comment by David Dawes).
- fixes for gcc redefinition warnings when built using imake
(reports by David Dawes, Marc La France).
- add configure check for workaround in
patch #208
for Solaris' inconsistent support for struct lastlog to quiet
compiler warnings
(prompted by David Dawes commit message for XFree86).
- fixes for BASE64 selection manipulation,
e.g., ensure that the string
terminator is written after cut-buffer data (report by Joe Allen).
- add vttests/paste64.pl script to test experimental option for
setting/getting selection data.
- add some error-checking in fontutils.c
(prompted by David Dawes commit message for XFree86).
- change xterm manpage to show the actual color resource names
XtDefaultForeground
and
XtDefaultBackground
rather than black and white
(prompted by discussion with Emanuele Giaquinta).
- add
utf8Title
resource and menu entry, allowing the
user to control whether title strings are interpreted as ISO-8859-1
or UTF-8 encoding (Novell #52655, #113206).
- change order of ifdef's for utempter versus platforms in
Imakefile
to ensure a proper value for
InstallXtermSetGID
(prompted by Marc La France commit message for XFree86).
- update the cursor GCs when menu entry for reverse video is toggled.
(Redhat #183993).
- a memory-leak fix for
set_cursor_gcs()
in patch #208 broke the
-cm
option (Redhat #182382).
- remove
setf
and setb
from
xterm-256color
terminfo entry to avoid issues with
applications that ignore the ANSI strings (report by Emanuele
Giaquinta).
- remove obsolete references to "Xorg" to avoid confusion with
"X.org" (prompted by David Dawes commit message for XFree86).
- improve initial layout performance for the toolbar configuration
by precalculating the height of the toolbar.
- remove menu entry for "Enable Curses Emulation" (to make room for
"Select To Clipboard").
- add resource
selectToClipboard
,
action set-select
and a menu entry to allow
users to switch between PRIMARY and CLIPBOARD for select/paste.
- allow cursor to have the same color as foreground (text), since it
is rendered as reverse (Debian #350664).
- amend change for loading
utf8Fonts
resource from patch #204 to allow an ISO-8859-1 "normal"
font to be combined with an ISO-10646 font if the latter is given
via the -fw
option or its corresponding resource
value (prompted by comment in Novell #49305).
- add
TIOCSCTTY
ioctl()
ifdef'd for
__GNU__
to set the controlling terminal (Debian
#348457).
- add configure option
--disable-leaks
.
- add a check in
Bell
to ensure that the VT100 widget
is realized, since it may be called by xtermLoadFont
given an incorrect font resource (Redhat #180450).
- improve initialization of wide-bold font by not using the derived
value when it happens to have few glyphs (report by Mboso Sampson).
- improve dynamic colors by not repainting the screen if only the
cursor color changes (request by Bram Moolenaar).
- fix menu initialization for tek4014 window broken in
patch #206.
- typo in manpage (Debian #351425).
- correct loop logic in
dotext
to prevent an infinite
loop if a wide character was just at the right margin when wrapping
was disabled (report by Serge van den Boom).
- initialize the saved-cursor data so a restore-cursor operation
without a preceding save-cursor operation will not modify the
foreground color.
- add a new selection feature: regular expressions, and new resources
which specify what happens on multiple mouse clicks:
on2Clicks
,
on3Clicks
,
on4Clicks
and
on5Clicks
.
- revert the
XTerm.ad
change from
patch #208 (Debian #348384).
- fixes for the print-window to make it handle combining
characters in UTF-8 mode.
- add check to ensure that double-clicking to extend selection will
not extend it into the scrollback area. This still allows users
to scroll back and select text (Debian #347415).
- add configure option
--with-tty-group
to help work
around deficiencies in packager's build environment (Debian
#349142).
- fix typo in configure script option
--disable-narrowproto
(report by David Martínez Moreno).
- amend CF_X_FREETYPE changes for
pkg-config
check to
ensure that Xft
is known to that tool (report and
patch by Emanuele Giaquinta).
- add an ifdef to allow
./configure --disable-active-icon
to work, broken by new code for testing memory leaks in
patch #208 (report by Brian Lindholm).
- add
charClass
resource to XTerm.ad
and
UXTerm.ad
which simplifies selecting URLs (prompted
by Kirill Ponomarew).
- modify install rule for
uxterm
to account for the
--program-prefix
, etc., options by invoking the
transformed name of xterm rather than simply "xterm".
- modify configure
--with-app-defaults
option to allow
--without-app-defaults
.
- add configure
--with-symlink
option to make it simpler
to install successive versions of xterm
renamed using
the --program-prefix
, etc., options with a symbolic
link pointing to the most recent.
- make
-iconic
option work with toolbar configuration
(GenToo #113604).
- suppress
lastlog
feature for 64-bit Solaris
configuration since that platform provides only a 32-bit interface
(report by Peter Bray).
- fix memory reallocation for the "UTF-8" menu entry when xterm is
started using the
+u8
option (reported by Jan Willem
Stumpel).
- add a configure check for the actual path of
luit
,
to work around broken imake
configurations.
- add a configure check for
pkg-config
(Redhat Bugzilla
#173541).
- modify install-rule for
uxterm
to omit executable
suffix, e.g., for Cygwin.
- modify
sinstall.sh
to work around quirks in Cygwin
configuration.
- enable
lastlogx
support for NetBSD (was added, but
not enabled in patch #186).
- work around broken
lastlog.h
in glibc 2.3.5, which
includes utmp.h
.
- revert part of recent XFree86 Imakefile change, restoring the
-I.
needed for xmkmf
builds of xterm
(XFree86 Bugzilla #1633, reports by Alexander Pohoyda and Matthieu
Herrb).
- change compiled-in default for
printerCommand
resource to an empty string. People who want to use the
printer should be able to read the manual (Debian #311490).
- modify
Imakefile
to work around old problems in
imake
configuration to allow test-builds using
xmkmf
on Linux. (This was not noticed since several
releases had broken definitions relating to Xft which were harder
to work around).
- link
resize
for SCO platforms (Kean Johnston).
- add configure
--with-app-defaults
option to allow
app-defaults directory for install-rules to be customized.
- remove default translations for
dabbrev-expand()
due to conflicts with existing keyboard arrangements.
- remove redundant check for
_NET_WM_PID
(report by Emanuele Giaquinta).
- set icon border width explicitly to work around fvwm problem
with active icon resizing (report by Steve Morris, analysis
by Dominik Vogt).
- modify resource files to make the font-resources a little
more specific, e.g., changing "*VT100*" to "*VT100.", to
make the distinction between VT100.font and VT100.utf8Fonts.font
sharper, in case a packager modifies one of those.
- expanded comments in
UXTerm.ad
regarding the
font resources (Debian #319179).
- add
--enable-narrowproto
configure option to
accommodate X.org "modular" build (report by Stephan Hermann,
GenToo #17220).
- fix typo in xterm.man description of
+wf
(patch
by Tobias Stoeckmann).
- add
scrollBarBorder
resource (request by Floyd L
Davidson).
- modify
xterm-new
terminfo entry to use capabilities
for shifted scroll forward/reverse as shifted cursor up/down.
- correct updating of checkmark for toolbar entry in popup menu
(report by Emanuele Giaquinta).
- fix ifdef's to allow compiling with toolbar and without tek4014
(patch by Emanuele Giaquinta).
- use
openpty()
for Darwin port (patch by Emanuele
Giaquinta).
- fix GenToo #90697 a different way, postponing the logic in
SetupToolbar
until the toolbar is actually needed,
i.e., the +tb
option is handled as expected.
- revert fix made in patch #203 for GenToo
#90697. That introduced a problem with the control mouse
click-popups, while most of the performance problems can be
resolved by restricting the menu fonts (report by Emanuele
Giaquinta).
- fix a file-descriptor leak when calling
openpty()
(OpenBSD system/4561).
- make a special case of resizing work like vt100: a hard reset
also resets the 132/80 mode. The code to support this was
present since X11R5, but not used because the corresponding
initial state of the
-132
option was not saved.
- restore window manager hints after
XtMakeResizeRequest()
calls. One instance from patch #205
resulted in the window manager displaying pixels rather than
than characters after selecting a different font size (FreeBSD
ports/87424).
- remove special case for Darwin in CF_XOPEN_SOURCE
(Emanuele Giaquinta).
- modify parsing of control sequence
CSI T
to allow scroll-down
to be sent while mouse tracking is enabled (request by
D Hugh Redelmeier).
- correct termcap "me" (mode-end) string so it does not modify the
alternate character set (report by Andrey Chernov).
- correct size-comparison in HandleInterpret() broken in changes
from patch #201 to allocate input
buffer (Debian #334317).
- amend adjustments for scrollbar layout from
patch #204 to make
this apply only to the toolbar configuration. In the non-toolbar
configuration, the resulting scrollbar was shifted by its
borderwidth (report by Matthieu Herrb).
- add select-cursor-extend() action.
- fix some broken href's in xterm.log.html, and typo in the
INSTALL file (report/patch by David Martínez Moreno).
- modify
Imakefile
to use setgid mode for installing
with Linux, OpenBSD and FreeBSD.
- add configure --with-setuid and --with-reference options to
allow packagers more flexibility in customizing install
permissions.
- generalize and make optional (configure --with-utmp-setgid)
the change made for XFree86 Bugzilla #878 in
patch #205
(FreeBSD bug report #ports/86663).
- correct a typo in CF_FUNC_TGETENT introduced in patch #198 fix for Gentoo #69926.
- implement logic in termcap query to process multiple parameters
as documented in ctlseqs.ms
- fix buffer size used for termcap query, which was not long enough
for the terminfo "colors" name (patch by Bradd W. Szonye).
- add configure option --enable-readline-mouse, which turns on the
experimental OPT_READLINE code (patch by Ilya Zakharevich).
- for FreeBSD, drop setuid privileges after startup
(XFree86 Bugzilla #878, report/patch by Alexander Pohoyda)
- add menu entry (alt-esc) and corresponding action (alt-sends-esc)
to toggle the
eightBitInput
resource setting.
- generate configure script with autoconf 2.52 (patched) to use
the feature therein which forces the script's locale to POSIX
(Gentoo Bugzilla #105369).
- modify computation of rows/columns on resize to avoid extending
beyond the given limits, e.g., if resizing in response to a
"maximize" in Gnome or KDE which do not use the window manager
hints for this case (Debian #289123, Novell #61153).
- modifications to work with z/OS 1.4 (Paul Giordano).
- improve error-reporting when chown/chmod of the pseudo-terminal
fails, e.g., if a copy of xterm which was designed to work with
old-style pseudo-terminals is not installed setuid or setgid
(report by Jeremy C. Reed).
- patches from Emanuele Giaquinta:
- ctlseqs.ms says that primary and secondary DA accept a
nonzero parameter, which is incorrect. Also modify code
to agree with this.
- correct a comment in 88colres.pl
- ctlseqs.ms says that the DEC Set/Reset control sequences for
the backarrow key make it send DEL/BS, respectively, while it's
the opposite.
- update the menu entries for the metaSendsEscape, deleteIsDEL
and numLock resources when changing them with the corresponding
DEC Set/Reset control sequences.
- fixes for configure script:
- add special case for QNX, defining _QNX_SOURCE.
- check for preprocessors which do not perform -U and -D options
in the given order.
- improve macro to determine gcc version
- improve check for Intel compiler and related warning options
- update config.guess, config.sub
- improve fix from patch #198 for
Cleanup()
by ensuring it is not called from the
SIGCHLD handler (patch from OpenBSD by Todd Miller).
- eliminate a retry for a better-matching bold font, to work around
recent font server changes.
- fixes for Novell #113277:
- specify weight for wide font which may be derived from
normal fontname.
- cache the derived wide- and widebolt-fontnames.
- workaround for GenToo Bugzilla #100728.
- add menubar's border width to layout computation. Normally this
is zero, but patterns such as
XTerm*borderWidth:1
would give poor layout for the toolbar configuration.
- work around quirk in shell which allowed user to "run" uxterm
script when there was no UTF-8 locale installed by entering
"sh -x uxterm". Also popup an xmessage to show the problem
for users who run this via a GUI (Debian #318513).
- disallow changes to fonts, toolbar and scrollbar when the vt100
window is iconified, to simplify management of the active icon.
- fixes to make
-geom
option work properly with the
toolbar configuration (Gentoo Bugzilla #90717, #91967).
- minor improvements to scrollbar layout: ensure that the scrollbar
border is zero if the vt100 border is zero.
- improve initialization due to
utf8
resource by
loading the utf8Fonts
resource in the case where
locale
resource is false. Also in this case, do
not disable switching UTF-8 mode on/off.
- minor optimization of TrueType font-loading, loads italic font
only when needed.
- correct variable used to store temporary result from lookup of bold
font, when initializing the wide-bold-font data and no immediate
match is found by asking for a bold variant of the wide-font. The
result was to use overstriking rather than the actual bold font
(Debian #318162, patch by Eugene Konev).
- add checks to ensure vt100 widget is realized when it might be
updated via actions handled from a tek4014-only configuration.
- modify initialization of
allowSendEvents
and
allowWindowOps
to prevent modification with the
editres protocol.
- fix compiler warning for NetBSD by including util.h in main.c
(XFree86 Bugzilla #1596).
- fix to build on Darwin 8.x, which no longer provides
setpgrp()
(patch by Min Sik Kim).
- adapted fixes for Legend (SCO) from diffs attached to
Freedesktop.Org Bugzilla #3180.
- fix typo in xterm manpage description of
-ls
option
(Freedesktop.Org Bugzilla #3543).
- add support for interpreting the underline attribute as an italic
font in Xft mode (patch by Chuck Blake).
- improve initialization of toolbar so that individual pulldown
menus are initialized on demand, as they are in the scenario
where they are invoked as popup menus (GenToo Bugzilla #90697).
- fix logic in
find_utmp
, which did not reset result
in getutid()
, causing an infinite loop in some
conditions (report by Emil Mikulic).
- set the
_NET_WM_PID
property (GenToo Bugzilla #91008).
- modify ifdef's in ptyx.h and xterm_io.h to build with DragonFly
(patch by Jeroen Ruigrok).
- change default values for
minBufSize
and
maxBufSize
to 4096 and 32768 respectively so that the
initial read request will match the value from before changes to
use sched_yield()
.
- make paste of UTF-8 faster for Western character sets by checking
range of incoming data (patch by Joe Allen).
- adapted patch by Joe Allen to add experimental option to allow
applications to get or set the selection data as a BASE64 string.
- fix an off-by-one error parsing
-S/nn
option
(Debian #311438, report/fix by Peter Chubb).
- fix an initialization bug from
patch #201 that broke logging
(report by Rodney Thayer).
- amend change to command-line processing in
patch #201 to avoid
conflict with
-e
option (report by Servatius Brandt).
- suppress configure check for
_XOPEN_SOURCE
on
darwin.
- update config.guess, config.sub
- add extended shift- and control-modifier cursor keys to
"xterm+pcfkeys" terminfo entry to correspond to ncurses 20050430
patch.
- fix a rare case where text would be written with the wrong colors
because output of scrolled text would reset the colors and the
new text would be written with the same colors (report/testcase
by Thomas Glanzmann).
- rename
$CMD
variable in plink.sh
because
it is a reserved symbol in bash 3.00.16 (report by Ted Taylor).
- add environment variables
$XTERM_SHELL
and
$XTERM_VERSION
(request by Zdenek Sekera).
- corrected workaround for background color of menubar, which gave
a too-broad expression, coloring the background of the VT100
widget unless overridden by another resource setting.
- correct an error in the logic which decides when
sched_yield()
is run; it would occasionally hang when
contending with other pseudo-terminal applications such as screen
(report by Kirill Ponomarew).
- modify initialization to decide whether to default to built-in
wcwidth()
versus system's version based on the
starting locale and whether the system's version is poor quality
(suggested by Bram Moolenaar).
- update table for
mk_width()
from UnicodeData 4.1.0
using Markus Kuhn's uniset
script.
- improve resource files to show how the menubar and popup menus can
be colored (prompted by report by Joe Wells).
- modify parsing of OSC (and SOS, etc), strings so their contents
are not interpreted as UTF-8. This allows non-ASCII title strings
to be set, provided that the window manager complies (report by
Thomas Wolff).
- improved some of the built-in line-drawing glyphs.
- correct color of "box" character drawn for line-drawing glyph 1
(report by Nicolas George).
- improve behavior when switching to UTF-8 mode after startup so
xterm will check if the current fonts are already wide
(ISO10646-1). If they are not, xterm will use the
utf8Fonts
subresource to load appropriate fonts
(request by Bram Moolenaar).
- modify logic for setting title-string so it applies to the current
widget rather than the vt100 widget.
- modify initialization for wide-bold fontname, to search for one
if none is given (report by Michael Schroeder).
- add resource
mkWidth
and command-line option
-mk_width
to control whether xterm uses the built-in
version of wcwidth().
- add resource settings for minimum/maximum input buffer size, and
call to
sched_yield
to improve performance with newer
Linux kernels (adapted from patch by Nicolas George).
- correct computation of width for wide characters with the invisible
attribute (report by Thomas Wolff).
- modify interaction between
+u8
and locale
resource to allow the command-line option to override the resource
(requested by Thomas Wolff).
- add a limit check for scrolling margins in a one-line screen,
overlooked in fixes for
patch #198 (Debian #297430).
- correct treatment of
iconBorderWidth
for resizing
an active-icon, and its description in manpage (Debian #296592).
- modify configure script
--disable-imake
to use the
script's definitions anyway if it cannot detect imake (prompted
by FreeBSD bug 77408).
- ignore error in the I/O initialization that tries to set the
tty to 7-bit input for the case where
eightBitInput
resource is false (Debian #298551).
- modify command-processing to accept an optional parameter that
tells xterm which shell program to use (request by Zdenek Sekera).
- add simpler resource
keyboardType
which, when set,
overrides the individual keyboard-type resources and eliminates
the possibility of conflict between them.
- add initialization for
scoFunctionKeys
resource
(report by Rick K).
- correct logic of
ReallocateBufOffsets()
which did not
copy the content of the old screen buffer to the proper location,
making a repaint clear after switching to wide-character mode
(report by Bram Moolenaar):
- implement the remaining pieces to make xterm allocate cells for
wide-characters when the "UTF-8" menu entry is selected. Also,
load the UTF-8 font when that menu entry is selected, or the escape
sequence for UTF-8 mode is received (report by Bram Moolenaar):
- add command-line options (
-tb
, +tb
) and
resource toolBar
to allow menu/toolbar to disabled or
enabled at startup (prompted by reports by Joe Wells).
- correct typo in configure script's --enable-dec-locator option
(report by Bram Moolenaar).
- increase color pairs value for xterm-256color and xterm-88color to
match ncurses, which has an experimental option to support this.
- modify ifdef's to make AIX use termios rather than termio; the
struct sizes for the two were not the same.
- improve CF_WITH_IMAKE_CFLAGS configure macro script for
OSMAJORVERSION and OSMINORVERSION values, e.g., for Tru64 and AIX.
- modify ifdef to define USE_POSIX_TERMIOS for Darwin (patch by Min
Sik Kim).
- modify find_utmp() to initialize the whole utmpx struct (except
ut_id), since that is needed for OSF1 4.0D to prevent an infinite
loop on exit.
- add configure check before adding -D_POSIX_SOURCE since some
platforms predefine it, e.g., cygwin.
- add simplified sed expressions in CF_IMAKE_CFLAGS configure script
macro to ensure value for PROJECTROOT is quoted on Solaris, i.e.,
when nested
\(
and \)
are not interpreted
correctly.
- correct DEC rectangle operations to reset state after completing
the operations.
- modify CASE_ST handling in charproc.c to ensure that the parse
state is reset even if xterm is not currently processing an OSC or
other string (patch by Johnny Billquist forwarded by Matthias
Scheler, NetBSD xsrc/29003).
- fix OS/2 build for innotek_libc (patch by David Yeo).
- fix a regression from patch #197 fix for
Debian #277832 which disowned the selection if it was scrolled,
e.g., by the user pressing return at the bottom of the screen
(Debian #291787).
- move the warning/exit for missing $DISPLAY into the error handler
in case
-display
is given, and the connect fails for
some other reason.
- instead of setting
$DISPLAY
, check for the unset
variable and warn/exit on this condition (comments by H Merijn
Brand and Bernhard R Link).
- fix a typo in Imakefile from patch #198
(reports/patches by Stefan Dirsch, and Mike Castle).
- set
$DISPLAY
to ":0" if it is not set.
- add
utmpDisplayId
resource to allow users to control
whether the display identifier (display number and screen number)
are retained in the connection information recorded in utmp
(discussion with Edoardo Tirtarahardja).
- add
bellOnReset
resource to allow users to disable
bell which sounds on hard reset since patch
#183 changes to DECSCL (discussion with Danek Duvall).
- improve
$WINDOWID
for configuration with toolbar by
making it refer to the top-level shell rather than the parent of
the current window. For that case, the parent is a form widget,
which does not have a name, which made the $WINDOWID
not very useful as a parameter for xwininfo
(suggested by Dave Bodenstab).
- fix a typo in WhichVFont() macro
from patch #197 changes
which broke the --disable-active-icon configuration
(report by Ralf S. Engelschall).
- improve some limit checks (Gentoo Bugzilla #75604).
- add --disable-setuid option to configure script (Gentoo Bugzilla
#76543).
- add --disable-full-tgetent option to configure script, allowing one
to ignore a termcap library in favor of ncurses/curses (Gentoo
Bugzilla #69926).
- modify configure script to choose useful warning options for Intel
version 8.0 compiler.
- update config.guess, config.sub
- make active-icon work properly when TrueType fonts are used
(Debian #286068).
- correct change from patch #157 which uses
getlogin() to check for an alias; the storage used for the related
getpwuid() call was overwritten by the data used for comparison
(patch by Per Hedeland).
- correct case of SCS for character set 0 (line-drawing) to allow it
to be selected into GR.
- fix a file-descriptor leak (Redhat Bugzilla #139597).
- modify
creat_as()
to only fork if xterm is actually
running as setuid and/or setgid. This works around a Cygwin bug
which hangs when logging is enabled and makes xterm a little
faster for systems using interfaces such as utempter (report by
Al Goodman).
- modify
Cleanup()
to avoid operations such as X calls
that might use unsafe functions when it is called by a signal
handler (report by Michiel Boland).
- fix bugs in patch #191 and in SRM changes
from patch #197 that
broke DECSET 38: switch to Tek4014 emulation (report by Dave
Bodenstab).
- fix for manpage escapes (Marc La France).
- improve on IRIX-specific change for Imakefile in XFree86 CVS versus
resize linking against termcap library to reflect definitions for
USE_TERMCAP in resize.c
- modify configure script to remove empty "-DPROJECTROOT=" definition
which resulted unusable values for luit's default path.
- update precompose.c based on Unicode 4.0.1
- several minor fixes based on Intel compiler warnings.
- change default translations so a
BtnDown
which is
not recognized is simply ignored rather than emitting a bell.
That makes it less obtrusive when the user tries to use a mouse
which provides more capabilities than the X mouse driver supports,
e.g., one with a horizontal scroll wheel (Debian #265133).
- note in xterm's manpage that
translations
is not
specific to xterm (Debian #278897).
- modify uxterm script to use locale program to verify if the
derived locale is installed (Debian #246398).
- correct font handling for active icon when in UTF-8 mode (report
by Paolo Liberatore).
- make active-icon and toolbar configurations work together.
- modify the criteria for disowning primary selection. Previously,
this happened anytime the cursor was moved before the end of the
selection. That would ensure that any insert/delete of char or
line, as well as scrolling, would disown the selection. The
new criteria change this to checking if the operations would
modify the data which is highlighted (Debian #277832).
- reimplement
DECALN
with functions for vt420 rectangles,
fixes selection for this case.
- implement vt420 rectangle operations.
- add parsing, for debug/test of vt220 soft-fonts.
- add menu entry, actions and escape sequence to allow
enabling/disabling toolbars at runtime.
- improve rendering for Xft, allow it to draw non-linedrawing
characters such as "pi", which were drawn from internal tables
with patch #180
(Freedesktop.org Bugzilla #1260).
- add configure option
--enable-mini-luit
, ifdef'd the
mini-luit feature with OPT_MINI_LUIT
.
- add mini-luit feature, which supports Latin9 directly rather than
via luit, provided that Unicode fonts are used (Freedesktop.org
Bugzilla #1571, request by Stefan Dirsch, patch by Michael
Schroeder).
- for Linux, if IUTF8 is defined, e.g., on recent 2.6.x kernels,
set the corresponding flag for the slave pty, to enable UTF-8
interpretation of backspace in cooked mode (Freedesktop.org
Bugzilla #1578, request by Stefan Dirsch).
- modify
faceSize
resource to use a floating-point
internal value (adapted from patch by Sam Stephenson).
- correct handling selection of tabs over cleared space in UTF-8
mode. In this special case, xterm represents the whitespace with
a null rather than a space character (Debian #276447).
- amend fix for infinite loop from patch
#192 to check if there is wrapped text to output in a following
iteration (Debian #273202).
- fixes ifdef'd with
__INTERIX
to allow building with
Interix (Windows Services for UNIX) 3.5 using the xlibs libraries
from freedesktop.org (patch by Min Sik Kim).
- amend solution for Debian #252873, #260471 from patch #194 by making the cursor not
explicitly colored if only the foreground color is set, and the
cursor is on a blank space (Debian #275473).
- correct logic for send/receive mode (SRM) with regard to control
characters.
- fix masking of invisible text in wide-character mode, which did
not work for line-drawing characters.
- incorporate CF_XOPEN_SOURCE into configure script, replacing
CF_GNU_SOURCE.
- add a special case to configure script to ignore NetBSD's
grantpt()
which was recently added (but not part of a
release), until someone is able to ensure that xterm can use it
(report by Min Sik Kim).
- clear the buffer returned by getutid(). This fixes an infinite
loop on some platforms introduced in patch
#193 by Debian #256468 fix (report by David Ellement).
- correct length used for blinking text, make the last column blink
(patch by Alexander V Lukyanov).
- start changes to make doublesize characters work with TrueType
fonts (see patch #44).
- trim leading/trailing blanks from color resources as done for
other strings in patch #167.
- fixes for
showBlinkAsBold
resource (report by
Christoph Berg).
- change clearing operations so foreground color attribute is not
set. Usually this is benign, but in some cases when the cursor
color is not set explicitly, the cursor would show this color
(Debian #252873, #260471).
- add extra state (cursor-moved) to guard against deciding that the
cursor did not require repainting after an indexing operation
that leaves the cursor in the same location on the screen.
- fix a case where a full-screen indexing operation would
not restore the cursor-busy state.
- fix a repainting bug introduced in
patch #180: when using a font
lacking line-drawing characters, a repaint of the screen could
skip horizontally an extra amount after filling in the missing
character (reports by Nicolas George, Hans de Goede, Redhat
Bugzilla #128341).
- rename terminfo fragment "xterm-pc-fkeys" to "xterm+pcfkeys" for
consistency with ncurses.
- fix for wide-character selection from OpenBSD CVS
(report/patch by Matthieu Herrb).
- modify initialization and cleanup of utmp data to also compare
the
ut_line
member (Debian #256468).
- modify check on focus-change to ignore
FocusOut
events
generated by XGrabKeyboard
. This fixes a case where
the text cursor would act as if focus were lost when selecting the
"Secure Keyboard" menu option.
- add
gen-pc-fkeys.pl
script, use that to generate
terminfo fragment corresponding to the pc-style function keys.
- fix a case where the checkmark by the "VT220 Keyboard" menu entry
was not set on startup.
- separated two methods for making the cursor blink (menu and
escape sequence) by using the menu as the primary method and
XOR'ing the state of the escape sequence against that.
- modify logic for enabling blinking cursor via escape sequence as
well as the related save/restore operations so this is only
available if the
cursorBlink
resource was set on
startup.
- change resource settings for color4 and color12, add some discussion
in
XTerm-col.ad
(Debian #241717).
- add a note in xterm manpage discussing the difference between
alt- and meta-keys, and the way the latter is used in the
eightBitInput
resource.
- add a note in xterm manpage regarding possible conflict between
resource settings for
xterm.vt100.font
and
xterm.vt100.utf8Fonts.font
(Debian #254650).
- add compile-time customization of
backarrowKeyIsErase
and ptyInitialErase
default resource values
(adapted from OpenBSD CVS).
- change parameter of
FIONREAD
ioctl()
call
from long to int
(discussion on tech-x11@netbsd.org regarding LP64 by
John Heasley and Matthias Scheler).
- modify configure script options for Athena widgets to work as
expected for "--without-Xaw3d", etc., (GenToo Bugzilla #53455).
- add case to uxterm to accommodate locales ending with "@euro",
e.g., fr_FR.UTF-8@euro (Debian #255197, report/analysis by
Matthieu Lagouge).
- add special case for VT100 graphic's "box" character (discussion
with Ben Armstrong).
- add missing initialization for bitmap-font sizes needed to make
fonts menu work with TrueType fonts (report by Ben Armstrong).
- save the fontnames for bold fonts that are derived from normal
fonts, or from the
boldFont
resource, so the same
value is restored when switching with the VT Fonts menu (Debian
#256086).
- fix manpage preprocessing (Marc La France).
- fix typo in manpage's description of character classes (Debian
#257073).
- modify terminfo to accommodate luit, which relies on G1 being used
via an ISO-2022 escape sequence (Debian #254316, analysis by
Juliusz Chroboczek).
- modify Makefile.in rule for ctlseqs.txt to work around groff SGR
misfeature.
- modify
XTerm.ad
to set saveLines
default
to 1024 (Redhat Bugzilla #127132).
- add a limit-check in
dotext()
to prevent infinite
loop in a corner case of UTF-8 configuration.
- update config.guess, config.sub
- correct options parsing for
-into
option so it
can be combined with -e
(Redhat Bugzilla #124518,
report/patch by James Armstrong).
- fix ifdef's for
OPT_COLOR_RES2
so that the fake resource table introduced in
patch #188
is not compiled if it is empty.
This happened to work with gcc (report by Joel Konkle-Parker).
- reorganize ptydata.c to use one input buffer shared between
the VTxxx and tek4014 emulators. In the new scheme, UTF-8
decoding is performed on characters as they are needed by the
state machine rather than on buffers as they are read.
- work around change in quoting of PROJECTROOT symbol when using
configure script, from changes made in
patch #187 for CF_IMAKE_CFLAGS
(GenToo Bugzilla #50982).
- correct state for values in the range 128-159 after translating
from UTF-8: this should be ignored unless the user overrides it
with the
allowC1Printable
resource (reported by
Simon Strandgaard).
- add configure-script check for nl_langinfo(CODESET), use this to
replace check of environment variables for UTF-8.
- change Makefile.in rules for 256colres.h and 88colres.h so they
are only made if they do not exist. The maintainer-clean rule
will remove these files; they require perl to be made.
- remove check in configure script --enable-toolbar that suppressed
this option when building with Xaw7.
- apply fixes to Tektronix widget used for VT100 widget to make
toolbar work with Xaw7 (XFree86 4.x).
- do not call xim_real_init() if
openIm
resource is
false (Debian #249025).
- minor improvements to built-in line-drawing.
- fix a few portability issues with dynamic abbreviation support,
i.e., did not compile on Tru64.
- modify constraints in form used to layout toolbar, to work with
newer Xaw in XFree86 4.x.
- correct table entry for DEL in the ground state, which marked it
as a printable character from patch #171
(report by D Hugh Redelmeier).
- improve fix in patch #186 for failure in
xim_real_init() by adding a sleep.
- fix a typo in os2main.c
(XFree86 Bugzilla #1358, report/patch by Frank Giessler).
- make escape sequence reporting dynamic colors consistent with the
logic that sets it; choosing the opposite color when reverse
video is set (XFree86 Bugzilla #1361, reported by Bradd W Szonye).
- modify initialization of 256- and 88-colors so that colors beyond
16 are normally not X resources. This works around a hard-coded
limit in Xt which breaks xterm when 256-colors and luit are both
configured (report by Noah Friedman).
- remove
ncv
from xterm-256color
terminfo
entry since it is no longer needed (report by Eli Zaretskii).
- add "erase2" and "eol2" keywords to
ttyModes
resource,
for recent/current FreeBSD.
- improve ifdef's for utempter library to omit direct calls to
setutent()
or getutent()
(adapted from
patch by Christian Biere).
- add dynamic abbreviation support like Emacs (patch by Tomasz
Cholewo). This is ifdef'd with
OPT_DABBREV
, and
enabled via the configure script --enable-dabbrev
option.
- fix problem responding to session management events, e.g., which
would make logging out very slow (patch by Eddy De Greef, Debian
#233883).
- work around a newer bug in toolbar with XFree86 by forcing menus
to be fully initialized at startup. In older versions of XFree86
and X11R6, it was possible to delay initialization of the menu
contents until it was popped up. (The longstanding bug with
XFree86 4.x layout for toolbar still exists, though).
- modify
xtermAddInput
to work around core dump on
IRIX64 when initializing scrollbar translations if toolbar is
compiled-in.
- fix some minor conflicts in the 2-character entry names in the
termcap file.
- change xterm version string to use
__vendorversion__
where that is available, and "XTerm" otherwise.
- improve description of
utf8
resource in manpage
(Debian #179407).
- modify configure macros CF_IMAKE_CFLAGS and CF_ADD_CFLAGS to
handle
-D
options that define string values, e.g.,
for XVENDORNAME
.
- modify configure macro CF_IMAKE_CFLAGS to allow (if
$PATH
is set accordingly) to use the
xmkmf
script within an X build tree.
- add missing
#undef OPT_SESSION_MGT
to xtermcfg.hin
to make the configure script's --disable-session-mgt option work.
- update config.guess, config.sub
- change reset on
DECSCL
to a soft-reset (appears some
DEC manuals have errors).
- add a section to ctlseqs.ms elaborating on normal/alternate screens.
- modify initialization of Acolors[] so that any XtDefaultForeground
or XtDefaultBackground values are translated as in the Tcolors[],
to use the window's foreground/background colors. This affects
the
colorBD
and similar resources which normally have
no explicit color assigned.
- modify initialization of Tektronix window so that control sequences
setting its color before the window is popped up will apply to
its initial colors.
- add control sequence to set Tektronix window's text-cursor.
- modify initialization of terminal colors, e.g., mouse pointer and
text cursor, to treat
XtDefaultForeground
and
XtDefaultBackground
values as the actual foreground
and background colors of the terminal rather than white and black
(Debian #241717).
- remove an incorrect comparison against
PTYCHARLEN
in
parsing the -S
option (report by Michael B Taylor).
- minor restructuring of terminfo/termcap files, having noted some
packager's customizations which caused the structure to be
confused.
- eliminate an isolated use of MIN/MAX in charproc.c
- replace
XtExtdefaultfont
and
XtExtdefaultbackground
by their more familiar
equivalents
XtDefaultFont
and
XtDefaultBackground
.
- replace ifdef's using
SCO
, sco
and
SCO325
with __SCO__
(XFree86 Bugzilla #1301, Kean Johnston).
But ensure that it still builds on platforms where this symbol
is not defined.
- add
scoFunctionKeys
resource, to match manpage.
- update manpage discussion of menus and related resources.
- enable utmpx support for NetBSD 1.6C and newer (patch by
Matthias Scheler).
- add a note in the manpage discussing xterm's treatment of open
file-descriptors (request by Dan Shearer).
- modify
Help()
to make "xterm -h" write to standard
output rather than standard error (patch by Bram Moolenaar).
- check for type of failure in xim_real_init() to avoid looping when
the problem is an unsupported input method rather than a failure
to connect to the XIM server. Problem was introduced in
patch #175 (XFree86 Bugzilla #1306).
- modify
Imakefile
to remove dependency of "install"
target on the xterm
executable to make installs from
tree without attempting to rebuild anything (David Dawes, based on
a patch and report from Lee Olsen).
- remove call to
ShowCursor
from
SetCursorBlink()
since that is redundant,
and can cause display glitches if the cursor is already
blinking (XFree86 Bugzilla #1158, patch/report by Andreas Schwab).
- fix tcap-query logic for the backspace key (XFree86 Bugzilla #1233,
report/patch by Anton Kovalenko).
- add test-scripts resize.pl and tcapquery.pl
- add translation to ASCII of commonly-used characters that groff
translates to Unicode, when the font in use does not provide the
corresponding glyphs (Debian #219551).
- modify RequestMaximize(), which performs maximize/restore via
control sequences, to account for window-frame (patch by
Jess Thrysoee).
- improve pattern used in
uxterm
to check for UTF-8
locale, e.g., for HPUX (patch by H Merijn Brand).
- add
-fd
option and resource
faceNameDoublesize
to specify double-wide fonts with
Xft (adapted from patch by Zarick Lau).
- change a couple of resource classes from "Boolean" to specific
values:
freeBoldBox
, forceBoxChars
.
- add resource
showMissingGlyphs
to outline places on
the screen where a font lacks the corresponding glyph.
- add resource
showBlinkAsBold
to control whether
blinking text should be shown as bold or actual blinking text.
- improve logic in ShowCursor() to avoid repainting the cursor when
it is already visible, e.g., in response to the DECTCEM escape
sequence. This also addresses XFree86 Bugzilla #1158.
- implement blinking text, using the timer for blinking cursor.
- modify FreeType support to allow resizing the font, in the same
ways the window can be resized if fixed fonts are used. The
relative font sizes are derived from the fixed font sizes.
- add menu items and corresponding actions for switching on/off
the UTF-8 mode and Xft (TrueType) support.
- add logic to handle switching UTF-8 mode on/off. It worked if
the escape sequences were flushed, but if data was mixed in with
the same write, some were not handled properly (report by
Nicolas George).
- modify to allow turning UTF-8 mode on/off via escape sequence even
if
-wc
option was not given at startup (patch by Peter
Berg Larsen).
- amend fix for XFree86 Bugzilla #981, adjusting for savedlines value
(report by Tim Adye).
- fix a typo in computing relative font size (Jess Thrysoee).
- improve configure-script checks for FreeType and related libraries,
using
xft-config
or freetype-config
scripts when available.
- fix configure-script check for
SYSV
definition by
ensuring whether sys_errlist[]
is declared, and by
modifying the test program to include X11/Intrinsic.h
to check that wchar_t
is declared consistently (report
by H Merijn Brand).
- correct logic for configurations that may attempt to open both
old/new-style pseudoterminals. In this case, the old-style are
preferred. Logic was broken in patch #145
(XFree86 Bugzilla #997, report/patch by Kean Johnston).
- modify handling of
eightBitInput
resource in UTF-8
mode to translate the value into UTF-8. Otherwise an illegal
UTF-8 code is sent to the application (report by Bram Moolenaar).
- modify
uxterm
script to interpret help and version
options so xterm does not always create a window when the user
requests this information (Debian #223926).
- add a limit check to ScrnTstWrapped() (XFree86 Bugzilla #981).
- modify DECSCL to perform a hard reset (RIS) as per DEC manuals.
Extended DECSCL to accept parameters for vt4XX and vt5xx terminals.
- correct logic for ANSI conformance level escape sequences, which
were confused with DEC conformance level escape sequences.
- correct state for vt52 shift-in/shift-out, which was not reset
properly after patch #171.
- correct handling of graphics characters for vt52 mode, which did
not display line-drawing characters after G1 fix from
patch #182.
- fixes for configure script to work with current Cygwin headers
and libraries.
- modify
Imakefile
to put the current directory at the
beginning of the include searchpath (David Dawes).
- correct logic for
metaSendsEscape
resource to allow
for the meta-right key to be tested. Improve check for meta/alt
modifiers by dropping the assumption that a keysym is associated
with only one modifier, and by ignoring NoSymbol entries in the
xmodmap data (XFree86 Bugzilla #924, patch by David Dawes).
- correct wrapping logic for line-drawing characters written in
non-UTF-8 mode of xterm build for wide-characters (XFree86 Bugzilla
#918, report/patch by Jürgen Keil).
- improve manpage description of resources, in particular the
utf8Fonts
class (XFree86 Bugzilla #905).
- add definitions to compile with glibc-based GNU/Hurd, GNU/KFreeBSD
and GNU/KNetBSD (XFree86 Bugzilla #893).
- compiler-warning fixes (patch by Christian Biere).
- add README.i18n (Tomohiro KUBOTA).
- correct initialization of G1 character set mapping, which used
line-drawing set as a result of confusion between "DEC Supplemental
Graphic" and "DEC Special Graphic" character sets
(see patch #34 regarding DECSTR).
- correct ifdef in main.c for variable utret (patch by
Bernhard Rosenkraenzer).
- document in xterm's manpage how to use XFree86 ":unscaled" keyword
to suppress scaling of bold fonts.
- when deriving bold fontname from normal fontname, use the normal
font's average width to avoid for example selecting 7x13bold
from an 8x13 normal font (Debian #107769).
- implement
boldMode
for wide-character logic in
drawXtermText()
(report by Michael Schroeder).
- modify
UXTerm.ad
resource file to include
"XTerm-color" rather than "XTerm", in case the latter file contains
no color resource definitions, e.g., after patch #180.
- add action
load-vt-fonts()
and configure option
--enable-load-vt-fonts
which allows users to define
additional sets of VT-fonts which can be loaded at runtime.
- add logic to wide-character support which attempts to load fonts
specified by
utf8Fonts
subresources at startup. The
subresources have the same names as the fonts which they replace,
e.g., font
, font1
, etc., so that the
ISO-10646-1 fonts can be specified in the XTerm
app-defaults file (this is an adaptation of a patch by Tomohiro
KUBOTA).
- improve Set Font escape string handling by making the relative
settings apply to the size of the font, as in shift keypad
plus/minus rather than the menu index.
- simplify parameter passing for the
set-vt-font
action
and related code.
- cleanup some include-ordering, moving some recently-added hardcoded
stuff into xterm.h where it will not interfere with the configure
script.
- modify
xtermAddInput()
(see note on augmentation in patch #158) to use the complete set of
default keyboard translations so that one can use shifted pageup,
wheel mouse, etc., while the mouse pointer is over the scrollbar.
(Debian #178812).
- make save/restore mode controls apply to show/blink cursor states.
- add escape sequence to start/stop blinking cursor, which allows
implementing
cvvis
terminfo capability (request by
Nate Bargmann).
- add
indp
and rin
to terminfo entry.
- fix an out-of-bounds array reference in ScrnRefresh() for wide
characters (report by Dan Harnett, patch by Todd Miller, bug dates
from patch #141).
- several fixes for rendering using Xft (option
-fa
):
- translate Unicode values (from UTF-8 output to xterm) for
line-drawing to xterm's internal code, etc., since TrueType fonts
generally do not have either set of line-drawing glyphs. xterm
can draw these directly (report by Abigail Brady).
- pass 16-bit values rather than 8-bit values to
xtermXftDrawString() to allow for wide-characters.
- remove spurious check for
colorBDMode
resource in
logic that does bold fonts.
- implement underlining.
- patches by Ilya Zakharevich:
- improve drawXtermText() by making the recursive calls
communicate through arguments, and not through saving/restoring
global variables.
- make double-width characters work with
-u8
option.
- modify lookup of double-sized fonts by checking for a match
ignoring x/y resolution if the first check fails.
- make height of TrueType fonts match ascent+descent (patch by
Keith Packard).
- correct configure-script check for imake $CFLAGS, which did not
check properly if imake was not available.
- correct install rule in Makefile.in for
uxterm
, which
was attempting to strip the script (newsgroup posting by Fernan
Aguero).
- correct AF/AB strings in termcap for xterm-256color and
xterm-88color entries (report by Josh Howard).
- update wcwidth.c to incorporate changes from Markus Kuhn's
2003-05-20 (Unicode 4.0) version of that file.
- modify
scroll-back
and scroll-forw
actions to accept an adjustment value, e.g.,
scroll-back(1, page-2)
to scroll back by 2 lines less than a page (patch by Greg
Klanderman).
- use color resource setting from Debian package for xterm VT100 widget,
since the choice of blues provides better contrast.
- remove color resources from
XTerm.ad
, leaving them
only in XTerm-col.ad
(prompted by Debian package for
xterm).
- correct configure script option --enable-pty-handshake (report by
Paul Gilmartin).
- add
visualBellDelay
resource to modify the length of
time used for visual bell, for very slow displays or very fast
computers (reports by Ingo van Lil and Doug Toppin).
- correct logic for initializing dynamic highlight color (patch by
Jess Thrysoee).
- add a check for non-zero size in call to
XCopyArea()
to accommodate a Solaris bug.
- correct typo in example for character classes in xterm manpage
(Debian #198910).
- link xterm with bind_on_load option on Darwin to work around a
deadlock in the dynamic loader when a signal is received while
the dynamic loader is looking up symbols (patches by Rob Braun,
Torrey Lyons).
- modify configure script to avoid using "head -1".
- update config.guess, config.sub
- modify ifdef's to work around inclusion of types FcChar32 and
XftCharSpec with FreeType 2.0 (see patch #175).
- modify the predictable version of the generated logfile name (see
patch #171) to append the process-id rather
than a random value.
- resync with XFree86 CVS:
- Enable SCO function keys in xterm
- Make Delete key send DEL by default on SCO in xterm
- modify ifdef's for WTMPX_FILE to allow building on cygwin again.
- change the default of pty-handshaking configure option (and related
default for imake) to assume this feature is needed.
- add ifdef's so configure option for XawPlus library works (patch
by Pavel Roskin).
- add
$(MAIN_DEFINES)
to the variables checked by the
configure script that may contain information set by imake. This
allows xterm to build/run properly using the configure script on
IRIX64.
- add configure check for ".exe" suffix on cygwin.
- modify default for configure
--enable-pty-handshake
option to enable it for Solaris (report by Nelson Beebe).
- modify
in_put()
function to call
PreeditPosition()
only when the cursor's position has
changed. This addresses report by Stefan Baums of high CPU usage
while xterm with chinput are running in the background (patch by
Yong Li).
- improved explanation of
-ls
conflict with
-e
option in xterm manpage (adapted from comments by
Henning Makholm).
- correct comment in terminfo file regarding modifier used for
kDC
(Debian #189764, report by Henning Makholm).
- correct/extend some of the keypad description in ctlseqs.ms
(report by Henning Makholm).
- correct keypad-mapping table in input.c so
XK_KP_Equal
works (report by Henning Makholm).
- modified to work with CJK double-width (bi-width/monospace) fonts.
They're similar to Roman Czbora and David Starner's gnuunifonts in
that Latin letters and numbers have all the same width which is
exactly the half of the width of East Asian characters. (patch by
Jungshik Shin <jshin@mailaps.org>).
- add configure option
--enable-broken-osc
and resource
brokenLinuxOSC
to accommodate scripts which do not
distinguish between running in the Linux console and running in X.
Linux console recognizes malformed control strings which start
with an OSC
, but are fixed-length, with no terminator.
- add configure option
--enable-broken-st
and resource
brokenStringTerm
to allow
user to revert one part of the parsing table corrections from
patch #171. (reports by
Matthias Scheler and
Kirill Ponomarew indicate that someone's
network firmware sends an <escape>X
).
- modify configure
--disable-imake
to provide values
for OSMAJORVERSION
, OSMINORVERSION
,
FUNCPROTO
and NARROWPROTO
(report by
Heiko Schlichting).
- correct
vttests/16colors.sh
, which omitted the
$SUF
variable in output strings (patch by Paul
Gilmartin).
- modify shell scripts in
vttests
directory to attempt
to use named signals in the trap
statement, making
this portable to OS/390 (report by Paul Gilmartin). Tested on
SunOS 4.1.4, which implements only numbers.
- fix definition of
USE_HANDSHAKE
, must be numeric
(reported by Jens Schleusener).
- add configure option
--enable-pty-handshake
to allow
one to compile-in support for the pty handshaking logic, and
resource ptyHandshake
to enable or disable it
(suggested by Ian Collier).
- restore
USE_HANDSHAKE
ifdef removed in
patch #159
to address Debian #39964.
- move ifdef's for ttysize/winsize into xterm_io.h
- simplify loop on
tgetent
, check if the successive
entries in the lookup table are the same. That makes xterm do
one less lookup if there is no "xterm" entry in the termcap file
(report by Derek Martin).
- correct manpage discussion of
$TERM
and
$TERMCAP
variables, which omitted the Tektronix
emulation and a note of the final "dumb" fallback.
- broaden ifdef for
XRegisterIMInstantiateCallback()
from patch #175 (XIM fix) to exclude
non-XFree86 (report by Nelson Beebe indicates this breaks for
Solaris, IRIX and OSF/1).
- correct resource-size for
iconFont
(this was added
by X11R6.3).
- improve configure check for XKB bell extension, to work around
inconsistent implementation of this feature (reports by Nelson
Beebe, Kriston Rehberg and David Ellement).
- modify configure-check for
tty
group to be less
strict in batch mode (report by Nelson Beebe).
- modify to allow building with g++, to use its compiler warnings
(suggested by Nelson Beebe).
- modify
dec2ucs[]
table to reflect newer codes
available for scanlines 1, 3, 7, 9 (report by Michael Schroeder).
- add configure option for XawPlus library.
- fix a SIGSEGV which could occur if xterm is connecting to XIM
server, and the XIM server is destroyed (patch by Nam SungHyun).
- modify to use built-in line-drawing characters for Xft fonts
(patch by Andrew Tipton).
- make menu reflect the state of the
tekInhibit
resource.
- make
signalInhibit
resource work, i.e., disable the
menu entries that would send signals to, or exit xterm. This was
probably broken in X11R5 when logging was disabled (report by Sven
Mascheck).
- changed classes of
colorBDMode
and similar
resources that override colors when a video attribute is
set to ColorAttrMode
, to make them distinct
from ColorMode
. This avoids an unexpected
rendering of reverse video, for example (report by Paul Fox).
- changed class of
veryBoldColors
to
VeryBoldColors
, since
ColorMode
is associated with boolean resources.
- add option
-k8
and resource
allowC1Printable
to allow users of non-VTxxx
character sets such as KOI-8 to treat the C1 control area
(character codes 128-159) as printable rather than control
characters.
- add a null-pointer check for return-value of
ptsname()
in HPUX-specific code (report by David Ellement).
- revise the ifdef's used for
XKB
bell support. The
code was using a nonstandard call XkbStdBell()
.
Changed to use XkbBell()
(based on patch by
<derek@signalmarketing.com>).
- add a null-pointer check in
xtermLoadFont()
in case
there is no wide-bold font (Nam SungHyun).
- change
Makefile.in
to use autoconf's
bindir
, libdir
and mandir
variables (report by Nam SungHyun).
- add
le
to termcap xterm-basic
entry.
Though missing from older termcaps for xterm, some applications
check for it (report by Matthias Buelow).
- modify
uxterm
script to strip modifiers such as "@euro"
from the locale setting before adding ".UTF-8" (Debian #179929).
- modify the remaining places where tek4014 emulation uses
XDefineCursor()
, to make it work as originally
implemented, e.g., when switching back to alpha mode.
Added test-screen in vttest to test this feature properly.
- work-around for XFree86 bug which made
XDefineCursor()
on a shell-window no longer work. The tek4014 emulation used this.
Use the next lower window (report by Karl Rudolf Bauchspiess).
- add a resource setting
allowWindowOps
to control
whether the extended window operations should be allowed, e.g.,
resize, iconify, report window attributes. This is to accommodate
people who are not capable of using a pager to view log-files.
- reset mouse mode to normal on a full reset. This does not apply
to mouse hilite tracking mode, of course (see ctlseqs.ms).
- add a time-delay at the point where mouse hilite tracking mode
choses to not handle X events, to avoid runaway CPU usage
(report by D Hugh Redelmeier).
- check for illegal character in DECUDK string, quit if detected.
- fixes to make repainting of 256-color example work properly
(reports by Abigail Brady and Scott A Crosby).
- set flag in
AllocateAnsiColor()
to ensure the color
is allocated once only.
- fix check in
ScrnRefresh
, which was comparing
background colors only if the ANSI foreground colors also were set.
- merge
Error()
calls and some exit()
calls
into SysError()
, and change that to add the brief
explanation for each error code which is provided in the manpage.
Change a few SysError()
, calls to avoid using code 1, to
avoid confusion with exit status from places that do not use
SysError()
.
- simplify logic used to open a debug logfile as the standard error.
- modify the
-e
option so that if it fails, xterm will
check if only one argument follows, e.g., it was quoted, and then
retry using sh -c
.
- modify parsing of DECUDK string parameter to allow a comma between
pairs of hexadecimal digits (Ray Neuman <raymond@one.com.au>
reports that "real" terminals accept this; perhaps they simply
ignore unexpected characters).
- fix a few problems with the
$TERMCAP
string generated
by resize
:
- for Bourne shell, add an
export
command.
This was missing as far back as X11R5.
- escape exclamation marks, used in xterm's reset string.
- translate literal
\177\
to "^?".
- improve configure check for
tgetent()
to work when
$TERMCAP
has been set to a specific entry.
- modify
minstall.sh
to use "%" rather than "@",
to avoid problems with AFS (report by Zdenek Sekera).
- list fatal error codes from
error.h
in the manpage,
remove unused codes in error.h
.
- use more explicit wording for manpage list of color resources,
since at least one user confused the generic names such as "black"
with the names in rgb.txt (the latter are now used).
- minor fix to description of 1003 mouse mode in ctlseqs.ms
(Larry Riedel).
- modify parser tables to improve detection of malformed control
sequences, making xterm behave more like a real DEC terminal
(patch by Paul Williams).
- update comment in
input.c
to document
Meta
as a modifier for escape sequences (patch by D
Roland Walker).
- add ifdef'd code for logging option which adds the hostname and a
timestamp to the generated logfile name. The ifdef's are setup
with the configure script (patch by Nelson Beebe).
- remove
xevents()
call from the end of
BlinkCursor()
, to fix an occasional problem
which caused xterm to pause until a key was pressed.
The reason for this was that there was no check to ensure that
there really were events for xevents()
to process.
(patch by Semen A Ustimenko <semenu@FreeBSD.org>).
- remove unused mode-params from
open()
calls that do
not create a file.
- modify configure script to put new items first on
$CPPFLAGS
and $CFLAGS
to avoid conflict
with environment's -I and -D options.
- update config.guess, config.sub
- resync with XFree86 CVS:
- fix va_args glitches for xterm/libfontconfig: 0 == (void*)0
isn't true for all platforms (Egbert Eich).
- initialise ProgramName in xterm's main before referencing it
(#5473, Peter Valchev).
- some cleanup of Imakefile ifdef's (Marc La France).
- correct an off-by-one allocating data for sorted help message.
- modify configure script to check for Xpm library, on which XFree86
Xaw library depends.
- update config.guess, config.sub
- modify wording of some options in help message to make them use
-/+
consistently with respect to "on/off" or "off/on".
- sort options list which is displayed in help- and syntax-messages
at runtime to simplify maintenance.
- remove support for Amoeba and Minix (Juliusz Chroboczek noted it
was removed from XFree86 server; there have been no users since
1996).
- add configure script option
--disable-session-mgt
to control whether the session management code should be compiled-in
(request by H Merijn Brand).
- ifdef'd the session-management changes with
OPT_SESSION_MGT
, to accommodate X11R5 which predates
the related definitions.
- fix
decode_keyvalue()
, which did not properly parse
multiple settings as needed for the ttyModes
resource,
since it did not skip over the parsed data.
- fix an option-parsing conflict between
-class
and
-cjk_width
(Nam SungHyun)
- add a missing null in
XtVaSetValues()
call used in
Cleanup()
(Nam SungHyun)
- improve data reported for control sequence that requests window
position by taking into account the window decorations, e.g.,
border and title (patch by Jess Thrysoee <jess@thrysoee.dk>).
- add
-cjk_width
and corresponding resource
cjkWidth
(patch by Jungshik Shin
<jshin@mailaps.org>).
- add
-into
option, for embedding xterm in a Tcl/Tk
application (patch by George Peter Staplin <georgeps@xmission.com>).
- add simple session management (XSM) client capabilities to xterm.
So a session manager such as, e.g., xsm, should be able to respawn or
kill xterms without the help of an SM proxy (like smproxy), which is
a hack and almost always buggy (patch by David Madore).
- fix conflict between ifdef's for
OPT_DEC_LOCATOR
and
OPT_READLINE
in button.c (reported by Ilya Zakharevich).
- fix for inconsistent use of
struct utmp
versus
struct utmpx
introduced in patch #167
(patches by Paul Gilmartin, Marc La France).
- modify logic for
metaSendsEscape
to allow it to work
in a setup where the Meta-key is not recognized as a modifier by
the key-translations logic (from a discussion of eightBitInput
with H.J.Lu, however Vincent Lefevre reported this in January).
- use null pointer values consistently, rather than literal "0", for
ending variable-length argument lists, e.g., for
execlp()
(based on patch by Matthieu Herrb).
- correct logic of
ChangeAnsiColorRequest()
, which would
do a screen repaint after replying to a request for information.
- improve scripts in vttests to work with systems whose shells support
echo -n
and have, as does Debian, an unrelated
print
utility.
- add vttests/acolors.sh to demonstrate OSC 4, which queries or
sets ANSI colors.
- fixes for ctlseqs.ms (Pavel Roskin, Ilya Zakharevich).
- typos in xterm manpage (Jens Schweikhardt)
- remove a redundant GCC_UNUSED from InitPopup() (Nam SungHyun)
- correct ifdef's for
USE_TERMCAP
to match cygwin
configuration.
- fix several places in ctlseqs.ms which had no boxes around the
literal text (report by Ilya Zakharevich).
- integrated patch from Ilya Zakharevich to extend mouse support for
readline (ifdef'd with OPT_READLINE).
- modify terminfo description to match default for
modifyCursorKeys
resource.
- add
modifyCursorKeys
resource to control how the
shift- and similar modifiers are used to make a cursor escape
sequence. The default makes a modified escape sequence always start
with CSI and puts the modifier as the second parameter, to avoid
confusing applications that would interpret the first parameter as a
repeat count. The original behavior can be obtained by setting the
resource to 0 (from newsgroup discussion with Stephen J Turnbull
and Jeffrey Altman).
- correct missing initializations for
appdefaultCursor
and appdefaultKeypad
resources.
- add configure option
--enable-luit
and ifdef'd the
luit-related code with OPT_LUIT_PROG.
- integrate patch by Tomohiro KUBOTA from
http://www.xfree86.org/pipermail/i18n/2002-July/003378.html which
modifies xterm to invoke luit.
- update wcwidth.c to match Markus Kuhn's 2002-05-18 version.
- correct limit-checking in
ComputeSelect()
to handle
selections that extend off the visible area; rather
than modify the parameters to TrackText()
, use
ScrollSelection()
to update the highlighting limits.
(reported by Yegappan Lakshmanan and Nelson Beebe,
patch by Alexander V Lukyanov).
- correct manpage description of
tiXtraScroll
resource
(reported by Tony Finch).
- changes from OpenBSD:
- Make xterm setgid utmp to be able to update utmp even
with root privileges revoked.
- If not updating utmp, revoke group privileges totally too.
- changes from NetBSD:
- Check that the return value from ttyslot() is greater than 0
before writing the utmp file.
Fixes w's "w: Stale utmp entry: <user> <tty> <pty>" errors.
- Use openpty() to deal with new pty naming scheme.
- add
print-redir
action and menu entry to allow user to
switch terminal in/out of printer controller mode. It appears from
the manual that a real vt220 would not switch back to normal mode, so
another mechanism is used (addresses Debian #37517).
- check if
printerCommand
resource string is empty, use
this to allow user to disable printer function.
- trim trailing blanks from resource strings.
- check return value from
ptsname()
, which may return
null for example if someone has changed the permissions of /dev/pts
to zero (Debian #121899).
- modify OS/2 version to use
__UNIXOS2__
definition
rather than __EMX__
, related cleanup (patch by Holger
Veit).
- used modified indent 2.0
(patch 20020428)
to reformat most of the C source files, to simplify maintenance.
- fix a couple of places where there were leading tabs on
symbol-definition lines in Imakefile (Marc La France from report by
Tony Finch)
- add imake variable (TraceXTerm) to allow building debug version
(Egbert Eich).
- correct a bug in selection: double clicking on a word which
was partly scrolled off the screen may select that text (report
by Vincent Lefevre <vincent@vinc17.org>).
- implement
veryBoldColors
resource to control whether
the corresponding video attribute such as bold
is
displayed when using colorBDMode
, etc. (request by Josh
Howard <jrh@vicor-nb.com>).
- define escape sequences for function keys F21-F35 (patch by Steve Wall).
- change the colors for the 256-color model, making them less skewed
toward black (patch by Steve Wall).
- add
vt100Graphics
resource
(see patch #115,
based on discussion with Glenn Maynard).
- ifdef'd Xaw/Xaw3d/neXtaw includes separately to avoid potential
incompatibilities between these flavors of Athena widgets.
- add configure check for XFree86 4.x Xaw library, whose geometry
management is broken, to avoid trying to use it for toolbar
configuration.
- updates to configure script from vile and lynx to allow
configure.in to be compiled with autoconf 2.5x
- add a check for null pointer return by
ptsname()
(newsgroup posting from Mike Silva <mikesilva@lucent.com>).
- fill in a few details needed to allow UTF-8 mode to switch on/off
after startup. This requires that
wideChars
resource be
set. (based on comments in 4 Aug 2001 by Alexey Marinichev
<lyosha@lyosha.2y.net>).
- remove duplicate install rules that make directories, e.g., so installing
manpage will not create app-defaults directory.
- add comment in in
do_osc()
, reserving cases 30 and 31
for for Konsole (request by Stephan Binner
<Stephan.Binner@gmx.de>).
- fixes for ctlseqs.ms and xterm.man
(patch by Werner LEMBERG <wl@gnu.org>).
- add check for monochrome display, disabling colorMode in that
case (fixes Debian #134130).
- resync with XFree86 CVS:
- Fix some xterm build warnings on *BSD (David Dawes).
- Only use SA_RESTART in xterm when it's available (Frank Liu).
- Fix incorrect code in signal handlers in most of the clients,
xterm and xdm not done yet (Matthieu Herrb).
- modify
uxterm
script to strip encoding part from
environment variable before adding ".UTF-8" (based on Debian
#125947, but using a more portable solution).
- add an assignment statement in VTInitialize() to make
awaitInput
resource work.
- use new macros init_Bres(), etc., in VTInitialize() to add trace of
the initialization of resources.
- modify checks for $LC_ALL, related environment variables to ensure
the resulting strings are nonempty (report by Markus Kuhn).
- add an ifdef in charproc.c for num_ptrs variable in case all
configure options are disabled.
- modify definition of getXtermBackground() to avoid negative array
index warning on Tru64 (report by Jeremie Petit).
- improve fix from patch #165 (still Debian #117184, report by Matt
Zimmerman <mdz@debian.org>)
- correct install rule for uxterm in Makefile.in, to handle the
case where building in a different directory than xterm's source
(patch by Paul Gilmartin).
- documented ANSI.SYS-style cursor save/restore escape sequences
in ctlseqs.ms, which are in xterm since X11R5.
- correct two entries in the default charClass table, which did not
follow the manpage comment about the character number corresponding
to the class (patch by Marc Bevand <bevand_m@epita.fr>).
- fix a couple of typos in comments in the app-defaults files
(David Krause <xfree86@davidkrause.com>).
- resync with XFree86 CVS:
- update language of copyrights in some files to reflect the fact
that they were reassigned from X Consortium to The Open Group in
1998. Note that this xterm source is derived from the 1996
version from X Consortium, does not incorporate changes made by X
Consortium or The Open Group after that date, hence we do not add
The Open Group's 1998 copyright date to related files.
- save/restore
errno
in signal catcher (Matthieu Herrb).
- modify UXTerm.ad's font5 resource so that xterm can display double
width characters using a font distributed with XFree86 (Tomohiro KUBOTA).
- correct a case where
ptyInitialErase
and
backarrowKeyIsErase
resources combine to set
DECBKM
mode, but a reset
command would not
reset xterm to that state, making the erase character revert to ^H
(Debian #117184)
- correct ifdef's for
__QNX__
and
USE_SYSV_PGRP
in main.c call to tcsetpgrp
,
which broke bash behavior around patch #140
(report/patch by Frank Liu <fliu@mail.vipstage.com>).
- modify trace.c to fix missing definition of GCC_UNUSED for
compilers other than gcc when configured for trace code (report/patch
by Paul Gilmartin).
- change format in TraceOptions() to use long rather than int, since
the latter could lose precision on 64-bit machines (report/patch by
Nelson Beebe).
- modify xterm manual page and minstall.sh to allow imake rules
to define location of app-defaults directory (Debian #87611).
- review/update list of conflicting preprocesor symbols to remove
from $CPPFLAGS at the end of the configure script. In particular,
this allows one to configure xterm without the utempter library on
Redhat 7.1 (report/patch by Adam Sulmicki).
- correct logic that processes
-class
option, so that
a following -e
option is handled (Debian #116297).
- improve options-decoding to allow
-version
and
-help
options to be combined (Debian #110226).
- add a 10 millisecond delay in event loop when processing
-hold
option, to avoid using too much CPU time
(Debian #116213).
- prefix final program execution in
uxterm
with "exec"
to avoid a useless shell hanging around (Christian Weisgerber).
- modify logic that resets keypad application mode to avoid doing
this if there is no modifier associated with the Num_Lock keysym
(report by John E Davis <davis@space.mit.edu> and Alan W Irwin
<irwin@beluga.phys.uvic.ca>).
- add built-in translation for Control/KP_Separator to KP_Subtract,
to accommodate users who wish to use xmodmap to reassign the top
row of the numeric keypad.
- correct Imakefile install-rule for
uxname
script
(reported by Nam SungHyun <namsh@lge.com>).
- resync with XFree86 CVS: correct typo in
<ncurses/term.h>
ifdef.
- modify logic in main.c
(see patch #145) to avoid generating the
same identifier, for example, for /dev/tty1 and /dev/pts/1, which
is used to denote an entry in the utmp file (Debian bug report
#84676), A similar fix was also sent by Jerome Borsboom
<borsboom@westbrabant.net> in May, but I overlooked it when
reviewing bug reports.
- add configure check for
<ncurses/term.h>
to get
rid of hardcoded __CYGWIN__
ifdef in resize.c
NOTE: The CYGWIN port should not be linking resize
with ncurses. It appears that the only reason it is, is because
both the ncurses and termcap ports on that platform are badly
misconfigured (essential pieces have been removed, etc). Checking
for <ncurses/term.h>
does not hurt anything,
since there are some correct installations that are set up that
way.
- add a sample
uxterm
script, which uses the
UXTerm
application defaults for UTF-8 environments.
- undo change to xterm application defaults, since this introduced an
unnecessary incompatibility. The intended functionality was
already addressed by the UXTerm
app-defaults file.
- resync with XFree86 CVS:
- Modified xterm app default to use LFD fontnames instead of old type
(Michael Schroeder).
- Fix xterm when XIM is disabled - caused a segfault
(Tomohiro Kubota).
- remove an ifdef for
USE_HANDSHAKE
added in patch
#158 from the second TIOCSSIZE
ioctl call in the
initialization code. Paul Gilmartin reports that for Solaris 2.6
(sparc), stty does not show that xterm sets rows and columns unless
the second ioctl is executed.
- correct treatment of empty parameter list for some OSC strings
(report by Sami Farin <sfarin@ratol.fi>).
- augment key translations for scrollbar widget to ensure that
keystrokes intended for the text area are not lost if the mouse
pointer happens to fall on the scrollbar. This can happen, for
instance, if the user's
app-defaults
or
.Xdefaults
file contains a translations resource,
though it may also happen through unrelated resource settings:
probably a bug in libXt (reported by Paul Fox
<pgf@foxharp.boston.ma.us> and Dmitry Yu. Bolkhovityanov
<D.Yu.Bolkhovityanov@inp.nsk.su>).
- widen ifdef's in xterm.h to define
__EXTENSIONS__
on
Solaris, for compilers other than gcc. This was added along
_POSIX_C_SOURCE
with in patch
#151, but is not sufficient since Sun's compiler does not define
__STDC__
by default (report by Matthias Scheler
<tron@zhadum.de>).
- modify xterm to obtain the closest matching color if an exact color
is not available, e.g., on 8-bit displays (patch by Steve Wall)
- patch by Tomohiro KUBOTA <tkubota@riken.go.jp> to implement
"OverTheSpot" preedit type of XIM input:
- This preedit type is a reasonable compromise between
simpleness of implementation and usefulness. "Root" preedit
type is easy to implement but not useful; "OnTheSpot" preedit
type is the best in the point of view of user interface but
very complex. And more, "OverTheSpot" is the preedit type
which the most XIM servers support. Thus, to achieve reasonable
usability, support of "OverTheSpot" preedit type is needed.
- In "OverTheSpot" preedit type, the preedit (preconversion)
string is displayed at the position of the cursor. On the
other hand, it is XIM server's responsibility to display
the preedit string. Thus, it is needed for XIM client (here
XTerm) to inform the XIM server of the cursor position.
And more, to achieve good visual proportion, preedit string
must be written using proper font. Thus, it is XIM client's
responsibility to inform the XIM server of the proper font.
The font must be supplied by "fontset". Fontset is a set of
fonts with charsets which are specified by the current locale.
Since XTerm uses ISO10646 fonts regardless of the current locale,
the fonts for XIM must be prepared separately. It is difficult
to prepare fonts which are similar to XTerm font. Thus, my
patch uses a simple way - the default font is "*" which matches
every fonts and X library will automatically choose fonts with
proper charsets. I added "-fx" command option and "ximFont"
resource to override this default font setting.
- changed the definition of "OverTheSpot" preedit type
from XIMPreeditPosition|XIMStatusArea
to XIMPreeditPosition|XIMStatusNothing.
This matches the behavior of other programs such as
Rxvt, Kterm, Gedit.
- A tiny XIM bugfix is also included. By calling XSetLocaleModifiers()
with parameter of "", it can consier XMODIFIERS environmental
variable which is a standard way for users to specify XIM server
to be used.
- adjust configure script to accommodate repackaging of keysym2ucs.c
as include-file for xutf8.c (patch by Tomohiro KUBOTA
<kubota@debian.org>).
- add the
UXTerm
app-defaults file to makefile install
rules (request by Juliusz Chroboczek).
- correct logic in
get_termcap()
, which returned false
if the tgetent()
call indicated that xterm was linked
with terminfo. Although the $TERMCAP
variable cannot be
adjusted in this case, xterm still needs information from this call
to extract data to initialize the erase-mode when the
ptyInitialErase
resource is false.
- modify
ScrollbarReverseVideo()
function to cache the
original border color, so it can restore that when an application
flashes the screen (Bugzilla #38872).
- resync with XFree86 CVS:
- remove ifdef's for X_NOT_STDC_ENV (David Dawes).
- add Cygwin to special errno handling case in ptydata.c (Alan Hourihane)
- set screen size earlier in initialization, to address a race
with window manager resizing its clients (Keith Packard).
- patch by Juliusz Chroboczek to clean up button.c and input.c. The
basic idea is to use a single set of APIs in the XTerm core, and put
a set of workarounds in a separate file. As you will notice, this
drastically simplifies parts of the code; in particular, the only
remaining ifdefs related to the differences between Xutf8 and legacy
systems are related to the selection provider logic.
This defines two new files, xutf8.h and xutf8.c, provide some
half-hearted but fully portable emulation for the three Xutf8*
functions that XTerm uses.
Putting these in a separate file will allow people to experiment with
more complex versions without making the core of XTerm more difficult
to maintain.
The functionality of the emulation is as follows.
- Xutf8TextListToTextProperty fully handles XStringstyle and
XUTF8StringStyle. It will only generate STRING for XStdICCTextStyle,
and wil only generate Latin-1 in XCompoundTextStyle (but label it as
COMPOUND_TEXT, as the spec requires). (I have hesitated to make this
function fail for XStdICCTextStyle and XCompoundTextStyle; this might
be a smart thing to do, in the hope that the selection requestor will
try UTF8_STRING afterwards; opinions?)
- Xutf8TextPropertyToTextList fully handles STRING and UTF8_STRING.
It systematically fails for COMPOUND_TEXT.
- Xutf8LookupString will properly handle single-keystroke input for
the keysyms covered by Markus' keysym2ucs function. It will not
handle either compose key input or external input methods.
- add an ifdef for
SunXK_F36
, used in
xtermcapKeycode()
(patch by Mark Waggoner
<waggoner@ichips.intel.com>).
- modify check for login name to try
getlogin()
and
$LOGNAME, $USER environment variables to detect if the user has
logged in under an alias, i.e., an account with the same user id
but a different name (Debian bug report #70084).
- add resource
tiXtraScroll
, which can be used to
preserve the screen contents in the scrollback rather than erasing
it when starting a fullscreen application such as vi
(patch by Ken Martin <fletcher@catsreach.org>).
- two patches by Denis Zaitsev <zzz@cd-club.ru>:
- added
forceBoxChars
resource to control the
"line-drawing characters" option.
- added
freeBoldBox
resource, which, when set true,
suppresses check in same_font_size()
, so xterm does
not attempt to ensure that the bold font is the same size as
the normal font.
- change the color class for ANSI colors and similar ones such as
bold-color, etc., to follow the convention that the classname is the
instance name with a leading capital (e.g.,
color0
and
Color0
rather than color0
and
Foreground
). There was little use for Foreground as a
class other than to create occasional confusion and bug reports, most
recently by Nelson Beebe who reports that it disables colors in xterm
but not on Linux, which is probably due to a difference in resource
evaluation order. A configure script option (--disable-color-class)
is provided for anyone who did use the older behavior.
- fix a signal-handling bug. When running xterm with
ksh
or similar shell such as bash 2.05, xterm will hang
and not respond to keystrokes after the user types
suspend
. Additionally the popup menus do not respond,
so it is not possible to send SIGCONT to the shell.
What is happening is that the shell is sending itself SIGSTOP, and it
is being stopped. Per specification it also means that the operating
system is sending SIGCHLD to parent to the bash (XTERM).
Now the issue is that xterm assumes it cannot happen and it expects
to receive SIGCHLD only upon termination of its children.
This causes a deadlock with xterm waiting for the child to
die, and the child waiting for SIGCONT.
(report/patch by Adam Sulmicki), analysis/testing by Sven Mascheck
<sven.mascheck@student.uni-ulm.de>).
- correct some inconsistent checks for
XtReleaseGC()
calls in xtermLoadFont()
(patch by Nam SungHyun
<namsh@lge.com>).
- updated wcwidth.c and keysym2ucs.c to versions dated 2001/1/12
and 2001/4/18, respectively from
http://www.cl.cam.ac.uk/~mgk25/ucs/
- correction to change from patch #90,
which was intended to
reset the saved cursor position for normal/alternate screens
on a soft reset, but actually wiped out all of the saved cursor
information. Just reset the saved position for the current screen
(report by Michael Schroeder).
- modify ShowCursor() and HideCursor() so that if the cursor points
to the second part of a wide character, make the show/hide operate on
the first position of the wide character (patch by Sven Verdoolaege).
- scrolling in the alternate screen just before switching back to the
main screen can cause extra blank lines to be inserted into the
scrollback buffer (patch by Paul Vojta
<vojta@math.berkeley.edu>).
- resync with XFree86 4.1.0:
- Use TermcapLibrary as -lncurses instead of -ltermcap, fixes
problem building xterm/resize on Cygwin/XFree86 (Harold Hunt).
- Install xterm.termcap and xterm.terminfo when installing xterm
(Torrey T. Lyons).
- Fix some build issues on Cygwin/XFree86 (Suhaib Siddiqi).
- Define CBAUD, when it's missing in xterm, on LynxOS
(Stuart Lissaman).
- change order of selection-target types to make 8-bit xterm prefer
UTF8_STRING to COMPOUND_TEXT (patch by Juliusz Chroboczek).
- document
-fa
, -fs
command-line options
and faceName
, faceSize
resources which are used by the freetype library support.
- if configure script finds freetype libraries, but imake definitions
do not have the XRENDERFONT definition, define it anyway.
- modify configure script check for freetype libraries to include
<Xlib.h>
, since an older version of the related
headers relies on this (patch by Adam Sulmicki).
- correct return type of in_put() from patch #153
changes, which left it not wide enough for UTF-8 (patch by Bruno Haible).
- undo check for return value from
pututline
(used for
debugging) since that function does not return a value on Slackware
3.6.
- correct length in ScreenWrite, when rendering invisible text
(patch by Sven Verdoolaege <skimo@kotnet.org>).
- fixes/improvements for the
i18nSelection
resource
from patch #153, by Bruno Haible:
- add missing initialization for
i18nSelection
resource.
- split-out the non-ICCM aspect of the
i18nSelection
resource as a new resource,
brokenSelections
.
- add configure check for
<time.h>
and
<sys/time.h>
, to allow for Unixware 7,
which requires both. If the configure script is not used, only
<time.h>
will be included as before (report
by Thanh Ma).
- fix redefinition of
dup2
, getutent
,
getutid
, getutline
and sleep
functions on Unixware 7 (report by Thanh Ma
<Thanh.Ma@casi-rusco.com>)
- add a fall-back definition for
__hpux
, which is
apparently not defined in some compilers on HPUX 11.0 (reported
by Clint Olsen).
- change VAL_INITIAL_ERASE, which is used as a fallback for the
"kb"
termcap string to 8, since that matches the
xterm terminal description (request by Alexander V Lukyanov).
- correct an off-by-one in
ClearInLine
, which caused
the erase-characters (ECH) control to display incorrectly
(patch by Alexander V Lukyanov).
- correct escape sequences shown in terminfo for shifted editing
keys. The modifier code was for the control key rather than
the shift key.
- increase PTYCHARLEN to 8 for os390, add some debugging traces
for UTMP functions (patch by Paul Gilmartin).
- correct an misplaced brace in
SelectionReceived()
(patch by Bruno Haible).
- correct an assignment dropped in
SelectionReceived()
which made it not compile for wide-characters combined with debug
traces.
- correct typo, clarify description of 88- and 256-color controls
(report by Bram Moolenaar).
- correct a typo in ctlseqs.ms which caused DEC Locator control
sequences using single quote "'" display grave "`" instead (reported
by Paul Williams, apparently in patch #114).
- correct index in inner loop in
VTInitI18N()
from
patch #151 changes, which resulted in infinite loop under some
conditions (report/analysis by Paul Gilmartin).
- remove spurious "%|" from terminfo sgr capabilities
(report/analysis by Adam M Costello, Debian bug #89222).
- add shell script to adjust list of dynamic libraries linked by
resize
when building with the standalone configure
script. Otherwise it uses the same list as for xterm, which is
excessive.
- fix a few compiler warnings reported by the 20010305 gcc snapshot.
Changes from XFree86 4.0.2:
- add definition of
_POSIX_C_SOURCE
for Solaris to
make this compile with gcc -ansi -pedantic
(report
by <mark@zang.com>.
- move the binding for shifted keypad plus/minus, which invokes the
larger-vt-font()
and smaller-vt-font()
actions, respectively, into the translations resource (suggested by
Marius Gedminas <mgedmin@puni.osf.lt>).
- modify configure script to support the
--program-prefix
, --program-suffix
and
--program-transform-name
options (request by Alison
Winters <alison@mirrabooka.com>).
- patch from Robert Brady
- fix a scrolling / combining characters display anomaly
- fix a problem with double-width characters where if the primary
font had no box-drawing characters, the right hand half of
double-width characters was erased (reported by Yao Zhang
<yzhang@sharemedia.com>).
- fix special case of null byte for key handling in UTF-8 locales.
- modify logic that compares sizes of normal and bold fonts to be
more forgiving of the font server's choice of bold font which must
match the normal font's size. Now
same_font_size()
compares the height of the fonts rather than individually ascent and
descent, and allows the bold font to be one pixel smaller than the
normal font (addresses a report by Alan Citterman
<alan@mticket.com>, who says that something in patches #146 to
#148 made xterm more likely to overstrike bold fonts, and indirectly
Debian bug report #76404, which reports the opposite).
- make configure script use $CFLAGS and $CPPFLAGS consistently,
including removing a chunk from configure.in which attempted to
save/restore $CPPFLAGS while processing value set by the --x-includes
option, but lost values set in an intervening AC_CHECK_HEADERS. This
change modifies macros CF_ADD_CFLAGS, CF_ANSI_CC_CHECK and
CF_X_TOOLKIT, as well as removing variables IMAKE_CFLAGS and X_CFLAGS
from the generated makefile (the AC_CHECK_HEADERS problem was
reported by Albert Chin-A-Young <china@thewrittenword.com<).
- correct a comparison in SELECTWORD case of ComputeSelect(), which
resulted in a word-selection wrapping past the first column without
checking the first column's character class (reported by Christian
Lacunza <celacunza@netscape.net>
- correct a logic in UTF-8 mode for selecting double-width characters;
a combining character was omitted (patch by Markus Kuhn).
- add feature to pop (raise) window when a bell is received
(patch by Gael Roualland <gael.roualland@dial.oleane.com>).
- add __NetBSD__ and __OpenBSD__ to special-case in xterm_io.h
for USE_POSIX_TERMIOS definition (patch by Christian Weisgerber).
- move special-case HPUX include for <sys/bsdtty.h> to
xterm_io.h to define TIOCSLTC, making HAS_LTCHARS defined for HPUX
10.20 (report by Bruno Betro).
- restructured includes for
termios.h
,
termio.h
and related definitions for main.c, os2main.c,
screen.c and resize.c so they will share equivalent definitions in a
new header xterm_io.h
. This is intended to solve some
problems mainly for HPUX which appear to arise from inconsistent
definitions for SIGWINCH- and HAS_LTCHARS-related symbols (reports
by Bruno Betro, Jeremie Petit and Clint Olsen).
- improve usability of double-width fonts by allowing normal fonts
to be given as double-width (from a patch by Fabrice Bellard
<bellard@email.enst.fr>).
- correct a few compiler warnings in TRACE() macros for
signed/unsigned variable differences (reported by Clint Olsen).
- make configure script use $CFLAGS and $CPPFLAGS more consistently,
i.e., by using CF_ADD_CFLAGS in CF_ANSI_CC macro.
- expanded description of environment variables in manual-page.
- modify OPT_TCAP_QUERY feature to always return the termcap or
terminfo capability string in the response, and to read/write the
names in hexadecimal form to allow for the special case of termcap's
k;
name (patch by Bram Moolenaar).
- add OPT_SAME_NAME and OPT_TCAP_QUERY to xtermcfg.hin, so the
corresponding configure options work (patch by Bram Moolenaar).
- resync with XFree86 4.0.1g:
- Rewrite Xft library for Render extension/core text and font management
Change xterm to use new interface (Keith Packard).
- document logfile options in man-page.
- correct spelling of
-samename
option in help message.
- add configure script option
--enable-tcap-query
(request by Bram Moolenaar).
- patch by Bram Moolenaar to add a
"Co" or "colors" entry to the OPT_TCAP_QUERY feature.
- patch by Kiyokazu SUTO <suto@ks-and-ks.ne.jp>:
- add support for bold font for double width characters.
The font name may be specified with the command line option
-fwb
or with resource
wideBoldFont
(class WideBoldFont
).
- correct underlining of double width character string, which
was drawn only half width.
- correct binary search of precomposed character table, which
may return wrong result when
int
is just 32 bits.
- some changes to align terminfo with ncurses 5.2:
- remove xtermm description, retaining xterm-mono since the former
conflicts with ncurses.
- modify initialization and reset strings to avoid putting the
save/restore cursor operations bracketing changes to video
attributes, since the changes could be lost when the cursor is
restored. This affects xterm-r6 and xterm-8bit (the xterm-xfree86
entry uses the soft-reset feature which resets scrolling margins
and origin mode without requiring us to save/restore the cursor
position).
- make a few entries explicitly inherit from xterm-xfree86 rather
than xterm: xterm-rep, xterm-xmc, xterm-nrc
- ensure that sign-extension does not affect
ctype
macros by using CharOf()
macro to coerce the parameter
to an unsigned char.
- resync with XFree86 4.0.1d:
- Add primitive support in xterm for Xft based fonts (Keith Packard).
The changes are ifdef'd with
-DXRENDERFONT
.
- correct implementation of
ptyInitialErase
: the
value assigned to initial_erase
was for the control
terminal, which is correct as far as it goes. But there was no
following test for the pseudo-terminal's erase value, which would
overwrite the default obtained from the control terminal
(reported by Christian Weisgerber <naddy@mips.inka.de>).
- modify check for printable-characters in OSC string to use xterm's
ansi_table rather than isprint() macro, to isolate this check from
locale settings. This fixes a problem using 8-bit characters to
set the title (reported by Ricardas Cepas <rch@richard.eu.org>).
- modify sample scripts to check for printf before print, since the
latter is not as well standardized (e.g., on Linux).
- updated config.sub, config.guess to reflect changes on
subversions.gnu.org
- correct two instances overlooked from patch #141 which assumed
UTF-8 mode without checking, causing a core dump in non-UTF-8 mode
(one instance was reported by Tommi Virtanen <tv@debian.org>).
- correct a problem selecting from the scrollback buffer in UTF-8
mode by changing remaining getXtermCell() calls to XTERM_CELL() as in
the non-UTF-8 cases (report by Markus Kuhn, patch by Robert Brady).
- several changes from Robert Brady for UTF-8 configuration:
- doublewide characters don't lose their accents when the cursor
moves onto or from them (a visual bug)
- fix logic in addXtermCombining, which mean that if the low byte
of a cell's first combining char was 0, a following combining char
would go into combining slot 1, not 2.
- modify logic for cut-buffers so UTF-8 data is first converted
to Latin1.
- collapse surrogates, 0xfffe, 0xffff to UCS_REPL.
- modify to allow xterm to to show combining characters
attached to doublewidth characters.
- correct bug in linewrap with -u8 option (reported by
Andreas Koenig <andreas.koenig@anima.de>).
- several changes to PTY logic (based on request by Tim Ryan
<timryan@nortelnetworks.com>).
- modify treatment of
-S
option to to make it work with
Unix98 PTY's.
- restore sense of IsPts flag in
get_pty()
, which was
lost in Unix98 changes.
- use new functions
my_pty_id()
and
my_pty_name()
to simplify/fix strings used for utmp,
wtmp identifiers.
- simplify
get_pty()
function, making it have a single
return point so its inputs/outputs can be identified.
- update config.guess and config.sub and scripts to my 20000819 patch,
adding cases for OS/2 EMX.
- add special case for os390 compiler options to configure script
(patch by Paul Gilmartin)
- fix some unused-variable compiler warnings (reported by
Zdenek Sekera).
- split-out some string functions into xstrings.c, to use them
more consistently among main.c, os2main.c and resize.c
- align termcap/terminfo files, adding entries to make them match.
The termcap entries are necessarily less complete than the terminfo,
to fit within 1023 character per entry.
- add terminfo entry for xterm-sco (SCO function keys).
- modify
same_font_name()
to properly handle wildcard
introduced in bold_font_name()
, making comparison for
different fonts succeed when only the normal font is specified. This
is needed to decide if 1-pixel offset should be used. (reported
in a newsgroup by Bart Oldeman <enbeo@enbeo.resnet.bris.ac.uk>)
- correct preprocessor line for OPT_WIDE_CHARS in drawXtermText()
from patch #141 which resulted in overstriking for bold fonts not
working.
- correct Imakefile from 4.0.1c resync so UTF-8 modules are in
UTF8SRC, UTF8OBJ lists, allowing build without UTF-8 support.
- remove a spurious assignment in ScreenWrite() from Robert Brady's
patch which set a null at the "end" of the buffer to be written.
That made the autowrap feature write a blank in the first column for
the non-UTF-8 configuration, rather than the actual character
(reported by Alan Citterman <alan@mticket.com>).
- add a check to ensure that
-class
command-line option
is not confused with -c
(reported by Paul Townsend
<aab@aab.cc.purdue.edu>).
- correction to precompose scripts, so 0061 + 0300 will now be really
be displayed as 00C0 (patch by Robert Brady
<robert@susu.org.uk>).
- correct macro ClassSelects() in button.c, used to hide ifdef's for
OPT_WIDE_CHARS in patch #141 (reported by Andreas Paul
<paula@informatik.tu-muenchen.de>).
- change wcwidth.h to include stddef.h rather than wchar.h, which is
not present on OpenBSD and FreeBSD (reported by Christian
Weisgerber and Bram Moolenaar).
- newer config.sub and config.guess, from lynx 2.8.4dev.7
- Most of this patch is an integration of Robert Brady's patch #11
for doublewidth and combining characters, from
http://www.ecs.soton.ac.uk/~rwb197/xterm/. In this context,
doublewidth refers to 16-bit character sets which may have glyphs
occupying two cells.
- add command-line option
-class
, which allows one
to override xterm's resource class. Also add resource file
UXTerm.ad
, which simplifies using xterm for both
8-bit character sets and UTF-8.
- fixes/improvements to OPT_TCAP_QUERY logic (patches by Bram
Moolenaar, Steve Wall).
- modify Makefile.in to circumvent GNU make's built-in suffix rule
for ".sh" which confuses install.sh with the "make install" target
(report/patch by Paul Gilmartin).
- implement an experimental control sequence which an application may
use to query the terminal to determine what sequence of characters it
would send for a given function key. This is ifdef'd with
OPT_TCAP_QUERY (request by Bram Moolenaar).
- add /usr/local to search path in CF_X_ATHENA configure macro
to build with Xaw3d on OpenBSD (patch by Christian Weisgerber).
- add missing
#undef HAVE_TERMIO_C_ISPEED
to
xtermcfg.hin, omitted in patch #133 fix for IRIX 6.5 baudrate (report
by Alain Filbois <Alain.Filbois@loria.fr>).
- correct a few errors in xterm.man: font in filename example for
Tektronix emulation, and description of -nul/+nul command-line
options (report by Eric Fischer <enf@pobox.com>).
- update config.guess and config.sub (from tin and lynx)
- back out change to
-name
command-line option,
restoring its original behavior (as noted by David Madore, the
correct interpretation of this option is the application instance
rather than the application class).
- workaround for fixed fonts which are generated from Unicode fonts:
they omit glyphs for some xterm's less-used line-drawing characters,
which caused xterm to set a flag telling it to use only its internal
line-drawing characters. Do not set the flag (it can be set from the
popup menu), and xterm will generate only the line-drawing glyphs
which actually are missing.
Otherwise, when used for large fonts, xterm may generate a 2-pixel
wide line, which can leave dots on the screen.
- restore first line of 256colres.pl, omitted in 4.0c diffs.
- make command-line
-name
option work as documented.
Apparently this was lost in X11R5 when coding to use
XtAppInitialize
.
- limit numeric parameters of control sequences to 65535 to
simplify checks for numeric overflow.
- change index into UDK list to unsigned to guard against numeric
overflow making the index negative (Taneli Huuskonen
<huuskone@cc.helsinki.fi>).
- change
sun function-keys
resource name to
sunFunctionKeys
to work around redefinition of the
token sun
by xrdb on Solaris. Similarly, renamed
resource sun keyboard
to sunKeyboard
(Steve Wall).
- change similar resource names for HP and SCO to avoid potential
conflict with xrdb symbols on other systems, as well as for
consistency.
- reorganized the install targets in the autoconf'd Makefile, adding
install-app, install-bin, install-dirs and install-man. The
app-defaults class can be overridden by setting the make variable
'CLASS', simplifying customization of xterm as a Unicode terminal,
e.g., CLASS=UXTerm.
- add limit checks to
ClearInLine()
,
ScrnInsertChar()
, ScrnDeleteChar()
to
correct potential out-of-bounds indexing (prompted by Debian bug
report #64713, which reported a problem with ICH escape sequences).
- updates to config.sub and config.guess
Kevin Buettner <kev@primenet.com> for elf64_ia64
Bernd Kuemmerlen <bkuemmer@mevis.de> and MacOS X.
- patch from Paul Gilmartin for os390 to check for errno set to
ENODEV on failure to open /dev/tty when there is no controlling
terminal.
- patch from H Merijn Brand <h.m.brand@hccnet.nl> for
building on Digital Unix 4.0 and AIX 4.2.
- modify DECRQSS reply for DECSCL to additionally report if the
terminal is set for 8-bit controls.
- add a resource (
limitResize
)
limiting resizing via the CSI 4 t and CSI 8 t sequences.
- ignore out-of-bounds resize requests, i.e., where sign-extension
or truncation of the parameters would occur.
- remove code introduced in #134 which made some backgrounds bold.
- minor correction to format of updated $TERMCAP when adding
kb
capability for ptyInitialErase
logic.
- improved test for SVR4 definition.
- update URL's and mailing addresses, moved to http://dickey.his.com
and dickey@herndon4.his.com
- correct missing quotes in CF_TTY_GROUP configure script macro in
case the script is run in batch mode.
- modify ownership-check of log file to ignore the group ownership.
Otherwise xterm cannot create logfiles in directories with set-gid
permissions.
- simplify the logic that reads termcap data.
- add fallback definition for B9600 in case line speed definition
for 38400 is missing (report by Jack J Woehr <jwoehr@ibm.net>,
for OpenBSD 2.6).
- fix: Set highlightColor, and select a region containing the text
cursor. If the window loses focus, the cursor becomes hollow, with
the region inside the cursor being background/foreground, unlike the
rest of the selection, which is foreground/highlight
(patch by Ross Paterson <ross@soi.city.ac.uk>).
- add configure script tests to define SVR4, SYSV and USE_POSIX_WAIT,
which enables xterm to compile on Solaris 7 and SCO Openserver
without imake, though there are still a few features for the latter
which require
sco
to be predefined.
- patches from Steve Wall:
- add support for two Sun-specific function keys. These keys are
labeled F11 and F12 on Sun Type 5 keyboards, but return SunXK_F36 and
SunXK_F37. Support will only be compiled in if the header file
<X11/Sunkeysym.h> exists and contains the appropriate symbol
definitions. The keycodes for the DEC keycodes were arbitrary unused
codes, but the ones for the Sun keycodes are what cmdtool and
shelltool actually send.
- add
colorRV
and colorRVMode
resources to
allow specifying a color to use for reverse video, similar to the
existing UL, BD, and BL modes.
- add
alwaysUseMods
resource, to override check if
alt
or meta
modifiers are used in
translations
resource. Revamped the code to calculate
the modifier value, and included Meta if alwaysUseMods is TRUE, using
values 9-16.
- patches from Paul Gilmartin for os390:
- regularize the definition of CONTROL() and remove an
acknowledged "trial and error" table.
- translate "^?" into A2E(0177) which is the EBCDIC "DEL"
rather than plain 0177 which is the EBCDIC quotation mark.
- modify
xtermMissingChar()
so that EBCDIC codes 128-159
are not rendered as blanks by X server running on Solaris, which sees
those as control characters.
- make debugging traces (configure --enable-trace)
work properly with EBCDIC.
- add substitutions in autoconf'd Makefile for CPPFLAGS, LDFLAGS and
AWK (reported by Neil Bird).
- correct uninitialized
childstat
variable from patch
#131 in creat_as()
function, which caused logging to not
work on Solaris, whose waitpid()
function does not
initialize its parameter. Add check for EINTR on return from
waitpid()
as well (reported by Neil Bird
<neil.bird@rdel.co.uk>).
- remove a redundant check for working
setuid()
function
introduced in patch #132 (Greg Smith reports that this does not work
as intended on os390).
- change line speed from 9600bd to 38400bd, to accommodate people who
mistakenly use $TERM set to vt100, to reduce the effect of
padding associated with this terminal type.
- add configure script check for IRIX 6.5's redefinition of baud
rates associated with
struct termio
, to correct a
situation where the baud rate was initialized to zero (reported by
Andrew Isaacson <adi@lcse.umn.edu>).
- remove unused configure script check for VDISABLE.
- undo an incorrect change from patch #113 caused the right scrollbar
to be positioned incorrectly when re-enabling it (analysis by
D Roland Walker).
- add ctrlFKeys resource, replacing constant for adjusting
control-F1 to control-F12 to VT220-style F10-F20. The resource
changes the constant 12 to a default value of 10 (request by
Jim Knoble <jmknoble@pobox.com>).
- correct ifdef'ing for conflict between definitions in AIX's
<sys/select.h> and <X11/Xpoll.h> (reported by Clint
Olsen).
- add checks for return-values of getutid(), initgroups() and
setuid() in main.c, as well as modifying ifdef's for __osf__ to
include tty-group and WTMP logic (adapted from patch by Paul Szabo
<psz@maths.usyd.edu.au>)
- modify resize.c to build and work on os390 (uses EBCDIC)
(adapted from patch by Phil Sidler <Phil.Sidler@airborne.com>)
- use Ires(), Bres() and Sres() macros to simplify resource list in
charproc.c
- resync with XFree86 4.0a:
- correct a typo in os2main.c (Holger Veit, from 4.0a).
- integrate patch by Branden Robinson for improving logfile
security:
- make the
creat_as()
function more strict by using
O_EXCL rather than O_APPEND.
- fixes to make DEBUG ifdef's compile/run, including making the
debug logfile more unique by appending a timestamp to its name.
- include <term.h> in resize.c, to fix a missing-prototype
warning.
- modified
creat_as()
a little more, retaining the
ability to append to a logfile If the user specifies the name.
Also, check if the opened file (which patch #130 ensures is
owned by the effective user) is not writable by other users.
- use
creat_as()
logic to make tek4014 screen-copy
more secure (noted by Branden Robinson).
- ifdef'd some of Branden's changes to build/work on older machines.
- correct missing initialization of the
.mode
flag in
ColorRes
struct, from patch #129. This worked on Linux
because malloc()
zeroes memory on that platform
(reported by Christian Weisgerber).
- modify logic for
deleteIsDEL
resource so it has
internally 3 states: unspecified, true and false. If unspecified,
the keyboard type determines whether the Delete key transmits
<ESC>[3~
or \177
, and the popup menu
entry reflects the internal state. Otherwise, the popup menu entry
overrides the keyboard type (suggested by Dr Werner Fink, to make it
simpler to set resources that imitate the legacy X11R6 xterm).
- modify
scroll-forw()
and scroll-back()
actions, adding a third parameter which will direct xterm to ignore
the action when mouse reporting is enabled. This is needed for
the wheel mouse to be used to report to the application rather than
scroll the window.
- add menu entry and action to allow disabling xterm's assumption
that the current font contains line-drawing characters if the
font cells 1-31 are nonempty. Some fonts may have other characters
(reported by Bruno Betro <bruno@iami.mi.cnr.it>).
- add a check in
creat_as()
to ensure that the user
really owns the logfile that has been opened.
- add logic to implement SCO function-keys. (This is really
incomplete, since I intend to revisit this and make xterm able to
emulate scoansi better than just the function-keys).
- add configure script option --enable-sco-fkeys, minor related fixes
(patch by Dr Werner Fink).
- fix typos in ctlseqs.ms (reported by Bram Moolenaar)
- fix typo in sinstall.sh default for $TST_PROG (reported by
Paul Gilmartin <pg@sweng.stortek.com>)
- improve initialization of ANSI colors by delaying allocation until
each color is first used.
- remove ifdef that prevented colorBD/colorUL/colorBL resources from
working when 256-color configuration was built (reported by
Todd Larason).
- fix some minor inconsistencies in terminfo (Debian #58530).
- correct logic for
oldXtermFKeys
resource, fixes a core
dump when attempting to set it from the command-line (reported by Dr
Werner Fink).
- correct ifdef for meta-sends-escap so configure --disable-num-lock
builds.
- add resource, popup menu entry and control sequence to allow
changing the Delete key to send either DEL or the VT220-style
Remove escape sequence.
- remove logic for metaSendsEscape that would allow xterm to send
<ESC>[3~
before a function key that would begin
with <ESC>[3~
(request by Christian Weisgerber).
- add missing action and documentation for meta-sends-escape.
- correct a few typos in ctlseqs.ms (incorrect code for Cyan color)
- patch by Markus Kuhn:
ensure that xterm will automatically activate the UTF-8 mode whenever
the name of the locale environment variable suggests that a UTF-8
locale is in use. This will help that by simply setting LC_CTYPE an
entire system can be switched over to UTF-8, without users having to
remember the UTF-8 command line options ("-u8", etc.) of the various
applications. Command line options and X resource entries can still
be used to override this default choice.
- add old function-keys control sequences and popup menu entry, for
compatibility with legacy X11R6 xterm.
- revert translation of editing keypad "Delete" key to legacy \177.
- simplify the color-resource data expressions with macro COLOR_RES,
for later use in restructuring color initialization.
- change encoding of wheel mouse (buttons 4 and 5) to avoid conflict
with legacy mouse modifiers (suggested by Bram Moolenaar).
- integrate patch by David Mathog
<mathog@seqaxp.bio.caltech.edu> to make this work on OpenVMS
- rename some functions, e.g.,
Index
to
xtermIndex
so that ports such as VMS which link
externals ignoring case will not have library conflicts (reported by
David Mathog).
- correct logic of
do_reversevideo()
, which did not
update the corresponding popup menu check mark (reported by David
Mathog, this was a detail overlooked in patch #94).
- change TRACE macro so semicolon is not within definition, making
indent and similar programs work better.
- add
depend
rule to Makefile.in
- modify logic of boldColors resource to suppress it if an extended
color control has been used, e.g., for 88-color or 256-color mode
(patch by Todd Larason).
- revise logic that handles menus and input translation for keyboard
type so only one can be selected at a time.
- restore kdch1=\177 for the Sun function-key type, and make the
the Delete key send DEL (\177) if the oldXtermFKeys resource is set.
- rephrase logic and ifdef's for POSIX VDISABLE to avoid preprocessor
expression that will not compile on NetBSD/x86 1.4.1 (reported by
Takaaki Nomura <amadeus@yk.rim.or.jp>).
- change coding of editing keypad's "Delete" key to
<escape>[3~, in the default (Sun/PC) keyboard mode.
This makes the terminfo kdch1 capability independent of the
coding of the backarrow key, which sends either backspace (8)
or DEL (127). The reason for doing this (compatibility with
the screen program) outweighs the choice of DEL (127)
which was used in X11R5/X11R6 xterms. The screen
program translates whatever matches kdch1 into <escape>[3~,
even if it happens to be the stty erase character.
- add encoding for control/?, to work around xmodmap or key
translations which may confuse backspace and delete. A control/?
will send DEL (127), and a control/H will of course send backspace
(8).
- add encoding for kcbt to <escape>[Z (fixes Debian #54840).
- minor correction to logic that encodes Sun and DEC function keys
to avoid sending an escape sequence if the key symbol is not found
in xterm's lookup table.
- simplify ifdef's in main.c for POSIX VDISABLE so the "^-" pattern
is more likely to be implemented when imake configures xterm
(fixes Debian #55105).
- change manpage to make it clearer what codes are sent by the
backarrow key.
- add a note reserving OSC 51 for use in Emacs shell (request by
Rob Mayoff <mayoff@dqd.com>).
- correct a missing backslash in xterm-vt220 termcap.
- cleanup remaining quoted includes, preferring bracketed form.
- minor configure-script macro updates from tin and vile.
- add configure-script option for using utempter library, adapted
from Redhat 6.1 patch for XFree86 3.3.5
- resync with XFree86 3.9.17a:
- correction to QNX support (Frank Guangxin Liu)
- some cosmetic changes that did not correct any reported problems.
- move the suggested wheel-mouse button translations into charproc.c
to simplify customization. Correct some minor logic errors in the
support for buttons 4 and 5, used for wheel mice (reported by
Bram Moolenaar).
- implement metaSendsEscape resource, with corresponding
control sequence and menu entry. Like eightBitInput, this
causes xterm to send ESC prefixing the given key, but applies to
all keys and is independent of the 8-bit/7-bit terminal setting.
(requests by Alexander V Lukyanov and Marc Feeley).
- correct potential indexing with negative subscript in udk_lookup(),
(reported by Ian Collier <Ian.Collier@comlab.ox.ac.uk>).
- modify configure script that sets TERMINFO_DIR to use ${prefix}
rather than /usr if the --prefix option was specified (request by
Zdenek Sekera <zs@sgi.com>).
- modify checks for repeat-character control sequence to test the
character class against xterm's state table, rather than the
isprint() macro (patch by Alexander V Lukyanov).
- change several functions to macros to improve speed
- two corrections to simulation of bold font via overstriking:
- use clipping to avoid leaving trash at end of the text, and
- add brackets so wide-character logic does not fall-through
into the overstriking logic (reported by
Marc Feeley <feeley@IRO.UMontreal.CA>)
- add several entries to termcap file to make it have the same set
of aliases as the terminfo file.
- scale the color values used for xterm-256color terminfo entry to
0..1000, as expected by ncurses.
- change xterm-r6 terminfo definitions for F1-F4 to match program.
- Add QNX/Neutrino support (Frank Guangxin Liu
<frank@ctcqnx4.ctc.cummins.com>)
- refine the change to
SGR_Background()
in patch #119,
by not flushing the pending scrolling operation if the background
color is not actually changing. This combination occurs when using
color-ls to display a long listing, since each line ends with an SGR0
which affects only the foreground color. The unnecessary flushing
made it noticeably slower (reported by D Roland Walker
<walker@pobox.com>).
- remove obsolete documentation about modifiers which can be returned
in mouse tracking mode, and modify logic to ignore modifiers other
than the existing ones, e.g., NumLock (prompted by discussions with
Christian Weisgerber and Brad Pepers <brad@linuxcanada.com>).
- use free bit from obsolete shift-modifier coding of mouse tracking
button events to encode buttons 4 and 5, e.g., for a wheel mouse
(requests by Brad Pepers and Bram Moolenaar).
- correct a place where the ptyInitialErase logic did not set the
backarrowKey state, and modify it further to use tgetstr() rather
than parse the termcap data returned from tgetent() so the
ptyInitialErase logic will work when xterm is linked with a terminfo
library (based on a patch by Dr Werner Fink <werner@suse.de>).
- fix definition of HAVE_UTMP_UT_HOST for ISC configuration (patch by
<michael.rohleder@stadt-frankfurt.de>)
- improve configure script's utmp tests (based on reports by Greg
Smith for os390, and David Ellement for HPUX).
- modify sinstall.sh to use uid=0 rather than 'root' to determine if
the installer is privileged. This is needed on some systems since
more than one account may be privileged (report by Greg Smith).
- add an application resource,
messages
(and a
corresponding -/+mesg option) which controls the initial permission
on the terminal: if messages is set to true (the default), behavior
is as without the patch; if it is set to false (as per -mesg), the
terminal is opened in mode 0600, thus producing the effect of the
mesg n
command. This is useful for users who want to
redirect all their messages to one particular xterm: it is more
pleasant to do this with xterm resources than with explicit calls to
the mesg
program (patch, description by David Madore
<david.madore@ens.fr>).
- add responses (DA and DSR) for DEC locator mode
- add coding for ANSI color to DA response
- implement UTF-8 translation for Media Copy (print) operations.
- implement vt320 control sequences for Print Composed Main Display
and for Print All Pages. The latter directs xterm to print the
current screen as well as the scrollback buffer.
- correct error in _GNU_SOURCE configure test, which left it always
defined.
- add more information, i.e., with strerror for some system calls in
the main program which may fail due to insufficient permissions
(prompted by a problem report for
-C
by Jeremie Petit
<Jeremie.Petit@digital.com>).
- add workaround for conflict between <X11/Xpoll.h> and
<sys/select.h> on AIX 4.3 (Richard Griswold
<griswold@acm.org>).
- add configure script test to resolve conflict between between
<X11/Xpoll.h> and <sys/select.h>
- modify translation of UTF-8 sequences to reject "overly long"
variations (patch by Markus Kuhn).
- remove
utf8controls
resource, since Markus' change
removes the corresponding logic.
- correct a case where colors were not rendered properly. This
happened when an application inserted several lines, then changed
colors. If this was done all in one write, then there would be no
intervening refresh, and the new color was applied to the pending
scrolling operation which was awaiting the next refresh (reported
by Stephane Chazelas <Stephane_Chazelas@Raytheon.com>).
- refine configure test for utmp versus utmpx, to build on HP-UX 10.x
(reported by David Ellement).
- move the configure check for
const
after the check
for ANSI C compiler options, since those may be required to make
it work properly on HP-UX.
- add configure test for defining
_GNU_SOURCE
- correction to -hold option, ensure that if data is already
in the output buffer that it will be displayed before closing the
PTY.
- move the configure checks for setuid install of xterm into a script
to avoid installing it setuid'd to a non-root user (reported by
Adam Sulmicki <adam@cfar.umd.edu>).
- correct configure script's check for termcap.h to avoid using
ncurses' version of it on systems that have a working
tgetent()
function. This is needed to make
resize
work properly.
- fix some typography in ctlseqs.ms description of DEC locator events
(reported by Steve Wall).
- change order of tests in configure script for utmp and utmpx
to test utmpx first, to compile on Solaris (reported by
Leena Heino <liinu@uta.fi>
and Patrik Hagglund <patha@ida.liu.se>).
- add a configure test for utmp.ut_xtime, needed for SCO Openserver,
and for lastlog, needed for Redhat 6.0, to refine the utmp/utmpx
auto-configure.
- remove a spurious comma in an #undef (reported by
David Green <greendjf@cvhp152.marconicomms.com> and
David Ellement <ellement@sdd.hp.com> both on HP-UX, whose
compiler does care about syntax).
- change ifdef's using __CYGWIN32__ to __CYGWIN__ (reported by Suhaib
M. Siddiqi <Ssiddiqi@InspirePharm.Com>, who is told that the
next Cygnus release will drop that symbol in their next release).
- minor cleanup of ifdef's for makeColorPair (patch by Steve Wall).
- patch by Alexander V Lukyanov to work around problem observed
in XFree86 3.3.5, reported as bug #5419 to Mozilla. From the
problem report:
xterm consumes cpu when selecting text with mouse (holding
down left mouse button) and when a program working under the
xterm outputs something to stdout.
Easy way to reproduce:
while :; do echo aaa; sleep 1; done
(while this runs, select text and hold down left mouse button)
watch cpu load.
release left mouse button - spinning stops.
- integrated changes by Steve Wall to implement an 88-color model
for systems where 256-colors cannot be allocated.
- when 256-color configuration is compiled, colored bold and
underlining is not available; ifdef'd to avoid possible odd effects
in this case (reported by Steve Wall).
- add resource cacheDoublesize, to limit the caching of font
information for double-sized characters. This addresses a problem
reported by Aryeh Koenigsberg for X terminals with limited font
memory.
- modify treatment of line-drawing characters in UTF-8 mode so that
the Unicode values are used rather than the C0 codes for storing the
translated characters (request by Markus Kuhn).
- add configure script checks for Athena headers and libraries under
/usr/contrib to work on HPUX (reported by several people:
David Nixon <djn@csc.liv.ac.uk>
Aryeh Koenigsberg <aryeh.koenigsberg@telrad.co.il>
Johannes Mähner <johanm@camline.com>
Andrew Gaylard <andrew.gaylard@bsw.co.za>).
- add check to configure script if xterm is installed setgid rather
than setuid, since wtmp and utmp may be installed with group-writable
permissions other than root (based on Debian bug report #7112 by Bo
Branten <bosse@ing.umu.se>).
- rewrote logic that removes data from termcap entry, e.g., for
titeInhibit, to make it less likely to remove the wrong data.
- correct logic which checks for missing characters used for line
drawing. The 0 character was tested unnecessarily, leading to
some inefficiency when rendering.
- change termcap capability which is used as input or output of
ptyInitialErase logic from kD to kb.
Christian Weisgerber <naddy@mips.rhein-neckar.de> pointed out
in effect that kD (in terminfo kdch1) should
correspond to the control sequence for dch1, which deletes
from the current position toward the right.
- check for failure to change ownership of the PTY device and warn
when xterm is running setuid'd to root. This was reported to happen
on the FreeBSD/NetBSD/OpenBSD systems as a result of the chflags()
call.
- add xterm-noapp terminfo entry to illustate a nominally
bash-compatible terminal description.
Several fixes. The main one is a first draft of pulldown menus. It's not
complete (I have some minor/annoying geometry problems to correct), but is
usable. Once it's complete I plan to add a menu to support additional
selections that won't fit on the current popup menus. Also, this fits into my
longterm plan to allow configuring with Motif libraries.
- add null-pointer check to FlushLog(), fixes a core dump when both
-l and -lf options are used when xterm is configured with wide-character
support.
- remove "ISO" case for SD, which was due to a typographical error in
ECMA-48 (reported by Paul Williams <paul@celigne.co.uk> for
vttest).
- add "FILES" section to manpage.
- generate header file to initialize default resources for colors
16-255.
- patches by Greg Smith for os390:
- add README.os390
- use the pty_search() function to find an available pty/tty pair.
- move E2A() call out of getXtermCell() to SaveText() function
so it will be available in all configurations.
- patches by Todd Larason:
- enable SGR 48 5 in ISO color mode, not just 256 color mode
- change configure's --disable-256-color option to
--enable-256-color, to match its effect
- fix OSC 4 xx ? (report ansi color) to report a string which can
actually be used to set the color back
- fix OSC 4 xx yy (change ansi color) to not allow setting colors >
15 in 16 color mode
- simplify the COLOR_ settings a bit in ptyx.h, along with setting
NUM_ANSI_COLORS needed for #1 and #4 above
- correct string-terminator code passed for reference to OSC
responses; when in 7-bit mode, only the final byte of ST was seen.
- Allow multiple color #;name pairs in OSC 4,
and document changes to match.
- add control sequences for specifying the RGB value of the ANSI
colors, and for configuring with 256 colors (patch by Todd Larason
<jtl@molehill.org>). I made the default configuration to
16-colors, because xterm uses the default color map (which has only
256 colors).
- correct an error in DCS $ q m reporting for colors 8-15 (Todd
Larason).
- add test/demo script for double size characters. Used this to
test/correct display of double size characters that should wrap,
underlined double size characters.
- increased cache size for double size fonts to 8, to allow for both
normal and bold fonts (from discussion with Aryeh Koenigsberg
<aryeh.koenigsberg@telrad.co.il>).
- integrated patch from Greg Smith <rys@epaibm.rtpnc.epa.gov>
for port to OS390 (aka MVS). OS390 uses EBCDIC rather than ASCII.
- correct an off-by-one in binary search limits in keysym2ucs.c (Markus
Kuhn).
- implement logging for UTF-8 mode. The output is written in UTF-8 form.
- If colorMode is enabled by default, compile-in default resources to
match the colors listed in XTerm-col.ad (this should fix a
longstanding FAQ).
- added new OSC 3 ; PROPNAME=VALUE ST escape
sequence to set an arbitrary X property on the top level xterm X11
window. Omit "=VALUE" to delete the X property (patch by Greg Badros
<gjb@cs.washington.edu>).
- change internal flag used for utf8controls resource
so we allow 31-bit range of characters (suggested by Thomas Wolff).
- add check for 16-bit characters in OSC strings, change them to '?'
(reported by Thomas Wolff).
- modify logic of same_font_name() to avoid trying to interpret both
parameters as wildcard patterns. That does not (cannot) work, and in
some instances the font server will return unresolved wildcards for
the normal or bold fontnames, making them match inadvertently,
triggering the fallback overstrike logic (reported by Tim Adye).
- correct range-check from patch #108, which resulted in not being
able to select from the scrollback buffer (reported by Tim Adye
<T.J.Adye@rl.ac.uk>)
- correct "no available ptys" problem with Cygwin B20.1 (patch by Tim
Adye).
- modified install-ti rule in Makefile.in to allow override of the
terminfo directory when doing a "make install", i.e., by assigning
to TERMINFO_DIR (request by Zdenek Sekera <zs@sgi.com>).
- added install-full rule to Makefile.in
- resync mkdirs.sh and install.sh scripts against current autoconf
- implement $(DESTDIR) in Makefile.in, making it simple to install
xterm and associated files into a directory just for packaging a
binary release (suggested by CaT <cat@zip.com.au>).
- change IChar type to unsigned, rather than unsigned short, making
room for a flag to keep with 16-bit characters to prevent them from
being interpreted as C0 or C1 controls (reported by Thomas Wolff).
- correct a typo from patch #107, incorrect array name, in the
filterUTF8 function (patch by Bruno Haible <haible@ilog.fr>)
- add utf8controls resource to specify whether xterm should
interpret 16-bit characters unpacked from UTF-8 form as control
characters if they happen to fall into that range. This behavior
is left unspecified by the Unicode standard (request by Thomas Wolff).
- modify handling of OSC to recover if application sends 16-bit
characters with codes above 255. We cannot display them as is, but
translate out-of-range characters to a '?' (reported by Thomas
Wolff).
- add a range-check to LastTextCol(), to guard against indexing
before the beginning of the scrollback buffer. This appears to
happen with certain fonts under X11R5 (reported by Stephane Chazelas
<Stephane_Chazelas@Raytheon.com>).
- implement resource boldMode, to allow disabling the
simulation of bold fonts when the bold and normal fonts are not
different (requested by Will Day <willday@rom.oit.gatech.edu>).
- change the atom "UTF-8" to "UTF8_STRING", and fixes a few bugs in
the UTF-8 selection (patch by Juliusz Chroboczek).
- correct logic of binary-search in keysym2ucs.c (patch by Markus
Kuhn).
- add special interpretation of keysym codes above 0x1000000 as
the corresponding UCS value plus 0x1000000 (patch by Markus Kuhn).
- Two changes from Stephen P Wall.
From his description:
The first change is simple - I added ESC[3J to erase the stored lines
above the screen. That's what the changes to util.c and ctlseqs.ms
are.
The second change is to get the blinking cursor working. I took out
the cursorBlinkTime resource, and put in cursorBlink (Boolean),
cursorOnTime (time cursor is on in msecs) and cursorOffTime, and added
a cursorblink item to the vtMenu to enable/disable it.
- Integrated a patch from Juliusz Chroboczek <jec@dcs.ed.ac.uk>.
From his description:
With this patch, selection conversion works properly:
ISO 8859-1 xterm -> ISO 8859-1 xterm (transferred as STRING);
ISO 8859-1 xterm -> UTF-8 xterm (transferred as STRING);
UTF-8 xterm -> ISO 8859-1 xterm (transferred as STRING);
UTF-8 xterm -> UTF-8 xterm (transferred as UTF-8).
It will not work properly if one xterm is in, say, ISO 8859-2.
Actually, for this case xterm breaks the ICCCM routinely (sending ISO
8859-2 data as STRING), so I wouldn't worry too much about it. I have
not changed the behaviour in eight-bit mode in any way.
- remove duplicate fix for OpenBSD in resize.c
- correct logic in ScreenWrite, which did not reset the high bytes
of 16-bit characters when overwriting them with a 8-bit character
string (reported by Thomas Wolff).
- integrate patch by Markus Kuhn to provide limited support for
input of UTF-8 16-bit data by a lookup table.
- correct check in non_blank_line to ensure we're in wide-character
mode before looking at the high bytes, for InsertChar.
- implement new resource trimSelection, which allows xterm
to trim trailing blanks from selected lines. This does not affect
the highlighting. (reported by several people using mutt,
including
Hans Morten Kind <edphk@uib.no>,
Jeremy <jeremy@exit109.com>
and (Michael Fuller <msf@mds.rmit.edu.au>).
- add patch by Matthieu Herrb to include term.h in resize for OpenBSD.
- correct logic for UTF-8 in functions that hide and show the cursor;
it was displaying a space whenever the low byte of the character at
the cursor position was zero (reported by Thomas Wolff
<Thomas.Wolff@icn.siemens.de>).
This is a resync patch against XFree86 3.9Pn, reflecting changes which were
submitted by Branden Robinson, who worked with
Wichert Akkerman <wichert@cs.leidenuniv.nl>
to set up ifdef's to handle GNU libc 2.1,
and use getpt() which lets xterm avoid having to know the actual PTY name.
I have also added a few fixes for signed/unsigned mismatches, and corrected
a problem in the configure script (the UTF-8 code was always configured since
the Imakefile defines this).
- correct selection logic: I omitted an offset that accounts for
the distance into the scrollback buffer when rewriting this for
patch #101. Also fixed a similar problem for selecting double
size characters from the scrollback buffer (first was reported
by D Roland Walker <walker@pobox.com>).
- improved support for Unix98 PTY's, using patch in Debian bug report
#35650, by J.H.M. Dassen <jdassen@wi.leidenuniv.nl>. From
the patch description:
- No longer links xterm against libutil on a glibc2.1 system.
libutil is a compatibility library and should only be used when
necessary. Rather than having get_pty() use openpty() from this
compatibility library, use the real UNIX98 pty support in get_pty()
(open()ing the master pty, through getpt() if available (glibc
extension)). Use openpty() only under glibc2.0.
- GNU libc2 is not Linux-specific; already it runs on the Hurd. It
provides the UNIX98 pty functions (plus the getpt() extension),
regardless of the underlying OS. Changed two constructs to look for
GNU libc2 only, not GNU libc2 on Linux.
- improve font configuration, by checking if the user's resource
settings for normal and bold fonts give the same font sizes
(fixes problem reported by Peter Waltenberg <peterw@dascom.com>).
- revert change to openpty call in patch #101; this causes xterm to
fail on DEC-Alpha OSF/1 4.0B (reported by H Merijn Brand).
- modify print.c to move include of stdio.h after the autoconf'd
xtermcfg.h since HP's ANSI C compiler otherwise sees inconsistent
prototype for getopt, probably due to problem with const (reported by
H Merijn Brand).
- moved includes and definitions for 'select' from data.h to xterm.h
to fix problem introduced by prototype for getPtyData, part of UTF-8
changes (reported by Jens Schleusener <Jens.Schleusener@dlr.de>)
- added "Meta <Btn2Down>:clear-saved-lines()" default
translation (patch by H Merijn Brand)
- fixes to configure script and ifdef's in main.c to build on a
HP9000/D390 (hppa-2.0w) running HP-UX 11.00 (64 bit) with egcs 1.1.2
and HP's ANSI C compiler (patch by H Merijn Brand
<PROCURA_BV@CompuServe.com>)
- add more parentheses in ifdef's (patch by Bob Maynard).
- eliminate conflicting definitions for USE_TERMINFO in resize.c
(reported by Jeremy Buhler).
- change openpty call to pass NULL rather than ttydev parameter,
since that was used only to estimate the length of the
corresponding data, and may not really be long enough
(reported by Andreas Jaeger)
- update description in xterm manpage for character class table,
which said it handles only 7-bit codes.
- correct a typo in ScrnDeleteChar() which made it not clear the
high byte of wide-character data.
- add logic to convert selection to UTF-8 form when appropriate.
This makes select/paste "work", but further work is needed to
make UTF-8 recognized as a locale in Xlib.
- correct right-limit check when selecting double-width characters.
- change default answerback response to an empty string.
- Correct a typo in the default resource value for
backarrowKeyIsErase: it was always true (reported by Bram
Moolenaar).
- improve configure script's test if the installed xterm is setuid,
in case that is a symbolic link.
- correct "install-ti" rule in Makefile.in, by not setting a blank
$TERMINFO value. That is interpreted as "." by ncurses' tic.
- correct logic that computes num_ptrs count of the number of indices
into the screen buffer. This is the maximum of the colors and
character-set indices; was incorrect in patch #97.
- correct argument type for sigsetjmp, incidental change in patch
#96's Unix88 PTY patch (reported by Bram Moolenaar).
- correct description of secondary DA in ctlseqs.ms (reported by Bram
Moolenaar).
- decouple the backarrowKey and ptyInitialErase resources by
adding a new resource backarrowKeyIsErase, to accommodate people
using applications which have hardcoded tests for characters 8 and
127 rather than relying on the stty settings.
- modify the UTF-8 decoder so that all possible illegal UTF-8
sequences are properly represented by U+FFFD. This should be very
helpful for developers of code that output UTF-8 strings for
debugging. See the file utf-8-test.txt in
http://www.cl.cam.ac.uk/~mgk25/download/ucs-fonts.tar.gz for a
demonstration text that contains numerous illegal UTF-8 values.
(patch by Markus Kuhn).
- correct a place in ScrnRefresh where I was filling the high byte of
a wide character with a space rather than a null (reported by Markus
Kuhn).
- correct data manipulation in unparseputc(), broken for
little-endian machines by patch #97's UTF-8 changes. This meant that
keyboard input on SunOS did not work, though Linux i386 was fine.
- modify initialization for backarrowKey and logic for initial-erase
to prevent the initial-erase from overriding an explicitly set
backarrowKey resource (reported by Vikas Agnihotri).
- add a missing null-pointer check in ScrnRefresh, for the
wide-characters configuration.
- add configure script test for -lutil, needed for openpty call when
configuring xterm for Glibc-2.1 and Unix98 PTY's (first reported by
Martin Lorentz" <m.lorentz@w12.link-goe.de>).
- completely parenthesize ifdef expressions for Glibc (suggested by
Bob Maynard).
- add initial-erase options (-ie, +ie) to help message (reported by
Vikas Agnihotri).
- remove duplicate definition of USE_USG_PTYS (reported by Jeremy
Buhler).
- change termcap kD and terminfo kdch1 to a DEL
(\177).
I overlooked this when separating the styles of keyboard with
the sunKeyboard resources in patch #94, so that it normally
matches the value of the stty erase character:
- Reported by Jae Gangemi <jgangemi@ccf.rutgers.edu>,
this caused emacs to not process the DEL properly, combining it
with succeeding characters.
- This does not appear to be related to a problem which I have
found with screen, which translates the stty erase into
the termcap kD or terminfo kdch1 value
(depending on how it is linked)
if the $TERMCAP variable is set when screen is invoked.
- add command-line options for enabling UTF-8 mode: -u8 and +u8.
The more obvious -utf8 and +utf8 would conflict with xterm's
-ut and +ut (utmp) options.
The UTF-8 changes were requested by Markus Kuhn
<Markus.Kuhn@cl.cam.ac.uk>. This patch does not complete UTF-8
implementation, but makes it usable, i.e., display and refresh work,
and I am able to display the test cases which Markus provides.
More work is needed to complete this feature:
- modify Makefile.in to work with configure script's --srcdir option.
(patch by Jeremy Buhler <jbuhler@cs.washington.edu>)
- add checks for 'echo -n' equivalent for 8colors.sh and 16colors.sh
scripts (reported by Vikas Agnihotri).
- improve logic that looks for bold fonts to allow for wildcards
in the specification for normal fonts, and to ensure that if
a bold font is specified as normal, that xterm will simulate a
bold version of that using a one-pixel offset overstrike
(reported by Henrik Harmsen <harmsen@erv.ericsson.se>).
- correct horizontal spacing of double width line-drawing characters
that xterm simulates.
- improve support for Unix98 PTY's, using patch in Debian bug report
#35650, by Topi Miettinen <Topi.Miettinen@medialab.sonera.fi>.
Andreas Jaeger says this also corrects a permissions problem
reported by cat@zip.net.au
- modify initial-erase logic to ensure that
ttyModes
resource overrides it.
- modify primary DA response to allow a '1' parameter.
- add printer and national replacement character sets to VT220
primary DA response.
- document primary and secondary DA responses in ctlseqs.ms
- use the patch number (e.g., 95) in the secondary DA response,
providing user applications a means of determining the version
of xterm for feature comparison (request by Bram Moolenaar).
- make xterm respond to secondary DA when the decTerminalID
is set for VT100.
- limit user-defined keys (DECUDK) to VT220-style keyboard
when sunKeyBoard resource is true.
- modify ifdef's for Linux-2.2.x with Glibc-2.1 to work with
Glibc-2.1 and no Unix98 PTY support (patch from From Andreas Jaeger
<aj@arthur.rhein-neckar.de>)
- add optional feature (resource and command-line options) to make
xterm use the PTY's sense of erase character on startup, rather than
requiring it to be \177, or set the PTY's erase character to match
xterm's configuration. Note that while $TERMCAP is modified to
reflect the actual configuration, the terminfo kdch1 string is not
(request by Dirk H Hohndel <hohndel@suse.de>)
- improve scripts in vttests to work with newer shells that do not
use 'echo -n'.
- add fonts.sh example script
- correct inequality in handling of "#1" font specification.
- correct call to XGetWMNormalHints() used for computing maximum
screen size; the size hints may not have been set.
- begin implementation of support for wide-characters (configure
option --enable-wide-chars defines OPT_WIDE_CHARS, invoke xterm with
-wc option to activate this feature). This patch optionally widens
internal data structures, invokes the 16-bit text output rather than
the 8-bit version and adds some tables.
- further fixes for terminfo: ka1, ka3, etc., differ between the
default xterm-xfree86 and xterm-vt220 entries.
- change default (with sunKeyboard resource false) behavior of
the editing keypad "Delete" to send a 127, like xterm-r6.
The VT220-style
<ESC>[3~
is sent when
sunKeyboard is true (reported by Tomas Vanhala).
- add parameters to function keys to indicate if shift, control
or alt are set. The codes are based on a description of
a DEC VT510 with a PC keyboard, from Jeffrey Altman
<jaltman@watsun.cc.columbia.edu>.
- add control sequence 1035, set-num-lock action and num-lock
menu entry to control the use of the NumLock and Alt keys for
the Sun/PC and VT220 keyboard extensions.
- implement DECSET/DECRST numeric keypad (DECNKM) mode.
- modify terminfo and termcap to use recommended "X Window" or "X11"
names rather than "X Windows" (reported by Tomas Vanhala).
- suppress translation of shifted keypad "+" when sunKeyboard
is true.
- workaround unexpected behavior (perhaps bug) in XmbLookupString,
which returns trash in the string buffer for numlock and control-key
combined with keypad-keys.
- modify ScrollBarReverseVideo() to keep scrollbar border visible
when reverse video is toggled.
- correct missing case for parameter 17 (set highlight color) in
dynamic colors control sequences.
- extend dynamic colors control sequences to allow users to
determine the colors and font which are currently active.
- minor tweak to OSC responses, to use BEL if the application used
that to end the request, rather than ST. This works better with
shell scripts, which may not handle an
<ESC>backslash
very well.
- separate menu settings for reverse video from that done under
program control.
- corrected ifdef's for menus, which did not allow tek4014 to
be suppressed properly (reported by Clint Olsen).
- integrated patch from Pavel Roskin
<pavel_roskin@geocities.com>
for Linux-2.2.x with GLibc-2.1 and
/dev/ptmx support:
- main.c and resize.c were using different rules to determine
whether ATT should be defined (actually USE_USG_PTYS is more
apt).
- copy definitions from main.c to resize.c to prevent
sys/stream.h and sys/ptem.h from inclusion when SYSV is not
defined
- define CNUL if not already defined like other variables.
- /dev/tty does exist in Linux, but it doesn't mean, it
should be used. Therefore EACCES is now an acceptable
result.
- ifdef'd several calls such as
ioctl (ptyfd, I_PUSH,
"ptem")
to build on Linux (I_PUSH is not defined when
sys/stropts.h is not included).
- initialize second "ltc" variable in main.c (reported by David
Dawes).
- provide definition for USE_USG_PTYS in screen.c
- add resource-files to install rule in standalone Makefile.in
- add sample scripts to illustrate titlebar controls, resizing
and colors.
Here are several fixes and minor enhancements. The chief ones
are the fixes for NumLock mode and reverse video, since we had become
used to working around the problems.
- remove kfnd/kll/kslt strings from terminfo, because curses
applications do not necessarily return khome/kend pairs
(reported by Vikas Agnihotri).
- implement NumLock resource which overrides the keyboard tables for the
special case of keypad keys. This is a problem introduced in xterm
by X11R6 changes, i.e., an ambiguity which in effect discarded vt100
keypad support.
- modify Sun/PC keyboard mode to extend this (emulation of DEC vt100
keypad) to the remainder of the numeric keypad. Now, the default
operating mode of xterm uses the keyboard tables as-is (except if
the NumLock mode overrides), but provides good vt100 keypad compatibility
if the Sun/PC keyboard menu item is checked.
- separate command-line settings for reverse video from that done
under program control. This is a problem which was introduced by
X11R6. Though correct, most users are confused by allowing
the reset command to undo the effect of the command-line -rv
option.
- add description of function keys, keypad and cursor keys to ctlseqs.ms
- add terminfo entries for xterm-vt52, xterm-sun and xterm-hp
- correct typo (missing case value) for DECSET 35, enable/disable
shifted keypad action and a few compiler warnings (reported by Zdenek
Sekera <zs@sgi.com>).
- correct reporting of color values 8-15 in DECRQSS (reported by
Vikas Agnihotri).
- modify parsing of ttyModes resource to recognize "^-" as "undef"
(requested by Tomas Vanhala).
- integrate/extend changes to add iconify/maximize actions
(from Edward S. Arthur <eda@ultranet.com>).
- add control sequences for maximizing/restoring window, and
for reporting maximum screen size.
- add 'interpret' action, to support local function-key interpretation.
Used properly, this makes most of the specialized actions of xterm
redundant.
- add control sequence private modes 1051, 1052 and 1052, for
setting the Sun and HP function key modes, and for setting the
Sun/PC keyboard mode.
- add configure option --disable-maximize
- add configure option --disable-num-lcok
- extend descriptions of configure script options in INSTALL.
- increase buffer size for tgetent (i.e., termcap) to 1500. This
fixes a problem where screen is built using ncurses or
GNU termcap and xterm is built using the standard termcap
interface. The former does not limit the termcap size, while the
latter is assumed to be no longer than 1023 characters. The
screen program's termcap entry is about 1200 characters
long.
- change update_menu_item() to a function, to simplify debugging.
This also reduces the executable by 4Kb.
- add control sequences for DECSET 30, 1010, 1011 like rxvt (enable
or disable some features that were only settable via resources or
command line arguments).
- add control sequence for DECSET 35, which enables/disables the
shifted keypad functions.
- add support for switching font sizes, by stepping through the
font menu using shifted keypad plus and minus.
- correct missing initialization of tekInhibit and tekSmall resources.
- correct ifdef's in charproc.c for XtNgeometry and XtCGeometry
(reported by Bram Moolenaar).
- Implement logic to translate input characters which are mapped
when in vt220 National Replacement Character mode (requested by
Tomas Vanhala).
- Resync configure scripts with my patches to autoconf 2.13
- Change order of -lXmu and -lXext to accommodate cygwin32
(reported by Vikas Agnihotri).
- Add "-ti" option to set terminal emulation level from command
line rather than via resource.
- Simplify some of the preprocessor logic using #elif.
This implements several small fixes and enhancements. The chief one implements
fallback support for line drawing characters with fonts that do not include
those characters. But I implemented that last.
- If any of the glyphs in positions 0-31 (used by xterm to implement
the VT100 alternate character set) are zero-sized (i.e., missing),
xterm will reserve a normal space for the glyph when drawing. I
implemented a simple stroke-drawing function to draw the line-drawing
characters and a couple of the other (simpler) characters such as
diamond. (This was suggested by Vikas Agnihotri).
- Modify the computation of doublesize characters to work around font
servers which shift the scaled characters up/down or do not give the
correct width.
- Add popup menu item and corresponding resource settings to disable
the font-scaling logic for doublesize characters to work around
(older) font servers which simply do not draw the fonts scaled to the
size that they said they would. I see this problem on a SunOS system
running X11R5; the X11R6 servers seem well behaved.
- Implement new escape sequence, private mode 1049, which combines
the switch to/from alternate screen mode with screen clearing and
cursor save/restore. Unlike the existing escape sequence, this
clears the alternate screen when switching to it rather than when
switching to the normal screen, thus retaining the alternate screen
contents for select/paste operations.
When I implemented the popup menu entry to toggle between the normal
and alternate screens, I considered only pasting from the normal
screen to the alternate; this improvement allows either direction.
- Changed the termcap and terminfo for xterm-xfree86 and xterm-8bit
to use the new 1049 private mode.
- Modify the logic which switches between normal and alternate
screens so that the save/restore cursor operations apply only to the
current screen. That means that applications which use the terminfo
smcur/rmcur or termcap ti/te capabilities will restore the cursor to
the original position on the normal screen rather than to the most
recent place where a save-cursor operation was performed.
I note that a real VT100 terminal would not behave in this way,
but it is a moot point since the VT100 does not implement alternate
screen, and therefore the save/restore cursor sequence would not be
used in this context. I reviewed the logic which switches between
normal and alternate screens based on some recent newsgroup postings
as well as a proposed patch in the Debian group which attempts to
do this (the patch has a bug, however, so I did not use it).
- Add popup menu entry for toggling the titeInhibit resource.
- Add new resource answerbackString, which overrides the default
"xterm" returned by xterm when responding to an ENQ (control/E)
character (request by Rajesh Vaidheeswarran <rv@fore.com>).
- Add new resource keyboardDialect for setting the NRC display
character set (request by Tomas Vanhala, who notes that I should
add logic to translate the keyboard as well).
- Add new command-line option and corresponding resources for making
xterm generate escape sequences compatible with HP terminals. Like
the existing Sun escape sequences, this is available as a popup menu
item. It is enabled by the configure script with the option
--enable-hp-fkeys (requested by Toni Mueller <sales@oeko.net>).
- Add configure script option --disable-boxchars to disable the
fallback support for line drawing characters.
- Fix ifdef's for configure script --disable-ansi-color, and reviewed
all configure options to ensure that all can be enabled/disabled
appropriately.
- Update config.guess and config.sub, from Lynx.
This patch completes the implementation of double-sized character support
for the VT100 emulation, and fixes a few minor bugs:
- corrected the cursor position in HideCursor, which did not multiply
the column by two when in doublesize mode.
This bug, which did not appear in normal use,
dates back to my original changes to partly implement
double-sized characters.
I noticed it when cat'ing a typescript from vttest's double-sized character
test.
- ensure that the current line is repainted when switching between
single and double width characters.
- reduce the number of bits used for double-sized character coding
from 3 to 2, to make more room for soft-font codes.
- copy newer ifdef's from the XFree86 3.3.3 release's main.c,
which address details of glibc and powerpc.
- moved definition of DECL_ERRNO in xterm.h to match XFree86 3.3.3
- modify resize to remove the ifdef on SVr4 that suppressed
printing the script for $LINES and $COLUMNS.
Solaris' resize utility does this; suppressing the behavior is unnecessary.
I tested the double-sized characters using vttest and the xfsft patch.
These fonts worked reasonably well:
-bitstream-courier-medium-r-normal--0-0-0-0-m-0-iso8859-1
9x15
The iso8859 font does not include box characters, of course, but looks good.
This refines my #85 patch by checking for a case where the font server
returns a bold font that does not quite correspond to the normal font.
When I asked for a bold version of the 6x12 font, the font server
returned a near equivalent where the ascent and descent values did not
match, causing xterm to leave lines across the display.
This patch makes xterm reject that type of mismatch, falling back to the
old font behavior.
This corrects a problem reported by Stefan Dalibor. My table entries for the
printerExtent and printerFormFeed resources used the wrong
types for sizeof, causing the printer to not work properly on some platforms
because the printAttributes resource was overwritten (e.g., Digital Unix with DEC Alpha).
I reviewed all of the resource table entries and fixed a potential problem with
resizeGravity, which was typed as int rather than
XtGravity.
A small fix: when switching to/from the continuous mouse reporting mode,
the event mask was incorrect if xterm was built under X11R5 because the
original data was saved under an ifdef for active-icon.
Some cleanup (I noticed the pixel droppings a few months ago after getting a
new 17" monitor):
- split-out the functions that load/reload fonts for xterm as new
file fontutils.c to extend them to support automatic loading of
bold font corresponding to the normal font. Adapted logic from
EMU 1.3 for this purpose. This fixes most occurrences of pixel
droppings from bold characters.
- modified by renaming variables and adding casts to permit compile
with g++.
- modify headers so they can all be compiled without order
dependencies, and use bracketed rather than quoting includes to allow
compile from separate directory.
- renamed xtermm terminfo entry to xterm-mono, to avoid conflict with
Solaris entry now in ncurses.
Several small fixes and enhancements, including a patch from
Bjorn Helgaas:
- correct initialization of TERMCAP environment variable, which
was frequently set to garbage on non-Linux systems because
"termcap" and "newtc" contained random data from the stack.
- remove the LINEWRAPPED attribute from lines as they are cleared.
Previously, the attribute was set but never cleared.
- make word and line selections work even when lines are wrapped
by xterm. Previously, selections were limited to one screen line.
as well as
- modify logic for line-wrapping to reset the associated flag if
the application deletes a character. This fixes a problem reported
by Bjorn Helgaas where word/line selection would still wrap even
after deleting characters from the first line.
- add kll/kH capabilities to xterm-xfree86 entries in termcap and
terminfo (request by Michael Schroeder).
- shorten descriptions in termcap to make resolved entries all
shorter than 1023 character limit.
- use DECSTR control sequence to shorten initialization and reset
strings in xterm-xfree86 termcap and terminfo.
- use rmul/smul and rmir/smir in xterm-r5 terminfo to match termcap.
- correct typos in initialization and reset strings in xterm-r5
termcap and terminfo.
- disable special translations of key symbols (the backarrow key,
the editing keypad and the keypad "+") when a modifier other than
shift, control or numlock is used. This makes xterm handle the meta
key as expected by people using emacs (reported by Pete Harlan
<harlan@pointofchoice.com> in linux.debian.user newsgroup).
Merge changes through patch #83 with the 3.3.2e version. This follows a
patch by Matthieu Herrb <matthieu@laas.fr> to add checks for non-null
return from malloc.
Several small fixes and enhancements:
- add configure test to infer if xterm should be installed setuid
based on previously installed xterm (reported by Stephen Marley
and Stefan Dalibor).
- integrate/extend patch by Jason Bacon to implement quasi-continuous
mouse reporting.
- correct control sequences transmitted by function keys F1 to F4
when sunFunctionKeys resource is true (it was still using the
VT100 control sequences).
- modify handling of backarrow key so that the control modifier
toggles the backspace/delete interpretation set by the
backarrowKey resource.
- limit the row and column values used to report mouse position.
From resync with XFree86 3.9Nb:
- add support for the VSTATUS control character (patch by
Robert Earl <rearl@teleport.com>).
Bug fix for patch #81:
- remove an #undef for NBBY, which caused compile problem on FreeBSD
(reported by David Dawes).
More bug fixes:
- fix conflicting ifdef's for TIOCSLTC when building with Linux on
AXP aka DEC Alpha (reported by Robin Cutshaw).
- correction to patch #79, move assignment for *utptr->ut_user = 0;
back into non-SVR4 ifdef in main.c, since this clobbers username on
Solaris 2.5.1 (analysis by Will Day
<willday@rom.oit.gatech.edu>).
- corrected khome/kend in xterm-8bit terminfo description.
- improve cursor color by making it always the reverse of fg/bg
unless the cursorColor resource is set, i.e., to something other than
the default foreground (reported by Vikas Agnihotri and Bram
Moolenaar).
- minor fixes for compiler warnings, including a syntax error in
the AMOEBA ifdef's.
From resync with XFree86 3.9Aj:
- correction to patch #73, supply missing #else for fallback definitions
of size_t, time_t (Robin Cutshaw <robin@intercore.com>).
This fixes a couple of items leftover or introduced by patch 79:
- take out the logic that suppresses editing-keypad in vt100 mode
(those keys are too valuable to give up for a fine point of
emulation).
- corrected a couple of places in terminfo where I missed using the
vt220-style editing-keypad codes for Find/Select (mapped to Home/End).
- checked termcap file against terminfo, fix several places where it
was inconsistent.
This patch fixes several small bugs:
- use X_EXTRA_LIBS in standalone Makefile.in (patch by Tomas Vanhala).
- add new resource 'oldXtermFKeys' which provides backward compatibility
for F1-F4 control sequences with TOG's xterm.
- determine the server's default foreground/background Pixel values,
needed if the -flipPixels X server option is used (reported by
David Dawes).
- correct logic for F1-F4 function keys so that they generate VT100
compatible escape sequences in VT220 mode, since that is what the
numeric keypad is supposed to do (reported by Ron Johnson, Jr.
<ronjohn@communique.net>).
- modify logic for editing keypad to work more like VT220: don't
pass those codes in VT100-mode unless oldXtermFKeys mode is set.
- correct an interaction with the editing-keypad logic that prevented
backarrow key from sending a 127 for the delete key (the 'remove'
escape sequence was being sent instead).
- use return-value from getuid() rather than the parameter, to work on
systems which do not update the latter (patch by Kevin Buhr
<buhr@mozart.stat.wisc.edu>)
- correct scrollbar border color when toggling to/from secure keyboard
mode (patch by Jeff Uphoff <juphoff@tarsier.cv.nrao.edu>)
- modifications to terminfo file:
- rename description to xterm-xfree86, adding an entry 'xterm'
which is derived from xterm-xfree86 to simplify customization.
- change string for kdch1 from \177 to \E[3~, to address complaints
from Debian developers. (This applies to the key labeled "Delete",
and does not affect the backarrow key).
- add user-strings u6, u7, u8, u9 to entries to make them work with
Daniel Weaver's "tack" program.
- modify xterm-24, xterm-bold, xterm-boldso entries to disentangle them from
explicit dependency upon xterm-xfree86.
- add generic 'xterm-color' entry.
- minor corrections to xterm-xfree86, xterm-8bit, xterm-r5 and
xterm-r6 entries.
Again, most of the bulk of this patch is for ANSI conversion. I used the
IRIX compiler's -wlint option to find the remaining functions that use
K&R syntax (since gcc does not do this properly).
Also, I changed the logic in the print code slightly to close unwanted files
before opening a pipe to the printer. This may help in some configurations
where the line printer hangs until xterm closes the pipe.
Most of the bulk of this patch is to convert the extended C (K&R functions
with prototypes) to ANSI. I verified that on Linux by comparing object
files, to ensure that I did not, for example, interchange parameters in
the function declarations.
The rest of the patch fixes several minor bugs, and adds a few features:
- back-out my use of ncurses "captoinfo -f" option (if/then/else/endif)
formatting, since ncurses did not correctly filter embedded newlines
in terminfo capability strings until _after_ ncurses 4.1, thus
corrupting setf/setb/sgr strings (reported by Darren Hiebert and
others).
- document SGR 8, 28 (invisible/visible), add corresponding
capabilities to terminfo description.
I would also add the 'prot protected capability, but the control
sequences for that would not be recognized or properly ignored by the
older xterm programs.
- modify ChangeGroup to not suppress a null-resource, but treat it as an
empty string (recommended by Stefan Dalibor).
- add printerAutoClose resource to control whether printer is closed
when going offline. More than one person reports problems (on
Solaris 2.6 and Digital Unix 4.0) getting the printer to proceed
unless xterm exits; I think that it is a problem flushing the pipe.
Closing it ought to flush it.
- adapt TOG fix-3 to in HandleKeymapChange and VTInitI18N (but adapt
XtStackAlloc/XtStackFree for clarity, as well as fixing memory leak).
- change calls on FillCurBackground to ClearCurBackground, in effect
using XClearArea rather than XFillRectangle when clearing as a
side-effect of scrolling and insertion (patch by Alexander V
Lukyanov)
- correct some places where insert/delete did not _move_ the color
attributes, using memmove (patch by Alexander V Lukyanov
<lav@long.yar.ru>)
- add ifdef's for __CYGWIN32__, for port to cygnus version B19.1
(patch by Andrew Sumner <andrew_sumner@hotmail.com>).
- remove #define for hpux that turned on USE_SYSV_ENVVARS, since this
causes some applications (such as 'less') to get incorrect $LINES and
$COLUMNS values (reported by Clint Olsen).
- modify behavior for HP-UX, to set the "reserved" process group
controls to _POSIX_VDISABLE so the TIOCSLTC ioctl does not produce an
error (patch by Ben Yoshino <ben@wiliki.eng.hawaii.edu>).
- correct length of underlining, reducing it by one pixel to avoid
leaving a dot when the application does not clear the whole screen
(patch by (Sergei Laskavy <Laskavy@cs.msu.su>).
I noticed this only recently myself (and other people as well); it
depends on the font chosen. A 6x10 font shows it, but the other
fonts (from XTerm.ad) do not. I also see a similar problem with the
emulation of bold fonts.
- add include for Xos.h to xterm.h, to ensure proper definitions
(reported by Holger Veit).
- update config.guess to recognize Unixware 2.1 and 7 (patch by
Mike Hopkirk <hops@sco.com>).
A fix for the print-window function, and some minor cleanup:
- modify logic that closes pipe in the print-window function to not use
pclose, which does not work on all systems, since I did not open the
pipe with popen (reported by Stefan Dalibor).
- correct name of $(EXTRA_LOAD_FLAGS) imake variable (reported
by Stefan Dalibor).
- guard logic in ChangeGroup() function against null pointer
(reported by Stefan Dalibor).
- ensure that menu entry for toggling sunKeyboard resource is
initialized (reported by Branden Robinson <branden@purdue.edu>).
- gcc unused-variable warnings (reported by Bernd Ernesti
<bernd@arresum.inka.de>)
- rename global variable 'buffer' to 'VTbuffer'
This incorporates fixes from several people, as well as some improvements
that I made based on feedback from users:
- add option to standalone configure script, "--with-own-terminfo-dir",
which causes xterm to pass a predefined value of $TERMINFO to the
application. Also use this value in install rule "make install-ti",
for the standalone configure script.
(patch & feedback from Tor Lillqvist <tml@hemuli.tte.vtt.fi>)
- change ifdef's for "hpux" to "__hpux" (patch by Tor Lillqvist). The
imake configuration uses the former, but the latter is predefined by
HP's compilers.
- define USE_SYSV_ENVVARS for HP-UX, curses does not use $TERMCAP (patch
by Tor Lillqvist).
- on HP-UX, use the /dev/ptym/clone device to allocate PTY's. Works
both on HP-UX 9 and 10. (patch by Tor Lillqvist).
- modify configure script to obtain the $(EXTRA_LOADFLAGS) value from
imake, needed for compiling under DEC OSF/1 (reported by
Stefan Dalibor)
- modify print-window action so that the printer is closed after
printing a window, unless the printer was already opened (i.e.,
by an application running in the window). This makes the printing
complete without having to exit xterm, since not all systems treat
fflush through a pipe very well (reported by Stefan Dalibor)
- modify printing code so that the ^M's are not printed if the
printAttribute resource is set to zero (request by Stefan Dalibor).
- correct typo in xterm.man, for the default value of printAttribute
(reported by Stefan Dalibor).
- correct printing code so that the alternate character set is
printed, like other attributes, with escape sequences.
- correct termcap description, removing spurious 'm' character from
the 'op' capability (reported by Greg Woods <woods@weird.com>).
- correct trace code so that the initial timestamp is set.
- correct/modify utmp data for the Linux glibc 2 configuration,
so that the ut_line member is set before using it to update wtmp
(patch by Bill Nottingham <wen1@cec.wustl.edu>).
This corrects a couple of recent bugs and adds a new resource:
- modify definition of TRACE_CHILD so that it does not conflict with
ifdef's for USE_USG_PTYS in main.c (reported by Vikas Agnihotri
<VikasA@att.com> and Stefan Dalibor).
- correct ownership of file (actually pipe) written by the print
controls. When undoing the setuid changes in patch #69, I overlooked
this. Now xterm forks a process which resets setuid and routes the
printer data as the real user.
- add a new resource, "printAttributes", which controls whether
color attributes (or any attributes) are sent to the printer.
This patch does the following:
- implements a print-window facility for xterm. Though useful in
itself, I added it as part of some debugging which I am doing.
(Occasionally during an exposure event xterm fails to restore the
proper colors for highlighted text, and printing the screen will
show the internal states nicely).
The print facility now also displays the color information.
(I will probably make this a resource).
- modified the xterm-16color terminfo description to use the setaf and
setab strings, which is a little more efficient (requested by Stephen
Marley).
- reduced some clutter of the ifdef/includes (e.g., stdlib.h, unistd.h,
errno) making the configure script test for these.
I removed the symbols Size_t and Time_t, since they no longer serve
a useful purpose.
- added some debugging traces to show the initial screen size,
and the success/failure of the ioctl calls pass handle window
resizing events to the application (for Clint Olsen).
I also modified the trace code to produce two files since some
of the information is produced by the child process. So now
they are Trace-parent.out and Trace-child.out
- updated configure test for ANSI compiler options to handle a
special case for HP-UX 10.x (reported by Clint Olsen).
This is a patch from Chris Siebenmann <cks@hawkwind.utcs.toronto.edu>,
which I have cleaned up a little, and integrated into the configure script.
From his description:
This set of patches is the latest incarnation of patches originally
written by Ian! D Allen, then of the University of Waterloo and now of
who knows where; I have been carrying them forward from xterm to xterm
ever since about X11R4. What they do is add an option so that when an
iconified xterm receives output it prepends '*** ' to its icon title
and (optionally) beeps the bell; deiconifying the xterm removes the
'*** '. Over the years I've found this to be incredibly convenient for
monitoring all sorts of low-activity things.
This patch is a slightly modified version of one by Richard Braakman, which
prevents buffer overflow in the input-method and preedit-type parsing in xterm.
I changed a couple of details to make the code more maintainable, and looked
for similar things - copying into a fixed-size buffer (found none, though I did
spot an unused variable).
This patch corrects some minor bugs in xterm, and fills in some more details
in the VT220 emulation:
- modify Imakefile to use SpecialCObjectRule for menu and data modules,
making xterm build properly if logging is enabled
(patch by Scott Sewall <scott@iprg.nokia.com>).
- restore "ich" capability to terminfo entries, since
Michael Schroeder points out that "ich1"
is the one which is the problem in Solaris vi.
- correct color of cursor, which would disappear on inverse-video
since the initialization did not compare the cursor color against
both foreground and background (reported by Olivier Calle).
- correct abbreviation-test for -version and -help options, making
command-line option -vb work (reported by Stefan Dalibor).
- correct a dependency between ifdef's for OPT_I18N_SUPPORT and
OPT_INPUT_METHOD (reported by Stefan Dalibor).
- split-out character-set translations as new module charsets.c, to
implement VT220 national replacement character sets (a mode where
some of the characters are displayed as specific European glyphs).
This relies on xterm using an ISO 8859-1 font (approach suggested by
Kenneth R. Robinette <zkrr01@mailbox.neosoft.com>).
- correct a missing increment, which made SS2 and SS3 controls
repeat the shifted character.
- add xterm-nrc to terminfo to illustrate the VT220 national
replacement character sets.
- reformat terminfo using new ncurses tic option "-f", which makes
if/then/else/endif expressions easier to read.
This corrects the problem in xterm with utmp, reported by Olivier Calle
<olivier@tc.fluke.com>
as well as some other people after the XFree86 3.3.2 release.
The error was introduced by my patch #53 in XFree86 3.9r (October 1997).
The correction removes the reset of setuid/setgid before the main event loop,
and solves the problem which I had worked around in a different manner: for
some reason, the particular waitpid() call in creat_as() hangs, does not
return when the child process exits. I changed the ifdef's to force the Linux
configuration to use wait() instead. This call appears to work properly on
other platforms such as SunOS and Solaris.
I also added tests in the standalone configure script to check for the
existence of waitpid().
This corrects another problem with the logic for highlightColor resource.
As reported by David Dawes:
I've just noticed a problem with with the "inverse" control sequence
(ESC[7m) with the 3.3.2 xterm. What it does is sets the background
black, and the text the usual foreground colour rather than simply
swapping the foreground/background.
This appears to be because when I added logic to check that the highlightColor
was distinct from foreground and background colors, I did not add a further
check to see that it was not black (I would make an explicit check for the
resource not being set, but see nothing definite in the headers that would let
me reference an explicitly-undefined Pixel value, though there are some
implications in xpm.h). But this should work.
This patch does the following:
This fixes the problem reported with failure to build the resize
program (BSDI, OSF/1) due to not having <termcap.h>, by changing the
ifdef to one that would be set only if the file exists (not currently
specified, except by the standalone configure script). We do not really need
to include <termcap.h> to build, but only for a clean compile, since it
may declare the tgetent() prototype.
I also updated the man-page for resize, since I had recently noticed
that it can be used to resize xterm using the "Sun" control sequences
option.
This is a small patch to xterm's 8-bit terminal description. I noticed
while testing ncurses that I had specified the wrong (VT100-style) codes
for the F1-F4. Xterm only uses VT220-style function keys in 8-bit mode.
This fixes the following problems with xterm:
This is another patch from Bjorn Helgaas <helgaas@rsn.hp.com>, which I've
reviewed (and learned some). Following are his notes:
I poked around some more and finally got xterm-62 to build and run
cleanly on HP-UX 10.20. Here are the patches. They look sort of
ugly, so here's a little explanation:
- aclocal.m4: Removed side effects from the AC_CACHE_VAL
commands in CF_FUNC_TGETENT. Previously, LIBS was set inside
AC_CACHE_VAL, which worked fine the first time configure was
run, but failed if there were cached values.
- aclocal.m4: Added temporary setting of LIBS before
AC_TRY_LINK in CF_FUNC_TGETENT. Previously, the last value set
by the AC_TRY_RUN loop was used, so only -lcurses was checked.
- configure.in: Added temporary setting of CPPFLAGS before
AC_CHECK_HEADERS for X11 files. Previously <X11/DECkeysym.h>
and <X11/Xpoll.h> were found only if they were in the compiler's
default include directories, even if `--x-includes=DIR' had been
used or AC_PATH_XTRA had found them elsewhere.
The problem on HP-UX was that we were linking with -lcurses rather than
-ltermcap due to the second bullet above, and apparently something in
HP-UX curses is broken. This seems very strange, because the only thing
used is tgetent, which should affect any tty/pty configuration, but I
lost interest in tracking down the exact problem.
This is a patch mostly by Bjorn Helgaas <helgaas@dhc.net> (I added the
os2main.c change, and a little of the documentation). From Bjorn's
description:
- If you use the "-hc <color>" option or set the "highlightColor"
resource, text is highlighted by changing only the background color,
rather than using reverse video. I find this easier to read,
especially when selecting multi-colored text, and it is similar to
the way Netscape shows selections.
- Most of the code changes are under "#if OPT_HIGHLIGHT_COLOR". The
principal exception is in screen.c, where I added a couple calls to
resetXtermGC(). This seems like it could be a bug even without
the color highlighting changes (though I don't pretend to understand
all the logic).
This patch modifies the reset behavior of xterm slightly:
- change the terminfo entry so that rs1 (one of the strings used by
the 'reset' program) does a hard reset rather than switching
character sets. This is more in accord with other terminal
descriptions.
- modifies the treatment of hard reset by the xterm program to
reset the saved lines.
- corrects hard reset by also resetting user-defined keys (DECUDK).
This fixes some minor bugs and adds new functionality:
- add support for blinking text.
- This does not actually cause the
text to flash, but text with the blink attribute can be displayed
in color, using new resources colorBL and colorBLMode.
- If colors are not used, the blinking text will be displayed as
before (just like bold). The main purpose of this is to make
applications work properly when they assume the emulator supports
blinking text.
- I did this by moving the per-cell LINEWRAPPED flag to a per-line
flag, to make room for the new BLINK flag. There were no per-line
flags, so this changes a lot of logic.
- corrected missing save-cursor logic in the handling of SGR 1048
(the new control sequence I added in patch #54, 1997/10/17).
Reported by Darren Hiebert.
- flush the output of the transparent printing after each line
Reported by Tomas Vanhala <vanhala@ling.helsinki.fi>.
- correct the modes that are affected by save/restore cursor by adding
WRAPAROUND and PROTECTED.
- corrected placement of one of the XSync calls that I added in patch
#51, 1997/9/15, which had the side-effect of writing on the window
border when the xterm was resizing from 132 to 80 columns.
- work around an incompatibility of the XKB definition used in xterm
versus that symbol from IRIX 6.2's imake definitions (by adjusting
the standalone configure script).
My last patch has an off-by-one error in the comparison for argc. Douglas
Kosovic <douglask@dstc.edu.au> showed me where (he got a core dump).
Also, I think this explains Clint Olsen's problem, but the symptoms were more
subtle (EINVAL for a system call if the -display option is omitted).
This patch does the following:
- implement logic to permit xterm to work with proportional fonts.
- Thomas Wolff
<Thomas.Wolff@sietec.de>
requested this (but it isn't exactly what he's asking
for - that's a more involved task).
- I chose to do this by rendering the characters on a fixed pitch,
because it would not be useful for existing applications to display
varying numbers of characters on each line.
- Except that this forces the display to be wider, it works reasonably
well. A couple of special cases (reverse + colorBD, for example)
do not display with proper colors, since the inter-character gaps
are painted with the background.
- added a version number to the program (several people have requested
this).
- make the -version and -help options interpreted before the program
attempts to open the display.
- minor reorganization of the man-page (ordered the options, resources
and translations alphabetically - and eliminated some duplication).
- corrected a misspelled filename in Makefile.in, and added a lint
rule.
- updated the configure script to correct behavior when it cannot
find imake, as well as to fix the IRIX+gcc build (conflict with
/usr/include).
- regenerated the configure script with a newer patch to autoconf
that fixes a problem with environment space vs the configure --help
message.
This patch is mostly concerned with the standalone configure script; a few
minor corrections are added:
- add configure option --disable-tek4014, to allow xterm to be built
without the tek4014 emulation.
- add configure option --with-terminal-type, to allow xterm to be
compiled with default $TERM value other than "xterm" (e.g.,
"xterm-16color") -- requested by Stephen Marley <stephen@memex.com>.
- fix a typo in the configure --help message -- reported by Darren
Hiebert <darren@hmi.com>.
- review diffs between main.c and os2main.c, to make them more alike.
(applies some minor bug-fixes to OS/2's version).
- add missing quotes in memmove/bcopy configure test
This patch is based on analysis by Arfst Ludwig <arfst@luxor.IN-Berlin.DE>,
who reported:
Setting the following resources xterm (all current versions) receives a
segmentation fault on <Btn2Up> after scrolling:
*XTerm*VT100*translations: #override \
~Shift~Ctrl<Btn2Up>: insert-selection(PRIMARY, CUT_BUFFER0)\n\
Shift~Ctrl<Btn2Up>: insert-selection(CLIPBOARD, CUT_BUFFER1)\n\
~Shift<BtnUp>: select-end(PRIMARY, CUT_BUFFER0)\n\
Shift<BtnUp>: select-end(CLIPBOARD, CUT_BUFFER1)
(The above resources intention is to be able to paste the latest
selection even if the xterm was cleared.)
And here is how it works (and a fix!): The widget given to the action
handler as first argument is not guaranteed to be a XtermWidget (it can
be the ScrollbarWidget). Instead of accessing the widget's member
directly XtDisplay gives the required pointer in a safe way.
I noticed that this was not the only instance (by reading the code, and testing
with his example), and extended the solution to check the widget-class to
ensure that it is indeed xterm's widget class before attempting to use it in
the context of translations.
This fixes the segmentation violation noted by Rogier Wolff about a month
ago. He'd set xterm to 400 (rows) by 150 columns, which broke because there
were limited buffers (200 rows) used for juggling data when adding or deleting
lines and for switching between alternate and normal screens. I replaced this
by an allocated buffer.
The bug is simple to test if you set titeInhibit false.
This patch does the following:
- correct a minor placement problem with the right scrollbar.
- implement a new set of control sequences for switching between the
normal and alternate VT100 screens. These work around the older
sequences limitation that required modification of the runtime
$TERMCAP to cooperate with the titeInhibit resource (that can't work
with terminfo). I do this by moving all of the functionality of the
rmcur terminfo capability into the control sequences.
- implement the alternate-screen menu entry
This patch adds a fix and implements a new feature (as well as some minor
typos):
- JCHANDRA@Inf.COM (JCHANDRA) noted that there was still a problem
with the wait call with the logging option. It hung when the logfile
was opened as a command-line option. I fixed this by moving the
StartLogging() call down past the place where I'd reset the setuid
mode. So the logfile is opened as the real user, without having
to fork.
- Michael Rohleder <michael.rohleder@stadt-frankfurt.de> sent
me a patch which implements right-scrollbars for xterm. I used that
as a starting point, renamed the command-line options and reduced
the number of ifdef's.
This patch addresses bugs and requests reported by
- Bob Maynard <rmaynard@montana.com>,
- Clint Olsen <olsenc@ichips.intel.com>,
- JCHANDRA@Inf.COM (JCHANDRA),
- Michael Schroeder <Michael.Schroeder@informatik.uni-erlangen.de>,
- Pablo Ariel Kohan <pablo@memco.co.il>
Some of the changes are interrelated (it was an unusually busy week).
- change the default resource value for colorMode to true, matching
the Xterm.ad file.
- correct behavior of 'ech' control, making the default and 0
parameters erase one character rather than to the end of line
(reported by Michael Schroeder).
- add resource boldColors, command-line options +pc and -pc and
configure-script option to specify behavior of xterm's mapping bold
colors 0 through 7 to colors 8 through 15.
(request by Pablo Ariel Kohan).
- add resource colorAttrMode to specify whether colorULMode and
colorBDMode can override the ANSI colors
(from a problem report by Clint Olsen).
- correct a conflict between colorULMode/colorBDMode versus ANSI
colors, where exposure events would occasionally pick up the
former (e.g., colorBD) rather than ANSI colors. Testing the
colorAttrMode made this apparent, though it has been in the
code since 3.2A (patch #35 in Jan 1997).
- correct two problems with the optional logging support. On Linux
at least, the waitpid call in creat_as hangs when the logging is
toggled from the popup menu. Also, the mktemp template has the wrong
number of X's (since X11R5!). Fixed the waitpid problem by
exploiting the fact that the setuid behavior is reset before the
popup menus are available.
(reported by Jayachandran C.).
- add configure script options for building with the Xaw3d and neXtaw
libraries.
- correct CF_IMAKE_CFLAGS standalone configure script macro, so that it
will pick up $(ALLDEFINES) rather than $(STD_DEFINES). This is
needed to make scrollbars work on Linux, since that uses narrow
prototypes.
(reported by Bob Maynard).
- various minor updates to configure-script macros.
Most of this patch is related to the standalone configure script, though
there are fixes/enhancements as well:
- add a new resource sunKeyboard, with associated command-line
option and menu-toggle that allows using a normal Sun or PC
keyboard to generated the complete DEC-style function keys
and keypad.
- correct a reversed foreground/background test in the control
sequence that replies with the current SGR settings.
- correct, by invoking XSync, a display problem that caused the
program to not properly update newly exposed areas when a font
change or 80/132 resize request was not completely accepted.
- restructured autoconf macros (I made a library of all of the
macros across the complicated configure scripts I'm working on).
- use the autoconf config.guess and config.sub scripts to better
identify the host-os.
- improve the configure script that uses 'imake' as a fallback for
definitions.
- correct several instances of unsigned/signed mixed expressions.
I've tested the configure script on Linux, SunOS 4.1.3, Solaris 2.5.1,
IRIX 5.2 and 6.2, AIX 3.2.5 and CLIX 3.1 (all but the last run properly
as well).
This is a collection of small fixes, and a couple of minor enhancements:
- plug a security hole in the implementation of Media Copy (print)
by invoking setuid just before the main loop.
- add an ifdef'd include for <sys/termio.h> for HP-UX, which allows
the program to process SIGWINCH events (this is a bug in X11R6.3)
- add state-table entries for VT52 emulation to enter/exit keypad
application mode.
- disable the popup-menu entry for 8-bit controls when the terminal-id
is less than 200 (e.g., VT52 or VT100).
- ensure that the popup-menu entry for 8-bit controls is updated when
the application enables/disables this mode, including the response
to a full-reset.
- implement VT300 DECBKM feature: set interpretation of the backarrow
key to either backspace or delete. The initial setting is via
resource; it can also be modified in the main popup menu.
- implement VTxxx KAM (ISO AM), which allows a keyboard to be locked
(i.e., the terminal discards input).
- implement VTxxx SRM, which is used to control local echoing of
input on the terminal.
- add terminfo and termcap entries for xterm-8bit, a variation of
the xterm description that uses 8-bit control characters.
- add fallback definitions for Imakefile to allow it to work on some
X11R5 systems that have no SpecialCObjectRule or ProgramTargetName
macros.
- add .c.o and .c.i rules to standalone Makefile.in
- correct order of -lXmu and -lXext in standalone configure script.
- add configure script options to allow selective disabling of
active-icon, input-method and i18n code (mainly for users with X11R5
or an incomplete X11R6 configuration).
- change menu-indices from #define's to enum values, thereby making
it work better with the ifdef's for logging and active-icon (the
X11R6.3 active-icon code is incorrectly ifdef'd; this corrects an
error introduced by incorporating that code).
- correct minor compile errors in the configuration where active-icon
is not used.
- add configure option to suppress echoing of long compiler commands
- correct spelling of decTerminalID in configure script help message
- use gcc __attribute__((unused)) to quiet warnings about unused
parameters when compiling with -W (to make it simpler to find the
real problems).
This patch implements the VT100/VT220 Media Copy (i.e., print-screen) control
sequences.
This patch does the following (all but the first affect only the standalone
configure script):
This patch does the following
- corrects an indexing error in the doublesize character logic
(button.c) that caused core dump (this was reported by J. Wunsch).
- corrects the logic of ShowCursor when it is painting in a doublesize
cell (charproc.c).
- corrects, according to vttest, the behavior when switching to
doublesize characters and back again (doublechr.c).
- adds cbt (back_tab) to the terminfo description (this was something
that I'd overlooked as applicable to curses optimization last
summer).
- corrects, for the standalone xmc test, the logic for disabling xmc.
This is a patch to provide test-support for some work I'm doing on ncurses. It
does not modify the normal configuration of xterm; the code is compiled if the
standalone configure option "--enable-xmc-glitch" is specified.
This fixes the problem reported with xterm's cursor color versus the background
(the second chunk in this patch) and also removes some duplicate initialization
of the cursor GC's. If the cursor color at startup is the same as the
background, then xterm will use the reverse GC, ignoring the setting of the
colorMode resource.
This implements the first part of the VT100 doublesize characters for xterm,
as well as fixing a handful of bugs:
- the doublesize character support uses the normal font (using scaled
fonts will be another patch) with blanks to simulate doublesize
characters. This patch does most of the global changes that'll be
required. I've hidden most of the details in macros and ifdef's so
it's easy to configure out (part of the patch is a configure option
for that purpose).
- corrected limits in DeleteChar() function -- it's always ignored the
size of the left border and scrollbar. I noticed this when working
on the doublesize characters since the glitch was doubled in size
(i.e., it wrapped some garbage around the right margin).
- corrected 'memmove()' logic, for standalone builds (it referenced a
malloc wrapper from my development library).
- add a check for HideCursor() to prevent repeated screen updates
(which can cause a spurious cursor glitch to appear, e.g., during
scrolling). I noticed this with the 3.2A version (but only a few
weeks ago, when I started working on this patch).
Here's a fix for two problems:
- modify handling of tgetent results in xterm and resize programs to
make them tolerant of missing termcap file, or unknown terminal name.
In this scheme, an explicit "-tn" option will succeed, overriding
the fallback list.
- a nit in the configure script (log extra information to help diagnose
which case of the test-compile of tgetent was used).
Bram Moolenaar reported that the cursor color changed unexpectedly while
scrolling. The cause was that it used the same GC's as the logic that draws
the ANSI colors. The bug only appears if the cursorColor resource isn't set,
and has been present since the initial implementation early last year. (The
same bug also appears in rxvt ;-). Here's a fix.
Some nits found by Darren Hiebert (missing part of install-rule, incorrect
assignment for --enable-color-mode option).
Patch for the configure script's logic for obtaining imake predefined
symbols.
This patch does the following:
- integrate the 16-color change for 'xterm'
- minor fixes/clarification of tgetent in terminfo vs termcap to
'resize'
(both changes also modify the configure script)
This implements a simple configuration script with autoconf (to which I'll
add more options later). It does the following:
- configures xterm to build with X11R5 (at least on SunOS 4.1, Solaris
2.4, possibly IRIX - sorry network was down today, but I did test
an earlier version yesterday).
- enables/disables the configuration ifdef's for ANSI color and VT52
emulation.
It does not make tests for the things that imake does (that's another project),
instead it uses a hybrid of the autoconf tests for libraries and adds imake's
compiler options (which are necessary in some cases to get main.c to compile).
This corrects a minor, but annoying error in the vt220 emulation: the DECUDK
is only supposed to be interpreted for _shifted_ function keys.
This corrects something that I overlooked in patch #27 (21-aug-1996), which is
that when trimming the region to be repainted for the highlightSelection
resource of xterm, I still have to paint the background past the highlighted
region. This only happens when I first do a selection in a window that's
partly off-screen, then move the window on-screen.
This patch does the following:
- combines the coding for foreground and background colors into a
single byte, reducing the memory required to store saved-lines in
color. (I'll take back that byte in a following patch to use to
ensure the character-set, so there's no long-term decrease in memory
use).
- modifies the PF1-PF4 coding in termcap/terminfo. Because xterm is
still by default emulating vt100, the function key codes are
vt100-compatible (I overlooked this in patch #31).
I also reformatted the whole terminfo file into a single-column,
for consistency.
- adds an interim xterm-vt220 description to accommodate the old and new
styles of function-keys (though probably it'd be better to drop the
old-style altogether).
This patch does the following:
- implement DECSTR (soft terminal reset). The biggest diff is due to
adding another state table (note that there's only one useful state
here, but it's only 256 bytes rather than 1k as it would have been
before I reduced the size of state entries).
- some minor tidying up (e.g., signed/unsigned use bitcpy, MODE_DECCKM,
resetColor, resetCharsets). More is done in patch #35.
I got the description of DECSTR from a vt420 user's manual. I'll do some
testing with vttest to ensure that there's nothing else to do than what was
documented.
This adds to the reset-fix by Matthieu Herrb <Mathieu.Herrb@mipnet.fr> a
small change to make xterm able to output 8-bit characters in VT100 mode.
Applications that run on real VT100's don't do that anyway, and this feature
should be removed sometime after finishing off the VT220 emulation (VT220's can
do 8-bit characters). That would be a good time to change the default
terminal-id to 220.
This implements the REP (repeat) control for xterm. That isn't part of the DEC
VTxxx series, but is defined in ISO 6429. (Note that the base xterm terminal
description is not changed -- I added a variant, "xterm-rep").
This implements vt52 emulation in xterm (ifdef'd so it can be removed).
I've been using it for testing for the past month or so.
From bug-report by <auroux@clipper.ens.fr> (Denis Auroux), missing reset to
ground state. I checked through the rest of that table and found another,
in the unimplemented MC (screen print).
This patch does the following:
- corrects the restoration of color for bold/underline color mode
- adds a resource 'decTerminalID' to control the reporting level of
xterm (e.g., VT100, VT220).
- uses the new resource to implement/correct the DA1, DA2 and
DECRPTUI reports.
- change valid-response code in DECRQSS from 0 to 1 (the manual says 0,
but the VT420 terminal I've been testing on says 1).
All of these changes are based on vttest 2.6
(Most of the volume in the patch is to add 2 more state tables for parsing
the 2nd/3rd device-attribute controls).
This patch corrects the following reported by Roland Rosenfeld
<roland@spinnaker.rhein.de>:
- handle SGR 22, 24 and 25 in combination with colorUL and colorBD
resources. Also noted & fixed reset of colored underline/bold
with SGR 0.
- a typo in the termcap (missing '['), from 3.1.2Dj (my error)
Roland also complained that he couldn't use box characters with
-adobe-courier-bold-r-normal--12-120-75-75-m-70-iso8859-1
but that's a known xterm limitation (the box characters must be part of the
font, in the first 32 locations).
This patch fixes one of my long-term gripes: xterm's selection doesn't clearly
show what's being selected (as per David's request, it's controlled by a
resource, which defaults to the older behavior).
Here's a patch to fix a problem with xterm's cut/paste and another to modify
the appearance of the highlighting while selecting. (The changes are
independent, so you can see if the change to screen.c is desirable).
Here's a correction for two minor bugs that I picked up in testing, plus
some lint (from Solaris 2.5) where NULL was used incorrectly:
- make the second alternate font the same as the first (that's what
vt420 and dtterm do)
- corrected DECSCL report when DECSCL hasn't been set (i.e., don't
return a '60').
This patch does several things. In effect, xterm can (I think) do a reasonably
good job of emulating vt220 and vt320 terminals (as well as it was doing
vt100, at any rate ;-).
It does NOT do:
- soft fonts
- rigel or sixel graphics
Anyway, I:
- added ECH, CPL, CNL, SU, SD, CBT, CHT controls
- added popup-menu for switching between DEC and Sun function keys.
(corrected alignment err wrt logging entry at that point).
- make xterm recognize both 8-bit and 7-bit controls (including
popup menu for switching modes).
- add user-definable function keys (aka DECUDK)
- support concealed text
- support protected text (both ISO compatible and DEC compatible -
that's not the same thing, btw), with SPA, EPA, DECSCA, DECSED,
DECSEL controls.
- implement DECSCL.
I'll be continuing to test this patch for a while, but don't expect to add any
new functionality (it passes all of the current tests I've built in vttest, but
I need to make more tests)..
This removes the blinking cursor I added last week (for performance reasons).
Time-permitting, I'll revisit this after 3.2 is released (there will be more
work after XFree86 3.2, I assume).
I looked more closely at my "double-negative" and realized that I had been
confused by the default color scheme (black on white) in combination with
reverse video. However, I did see that the original_fg and original_bg data
weren't really used - so I removed that logic.
Also:
- during initialization, check if ANSI colors are set with non fg/bg
values, disable color mode if not. This makes xterm tolerant of
applications that allocate the whole color map.
- implemented blinking cursor (default is off)
This patch does the following:
- fixes some minor typography in the control-sequences documentation
(it didn't occur to me til I'd sent the last patch that I could use
ghostview for previewing the troff output ;-)
- adjusts the shell's background color in ReverseVideo so that flicker
in resizing is reduced
- adds an ifdef OPT_ISO_COLORS to allow configuring xterm without
the ISO color support (saves a lot of memory)
- used that ifdef to isolate/modify logic so that if the user doesn't
have the colorMode enabled, then ISO color support is disabled (saving
memory).
(If anyone needs numbers, I had savedLines set to 2000, and found
a reduction from ~700k to ~400k of allocated memory, according to
Purify).
This documents the changes in control sequences for window operations that
I added in my previous patch. I'm testing another patch that allows the
user to use less memory if colors aren't needed.
This patch does the following:
This implements the following:
- escape sequences that act like the CDE dtterm's window operations
(though I have implemented the default width and height -- I've seen
a rather buggy dtterm running that seems to treat width=0 or height=0
literally -- maybe that's a feature, not a bug?)
- minor tweak to the screen-repainting when resizing (I still cannot
entirely get rid of flicker).
- still more fixes to terminfo & termcap (I corrected my error for
the hpa code and added some other stuff by comparing to ncurses'
description and rxvt's).
- a tweak to the patch by Michael Rohleder for the color translation
- re-order attribute codes to allow later implementation of protected
fields (dtterm supposedly does this; it's probably more useful than
blinking or invisible text -- that uses up all of the available bits
without changing the attribute scheme radically).
This patch implements for xterm several minor features from ISO 6429 which are
useful for terminfo applications. The HPA and VPA control sequences allow
cursor movement along a row or column, cutting down a little on the characters
transmitted. The other codes allow resetting specific graphic rendition
attributes without modifying the other attributes.
(now if someone just had time to implement blinking cursors...)
Adam Tla/lka <atlka@pg.gda.pl> told me a couple of weeks ago that I'd missed
some of the background coloring in xterm. I investigated, and found that while
I'd picked up on the clear-to-bottom and clear-to-end-of-line operations, I'd
overlooked the insert/delete lines. Just so I wouldn't overlook any more of
these, I updated a copy of vttest to test ISO colors and bce (background color
erase). This patch introduces a new function, ClearCurBackground, whose calls
replace the direct XClearArea calls that I'd overlooked.
(There's also a few compiler warnings fixed, etc ;-)
This fixes the problem reported by David Dawes, by making the 50msec select
timeout for the Xaw3d arrow scrollbar a resource. (I made it a boolean for a
variety of reasons -- to make it a number, you'd need an additional resource,
to avoid breaking the logic).
This patch brings the termcap and terminfo descriptions for xterm up to date.
I made the following changes:
This corrects my earlier changes for colors - the inner border of the xterm was
getting painted with the wrong color, since I'd moved the call to set the
background into the logic that tracks SGR information.
This corrects a memory leak in xterm that happens whenever one switches fonts.
This patch corrects the behavior of the ANSI colors in xterm when reverse
video is used, as well as some other lesser sins:
- button.c
- (compiler warnings: shadowing of 'time', redundant cast)
- charproc.c
- renamed screen.colors[] array to screen.Acolors[] to more
easily distinguish the non-ANSI colors from the ANSI colors.
- moved logic of SGR_Save() into VTInitialize, getting rid of
local private variables original_fg and original_bg.
- moved some logic into getXtermForeground and getXtermBackground
from SGR_Foreground, SGR_Background, etc.
- corrected misleading 'row' to 'col' in case for CUF, CUB
sequences.
- ctlseqs.ms
- xterm.man
- (correct a misconception which I'd added that the color0
through color6 resource values apply to non-ANSI colors)
- ptyx.h
- added original_fg, original_bg to TScreen structure.
- scrollbar.c
- (compiler warnings: redundant cast)
- util.c
- new functions getXtermForeground and getXtermBackground replace
the macros GET_FG and GET_BG, with the added functionality of
checking for the reverse-video status of xterm.
- in ReverseVideo, swap the SGR foreground and background colors
also.
I observed an occasional glitch in the xterm's color behavior; a clear to end
of line would get a color that had been used in a program that supposedly reset
colors. I traced this down to the way xterm was modifying colors of GC's on
the fly; it didn't restore the original color of the GC, even though it would
later be used in functions (such as ClearRight) that assumed (my error) that
the GC would have the current foreground or background color.
I fixed this by resetting the GC's colors with a new function 'resetXtermGC()',
and direct calls on SGR_Foreground/SGR_Background, as appropriate and using a
new function 'updatedXtermGC()' to encapsulate the logic that modifies the GC's
color. (I also removed some commented-out code that was trying to do this --
the problem was a little more obscure).
This patch fixes the remaining problems that I had making xterm run with x11r5,
as well as a couple of other bugs. It follows my patch from yesterday, that
added ifdef's for some of the input-method resources.
- corrected ifdef's that suppress the input-method code (doesn't
exist in my x11r5, and xterm works adequately without it).
- corrected fallback definition for 'Select()' macro (oops: I'd
copied the wrong text...)
- moved the declarations for the fd_set variables to data.[ch]
- corrected an ifdef in resize.c (sunos 4.x doesn't have termcap.h)
- corrected (in main.c) some unused/orphaned variables.
This is mostly a documentation patch for xterm. It describes the color control
sequences in more detail, and documents some other features of xterm that
aren't described elsewhere.
I've also added a couple of ifdef's to fix (part of) the problem that I'm
working on (making the program work properly on x11r5, where I'm doing memory
testing -- I have a "good" version from mid-January, but my resync version
doesn't work properly on x11r5). I'm not done with that yet.
I did a (clean) build of 3.1.2n on Linux 1.2.13 (ELF). I've got an S3 card.
This fixes the following in the 3.1.2n xterm:
- initialize cur_foreground, cur_background in charproc.c (Purify
told me they weren't initialized).
- add interpretation of codes 39, 49, to reset background and
foreground to default value (I'm told that ISO 6429 does this; but I
don't have a written reference -- yet -- can anyone help here?).
Anyway, rxvt does it, and it'll solve my remaining color management
problems.
- shadowing of 'time' in menu.c
- 'Cardinal' vs 'int' in scrollbar.c
- several changes to permit compile with X11R5 (the system that I've
got Purify on won't be upgraded to X11R6 for a long time).
I built this version (with a minor nit that I'll patch soon) on SunOS 4.1.3 so
that I can test it some more with Purify.
btw:
the changes made in Xpoll.h won't work on some older systems, because
fd_set isn't a defined type (I've got one machine at least that this
applies to).
This patch does all of the SGR foreground/background fixes (i.e., clearing the
screen after an SGR color is set causes that color to be used in the foreground
and/or background). If the FG_COLOR and/or BG_COLOR flags aren't set, then the
xterm foreground and background default to the window's values. This usage is
consistent with various types of hardware (especially the IBM PC), and is also
used in rxvt.
- charproc.c:
- add/use new macros GET_FG, GET_BG - n/c.
- add/use new functions SGR_Foreground() and SGR_Background()
to set corresponding colors in GC's, and to retain sense of
"original" colors.
=> This makes redundant some of the corresponding logic
in HideCursor to set the foreground and background,
but I left it in since it may be fixing an unrelated
requirement.
- set GC's in LoadNewFont() according to whether the SGR fg/bg
colors are active.
=> This fixes some glitches in the accompanying resize,
that leaves parts of the window in the original
background color.
- screen.c:
- util.c:
- modified ClearRight() so that if either of the SGR fg/bg
colors is set, we don't bzero the attributes and color
arrays, but instead fill them with the appropriate codes.
- modified ClearLeft to use SGR fg/bg colors.
This patch modifies the object code, by replacing indexing expressions with
temporary variables with the full indexing expression. At first glance, this
seems inefficient (it did to me ;-), until remembering comments made in the
compilers newsgroups that trying to "help" the compiler doesn't really work
that well. A good optimizing compiler can do a better job than the programmer
can. (There's a moral in the use of 'register' variables also, but I won't fix
those...).
Anyway, the revised code generates a smaller object...
- charproc.c:
- recode index expressions in ShowCursor() and HideCursor()
using SCRN_BUF_xxxxS macros - changes object.
- replace constant '4' by MAX_PTRS - n/c.
- ptyx.h:
- defined the SCRN_BUF_xxxxS macros in terms of BUF_xxxxS
macros, to pick up references to ScrnBuf data directly, and
added MAX_PTRS symbol to pick up those '4' constants strewn
about the code - n/c.
- screen.c:
- recode index expressions in ScreenWrite() using
SCRN_BUF_xxxxS macros - changes object.
- replace constant '4' by MAX_PTRS - n/c.
- use macros BUF_CHARS, BUF_ATTRS - n/c.
- cast calloc to 'Char *' to fix compiler warning on IRIX - n/c
- scrollbar.c:
- replace constant '4' by MAX_PTRS - n/c.
- cast calloc to 'Char *' to fix compiler warning on IRIX - n/c
When setting up for this phase, I saw that you'd corrected the bug that I found
in ClearLeft. I decided to make this series of patches anyway, since
readability never hurt (and there's the potential for finding another bug while
reviewing this set).
- button.c:
- use SCRN_BUF_xxxxS macros - n/c
- charproc.c:
- use SCRN_BUF_xxxxS macros - n/c
- ptyx.h:
- added four macros: SCRN_BUF_CHARS, SCRN_BUF_ATTRS,
SCRN_BUF_FORES, SCRN_BUF_BACKS to represent the four
arrays that are derived from screen->buf.
- screen.c:
- use SCRN_BUF_xxxxS macros - n/c
- util.c:
- use SCRN_BUF_xxxxS macros - n/c
This is my third (and final cleanup) patch for xterm. It gets rid of the
unused stuff, and converts several functions to static (thereby reducing their
scope).
At this point, the only compile warnings I've got (on Linux) are those about
the select arguments (int vs fd_set type), and a missing declaration for
waitpid. Those both are hard to get right without autoconfigure.
The next patches will address the functional changes...
- Tekproc.c:
- changed several functions to 'static' that aren't used
outside this module -- changes object
- charproc.c:
- changed several functions to 'static' that aren't used
outside this module -- changes object
- deleted unused function unparsefputs -- changes object.
- main.c:
- changed several functions to 'static' that aren't used
outside this module -- changes object
- ifdef'd out unused function 'consolepr()' -- changes object
- removed unused variable 'dummy_tio' -- changes object
- moved variable 'discipline' to quiet unused-warning -- changes object
- main.h:
- deleted unused definition of DEFBORDERWIDTH - n/c
- misc.c:
- changed several functions to 'static' that aren't used
outside this module -- changes object
- provide dummy return statements for xerror and xioerror to
quiet compiler warnings -- changes object
- ptyx.h:
- change sbuf_address and abuf_address to 'Char *' - n/c
- resize.c:
- changed several functions to 'static' that aren't used outside this module
-- changes object
- screen.c:
- remove unnecessary 'Char **' casts - n/c
- util.c:
- changed several functions to 'static' that aren't used outside this module
-- changes object
This is my second patch to xterm. It corrects most of the gcc warnings (except
for some that are due to X header files ;-). I compared objects to keep track
of the changes that don't affect the object code (n/c) versus those that do.
At this point, I'm compiling (fairly) clean with gcc options
-Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Wnested-externs
(I also compiled with -Wshadow, but while that found some things that I wanted
to find, there's far too many warnings from the X headers to be usable in this
context).
The changes:
- Tekproc.c:
- parenthesized expression to avoid gcc warning -- n/c.
- corrected nested-extern declaration for Bool
waiting_for_initial_map; ourTopLevelShellArgs, and
number_ourTopLevelShellArgs - n/c
- charproc.c:
- corrected potentially-unintialized variables 'scstype', 'xim',
and 'input_style' -- changes object.
- adjusted logic of VTparse so that gcc won't warn about setjmp
clobbering parsestate -- changes object.
- corrected initialization of 'scstype', which could have been
clobbered by setjmp/longjmp - changes object.
- corrected nested-extern declaration of 'term', 'ProgramName'
- n/c
- cursor.c:
- corrected nested-extern declaration of 'term' -- n/c
- renamed 'term' parameters to avoid gcc -Wshadow warning - n/c
- input.c:
- change interface of StringInput to assume size_t (i.e.,
unsigned) nbytes -- changes object.
- change interface of funcvalue, and sunfuncvalue to use
'KeySym' type instead of 'int' - changes object.
- main.c:
- moved definitions of SIGNAL_T, SIGNAL_RETURN to proto.h - n/c
- corrected missing params of 'do_hangup()' -- changes object
(note: the missing params were not used).
- corrected missing param of 'Error()' -- changes object
- corrected nested-extern 'environ' - n/c
- adjusted assignments to 'tty_got_hung' and 'no_dev_tty' so
that gcc can see they won't be clobbered by the longjmp -
changes object.
- use Size_t type - n/c.
- menu.c:
- removed redundant prototype for 'do_hangup()' -- n/c.
- renamed 'time' parameters to avoid gcc -Wshadow warning - n/c
- menu.h:
- renamed 'time' parameters to avoid gcc -Wshadow warning - n/c
- misc.c:
- corrected definition of 'HandleFocusChange()' -- changes
object
- cast parameters in call to 'TekExpose()' -- n/c
- corrected nested-extern declarations of 'term', 'toplevel',
ProgramName, and 'environ' -- n/c.
- use Size_t type - n/c.
- proto.h:
- moved definition of SIGNAL_T (and SIGNAL_RETURN) here from
main.c, resize.c to allow use of this symbol in prototypes
(mostly in xterm.h).
- added definition 'Size_t' to use as corrected type for
strncpy, malloc sizes - n/c.
- resize.c:
- moved SIGNAL_T definition to proto.h -- n/c.
- use Size_t type - n/c.
- screen.c:
- tabs.c:
- corrected nested-extern declaration of 'term' -- n/c
- util.c:
- corrected/supplied parameters to 'TekExpose()' -- changes
object (note: 'TekExpose()' doesn't use its parameters).
- corrected nested-extern declaration of
'waiting_for_initial_map' -- n/c.
- renamed 'term' parameters to avoid gcc -Wshadow warning - n/c
- xterm.h:
- prototype 'do_hangup()', 'HandleFocusChange()',
'TekExpose()', 'Error()', 'Exit()' - forces changes in
various places.
- adjusted prototypes that pass 'Boolean' arguments to use
'int' (this is the "correct" ANSI approach to extended
compiles; it's worth mentioning that gcc doesn't meet the
ANSI spec here). I used gcc -Wconversion to find these, but
there's a lot of unrelated warnings that are due to setting
NARROWPROTO in the config - n/c.
- renamed 'term' parameters to avoid gcc -Wshadow warning - n/c
This is my first cleanup patch for xterm. It addresses all of the gcc warnings
for -Wall, -Wmissing-prototypes and -Wstrict-prototypes that I can change
without modifying the object code. (I'm compiling this with gcc 2.7.0 for an
aout target, which makes it simple to compare objects. When I do ELF-only,
I've got a tool that compares that sort of thing as well).
Briefly, this patch adds (and uses) two header files in the xterm directory:
proto.h
xterm.h
I expect this to be the biggest patch by far. However (barring a misplaced
prototype), it shouldn't break anything, since the intent of the patch is to
provide missing declarations.