qbit/xenocara
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
6,121 Commits 1 Branch 0 Tags 396 MiB
f703f1b398
Commit Graph

904 Commits

Author SHA1 Message Date
okan
d42a248920 Reshuffle and slightly simplify menu_complete_path(), removing an 
allocation, for tab-completion; checked by Alexander Polakov as well.
 2015-03-28 22:09:10 +00:00
okan
f345dc8f9a plug a leak 2015-03-28 21:55:48 +00:00
okan
da47515de4 Simplify key/mb binding moving argtype into flags and dropping another 
variable; removes the need to zero out struct binding, leaving a simple
malloc.
 2015-03-26 21:41:43 +00:00
okan
99ed76e391 simplify error messages; discussed with doug@ 2015-02-14 18:24:12 +00:00
okan
8e6050dcaa calloc -> malloc 2015-01-24 18:16:59 +00:00
okan
6b49aaeac1 use malloc over calloc here 2015-01-23 20:26:36 +00:00
okan
3d638de617 First restore net_wm_state(ewmh), then wm_state(iccc); prevents clients 
from re-hiding on restart due to flag toggling (note that this is ripe
for re-vamping). Behavior only observed on restarts.

Problem found by, and initial patch from, Henri Kemppainen (thanks!),
though ever so slightly different one applied.
 2015-01-23 19:35:11 +00:00
okan
c199720bcc Switch to limits.h; replace MAXPATHLEN and MAXHOSTNAMELEN with PATH_MAX 
and HOST_NAME_MAX+1, respectively.

ok doug@
 2015-01-19 14:54:16 +00:00
okan
ef55bfa6b2 Catch up with src parse.y changes by jsg@: 
Don't allow embedded nul characters in strings.
Fixes a pfctl crash with an anchor name containing
an embedded nul found with the afl fuzzer.

pfctl parse.y patch from and ok deraadt@
 2015-01-17 02:05:03 +00:00
okan
7832f8c64d Add gcc format attributes for yyerror(); fix a few yyerror() calls. 
Adapted from src parse.y changes by doug@. OK doug@
 2015-01-16 18:28:08 +00:00
okan
d796bd3619 no need for calloc(1,.. here, malloc is fine since we initialize 2014-10-08 15:31:01 +00:00
okan
72676125b1 make group_init work like other *_init's 2014-10-08 12:48:51 +00:00
okan
c9178afc38 these have nothing to do with 'sticky', but rather group membership; rename. 2014-09-27 19:04:32 +00:00
okan
7832c14ed0 Pass just the group to group_setactive instead of the screen and an 
index which then needed to be found in a queue.
 2014-09-27 18:57:11 +00:00
okan
9cd0504ba3 Update _NET_CURRENT_DESKTOP with the screen's group_active->num. 2014-09-23 14:25:08 +00:00
okan
b9aa350408 Move stuff that doesn't belong in group_init; while here, explicitly 
initialize hideall and cycling.
 2014-09-23 13:45:48 +00:00
okan
c9ebdf69aa Move motion time check to the top of each MotionNotify block (and 
eliminate from ButtonRelease); further limits the amount of work done
outside the threshold, notably mousefunc_sweep_calc,
screen_find_xinerama and client_snapcalc.
 2014-09-18 13:56:58 +00:00
okan
1d2cb82cf4 these client actions are just toggles; less confusing with better names 2014-09-17 18:41:44 +00:00
okan
9daa5fe3e6 ewmh states _NET_WM_STATE_STICKY should not alter position 2014-09-17 18:09:30 +00:00
okan
05b4f3491a Use a similarly named check as sticky for hidden check in a group. 2014-09-17 16:32:53 +00:00
okan
49d0fee8b5 don't toggle _WM_STATE_HIDDEN here yet 2014-09-17 16:30:21 +00:00
okan
8ffcf70d79 Implement EWMH _NET_WM_STATE_HIDDEN. 2014-09-17 16:00:44 +00:00
okan
d4ceb9f4e3 Introduce a check to see if a group holds only 'sticky' clients and use 
this check to decide if a group is virtually empty.  Rationale: if a
group contains *only* 'sticky' clients, it should be skipped while
cycling through groups.  Apply similar logic to the group menu.

Based on an idea from phessler@, who also tested another version.
 2014-09-17 14:31:37 +00:00
okan
50da66bd50 use similiar style for client flags 2014-09-15 13:00:49 +00:00
okan
264064d617 Remove incorrect cast in kbfunc_exec. In kbfunc_ssh, reverse logic on 
truncation check so it's obvious.
 2014-09-11 16:06:26 +00:00
okan
3d7b8e2b10 fold in 'active' into 'flags' 2014-09-10 20:30:38 +00:00
okan
5b08aa926e move the check for an empty queue up during cycle 2014-09-08 21:24:27 +00:00
okan
57ff8d4658 name the group client queue appropriately, like other queues 2014-09-08 21:15:14 +00:00
okan
85b6a48da7 more style nits and wrapping 2014-09-08 20:37:02 +00:00
okan
f091741024 since mruq has been folded in, rename mru-named functions 2014-09-08 20:32:40 +00:00
okan
0fefd96f3e Remove duplicate client queue (mruq); instead, remove and take the 
global Clientq and place it inside screen_ctx since every client belongs
to a screen, then use the same per screen clientq to track stacking
order (the sole reason for mruq).
 2014-09-08 20:11:22 +00:00
okan
898bea2d90 Now that a group knows its screen, only pass down the group_ctx. 2014-09-08 13:51:29 +00:00
okan
b5dd6e391c Add screen_ctx to group_ctx, and populate on init. 2014-09-07 20:57:26 +00:00
okan
c4e86dacb9 more style nits 2014-09-07 19:27:30 +00:00
okan
ae092d4229 screen_fromroot -> screen_find 2014-09-07 17:38:38 +00:00
okan
63dc9657ad Get rid of a redundant array of groups per screen; we already have a 
link to the group queue for each screen.
 2014-09-07 17:27:20 +00:00
okan
ea3574d110 Few style nits; extend 'path' to MAXPATHLEN. 2014-09-06 18:50:43 +00:00
okan
28f5392d74 generic sighandler 2014-09-06 16:24:32 +00:00
okan
dc9a1b77d9 style nit 2014-09-06 16:18:08 +00:00
okan
70027868ed Move termpath and lockpath into cmdq; side effect is that 'lock' and 
'term' now show up in the application menu.
 2014-09-06 16:14:35 +00:00
okan
4abab66820 Rework group names: stash the group name inside the group_ctx as opposed 
to having to manage an array outside in screen_ctx for group names and
shortcuts.  Simplifies (and moves bits for) reading, and constructing
data for, EWMH's _NET_DESKTOP_NAMES.
 2014-09-06 16:08:58 +00:00
okan
bef5d30e83 bring menu bits closer together 2014-09-02 14:08:39 +00:00
okan
1150bfd22b add explicit paran and drop some empty lines bringing like functions closer 2014-09-01 18:17:32 +00:00
okan
de52ddf635 Merge group_menu into mousefunc_menu_group. 2014-09-01 18:04:58 +00:00
okan
ea1518cb5c Since the flatting out of sc->group_names is only for setting 
NET_DESKTOP_NAMES, merge the helper into xu_ewmh_net_desktop_names,
where we actually set the property.
 2014-08-25 14:31:22 +00:00
okan
749976d1d7 Implement _NET_WM_STATE_STICKY, bound to CM-s by default; allows any 
client to 'stick' to all desktops (ewmh speak) or groups - this
currently has the same affect as setting a client's group to 'nogroup',
with the exception that the client can also be in a group, so when
un-sticking, the client will go back to its original group/desktop.
 2014-08-25 12:49:19 +00:00
okan
4acfe91344 Continue effort to bring keyboard and mouse functions together; merge 
name_to_kbfunc and name_to_mousefunc.
 2014-08-24 15:49:58 +00:00
okan
4485c34f15 gc->hidden has never consistently kept track of a group's state; 
group_show() and group_hide() are not the only ways a group can change
state - if all clients in a group are either hidden or unhidden, then
that group's state should change, as well as the various EWMH ways.
Instead of trying to keep track in a wide variety of places, simply
query the clients in a group before needing to take action based on the
group's state.  Solves long standing confusion of when a group is hidden
or not.
 2014-08-24 15:37:45 +00:00
okan
9567454909 Fix nogroup regression, where nogroup became an actual group - the 
symantics between cwm groups and ewmh got in the way.  Ensure a client
that wants to be in nogroup stays in nogroup (thus stays in view), even
when (re)reading NET_WM_DESKTOP.  Paritially reverts patchset 644
(2014-02-07 13:09 PST) which deals with a NULL cc->group.  All to be
revisited when NET_WM_STATE_STICKY hits cwm.

Reported by many; testing and ok phessler.
 2014-08-22 19:04:00 +00:00
okan
b7cd8019f2 Purely mechanical; unify 'num', 'no' and 'shortcut'. 2014-08-20 15:15:29 +00:00
okan
045b994659 Split off group window restacking. 2014-08-20 13:42:27 +00:00
okan
2c1d1423f8 whitespace 2014-08-20 12:35:39 +00:00
okan
cb5bdeabf0 fix a misleading comment and function name 2014-08-20 12:33:12 +00:00
okan
f819bd3e15 Remove unnecessary memset since reload was replaced with restart; 
from Kent Spillner.
 2014-08-19 18:39:41 +00:00
okan
7fd50277e7 Pull highstack from group_ctx (and useless calculations of); in the one 
place that we use highstack, replace that usage with a local variable
(for now until stacking is done properly).
 2014-08-19 12:47:51 +00:00
okan
c4aace036f Get rid of nhidden in group_ctx; it actually never reported correctly 
since nhidden wasn't incremented nor decremeted in all the right places,
thus confusing matters.  We don't need to carry a count around, so just
use a local variable in the one place we need one to supply
XRestackWindows().
 2014-08-18 13:57:57 +00:00
okan
0cb1db2d4c plug memleak (currently unused func); from Tiago Cunha 2014-04-21 12:52:14 +00:00
okan
877931bf62 Alignment fix; found the hard way on sparc64 by landry@ (and thanks too 
for fast access to a box!)

ok deraadt@, matthieu@
 2014-02-27 00:52:57 +00:00
okan
875128a0cb Make sure we cycle through existing client's group membership and set 
the hidden state on the group; important to know group hidden state
after a re-exec or restart of cwm (as easily seen in group menu).
 2014-02-08 02:49:30 +00:00
okan
1a7c8d161a Replace a few hand rolled loops with like tailq loops. 2014-02-08 02:40:43 +00:00
okan
92bf6935f5 all mapped clients now should have a group, so simplify some cases 2014-02-07 21:59:56 +00:00
okan
60a1b7520a If _NET_WM_DESKTOP is set to -1 during client creation, place the client into 
group 0 (nogroup); solves problem initially discovered by oga@nicotinebsd with
tint2.  A clientmessage *after* client creation already handles this case.

Go further and assign every client to a group; in non-sticky mode, group 0
(nogroup) and sticky mode, the active group.  In both cases, autogroup will
override the group assignment.  Removing a group from a client always places
the client back into group 0 (nogroup).  Autogroup can also assign a client to
group 0 (nogroup) to keep a client always visible (unless of course one opts to
hide all clients).
 2014-02-07 18:09:54 +00:00
okan
b23ca72ab1 Some clients set the urgency flag even if they are the active client; 
prevent annoying behavior by only setting the cwm urgency flag if the client
is not active; diff from Thomas Adam.
 2014-02-06 20:58:46 +00:00
okan
16de3733be Introduce a region queue and replace screen's XineramaScreenInfo; we 
still use Xinerama to populate the regions per screen, but will switch
at a more appropriate time.
 2014-02-03 21:07:47 +00:00
okan
4c3987dcc1 make this XQueryTree like the other 2014-02-03 20:29:05 +00:00
okan
ea2abae9f3 Move redundant bits from screen_init (while dealing with existing 
clients) directly into client_init, performing the X roundtrip only
once. With the previous change in maprequest, this moves decision making
into one place for creating new clients.
 2014-02-03 20:20:39 +00:00
okan
bb4485df6b Move redundant window attr fetch from maprequest directly into 
client_init and perform that X roundtrip only once.
 2014-02-02 21:34:05 +00:00
okan
03847f1c2e No need to store screen colormap and visual; rather just use the X 
macros in the one place they are needed.
 2014-02-02 16:29:04 +00:00
okan
49f2f86dbd Unlike free(3), XFree(3) can't be passed a NULL pointer. 2014-02-02 16:13:50 +00:00
okan
4ce9b05438 The menu already limits entries with MENU_MAXENTRY, so don't bother 
holding a command name limit as well.
 2014-02-02 15:46:05 +00:00
okan
9062093012 Take menu's bwidth into account for position/size; reported by Thomas Adam. 2014-02-01 19:28:46 +00:00
okan
d413fd6b56 Let the config parser continue parsing even after encountering an error; 
original idea (with now-outdated patch) from Thomas Adam.  Since we now
report where errors exist, this now makes more sense.  Expand a bit on
config file parsing in the cwm(1).

Discussed with a few, including sthen; ok sthen.
 2014-02-01 00:25:04 +00:00
okan
364a7628cb re-add lost free from previous 2014-01-30 22:41:16 +00:00
okan
4de6836838 Switch ignoreq to winname struct since it's basically the same thing; 
removes limit on name matching.
 2014-01-30 22:17:22 +00:00
okan
ca2497d48b use the same autogroupwin variable as everywhere else 2014-01-30 15:43:53 +00:00
okan
9f5aa96cc7 Move cwm_status around to avoid header fu, and remove extraneous signal 
header from xevents.c; noticed by Christian Neukirchen.
 2014-01-30 15:41:11 +00:00
okan
06d9319772 Remove duplicate mouse functions and instead use the kbfunc ones. No 
user visable changes at this point, but they'll merge at an appropriate
time.
 2014-01-30 14:40:21 +00:00
okan
d5979e3ab6 Minimize trivial differences between a few kb and mb functions. 2014-01-29 22:30:00 +00:00
okan
e2d5d73e53 keybinding -> key binding 2014-01-29 21:17:33 +00:00
okan
78ff1f748c Merge keybinding and mousebinding queues into using the same merged 
struct, binding; they were essentially the same accept for what was
'pressed', keysym or button.
 2014-01-29 21:13:52 +00:00
okan
cd007c0d08 Much like we do for keyboard and mouse bindings, remove duplicates for 
command name - last match.
 2014-01-29 18:43:27 +00:00
okan
2ffb124daa Check command name/path for truncation and provide user feedback during 
config parse (and use conf_cmd_add to populate defaults); based on a
discussion with Tiago Cunha.  While this looks ugly, there are likely
some other changes here to come.
 2014-01-29 18:34:22 +00:00
okan
0590f4c1fc Check ignore windowname for truncation and provide user feedback during 
config parse; based on a discussion with Tiago Cunha.
 2014-01-28 20:22:21 +00:00
okan
2d6c7c78d8 The EWMH spec states that if the cardinal returned is 0xFFFFFFFF (-1) 
then the window should appear on all desktops, which in our case is
assigned to group 0.  Found to fix stalonetray due to the non-ewmh aware
range checking in group_movetogroup(); from Thomas Adam.
 2014-01-28 13:40:40 +00:00
okan
e395fd7bea Move conf_init/clear into main - no behaviour change; from Tiago Cunha. 2014-01-28 00:42:20 +00:00
okan
beb28798ef move some init up and shed some blank lines 2014-01-27 15:13:09 +00:00
okan
fad126f1a3 simplify parse_config using assignment; inspired by a very old diff from 
Tiago Cunha.
 2014-01-27 14:49:40 +00:00
okan
d0425acdda more range checking 2014-01-24 22:38:02 +00:00
okan
66e13c1a60 correct arguments and drop the cast. 
sanity check by oga@nicotinebsd
 2014-01-24 15:08:06 +00:00
okan
9ffdedb82e no need to quote within warning 2014-01-23 17:13:38 +00:00
okan
40c619037f If no title is supplied, term uses only the basename for its title. 
This is useless when searching for windows launched via the ssh command
menu; supply a more useful title: '[ssh] <hostname>'.

Idea from todd@, ok todd@
 2014-01-23 16:51:28 +00:00
okan
b740a0a91a zap whitespace 2014-01-22 22:41:09 +00:00
okan
fa2846fe29 cwm_argv doesn't need to be global any longer 2014-01-22 22:26:05 +00:00
okan
3aff0ea880 start properly releasing X resources during teardown 2014-01-22 22:14:02 +00:00
okan
3b8ad25f38 Somewhat streamline event loop/restart/quit handling; most notable 
change allows a restart to trigger proper teardown first, even though
teardown is not (yet) complete.

After some discussion with oga@nicotinebsd.org regarding a more
complicated version/idea.
 2014-01-22 21:48:27 +00:00
okan
b92e846e56 Sprinkle a few more const; from Tiago Cunha. 2014-01-21 15:42:44 +00:00
okan
69bb069674 Save the ptr position before lowering via kbd, so as to be able to cycle 
back with the pointer in the right place; matches behaviour when
lowering via the mouse function.
 2014-01-20 23:18:47 +00:00
okan
57bbf0fd90 merge KBFLAG_NEEDCLIENT and MOUSEBIND_CTX_*; brings kbfunc and mousefunc 
bits even closer.
 2014-01-20 23:03:51 +00:00
okan
42e2d07b2b Use argument to pass down flags for mousefunc cyclegroup; removes 
rcyclegroup wrapper need - now similar to kbfunc.
 2014-01-20 22:31:53 +00:00
okan
9a540a7adb constify and rename some confusing variables around cmdq. 2014-01-20 21:34:32 +00:00
okan
7e2aa0c80b - remove redundant range check for buttons in conf_bind_mouse. 
- make conf_bind_kbd return error on non-matches to match what
   conf_bind_mouse does.
 - rename some variables while here for clarity.
 - constify bind and cmd.

from Tiago Cunha.
 2014-01-20 19:06:04 +00:00
okan
83b0cbf116 Add a function that adds an entry to a menuq, normalizing a common code 
path; from Tiago Cunha.
 2014-01-20 18:58:03 +00:00
okan
72ccee09ff use consistent types 2014-01-03 15:29:06 +00:00
okan
a2ae5b4d2d state is long 2014-01-03 14:23:50 +00:00
okan
9fbf947a27 calculate proper menu width/height on the first Expose event; 'jump' (while using gap) noticed by Christian Neukirchen 2014-01-02 22:49:10 +00:00
okan
c0d34338d1 Accept _NET_CURRENT_DESKTOP ClientMessage; from Thomas Adam, though 
instead of group toggle, group only.
 2014-01-02 22:43:55 +00:00
okan
37b3ff69f9 Accept _NET_WM_DESKTOP clientmessage; from Thomas Adam 2014-01-02 22:26:27 +00:00
okan
24e4f6a4b6 bring mousefunc closer to kbfunc 2014-01-02 21:30:20 +00:00
okan
424dc78f8e gc keycode in keybinding since we only deal with keysym now 2014-01-02 21:17:23 +00:00
okan
6dd84359f1 rename for clarity 2014-01-02 21:15:39 +00:00
okan
164bcbb443 When a client doesn't specify size hints, nothing prevents a resize to 
0x0 - don't allow this situation during mouse resize (check already in
place for kbd resize).

Reported by brynet@
 2014-01-02 20:58:20 +00:00
okan
434826524f missing stdarg.h include 2013-12-17 16:12:18 +00:00
okan
d504b54a27 replace with memset 2013-12-17 16:10:43 +00:00
okan
468c12c5da Implement support for EWMH's _NET_WM_STATE_FULLSCREEN hint. 
Since we already have a form of 'maximize', we need to differentiate
between 'maximize' and the new 'fullscreen' mode.  The 'maximize' mode
will continue to honor gap but now *retains* the border, matching the
'vert/horz maximize' behaviour.  The new 'fullscreen' mode supports and
follows the _NET_WM_STATE_FULLSCREEN hint, allowing the client perform
additional window modifications; in this mode, cwm(1) will *ignore* gap,
remove borders and freeze(move/resize) the client.  Additionally,
'fullscreen' mode will remember various combinations of previous states.

* default keybinding changes: CM-f 'fullscreen', CM-m 'maximize' (re-map
  as desired).

Positive feedback from a few, testing and ok sthen@
 2013-12-16 19:02:17 +00:00
okan
4104232e02 Teach screen_find_xinerama() to apply gap only when told to do so; 
adjust callers.  Needed for an upcoming feature.
 2013-12-13 22:39:13 +00:00
okan
5671dd5497 Instead of using work area, use the Xinerama area for snap calculations; 
based on a patch from Thomas Adam with appropriate adjustments for gap.
 2013-12-13 21:51:56 +00:00
okan
8730d44943 we need the save-set when re-exec'ing so as to not lose State on our hidden clients 2013-12-13 15:56:44 +00:00
okan
c11a490e80 stray space and sort while here 2013-12-13 14:45:47 +00:00
okan
1d68a42ec0 Add support for XUrgency and matching _NET_WM_STATE_DEMANDS_ATTENTION 
ewmh hint; urgencyborder is configurable.  The urgency flag will stick,
even while on a client in a non-viewable group, until the client
receives focus (where the border is reset).  Initial diff from Thomas
Adam with some changes/enhancements from me.
 2013-12-13 14:40:52 +00:00
okan
baac27374e Make sure we really take work area gap into account with snap calculations; 
from Dominik Honnef via Christian Neukirchen.
 2013-12-12 21:50:50 +00:00
okan
e5da774880 ICCCM explicitly states that server time (CurrentTime) should *not* be 
used for focus events, but rather the timestamp of the generated event.
Track the last event timestamp and send it down for a WM_TAKE_FOCUS
ClientMessage.  I suspect we should do this for clients that don't
announce this Atom as well, though the raciness gets us into a bind.

Solves focus order issue since WM_TAKE_FOCUS; fix verified by sthen@

ok sthen@
 2013-12-12 20:15:07 +00:00
okan
c16e20981c we don't need to manage the save-set since we're not reparenting; left-over from pwin 2013-12-11 22:14:23 +00:00
okan
f1494daf70 since we are drawing in unhide, no need to during client setup 2013-12-11 17:23:31 +00:00
okan
b5f3d28152 apply mwm hints later 2013-12-11 15:46:47 +00:00
okan
3d5c10942f Add client wrapper for XWMHints to support XA_WM_HINTS in PropertyNotify 
events; based off a diff from Thomas Adam.
 2013-12-11 15:41:11 +00:00
okan
5da88fd68f Remove extra work and simplify client state handling. 2013-12-11 14:16:09 +00:00
okan
33eb08de92 Stash Class and WM Hints in client_ctx 2013-12-11 14:09:21 +00:00
okan
3c7dcdc9f9 Redraw client border when unhiding; during a hide, we just unset 
the active flag but never redraw since it'll be in IconicState.

Behaviour reported by sthen@
 2013-12-10 21:27:37 +00:00
okan
a6e6db763a If not using sticky mode (the default), clients aren't automagically 
assigned a group, thus cc->group will be NULL - fix the client group
shortcut in menu lists; crash reported by Christian Neukirchen.
 2013-12-08 13:51:38 +00:00
okan
7459d3af28 When we receive a NotionNotify event, there's no need to (incorrectly 
might I add) redraw the top menu selection.
 2013-12-02 20:01:19 +00:00
okan
e5072fc220 Always highlight the first menu item (helpful to see selected items when 
not using a mouse and therefore not generating Expose/MotionNotify
events); from Thomas Adam.
 2013-12-02 19:49:26 +00:00
okan
d7f3078e8e Prepend the group shortcut in the client search menu; from Thomas Adam. 
Likewise, prepend shortcut in unhide menu.
 2013-12-02 19:30:27 +00:00
okan
3207d6dcc9 Since we use IconicState as our hidden state, check for the hidden flag 
and unmanage the client if we're not hidden (basically if NormalState)
during an UnmapNotify event.

Resolves an issue with mplayer going fullscreen while not using NetWM
hints; behaviour regression reported by Ido Admon.
 2013-12-02 14:30:12 +00:00
okan
a287dfc793 like gap, make snapdist per screen 2013-11-27 18:34:34 +00:00
okan
efe2ba92f9 alter -r1.145 getsizehints to deal with clients that don't have 
WM_NORMAL_HINTS.
 2013-11-27 17:04:35 +00:00
okan
9b29ffac8c Remove the option to bind a key by keycode with brackets; it never 
worked (and no one complained!).  While it's fairly easy to fix, users
should be using keysym names and not keycodes.

Discussed at length months ago with todd@, matthieu@ and Owain.
 2013-11-27 16:24:17 +00:00
okan
a09ca80c45 simplify/unfold 2013-11-27 14:20:32 +00:00
okan
57ba45de2c Rewrite active/inactive client handling in client_setactive(); 
client_leave() served no real purpose, likewise no reason to handle
LeaveNotify events since an EnterNotify will process the next active
client (and we don't have anything important to process anyway), so
xev_handle_leavenotify() goes as well.  Allows a simplification of
client_mtf() and client_cycle_leave() for clarity.  While here, unify a
few client_current() checks.

No intended behaviour change.
 2013-11-27 00:01:23 +00:00
benno
3ab274cd32 Log message: 
use u_char for buffers in yylex, for ctype calls, as done in all other
parse.y in the tree
found by millert@, ok okan@
 2013-11-25 18:21:55 +00:00
okan
632f11c555 Alter the r1.35 of event.c race fix. Remove the forward looking event 
queue check (removing the need for a server grab/ungrab) - if the client
is going away, let it fall all the way through to a DestroyNotify event.
There's no longer a need for us to manually destroy a client ourselves
(removing yet another server grab/ungrab).  Instead, when the
UnmapNotify event is synthetic, simply set the state to Withdrawn (as
per ICCCM), else Iconic (in our case 'hidden').

Verified with test case from the 2009 race which was the original reason
for r1.35 of event.c.
 2013-11-12 21:25:00 +00:00
okan
ce53b02ca7 Put back the border draw call in client_resize; since we are adding and 
removing the border on maximized clients we need to redraw.

Also noticed by Tim van der Molen
 2013-11-11 12:51:15 +00:00
okan
e8fcfc29d4 stash WMProtocols in flags 2013-11-08 17:35:12 +00:00
okan
b543fee100 quick keyboard focus fix for clients that neither populate wmhints nor wmprotocols, like rdesktop; focus needs to be re-visited 2013-11-05 00:55:42 +00:00
okan
d21ac16a79 The only reason we need to keep XSizeHints in our client_ctx is for 
flags, so just add one to hints; consolidates sizehints and shrinks.
Additionally don't abuse PSize for XGetWMNormalHints() failures.
 2013-11-02 19:13:56 +00:00
okan
47ae5c2eb9 x/y from XSizeHints are obsolete (and have been for a long time), so 
instead use x/y from XWindowAttributes when USPosition|PPosition are
set.
 2013-11-01 21:54:20 +00:00
okan
95e47782f7 re-add support for WM_TAKE_FOCUS, and additionally this time only call 
XSetInputFocus() for clients that have the InputHint; latter fix
discovered by Valery Masiutsin with a PoC patch - solves keyboard input
focus loss for java apps.
 2013-11-01 14:07:19 +00:00
okan
a8efa775ea A client_delete should behave differently depending on whether the 
triggering event was unmap (with pending destroy) log destroy; we only
need to grab/ungrab the server lock, set WithdrawnState and
XRemoveFromSaveSet clients coming from an unmap event - doing so for
clients coming from destroy are already gone, hence we generate errors.
 2013-10-25 19:46:16 +00:00
okan
816ad65098 shuffle 2013-10-20 02:00:02 +00:00
okan
f22f30d08a wrap key ungrab like btn ungrab, for it'll be used again 2013-10-20 01:55:32 +00:00
okan
25ca41475e revert 1.138 (WM_TAKE_FOCUS) for now 2013-10-20 01:35:47 +00:00
okan
d5f92c3e42 Using xu_btn_ungrab() buttons during client_leave doesn't work (error 
BadValue) when the modifier is already AnyModifier .  Instead alter
xu_btn_ungrab() to ungrab AnyButton/AnyModifier and call it only when a
client is coming into focus in client_setactive(), instead of iterating
over ignore mods - matches how we handle key grabs.
 2013-10-19 19:39:34 +00:00
okan
70cf49457d I believe we redraw the border in too many cases; likely a leftover from 
the cc->pwin days - don't redraw on every unhide, resize, and mouse
move/resize Expose event (note, all Expose events trigger a redraw
anyway).

Tested with some finicky X apps I could think of, though I'm sure others
will find more - if so, and they 'lose' the border, please report!
 2013-10-19 18:59:22 +00:00
okan
f2ed8ceb47 For clients that support WM_TAKE_FOCUS in their WM_PROTOCOLS property, send 
a ClientMessage event.
 2013-10-19 00:24:54 +00:00
okan
0710bf7edc a few err->errx since we don't have error messages here; from Tiago Cunha 2013-10-17 13:59:10 +00:00
okan
c42f6cebe3 trying parsing a XLFD string first, then by pattern 2013-10-07 13:40:26 +00:00
okan
78f4db5140 unify type; no change 2013-10-03 13:51:57 +00:00
okan
0f156a8c2a we no longer need to construct an array for _NET_SUPPORTED. 2013-07-16 14:30:48 +00:00
okan
6cceb06057 don't need the size here 2013-07-16 14:22:25 +00:00
okan
cb56ed0c01 max -> nitems 2013-07-16 14:04:44 +00:00
okan
db709659c2 shuffle down protoypes 2013-07-15 23:53:19 +00:00
okan
76b17dcb11 collapse lines 2013-07-15 23:51:59 +00:00
okan
1ca1aa39ab simplify atom handling; allows us to limit to one round-trip to server 
for gathering Atoms.
 2013-07-15 14:50:44 +00:00
okan
407cedcacc bring buttonpress and keypress event handlers slightly closer together 2013-07-10 14:15:58 +00:00
okan
2d39ce5e52 type fixes 2013-07-10 14:11:42 +00:00
okan
0cd6dbc0fc since the root and event window are the same in the case of a button 
event on the screen's root window, there's no need to pass down the
entire XButtonEvent event, at least to group_menu(), the only callback
which takes an argument at this point; instead use the already populated
screen.
 2013-07-09 01:24:49 +00:00
okan
c2e750f350 add support for mouse based group {,r}cycle; from Rodrigo Mosconi. not 
bound by default.
 2013-07-08 18:39:20 +00:00
okan
ad88124f83 move kbfunc and mousefunc closer together 2013-07-08 18:19:22 +00:00
okan
473473704c clarify kbd vs mouse functions 2013-07-08 16:32:51 +00:00
okan
53d2c330b7 move duplicate kbd and mouse modifier parsing to a generic function; 
from Tiago Cunha
 2013-07-08 16:10:55 +00:00
okan
f3dbf2e427 replace a few (x)malloc with (x)calloc to prevent potential integer 
overflows; from Tiago Cunha
 2013-07-08 15:48:16 +00:00
okan
2993105e89 whitespace and style fixes; from Tiago Cunha and one from me. 2013-07-08 15:46:16 +00:00
okan
b72940ef73 properly fix (and re-organize) selfont selection. 2013-06-23 17:57:50 +00:00
okan
989f306272 when selfont is configured, make sure we continue and configure the rest 
of the screen (quick fix); discovered the hard way by Rodrigo Mosconi.
 2013-06-20 02:33:57 +00:00
okan
537fe7febb move Cursors into conf. 2013-06-17 17:11:10 +00:00
okan
8b4f5be847 now that we have conf_screen, which configures individual screens 
*after* config parsing, we no longer need to split up display/screen
initialization, so collapse.
 2013-06-17 14:08:51 +00:00
okan
a931e155f8 allow mouse button4 and button5; from Rodrigo Mosconi 2013-06-17 00:57:47 +00:00
okan
356be89e9f move synthetic responses and have client_msg only work with WM_PROTOCOLS, 
since that's all ClientMessageEvent is for anyway.
 2013-06-10 21:37:30 +00:00
okan
5daab9b270 Check for, and honour, CWStackMode and CWSibling change requests during a 
ConfigureRequest event.  Additionally, honour a border width change;
detailed report and patch from Mike Small.
 2013-06-10 20:11:43 +00:00
sthen
ca4996114f Unlike other parse.y variants, cwm's allowed 'command xx /path/to/xx' without 
quotes. Reinstate this support lost in recent sync diff and add a comment to
show that it's intentional. ok okan@
 2013-06-03 20:33:17 +00:00
okan
71bf0bfb16 fix type in a ClientMessage (xu_sendmsg). 2013-05-27 23:20:45 +00:00
okan
4c52391113 alter conf_grab(_kbd) to first ungrab AnyKey/AnyModifier, then proceed 
to grab keys in keybindingq.  we don't need to ungrab/grab on every
addition to the queue, just once with a complete keybindingq; simplify
grabbing keys per screen (during init) and during a MappingNotify.

while here, change conf_grab_{kbd,mouse} to require only a Window.
 2013-05-23 16:52:39 +00:00
okan
a6aa181292 since we don't have any screens yet, there's no reason to conf_{,un}grab 
here; just build keybindingq.
 2013-05-22 20:23:21 +00:00
okan
5496d2b0c6 get rid of long standing XXX: now that we configure screens based on 
config options, add the keybinding GrabKey calls here
 2013-05-22 16:54:09 +00:00
okan
82fdda20a0 move validation of pointer Button into conf_mousebind so we check 
validity during the parse phase and not bother adding it to the queue,
instead of each time a client needs to grab (when it's too late);
furthermore, make this a config error, stop parsing and load the
default config.
 2013-05-22 16:32:15 +00:00
okan
d121e367b1 sync with src changes 2013-05-22 13:02:14 +00:00
okan
d66a0bde40 handle _NET_WM_STATE ClientMessage; from Alexander Polakov. 2013-05-21 00:29:20 +00:00
okan
1e33cdcb18 stray whitespace 2013-05-20 21:32:00 +00:00
okan
d8afbe1a8b handle _NET_ACTIVE_WINDOW ClientMessage; from Alexander Polakov. 2013-05-20 21:19:15 +00:00
okan
0667dd4edd add support for _NET_WM_STATE_MAXIMIZED_{HORZ,VERT}; from Alexander Polakov. 
while I'm unsure of the final look of _NET_WM_STATE, there's no reason
to delay this support.
 2013-05-20 21:13:58 +00:00
okan
bd38e60d03 - configure menuwin with the screen, then create the xft drawable using 
the menu window since that's the only place on which we draw
- elminate the need to change the drawable on every font draw
 2013-05-20 20:21:04 +00:00
okan
85d547bcc5 no reason to pass around *sc when it's already in menu_ctx. 2013-05-20 20:04:36 +00:00
okan
ce73dfea93 move the 2 small font helper functions to xutil.c 2013-05-19 23:38:20 +00:00
okan
f3337f150c move the rest of xft init into screen_conf, since most of it is based on 
config parameters.
 2013-05-19 23:16:29 +00:00
okan
9baf72c106 - switch border colors to Xft 
- merge border/menu color structures/functions since they now both use Xft
- switch xu_xorcolor to operating on XftColor instead of just
  XRenderColor (basically adding pixel)
- if color name allocation fails, revert back to default (this, along
  with font validation should occur during config parse, but we don't
  have screens setup yet - likely to change at some point)
 2013-05-19 23:09:59 +00:00
okan
1f7de62e0c add support for _NET_CLOSE_WINDOW 2013-05-19 17:05:52 +00:00
okan
e8ab9bac94 treat WM_CHANGE_STATE like other atoms 2013-05-19 17:03:55 +00:00
okan
f67063c034 use XGetWMProtocols and simplify WM_PROTOCOL handling 2013-05-19 17:02:04 +00:00
okan
54d74a2ed2 simplify 2013-05-19 17:01:29 +00:00
okan
a6a2d45671 if -> ifdef 2013-05-14 13:39:53 +00:00
okan
7f75636e2f - let callers of font_draw figure out (and pass) the color instead of an 
'active' flag.
- use strlen() inside of font_draw; the only instance where it wasn't
  used happened to be ignored on a subsequent draw.
 2013-05-14 12:35:56 +00:00
okan
27a9825a40 swap x/y calculations in kbd move/resize to match those in the respective mouse functions 2013-05-11 22:03:17 +00:00
okan
7ab1469590 new -> init 2013-05-11 22:01:07 +00:00
okan
f00ab96178 replace conf_{gap,color,font} with conf_screen since really we are 
configuring the screen *after* parsing, just as we do a conf_client on
client manage.
 2013-05-11 21:46:27 +00:00
okan
dc5b3b52df more type fixes for mask/button 2013-05-10 16:32:47 +00:00
okan
6ab8a91ea8 spacing 2013-05-10 16:10:40 +00:00
okan
8044f37078 int type fixes 2013-05-10 16:05:34 +00:00
okan
f0fe071b5a fix KeySym type 2013-05-10 15:44:43 +00:00
okan
384bb6c501 border width/color makes sense for some, so put it back 2013-05-07 01:35:41 +00:00
okan
fb30b6ad26 negative values for borderwith, moveamount, snapdist and gap are 
configuration errors, so warn and load defaults.
 2013-05-06 19:09:19 +00:00
okan
52cbef8a12 remove group in client_delete directly. 2013-05-06 16:03:11 +00:00
okan
ed984685b1 border width/color makes no sense on menuwin 2013-05-06 16:00:34 +00:00
okan
72e88bc952 - no need to position and size the menu window before an Expose event 
since we'll be calculating required size later anyway; allows us to
  consolidate all prompt/display/search string building goop into
  menu_draw.
- reset the pos/size of menuwin when leaving a menu.
- reverse the 'prompt' NULL check to be consistent with 'initial' one
  and fix a whitespace nit while here.
 2013-05-02 20:18:35 +00:00
okan
c3f5c37243 zap leftover debug printf 2013-05-02 19:41:52 +00:00
okan
ed8f41814a get rid of cc->name in the resize box and make dimensions more readable. 2013-05-02 19:33:17 +00:00
okan
5e2856ce65 only redraw the name/size box when the client resizes, not every time 
there's movement; should slightly help with resize syncs.
 2013-05-02 19:30:10 +00:00
okan
f0a6447140 no need for font_{ascent,descent,height} wrappers; limit font_width to 
just requiring xftfont.
 2013-05-02 17:25:15 +00:00
okan
b0af7028d0 group conf_* init functions 2013-04-30 21:12:20 +00:00
okan
66a7b7fbf9 missing proto 2013-04-30 21:11:07 +00:00
okan
3b69bf465e type fix 2013-04-30 21:10:23 +00:00
okan
87e16df157 use an int in screen_init and avoid needing to cast for screen number (which). 2013-04-29 00:56:47 +00:00
okan
fe3f832f4b mechanical xu_{get,set}state -> xu_{get,set}_wm_state change 2013-04-17 13:57:06 +00:00
okan
62aed144f2 slightly rework WM_STATE set/get to make it less ambigious; will be more clear 
on what needs to change to make it right in the end.
 2013-04-17 13:52:20 +00:00
okan
fbc1e7edbd zap extra space 2013-04-17 13:31:47 +00:00
okan
373f1ddf90 add conf_ignore and move group_make_autogroup to conf_autogroup to match. 2013-04-17 13:30:38 +00:00
okan
726def3405 only a window is required to set WM_STATE. also un-confuse xu_ptr_getpos 
by using 'win' instead of 'rootwin' so as not to imply only the root
window is queried, rather any window.
 2013-04-14 16:13:17 +00:00
okan
461decc718 we handle WM_STATE here, so remove misleading comment. 2013-04-12 20:54:27 +00:00
okan
2dfe178aa9 we already set window state in client_hide or client_unhide right before, so 
there's no need to do it again.
 2013-04-12 20:45:57 +00:00
okan
5e28ed99db makes no sense to set an error handler which uses X_Dpy before XOpenDisplay. 2013-04-12 14:49:16 +00:00
okan
0b6abd364f push Screenq into screen_init 2013-04-12 14:46:30 +00:00
okan
a7e1ba7503 _NET_WM_NAME is UTF8_STRING type 2013-04-10 19:08:09 +00:00
okan
a1a6245df6 plug memleak; always need to menuq_clear even when a selection is made. 2013-04-08 15:43:04 +00:00
okan
4ad10add15 reverse logic to make it like the others 2013-04-08 13:05:27 +00:00
okan
a395df4a8f consistency 2013-04-08 13:02:31 +00:00
okan
29a51173bc missing prototype 2013-04-08 00:56:21 +00:00
okan
ec8c1c2f0f add missing proto; replace magic number 2013-04-05 17:36:02 +00:00
okan
13a11c8799 zap stray whitespace 2013-04-05 17:07:25 +00:00
okan
1eec28aa57 - no reason to breakout ClassHints work, so fold into client_{new,delete}, 
but keep _MOTIF_WM_HINTS separate.
- simplify fetching app/class hint.
- fix _MOTIF_WM_HINTS Atom type.
 2013-04-03 20:22:55 +00:00
okan
01d25075d0 honor PATH search order for exec; from Andres Perera. 2013-04-03 19:28:00 +00:00
okan
b0d374e0fb move XUngrabServer to the end of client_new() to avoid races where clients, 
such as those using sdl, attempt to manage the clients themselves when the
clients aren't fully ready.  other wm's grab the xserver during the whole
client setup process, so match.

behavior found by jsg.
 2013-04-03 19:20:50 +00:00
okan
118cf232b6 replace handrolled for loop with TAILQ_FOREACH; from andres.p@zoho.com 2013-03-09 21:55:56 +00:00
okan
a39c86a915 put back r1.68 which allows an empty group to be sticky; behavior 
change noticed by Thomas Pfaff and diagnosis why we need to
group_setactive in this case by Alexander Polakov.  replace XXX with
a useful comment.
 2013-01-13 13:55:12 +00:00
okan
01f04be317 set the initial group to '1', missed by recent off-by-one group 
numbering re-work; discovered the hard way by sthen@.

ok sthen@
 2013-01-10 15:28:11 +00:00
okan
a56cb7d9d2 add per-group vert/horiz tiling support; introduces 2 new bind commands, 
'vtile' and 'htile'; from Alexander Polakov.
 2013-01-08 15:16:04 +00:00
okan
62ff18b6d7 teach screen_find_xinerama() about gap and adjust (simplify) callers; 
menu becomes gap-aware for free.
 2013-01-08 04:12:51 +00:00
okan
1124cee92f fix menu/client placement in panning setups; XineramaQueryScreens gives 
us the width of the psuedo screen, but here we need the edge instead
(xmax/ymax); just re-use w/h here for now.
 2013-01-07 21:53:23 +00:00
okan
5c111b8c13 revert previous 2013-01-07 21:45:24 +00:00
okan
0fc885f41e unbreak xinerama support from r1.41 for panning setups 2013-01-07 20:32:19 +00:00
okan
968dc645ee use cc->bwidth in client_vmax since we've yet to reset it (matches 
client_hmax); from Jan Stary
 2013-01-06 01:01:26 +00:00
okan
65585e276f rename {h,v}max functions for consistency; from Jan Stary 2013-01-04 16:30:03 +00:00
okan
8ca4aa87e7 really these are just border colors, so adjust the define 2013-01-04 16:27:58 +00:00