Commit Graph

90 Commits

Author SHA1 Message Date
deraadt
ed32a4544c xenodm uses the libc authentication layer incorrectly.
fix by markus or millert
Reported by Qualys
2019-12-04 09:53:47 +00:00
matthieu
b9bedc770a Provide better xsession examples. exec the window manager last.
Convert user's example to /bin/sh. Remove xman for example.
2019-08-15 16:23:33 +00:00
matthieu
41003a131f check return values against -1 "reasonable" deraadt@ 2019-06-29 20:29:48 +00:00
espie
04c7986e14 add (commented out) blurb to get openbsd-wallpaper running.
"perso j'ai rien contre" ok matthieu@
2019-06-29 13:33:06 +00:00
matthieu
156c07dd53 Check asprintf() return values correctly. ok and tweaks tb@ 2019-06-29 08:31:22 +00:00
jsg
f8d726d75d chown the first drm render node in addition to the primary drm device
ok matthieu@
2019-05-12 11:53:06 +00:00
matthieu
3dc8e8dd7e Disable keyboard binding for abort-display() and update manual page.
while there remove a remaining reference to non-existent xdmshell(1).
Reported by Hiltjo Posthuma, ok solene@, bentley@
2019-04-16 05:51:04 +00:00
matthieu
b2e24c1d7c Remove the unused 'keyFile' resource.
It is not used anymore in xenodm (was used to specify the secret keys
for the XDM-AUTHORIZATION-1 authentication protocol in xdm with
xdmcp).
ok kn@
2018-11-03 18:04:45 +00:00
matthieu
b129529692 regen 2018-11-03 14:01:21 +00:00
matthieu
e0d21cc9e4 Remove useless check for XdmcpWrap().
It was only needed by xdmcp. ok tb@ mortimer@
2018-11-03 14:01:02 +00:00
matthieu
f9024c4d46 Pass the correct buffer length to strlcpy() to avoid truncation.
Problem noticed by Edgar Pettijohn III, ok tb@
2018-10-28 19:38:19 +00:00
matthieu
0523432214 This file is not generated by configure, @ substitutions arent available 2018-07-17 11:52:12 +00:00
matthieu
ebae2cc3f5 Remove useless test for DISPLAY number.
This script is only run by xenodm for DISPLAY=:0
2018-07-16 06:52:00 +00:00
matthieu
d39b1994a3 OpenBSD id 2018-07-15 09:58:03 +00:00
matthieu
d31532afbd Make Xstartup/Xreset consistent with GiveConsole/TakeConsole 2018-07-15 09:53:23 +00:00
matthieu
2a47fd34e2 regen 2018-07-15 09:07:48 +00:00
matthieu
10783d146c Revert the removal of Xreset and Xstartup. 2018-07-15 09:05:11 +00:00
matthieu
0aad528dd7 pledges for session can be tighten a bit now. 2018-07-11 20:28:41 +00:00
matthieu
15bc4073c0 The file descriptor parameter is not used by DefineSelf() in xenodm.
Zap it.
2018-07-11 19:51:12 +00:00
matthieu
4feeb26f77 sessreg -x is useless if not updating utmp. Remove it.
Also don't try to remove utmp lines that were not written.
2018-07-11 19:20:40 +00:00
matthieu
ec07007116 Ooops I didn't intend to commit that part. revert it. 2018-07-11 19:06:29 +00:00
matthieu
b3e8c00865 Actually remove the source files for Xstartup and Xreset 2018-07-11 19:05:22 +00:00
matthieu
35981369b1 Remove Xstartup and Xreset script. Xenodm uses GiveConsole and TakeConsole 2018-07-11 19:03:50 +00:00
matthieu
5d69c81cc1 Keep a better trace of pending children to be reaped. 2018-07-11 16:57:04 +00:00
matthieu
c3094ef041 Delete unused code 2018-07-11 16:33:44 +00:00
matthieu
6d7357f962 Bind <Key>Escape to erase-line by default. 2018-07-11 16:28:54 +00:00
matthieu
c8c914a77e Less ifdef cruft. 2018-07-11 16:26:25 +00:00
matthieu
bf265b5bbc use strvis on login name when logging debug information it since it
may contain control characters. And remove an extra logging of the same.
2018-07-11 16:20:20 +00:00
matthieu
8f540c071b Restore previous SIGCHLD handler in serverPause().
This fixes the issue where xenodm whould stay stuck after kill the
Xserver twice.

While here add some more Debug() calls to help following what's going on
2018-07-11 14:35:46 +00:00
matthieu
2c8cd3e507 Also revert this one, doesn't look right either. 2018-07-10 15:52:52 +00:00
matthieu
a8c7a38ea4 Revert some of the strlcpy() conversions which are wrong. 2018-07-10 15:32:27 +00:00
matthieu
8b4158c82d Remove more unused ifdefs blocks 2018-07-10 14:58:57 +00:00
matthieu
91c82fae6b Remove useless ifdefs 2018-07-10 14:50:21 +00:00
matthieu
a08190694c Get rid of strcpy and strncpy (they were all looking safe though) 2018-07-10 14:44:34 +00:00
matthieu
1b4f7ecea8 Consistant use of bool whenever possible. 2018-07-10 14:20:42 +00:00
matthieu
8e35b035af Remove unused code. 2018-07-10 13:57:31 +00:00
matthieu
72e68d3bca Remove the unused localHostname() function. 2018-07-10 13:15:50 +00:00
matthieu
53d0e5e23b Remove prototype for function that doesn't exist anymore in xenodom. 2018-07-09 16:52:19 +00:00
matthieu
e5b6c5a29f Source the Xsetup script before initializing the greeter widget.
Based on a request by weerd@, tested by jca@ and weerd@
2018-07-09 15:02:41 +00:00
matthieu
022476f90f static variable shadowing found by clang 2018-05-06 15:26:15 +00:00
matthieu
537654d79d Unused variables found by clang 2018-05-06 15:25:27 +00:00
matthieu
fc7d5d1825 Add missing brackets to multi-statement if in SaveServerAuthorizations
From Alan Coopersmith in xdm.
2018-05-06 15:18:42 +00:00
matthieu
e172c9b2ce xdm -> xenodm in log and error messages 2017-11-12 17:10:12 +00:00
matthieu
08a235a628 chown before chmod
This prevents a malicious user logging out from calling
chmod while still owning /dev/console and thus by-passing
the '622' mode that is set here.

Issue reported by Tim Chase. Thanks.


Merged from xdm upstreams
2017-10-04 18:28:59 +00:00
deraadt
5150e677a9 backout hard-coded behaviour change which was not discussed, in
particular no justification for why the current behaviour is wrong
2017-09-05 17:48:07 +00:00
dcoppa
44401622e1 amend comment 2017-08-30 07:59:00 +00:00
dcoppa
7055fe14e7 Use 'unix:0' for the DISPLAY environment variable
ok matthieu@
2017-08-30 07:48:56 +00:00
matthieu
1711398f5e Missing dot breaks semantic markup. from Klemens Nanni. Thanks. 2017-08-22 06:54:08 +00:00
matthieu
e1e9d732f3 Stop abusing cpp as generic macro processor in the build system.
ok naddy@
2017-07-26 21:14:54 +00:00
matthieu
7c70a5feaf regen 2017-07-26 10:05:19 +00:00