Bugfixes from upstream.

Minor tweaks (shutdown(2) related bits) by me.

OK matthieu@
This commit is contained in:
dcoppa 2010-10-06 07:50:06 +00:00
parent be028fef81
commit 964be84ed2
4 changed files with 17 additions and 5 deletions

View File

@ -26,6 +26,8 @@
/* Connection management: the core of XCB. */
#include <assert.h>
#include <sys/types.h>
#include <sys/socket.h>
#include <string.h>
#include <stdio.h>
#include <unistd.h>
@ -48,7 +50,7 @@ typedef struct {
uint16_t length;
} xcb_setup_generic_t;
static const int error_connection = 1;
const int error_connection = 1;
static int set_fd_flags(const int fd)
{
@ -243,10 +245,13 @@ xcb_connection_t *xcb_connect_to_fd(int fd, xcb_auth_info_t *auth_info)
void xcb_disconnect(xcb_connection_t *c)
{
if(c->has_error)
if(c == (xcb_connection_t *) &error_connection)
return;
free(c->setup);
/* disallow further sends and receives */
shutdown(c->fd, SHUT_RDWR);
close(c->fd);
pthread_mutex_destroy(&c->iolock);
@ -311,6 +316,13 @@ int _xcb_conn_wait(xcb_connection_t *c, pthread_cond_t *cond, struct iovec **vec
do {
#if USE_POLL
ret = poll(&fd, 1, -1);
/* If poll() returns an event we didn't expect, such as POLLNVAL, treat
* it as if it failed. */
if(ret >= 0 && (fd.revents & ~fd.events))
{
ret = -1;
break;
}
#else
ret = select(c->fd + 1, &rfds, &wfds, 0, 0);
#endif

View File

@ -564,7 +564,7 @@ xcb_generic_error_t *xcb_request_check(xcb_connection_t *c, xcb_void_cookie_t co
void *reply;
if(c->has_error)
return 0;
if(XCB_SEQUENCE_COMPARE_32(cookie.sequence,>,c->in.request_expected)
if(XCB_SEQUENCE_COMPARE_32(cookie.sequence,>=,c->in.request_expected)
&& XCB_SEQUENCE_COMPARE_32(cookie.sequence,>,c->in.request_completed))
{
free(xcb_get_input_focus_reply(c, xcb_get_input_focus(c), &ret));

View File

@ -49,8 +49,6 @@
#include "xcbext.h"
#include "xcbint.h"
static const int error_connection = 1;
int xcb_popcount(uint32_t mask)
{
uint32_t y;

View File

@ -174,6 +174,8 @@ void _xcb_ext_destroy(xcb_connection_t *c);
/* xcb_conn.c */
extern const int error_connection;
struct xcb_connection_t {
int has_error;