From 66a2bc1f37d13a6eb8aa31b5619d2d8bdb4b8308 Mon Sep 17 00:00:00 2001 From: okan Date: Tue, 25 Aug 2015 18:29:10 +0000 Subject: [PATCH] Split out sticky mode checks and the restoring of a client's group and _NET_WM_DESKTOP from the config-based auto-grouping; no (intentional) behavior changes. Needed for further work in cleaning up this area. --- app/cwm/calmwm.h | 6 ++-- app/cwm/client.c | 16 +++++++--- app/cwm/group.c | 77 ++++++++++++++++++++++++++++-------------------- 3 files changed, 61 insertions(+), 38 deletions(-) diff --git a/app/cwm/calmwm.h b/app/cwm/calmwm.h index 35bf72de2..4f6b2602d 100644 --- a/app/cwm/calmwm.h +++ b/app/cwm/calmwm.h @@ -15,7 +15,7 @@ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. * - * $OpenBSD: calmwm.h,v 1.302 2015/08/24 15:42:57 okan Exp $ + * $OpenBSD: calmwm.h,v 1.303 2015/08/25 18:29:10 okan Exp $ */ #ifndef _CALMWM_H_ @@ -426,7 +426,8 @@ void client_warp(struct client_ctx *); void client_wm_hints(struct client_ctx *); void group_alltoggle(struct screen_ctx *); -void group_autogroup(struct client_ctx *); +void group_assign(struct group_ctx *, struct client_ctx *); +int group_autogroup(struct client_ctx *); void group_cycle(struct screen_ctx *, int); void group_hide(struct group_ctx *); void group_hidetoggle(struct screen_ctx *, int); @@ -435,6 +436,7 @@ int group_holds_only_sticky(struct group_ctx *); void group_init(struct screen_ctx *, int); void group_movetogroup(struct client_ctx *, int); void group_only(struct screen_ctx *, int); +int group_restore(struct client_ctx *); void group_show(struct group_ctx *); void group_toggle_membership_enter(struct client_ctx *); void group_toggle_membership_leave(struct client_ctx *); diff --git a/app/cwm/client.c b/app/cwm/client.c index cf23cdaaf..b057e7e54 100644 --- a/app/cwm/client.c +++ b/app/cwm/client.c @@ -15,7 +15,7 @@ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. * - * $OpenBSD: client.c,v 1.205 2015/08/24 15:42:57 okan Exp $ + * $OpenBSD: client.c,v 1.206 2015/08/25 18:29:10 okan Exp $ */ #include @@ -120,9 +120,17 @@ client_init(Window win, struct screen_ctx *sc) else client_unhide(cc); - if (mapped) - group_autogroup(cc); - + if (mapped) { + if (group_restore(cc)) + goto out; + if (group_autogroup(cc)) + goto out; + if (Conf.flags & CONF_STICKY_GROUPS) + group_assign(sc->group_active, cc); + else + group_assign(NULL, cc); + } +out: XSync(X_Dpy, False); XUngrabServer(X_Dpy); diff --git a/app/cwm/group.c b/app/cwm/group.c index 3532c8a67..593a0d6c9 100644 --- a/app/cwm/group.c +++ b/app/cwm/group.c @@ -16,7 +16,7 @@ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. * - * $OpenBSD: group.c,v 1.114 2015/08/23 17:31:20 okan Exp $ + * $OpenBSD: group.c,v 1.115 2015/08/25 18:29:10 okan Exp $ */ #include @@ -34,7 +34,6 @@ static struct group_ctx *group_next(struct group_ctx *); static struct group_ctx *group_prev(struct group_ctx *); -static void group_assign(struct group_ctx *, struct client_ctx *); static void group_restack(struct group_ctx *); static void group_setactive(struct group_ctx *); @@ -43,7 +42,7 @@ const char *num_to_name[] = { "seven", "eight", "nine" }; -static void +void group_assign(struct group_ctx *gc, struct client_ctx *cc) { if (cc->group != NULL) @@ -324,51 +323,65 @@ group_alltoggle(struct screen_ctx *sc) sc->hideall = !sc->hideall; } -void +int +group_restore(struct client_ctx *cc) +{ + struct screen_ctx *sc = cc->sc; + struct group_ctx *gc; + int num = -1; + long *grpnum; + + if (xu_getprop(cc->win, ewmh[_NET_WM_DESKTOP], XA_CARDINAL, 1L, + (unsigned char **)&grpnum) <= 0) + return(0); + + num = MIN(*grpnum, (CALMWM_NGROUPS - 1)); + XFree(grpnum); + + if ((num == -1) || (num == 0)) { + group_assign(NULL, cc); + return(1); + } + TAILQ_FOREACH(gc, &sc->groupq, entry) { + if (gc->num == num) { + group_assign(gc, cc); + return(1); + } + } + return(0); +} + +int group_autogroup(struct client_ctx *cc) { struct screen_ctx *sc = cc->sc; struct autogroupwin *aw; struct group_ctx *gc; - int num = -2, both_match = 0; - long *grpnum; + int num = -1, both_match = 0; if (cc->ch.res_class == NULL || cc->ch.res_name == NULL) - return; + return(0); - if (xu_getprop(cc->win, ewmh[_NET_WM_DESKTOP], - XA_CARDINAL, 1, (unsigned char **)&grpnum) > 0) { - num = *grpnum; - if (num > CALMWM_NGROUPS || num < -1) - num = CALMWM_NGROUPS - 1; - XFree(grpnum); - } else { - TAILQ_FOREACH(aw, &Conf.autogroupq, entry) { - if (strcmp(aw->class, cc->ch.res_class) == 0) { - if ((aw->name != NULL) && - (strcmp(aw->name, cc->ch.res_name) == 0)) { - num = aw->num; - both_match = 1; - } else if (aw->name == NULL && !both_match) - num = aw->num; - } + TAILQ_FOREACH(aw, &Conf.autogroupq, entry) { + if (strcmp(aw->class, cc->ch.res_class) == 0) { + if ((aw->name != NULL) && + (strcmp(aw->name, cc->ch.res_name) == 0)) { + num = aw->num; + both_match = 1; + } else if (aw->name == NULL && !both_match) + num = aw->num; } } - if ((num == -1) || (num == 0)) { + if (num == 0) { group_assign(NULL, cc); - return; + return(1); } - TAILQ_FOREACH(gc, &sc->groupq, entry) { if (gc->num == num) { group_assign(gc, cc); - return; + return(1); } } - - if (Conf.flags & CONF_STICKY_GROUPS) - group_assign(sc->group_active, cc); - else - group_assign(NULL, cc); + return(0); }