qbit/xenocara
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

greet->password is wiped after handling it to auth_setdata().

Browse Source 
No need to wipe again it later.
This commit is contained in:
matthieu 2016-10-23 11:30:03 +00:00
parent 186b6af863
commit 1dfe3ca042
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/xenodm/greeter/verify.c
View File

@ -139,7 +139,6 @@ Verify (struct display *d, struct greet_info *greet, struct verify_info *verify)
if ((authok & AUTH_ALLOW) == 0) {
Debug("password verify failed\n");
bzero(greet->password, passwd_len);
auth_close(as);
login_close(lc);
return 0;
@ -147,7 +146,6 @@ Verify (struct display *d, struct greet_info *greet, struct verify_info *verify)
/* Run the approval script */
if (!auth_approval(as, lc, greet->name, "auth-xdm")) {
Debug("login not approved\n");
bzero(greet->password, passwd_len);
auth_close(as);
login_close(lc);
return 0;
@ -162,7 +160,6 @@ Verify (struct display *d, struct greet_info *greet, struct verify_info *verify)
/* Only accept root logins if allowRootLogin resource is set */
if (p->pw_uid == 0 && !greet->allow_root_login) {
Debug("root logins not allowed\n");
bzero(greet->password, passwd_len);
return 0;
}
@ -175,7 +172,6 @@ Verify (struct display *d, struct greet_info *greet, struct verify_info *verify)
/* did not found the shell in /etc/shells
-> failure */
Debug("shell not in /etc/shells\n");
bzero(greet->password, passwd_len);
endusershell();
return 0;
}