qbit/xenocara
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't compare a pointer to a null character constant but to NULL.

Browse Source 
With best regards from clang 10.
This commit is contained in:
mglocker 2020-08-05 11:34:00 +00:00
parent 4fa22cfd66
commit 044da0a592
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/video/video.c
View File

@ -1,4 +1,4 @@
/* $OpenBSD: video.c,v 1.32 2020/08/05 10:49:47 mglocker Exp $ */ /* $OpenBSD: video.c,v 1.33 2020/08/05 11:34:00 mglocker Exp $ */
/* /*
* Copyright (c) 2010 Jacob Meuser <jakemsr@openbsd.org> * Copyright (c) 2010 Jacob Meuser <jakemsr@openbsd.org>
* *
@ -1340,21 +1340,21 @@ parse_size(struct video *vid)
dimp++; dimp++;
} }
if (dimx > 0) { if (dimx > 0) {
if (dims[0] != '\0') { if (dims[0] != NULL) {
vid->width = strtonum(dims[0], 0, 4096, &errstr); vid->width = strtonum(dims[0], 0, 4096, &errstr);
if (errstr != NULL) { if (errstr != NULL) {
warnx("width '%s' is %s", dims[0], errstr); warnx("width '%s' is %s", dims[0], errstr);
return 0; return 0;
} }
} }
if (dims[1] != '\0') { if (dims[1] != NULL) {
vid->height = strtonum(dims[1], 0, 4096, &errstr); vid->height = strtonum(dims[1], 0, 4096, &errstr);
if (errstr != NULL) { if (errstr != NULL) {
warnx("height '%s' is %s", dims[1], errstr); warnx("height '%s' is %s", dims[1], errstr);
return 0; return 0;
} }
} }
} else if (dims[0] != '\0') { } else if (dims[0] != NULL) {
vid->height = strtonum(dims[0], 0, 4096, &errstr); vid->height = strtonum(dims[0], 0, 4096, &errstr);
if (errstr != NULL) { if (errstr != NULL) {
warnx("height '%s' is %s", dims[0], errstr); warnx("height '%s' is %s", dims[0], errstr);