e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
61 lines
1.2 KiB
Nix
61 lines
1.2 KiB
Nix
{
|
|
lib,
|
|
stdenv,
|
|
fetchzip,
|
|
perl,
|
|
}:
|
|
|
|
stdenv.mkDerivation (finalAttrs: {
|
|
pname = "convmv";
|
|
version = "2.05";
|
|
|
|
outputs = [
|
|
"out"
|
|
"man"
|
|
];
|
|
|
|
src = fetchzip {
|
|
url = "https://www.j3e.de/linux/convmv/convmv-${finalAttrs.version}.tar.gz";
|
|
hash = "sha256-ts9xAPRGUoS0XBRTmpb+BlGW1hmGyUs+rQLyUEgiZ54=";
|
|
};
|
|
|
|
strictDeps = true;
|
|
|
|
nativeBuildInputs = [ perl ];
|
|
|
|
buildInputs = [ perl ];
|
|
|
|
makeFlags = [
|
|
"PREFIX=${placeholder "out"}"
|
|
"MANDIR=${placeholder "man"}/share/man"
|
|
];
|
|
|
|
checkTarget = "test";
|
|
|
|
# testsuite.tar contains filenames that aren't valid UTF-8. Extraction of
|
|
# testsuite.tar will fail as APFS enforces that filenames are valid UTF-8.
|
|
doCheck = !stdenv.hostPlatform.isDarwin;
|
|
|
|
prePatch =
|
|
lib.optionalString finalAttrs.doCheck ''
|
|
tar -xf testsuite.tar
|
|
''
|
|
+ ''
|
|
patchShebangs --host .
|
|
'';
|
|
|
|
dontPatchShebangs = true;
|
|
|
|
meta = with lib; {
|
|
description = "Converts filenames from one encoding to another";
|
|
downloadPage = "https://www.j3e.de/linux/convmv/";
|
|
license = with licenses; [
|
|
gpl2Only
|
|
gpl3Only
|
|
];
|
|
maintainers = with maintainers; [ al3xtjames ];
|
|
mainProgram = "convmv";
|
|
platforms = platforms.unix;
|
|
};
|
|
})
|