From 7239af0a727d4da0fdcb141d1532c4528a605ce7 Mon Sep 17 00:00:00 2001
From: Maximilian Bosch <maximilian@mbosch.me>
Date: Sat, 16 Nov 2024 18:54:24 +0100
Subject: [PATCH] postgresql.pkgs.pg_embedding: remove

As discussed in #351306, this is scheduled for removal after 24.11
branchoff.
---
 pkgs/servers/sql/postgresql/ext/default.nix   |  8 ++++---
 .../sql/postgresql/ext/pg_embedding.nix       | 22 -------------------
 2 files changed, 5 insertions(+), 25 deletions(-)
 delete mode 100644 pkgs/servers/sql/postgresql/ext/pg_embedding.nix

diff --git a/pkgs/servers/sql/postgresql/ext/default.nix b/pkgs/servers/sql/postgresql/ext/default.nix
index 0a0a41aeb128..306d0dfc4f92 100644
--- a/pkgs/servers/sql/postgresql/ext/default.nix
+++ b/pkgs/servers/sql/postgresql/ext/default.nix
@@ -1,4 +1,6 @@
-self: super: {
+self: super: let
+  inherit (self) lib config;
+in {
 
     age = super.callPackage ./age.nix { };
 
@@ -26,8 +28,6 @@ self: super: {
 
     pg_ed25519 = super.callPackage ./pg_ed25519.nix { };
 
-    pg_embedding = super.callPackage ./pg_embedding.nix { };
-
     pg_hint_plan = super.callPackage ./pg_hint_plan.nix { };
 
     pg_ivm = super.callPackage ./pg_ivm.nix { };
@@ -110,4 +110,6 @@ self: super: {
     tsja = super.callPackage ./tsja.nix { };
 
     wal2json = super.callPackage ./wal2json.nix { };
+} // lib.optionalAttrs config.allowAliases {
+  pg_embedding = throw "PostgreSQL extension `pg_embedding` has been removed since the project has been abandoned. Upstream's recommendation is to use pgvector instead (https://neon.tech/docs/extensions/pg_embedding#migrate-from-pg_embedding-to-pgvector)";
 }
diff --git a/pkgs/servers/sql/postgresql/ext/pg_embedding.nix b/pkgs/servers/sql/postgresql/ext/pg_embedding.nix
deleted file mode 100644
index e79cef2f29af..000000000000
--- a/pkgs/servers/sql/postgresql/ext/pg_embedding.nix
+++ /dev/null
@@ -1,22 +0,0 @@
-{ lib, stdenv, fetchFromGitHub, postgresql, buildPostgresqlExtension }:
-
-buildPostgresqlExtension rec {
-  pname = "pg_embedding";
-  version = "0.3.6";
-
-  src = fetchFromGitHub {
-    owner = "neondatabase";
-    repo = pname;
-    rev = version;
-    hash = "sha256-NTBxsQB8mR7e/CWwkCEyDiYhi3Nxl/aKgRBwqc0THcI=";
-  };
-
-  meta = with lib; {
-    description = "PostgreSQL extension implementing the HNSW algorithm for vector similarity search";
-    homepage = "https://github.com/neondatabase/pg_embedding";
-    maintainers = with maintainers; [ ];
-    platforms = postgresql.meta.platforms;
-    license = licenses.asl20;
-    knownVulnerabilities = [ "As of Sept 29, 2023, the authors have abandoned the project and strongly encourage using pgvector, which is faster, has more functionality, and is actively maintained: check out the author's instructions to migrate at https://neon.tech/docs/extensions/pg_embedding#migrate-from-pg_embedding-to-pgvector" ];
-  };
-}