qbit/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci/request-reviews: Avoid duplicates with different casings

Browse Source 
It's possible to have different casings in OWNERS, so we need to handle
that
This commit is contained in:
Silvan Mosberger 2024-10-12 05:27:01 +02:00
parent d4c28e77c3
commit e612b89953
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ci/request-reviews/get-reviewers.sh
View File

@ -35,6 +35,7 @@ log "This PR touches ${#touchedFiles[@]} files"
git -C "$gitRepo" show "$baseRef":"$ownersFile" > "$tmp"/codeowners git -C "$gitRepo" show "$baseRef":"$ownersFile" > "$tmp"/codeowners
# Associative array with the user as the key for easy de-duplication # Associative array with the user as the key for easy de-duplication
# Make sure to always lowercase keys to avoid duplicates with different casings
declare -A users=() declare -A users=()
for file in "${touchedFiles[@]}"; do for file in "${touchedFiles[@]}"; do
@ -87,20 +88,20 @@ for file in "${touchedFiles[@]}"; do
log "Team $entry has these members: ${members[*]}" log "Team $entry has these members: ${members[*]}"
for user in "${members[@]}"; do for user in "${members[@]}"; do
users[$user]= users[${user,,}]=
done done
else else
# Everything else is a user # Everything else is a user
users[$entry]= users[${entry,,}]=
fi fi
done done
done done
# Cannot request a review from the author # Cannot request a review from the author
if [[ -v users[$prAuthor] ]]; then if [[ -v users[${prAuthor,,}] ]]; then
log "One or more files are owned by the PR author, ignoring" log "One or more files are owned by the PR author, ignoring"
unset 'users[$prAuthor]' unset 'users[${prAuthor,,}]'
fi fi
gh api \ gh api \
@ -111,9 +112,9 @@ gh api \
# And we don't want to rerequest reviews from people who already reviewed # And we don't want to rerequest reviews from people who already reviewed
while read -r user; do while read -r user; do
if [[ -v users[$user] ]]; then if [[ -v users[${user,,}] ]]; then
log "User $user is a code owner but has already left a review, ignoring" log "User $user is a code owner but has already left a review, ignoring"
unset 'users[$user]' unset 'users[${user,,}]'
fi fi
done < "$tmp/already-reviewed-by" done < "$tmp/already-reviewed-by"