From 34395aeb9f0e88c44443c7d5040b23d73d6ef871 Mon Sep 17 00:00:00 2001 From: Gaetan Lepage Date: Mon, 21 Oct 2024 11:50:55 +0200 Subject: [PATCH] python312Packages.torch-geometric: skip failing test on darwin --- .../torch-geometric/default.nix | 33 +++++++++++-------- 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/pkgs/development/python-modules/torch-geometric/default.nix b/pkgs/development/python-modules/torch-geometric/default.nix index ed3bbdc73569..80286ff1a950 100644 --- a/pkgs/development/python-modules/torch-geometric/default.nix +++ b/pkgs/development/python-modules/torch-geometric/default.nix @@ -1,5 +1,6 @@ { lib, + stdenv, buildPythonPackage, fetchFromGitHub, @@ -153,21 +154,27 @@ buildPythonPackage rec { export HOME=$(mktemp -d) ''; - disabledTests = [ - # TODO: try to re-enable when triton will have been updated to 3.0 - # torch._dynamo.exc.BackendCompilerFailed: backend='inductor' raised: - # LoweringException: ImportError: cannot import name 'triton_key' from 'triton.compiler.compiler' - "test_compile_hetero_conv_graph_breaks" - "test_compile_multi_aggr_sage_conv" + disabledTests = + [ + # TODO: try to re-enable when triton will have been updated to 3.0 + # torch._dynamo.exc.BackendCompilerFailed: backend='inductor' raised: + # LoweringException: ImportError: cannot import name 'triton_key' from 'triton.compiler.compiler' + "test_compile_hetero_conv_graph_breaks" + "test_compile_multi_aggr_sage_conv" - # RuntimeError: addmm: computation on CPU is not implemented for SparseCsr + SparseCsr @ SparseCsr without MKL. - # PyTorch built with MKL has better support for addmm with sparse CPU tensors. - "test_asap" - "test_graph_unet" + # RuntimeError: addmm: computation on CPU is not implemented for SparseCsr + SparseCsr @ SparseCsr without MKL. + # PyTorch built with MKL has better support for addmm with sparse CPU tensors. + "test_asap" + "test_graph_unet" - # AttributeError: type object 'Any' has no attribute '_name' - "test_type_repr" - ]; + # AttributeError: type object 'Any' has no attribute '_name' + "test_type_repr" + ] + ++ lib.optionals stdenv.hostPlatform.isDarwin [ + # This test uses `torch.jit` which might not be working on darwin: + # RuntimeError: required keyword attribute 'value' has the wrong type + "test_traceable_my_conv_with_self_loops" + ]; meta = { description = "Graph Neural Network Library for PyTorch";