From 2a13d67dcc622a92385f731d701c81cb4169e370 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Forsman?= Date: Wed, 2 Oct 2024 20:40:19 +0200 Subject: [PATCH] nixosTests.scrutiny: remove explicit wait for influxdb2 Explicitly waiting for influxdb2 in the test, instead of fixing the underlying issue[1], was hiding a real bug[2]. Now that the bug has been fixed we can remove the wait code. [1] Commit 732d36522f4426e3f7e839e2694d28bbaead3f72 ("nixos/influxdb2: wait until service is ready") [2] https://github.com/NixOS/nixpkgs/issues/317017 ("Scrutiny tries to start before influxdb has started") --- nixos/tests/scrutiny.nix | 4 ---- 1 file changed, 4 deletions(-) diff --git a/nixos/tests/scrutiny.nix b/nixos/tests/scrutiny.nix index 33160a6b3088..4ac1b47952e0 100644 --- a/nixos/tests/scrutiny.nix +++ b/nixos/tests/scrutiny.nix @@ -49,10 +49,6 @@ import ./make-test-python.nix ({ lib, ... }: testScript = '' start_all() - # Wait for InfluxDB to be available - machine.wait_for_unit("influxdb2") - machine.wait_for_open_port(8086) - # Wait for Scrutiny to be available machine.wait_for_unit("scrutiny") machine.wait_for_open_port(8080)