libconfig: Adopting package and refactor (#351618)

pkgs/by-name/li/libconfig/package.nix

@@ -0,0 +1,34 @@
+{
+  lib,
+  stdenv,
+  fetchurl,
+  # This also disables building tests.
+  # on static windows cross-compile they fail to build
+  doCheck ? with stdenv.hostPlatform; !(isWindows && isStatic),
+}:
+
+stdenv.mkDerivation (finalAttrs: {
+  pname = "libconfig";
+  version = "1.7.3";
+
+  src = fetchurl {
+    url = "https://hyperrealm.github.io/${finalAttrs.pname}/dist/${finalAttrs.pname}-${finalAttrs.version}.tar.gz";
+    hash = "sha256-VFFm1srAN3RDgdHpzFpUBQlOe/rRakEWmbz/QLuzHuc=";
+  };
+
+  inherit doCheck;
+
+  configureFlags =
+    lib.optional (stdenv.hostPlatform.isWindows || stdenv.hostPlatform.isStatic) "--disable-examples"
+    ++ lib.optional (!finalAttrs.doCheck) "--disable-tests";
+
+  cmakeFlags = lib.optionals (!finalAttrs.doCheck) [ "-DBUILD_TESTS:BOOL=OFF" ];
+
+  meta = {
+    homepage = "https://hyperrealm.github.io/libconfig/";
+    description = "C/C++ library for processing configuration files";
+    license = lib.licenses.lgpl3;
+    maintainers = with lib.maintainers; [ stv0g ];
+    platforms = lib.platforms.all;
+  };
+})

pkgs/development/libraries/libconfig/default.nix

@@ -1,32 +0,0 @@
-{ lib
-, stdenv
-, fetchurl
-, # this also disables building tests.
-  # on static windows cross-compile they fail to build
-  doCheck ? with stdenv.hostPlatform; !(isWindows && isStatic)
-}:
-
-stdenv.mkDerivation rec {
-  pname = "libconfig";
-  version = "1.7.3";
-
-  src = fetchurl {
-    url = "https://hyperrealm.github.io/${pname}/dist/${pname}-${version}.tar.gz";
-    sha256 = "sha256-VFFm1srAN3RDgdHpzFpUBQlOe/rRakEWmbz/QLuzHuc=";
-  };
-
-  inherit doCheck;
-
-  configureFlags = lib.optional (stdenv.hostPlatform.isWindows || stdenv.hostPlatform.isStatic) "--disable-examples"
-    ++ lib.optional (!doCheck) "--disable-tests";
-
-  cmakeFlags = lib.optionals (!doCheck) [ "-DBUILD_TESTS:BOOL=OFF" ];
-
-  meta = with lib; {
-    homepage = "http://www.hyperrealm.com/libconfig";
-    description = "Simple library for processing structured configuration files";
-    license = licenses.lgpl3;
-    maintainers = [ ];
-    platforms = platforms.all;
-  };
-}

pkgs/top-level/all-packages.nix

@@ -9570,8 +9570,6 @@ with pkgs;
 
   libcork = callPackage ../development/libraries/libcork { };
 
-  libconfig = callPackage ../development/libraries/libconfig { };
-
   libcmis = callPackage ../development/libraries/libcmis { };
 
   libee = callPackage ../development/libraries/libee { };