Muir Manders fe7c687bb5 internal/lsp: don't lower score of builtin completions ... Downranking builtins causes weird interplay with other completion candidates due to fuzzy matching. For example: notNil := 123 var foo *int = nil<> ranks "notNil" before "nil" in the builtin list, which is counter productive. Change it to not downrank builtins. In my testing with this change, builtins never were ranked above lexical items with similar names. I think this is because the "natural" order of completion items puts builtins last, and we stable sort items by score, so their relative order is preserved. Change-Id: Ifbad02be205e3cb26c1d4ce500b77690e7ac5b04 Reviewed-on: https://go-review.googlesource.com/c/tools/+/193897 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>		2019-09-06 20:37:48 +00:00
..
analysis.go	go/analysis: handle common nil pointers	2019-08-24 21:01:00 +00:00
completion_format.go	internal/lsp: switch to using protocol positions for document symbols	2019-09-06 18:11:17 +00:00
completion_snippet.go	internal/lsp: provide deep completion candidates	2019-06-27 18:58:03 +00:00
completion.go	internal/lsp: don't lower score of builtin completions	2019-09-06 20:37:48 +00:00
deep_completion.go	internal/lsp: limit deep completion search scope	2019-08-27 20:50:25 +00:00
diagnostics_test.go	internal/span: change URI.Filename so it just returns the filename	2019-06-10 21:39:43 +00:00
diagnostics.go	internal/lsp: abstract the diff library so it can be substituted	2019-08-20 03:37:07 +00:00
enums.go	internal/lsp: switch to using protocol positions for document symbols	2019-09-06 18:11:17 +00:00
folding_range.go	internal/lsp: switch folding range to protocol ranges	2019-09-06 18:26:38 +00:00
format.go	internal/lsp: change to protocol.TextEdit for formatting	2019-09-06 17:54:09 +00:00
highlight.go	internal/lsp: switch to using protocol positions for document symbols	2019-09-06 18:11:17 +00:00
hover.go	internal/lsp: use protocol.Ranges for source.Identifier	2019-08-29 05:14:58 +00:00
identifier.go	internal/lsp: switch to using protocol positions for document symbols	2019-09-06 18:11:17 +00:00
imports_test.go	internal/lsp: abstract the diff library so it can be substituted	2019-08-20 03:37:07 +00:00
imports.go	internal/lsp: abstract the diff library so it can be substituted	2019-08-20 03:37:07 +00:00
options.go	internal/lsp: move configuration options to structs	2019-09-06 17:30:54 +00:00
references.go	internal/lsp: fix declarations in references	2019-09-05 03:51:44 +00:00
rename_check.go	internal/lsp: use memoize package to cache source.Packages	2019-08-13 21:41:43 +00:00
rename.go	internal/lsp: use protocol.Position for textDocument/prepareRename	2019-09-06 18:55:03 +00:00
signature_help.go	internal/lsp: switch to using protocol positions for document symbols	2019-09-06 18:11:17 +00:00
source_test.go	internal/lsp: use protocol.Position for textDocument/prepareRename	2019-09-06 18:55:03 +00:00
suggested_fix.go	internal/lsp: abstract the diff library so it can be substituted	2019-08-20 03:37:07 +00:00
symbols.go	internal/lsp: switch to using protocol positions for document symbols	2019-09-06 18:11:17 +00:00
util.go	internal/lsp: switch to using protocol positions for document symbols	2019-09-06 18:11:17 +00:00
view.go	internal/lsp: move configuration options to structs	2019-09-06 17:30:54 +00:00