mirror of
https://github.com/golang/go
synced 2024-11-15 03:20:31 -07:00
f2b1cde544
CL 395854 made inline pass to not inlining function with shape params, but pass no shape arguments. This is intended to be the reverse case of CL 361260. However, CL 361260 is using wider condition than necessary. Though it only needs to check against function parameters, it checks whether the function type has no shape. It does not cause any issue, because !fn.Type().HasShape() implies !fn.Type().Params().HasShape(). But for the reverse case, it's not true. Function may have shape type, but has no shape arguments. Thus, we must tighten the condition to explicitly check against the function parameters only. Fixes #52907 Change-Id: Ib87e87ff767c31d99d5b36aa4a6c1d8baf32746d Reviewed-on: https://go-review.googlesource.com/c/go/+/406475 Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
27 lines
396 B
Go
27 lines
396 B
Go
// compile
|
|
|
|
// Copyright 2022 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
func f[T int](t T) {
|
|
for true {
|
|
func() {
|
|
t = func() T { return t }()
|
|
}()
|
|
}
|
|
}
|
|
|
|
func g[T int](g T) {
|
|
for true {
|
|
_ = func() T { return func(int) T { return g }(0) }()
|
|
}
|
|
}
|
|
|
|
func main() {
|
|
f(0)
|
|
g(0)
|
|
}
|