mirror of
https://github.com/golang/go
synced 2024-11-18 10:44:45 -07:00
54e8d504e8
Fixes #4396. For fixed arrays larger than the unmapped page, agenr would general a nil check by loading the first word of the array. However there is no requirement for the first element of a byte array to be word aligned, so this check causes a trap on ARMv5 hardware (ARMv6 since relaxed that restriction, but it probably still comes at a cost). Switching the check to MOVB ensures alignment is not an issue. This check is only invoked in a few places in the code where large fixed arrays are embedded into structs, compress/lzw is the biggest offender, and switching to MOVB has no observable performance penalty. Thanks to Rémy and Daniel Morsing for helping me debug this on IRC last night. R=remyoudompheng, minux.ma, rsc CC=golang-dev https://golang.org/cl/6854063
30 lines
497 B
Go
30 lines
497 B
Go
// run
|
|
|
|
// Copyright 2012 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// This test _may_ fail on arm, but requires the host to
|
|
// trap unaligned loads. This is generally done with
|
|
//
|
|
// echo "4" > /proc/cpu/alignment
|
|
|
|
package main
|
|
|
|
type T struct {
|
|
U uint16
|
|
V T2
|
|
}
|
|
|
|
type T2 struct {
|
|
pad [4096]byte
|
|
A, B byte
|
|
}
|
|
|
|
var s, t = new(T), new(T)
|
|
|
|
func main() {
|
|
var u, v *T2 = &s.V, &t.V
|
|
u.B = v.B
|
|
}
|