mirror of
https://github.com/golang/go
synced 2024-09-30 08:28:34 -06:00
7904946eeb
In order to fix issue #9401 the compiler was changed to add a padding byte to any non-empty Go struct that ends in a zero-sized field. That causes the Go version of such a C struct to have a different size than the C struct, which can considerable confusion. Change cgo so that it discards any such zero-sized fields, so that the Go and C structs are the same size. This is a change from previous releases, in that it used to be possible to refer to a zero-sized trailing field (by taking its address), and with this change it no longer is. That is unfortunate, but something has to change. It seems better to visibly break programs that do this rather than to silently break programs that rely on the struct sizes being the same. Update #9401. Fixes #11925. Change-Id: I3fba3f02f11265b3c41d68616f79dedb05b81225 Reviewed-on: https://go-review.googlesource.com/12864 Reviewed-by: Russ Cox <rsc@golang.org>
38 lines
803 B
Go
38 lines
803 B
Go
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Issue 11925. Structs with zero-length trailing fields are now
|
|
// padded by the Go compiler.
|
|
|
|
package cgotest
|
|
|
|
/*
|
|
struct a11925 {
|
|
int i;
|
|
char a[0];
|
|
char b[0];
|
|
};
|
|
|
|
struct b11925 {
|
|
int i;
|
|
char a[0];
|
|
char b[];
|
|
};
|
|
*/
|
|
import "C"
|
|
|
|
import (
|
|
"testing"
|
|
"unsafe"
|
|
)
|
|
|
|
func test11925(t *testing.T) {
|
|
if C.sizeof_struct_a11925 != unsafe.Sizeof(C.struct_a11925{}) {
|
|
t.Errorf("size of a changed: C %d, Go %d", C.sizeof_struct_a11925, unsafe.Sizeof(C.struct_a11925{}))
|
|
}
|
|
if C.sizeof_struct_b11925 != unsafe.Sizeof(C.struct_b11925{}) {
|
|
t.Errorf("size of b changed: C %d, Go %d", C.sizeof_struct_b11925, unsafe.Sizeof(C.struct_b11925{}))
|
|
}
|
|
}
|