mirror of
https://github.com/golang/go
synced 2024-11-23 07:50:05 -07:00
7b874619be
This reapplies CL 481061, with the followup fixes in CL 482975, CL 485315, and CL 485316 incorporated. CL 481061, by doujiang24 <doujiang24@gmail.com>, speed up C to Go calls by binding the M to the C thread. See below for its description. CL 482975 is a followup fix to a C declaration in testprogcgo. CL 485315 is a followup fix for x_cgo_getstackbound on Illumos. CL 485316 is a followup cleanup for ppc64 assembly. [Original CL 481061 description] This reapplies CL 392854, with the followup fixes in CL 479255, CL 479915, and CL 481057 incorporated. CL 392854, by doujiang24 <doujiang24@gmail.com>, speed up C to Go calls by binding the M to the C thread. See below for its description. CL 479255 is a followup fix for a small bug in ARM assembly code. CL 479915 is another followup fix to address C to Go calls after the C code uses some stack, but that CL is also buggy. CL 481057, by Michael Knyszek, is a followup fix for a memory leak bug of CL 479915. [Original CL 392854 description] In a C thread, it's necessary to acquire an extra M by using needm while invoking a Go function from C. But, needm and dropm are heavy costs due to the signal-related syscalls. So, we change to not dropm while returning back to C, which means binding the extra M to the C thread until it exits, to avoid needm and dropm on each C to Go call. Instead, we only dropm while the C thread exits, so the extra M won't leak. When invoking a Go function from C: Allocate a pthread variable using pthread_key_create, only once per shared object, and register a thread-exit-time destructor. And store the g0 of the current m into the thread-specified value of the pthread key, only once per C thread, so that the destructor will put the extra M back onto the extra M list while the C thread exits. When returning back to C: Skip dropm in cgocallback, when the pthread variable has been created, so that the extra M will be reused the next time invoke a Go function from C. This is purely a performance optimization. The old version, in which needm & dropm happen on each cgo call, is still correct too, and we have to keep the old version on systems with cgo but without pthreads, like Windows. This optimization is significant, and the specific value depends on the OS system and CPU, but in general, it can be considered as 10x faster, for a simple Go function call from a C thread. For the newly added BenchmarkCGoInCThread, some benchmark results: 1. it's 28x faster, from 3395 ns/op to 121 ns/op, in darwin OS & Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz 2. it's 6.5x faster, from 1495 ns/op to 230 ns/op, in Linux OS & Intel(R) Xeon(R) CPU E5-2630 0 @ 2.30GHz [CL 479915 description] Currently, when C calls into Go the first time, we grab an M using needm, which sets m.g0's stack bounds using the SP. We don't know how big the stack is, so we simply assume 32K. Previously, when the Go function returns to C, we drop the M, and the next time C calls into Go, we put a new stack bound on the g0 based on the current SP. After CL 392854, we don't drop the M, and the next time C calls into Go, we reuse the same g0, without recomputing the stack bounds. If the C code uses quite a bit of stack space before calling into Go, the SP may be well below the 32K stack bound we assumed, so the runtime thinks the g0 stack overflows. This CL makes needm get a more accurate stack bound from pthread. (In some platforms this may still be a guess as we don't know exactly where we are in the C stack), but it is probably better than simply assuming 32K. [CL 485500 description] CL 479915 passed the G to _cgo_getstackbound for direct updates to gp.stack.lo. A G can be reused on a new thread after the previous thread exited. This could trigger the C TSAN race detector because it couldn't see the synchronization in Go (lockextra) preventing the same G from being used on multiple threads at the same time. We work around this by passing the address of a stack variable to _cgo_getstackbound rather than the G. The stack is generally unique per thread, so TSAN won't see the same address from multiple threads. Even if stacks are reused across threads by pthread, C TSAN should see the synchonization in the stack allocator. A regression test is added to misc/cgo/testsanitizer. Fixes #51676. Fixes #59294. Fixes #59678. Change-Id: Ic62be31a06ee83568215e875a891df37084e08ca Reviewed-on: https://go-review.googlesource.com/c/go/+/485500 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> Run-TryBot: Michael Pratt <mpratt@google.com>
598 lines
11 KiB
Go
598 lines
11 KiB
Go
// Copyright 2011 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test cases for cgo.
|
|
// Both the import "C" prologue and the main file are sorted by issue number.
|
|
// This file contains //export directives on Go functions
|
|
// and so it must NOT contain C definitions (only declarations).
|
|
// See test.go for C definitions.
|
|
|
|
package cgotest
|
|
|
|
import (
|
|
"runtime"
|
|
"runtime/cgo"
|
|
"runtime/debug"
|
|
"strings"
|
|
"sync"
|
|
"sync/atomic"
|
|
"testing"
|
|
"unsafe"
|
|
)
|
|
|
|
/*
|
|
// threads
|
|
extern void doAdd(int, int);
|
|
extern int callGoInCThread(int);
|
|
|
|
// issue 1328
|
|
void IntoC(void);
|
|
|
|
// issue 1560
|
|
extern void Issue1560InC(void);
|
|
|
|
// twoSleep returns the absolute start time of the first sleep
|
|
// in ms.
|
|
long long twoSleep(int);
|
|
|
|
// issue 3775
|
|
void lockOSThreadC(void);
|
|
int usleep(unsigned usec);
|
|
|
|
// issue 4054 part 2 - part 1 in test.go
|
|
typedef enum {
|
|
A = 0,
|
|
B,
|
|
C,
|
|
D,
|
|
E,
|
|
F,
|
|
G,
|
|
H,
|
|
II,
|
|
J,
|
|
} issue4054b;
|
|
|
|
// issue 5548
|
|
|
|
extern int issue5548_in_c(void);
|
|
|
|
// issue 6833
|
|
|
|
extern unsigned long long issue6833Func(unsigned int, unsigned long long);
|
|
|
|
// issue 6907
|
|
|
|
extern int CheckIssue6907C(_GoString_);
|
|
|
|
// issue 7665
|
|
|
|
extern void f7665(void);
|
|
|
|
// issue 7978
|
|
// Stack tracing didn't work during cgo code after calling a Go
|
|
// callback. Make sure GC works and the stack trace is correct.
|
|
|
|
#include <stdint.h>
|
|
|
|
// use ugly atomic variable sync since that doesn't require calling back into
|
|
// Go code or OS dependencies
|
|
void issue7978c(uint32_t *sync);
|
|
|
|
// issue 8331 part 2 - part 1 in test.go
|
|
// A typedef of an unnamed struct is the same struct when
|
|
// #include'd twice. No runtime test; just make sure it compiles.
|
|
#include "issue8331.h"
|
|
|
|
// issue 8945
|
|
|
|
typedef void (*PFunc8945)();
|
|
extern PFunc8945 func8945; // definition is in test.go
|
|
|
|
// issue 20910
|
|
void callMulti(void);
|
|
|
|
// issue 28772 part 2 - part 1 in issuex.go
|
|
#define issue28772Constant2 2
|
|
|
|
|
|
// issue 31891
|
|
typedef struct {
|
|
long obj;
|
|
} Issue31891A;
|
|
|
|
typedef struct {
|
|
long obj;
|
|
} Issue31891B;
|
|
|
|
void callIssue31891(void);
|
|
|
|
typedef struct {
|
|
int i;
|
|
} Issue38408, *PIssue38408;
|
|
|
|
extern void cfunc49633(void*); // definition is in test.go
|
|
*/
|
|
import "C"
|
|
|
|
// exports
|
|
|
|
//export ReturnIntLong
|
|
func ReturnIntLong() (int, C.long) {
|
|
return 1, 2
|
|
}
|
|
|
|
//export gc
|
|
func gc() {
|
|
runtime.GC()
|
|
}
|
|
|
|
// threads
|
|
|
|
var sum struct {
|
|
sync.Mutex
|
|
i int
|
|
}
|
|
|
|
//export Add
|
|
func Add(x int) {
|
|
defer func() {
|
|
recover()
|
|
}()
|
|
sum.Lock()
|
|
sum.i += x
|
|
sum.Unlock()
|
|
var p *int
|
|
*p = 2
|
|
}
|
|
|
|
//export goDummy
|
|
func goDummy() {
|
|
}
|
|
|
|
func testCthread(t *testing.T) {
|
|
if (runtime.GOOS == "darwin" || runtime.GOOS == "ios") && runtime.GOARCH == "arm64" {
|
|
t.Skip("the iOS exec wrapper is unable to properly handle the panic from Add")
|
|
}
|
|
sum.i = 0
|
|
C.doAdd(10, 6)
|
|
|
|
want := 10 * (10 - 1) / 2 * 6
|
|
if sum.i != want {
|
|
t.Fatalf("sum=%d, want %d", sum.i, want)
|
|
}
|
|
}
|
|
|
|
// Benchmark measuring overhead from C to Go in a C thread.
|
|
// Create a new C thread and invoke Go function repeatedly in the new C thread.
|
|
func benchCGoInCthread(b *testing.B) {
|
|
n := C.callGoInCThread(C.int(b.N))
|
|
if int(n) != b.N {
|
|
b.Fatal("unmatch loop times")
|
|
}
|
|
}
|
|
|
|
// issue 1328
|
|
|
|
//export BackIntoGo
|
|
func BackIntoGo() {
|
|
x := 1
|
|
|
|
for i := 0; i < 10000; i++ {
|
|
xvariadic(x)
|
|
if x != 1 {
|
|
panic("x is not 1?")
|
|
}
|
|
}
|
|
}
|
|
|
|
func xvariadic(x ...interface{}) {
|
|
}
|
|
|
|
func test1328(t *testing.T) {
|
|
C.IntoC()
|
|
}
|
|
|
|
// issue 1560
|
|
// Test that C functions and Go functions run in parallel.
|
|
|
|
var (
|
|
issue1560 int32
|
|
|
|
issue1560Ch = make(chan bool, 2)
|
|
)
|
|
|
|
//export Issue1560FromC
|
|
func Issue1560FromC() {
|
|
for atomic.LoadInt32(&issue1560) != 1 {
|
|
runtime.Gosched()
|
|
}
|
|
atomic.AddInt32(&issue1560, 1)
|
|
for atomic.LoadInt32(&issue1560) != 3 {
|
|
runtime.Gosched()
|
|
}
|
|
issue1560Ch <- true
|
|
}
|
|
|
|
func Issue1560FromGo() {
|
|
atomic.AddInt32(&issue1560, 1)
|
|
for atomic.LoadInt32(&issue1560) != 2 {
|
|
runtime.Gosched()
|
|
}
|
|
atomic.AddInt32(&issue1560, 1)
|
|
issue1560Ch <- true
|
|
}
|
|
|
|
func test1560(t *testing.T) {
|
|
go Issue1560FromGo()
|
|
go C.Issue1560InC()
|
|
<-issue1560Ch
|
|
<-issue1560Ch
|
|
}
|
|
|
|
// issue 2462
|
|
|
|
//export exportbyte
|
|
func exportbyte() byte {
|
|
return 0
|
|
}
|
|
|
|
//export exportbool
|
|
func exportbool() bool {
|
|
return false
|
|
}
|
|
|
|
//export exportrune
|
|
func exportrune() rune {
|
|
return 0
|
|
}
|
|
|
|
//export exporterror
|
|
func exporterror() error {
|
|
return nil
|
|
}
|
|
|
|
//export exportint
|
|
func exportint() int {
|
|
return 0
|
|
}
|
|
|
|
//export exportuint
|
|
func exportuint() uint {
|
|
return 0
|
|
}
|
|
|
|
//export exportuintptr
|
|
func exportuintptr() uintptr {
|
|
return (uintptr)(0)
|
|
}
|
|
|
|
//export exportint8
|
|
func exportint8() int8 {
|
|
return 0
|
|
}
|
|
|
|
//export exportuint8
|
|
func exportuint8() uint8 {
|
|
return 0
|
|
}
|
|
|
|
//export exportint16
|
|
func exportint16() int16 {
|
|
return 0
|
|
}
|
|
|
|
//export exportuint16
|
|
func exportuint16() uint16 {
|
|
return 0
|
|
}
|
|
|
|
//export exportint32
|
|
func exportint32() int32 {
|
|
return 0
|
|
}
|
|
|
|
//export exportuint32
|
|
func exportuint32() uint32 {
|
|
return 0
|
|
}
|
|
|
|
//export exportint64
|
|
func exportint64() int64 {
|
|
return 0
|
|
}
|
|
|
|
//export exportuint64
|
|
func exportuint64() uint64 {
|
|
return 0
|
|
}
|
|
|
|
//export exportfloat32
|
|
func exportfloat32() float32 {
|
|
return 0
|
|
}
|
|
|
|
//export exportfloat64
|
|
func exportfloat64() float64 {
|
|
return 0
|
|
}
|
|
|
|
//export exportcomplex64
|
|
func exportcomplex64() complex64 {
|
|
return 0
|
|
}
|
|
|
|
//export exportcomplex128
|
|
func exportcomplex128() complex128 {
|
|
return 0
|
|
}
|
|
|
|
// issue 3741
|
|
|
|
//export exportSliceIn
|
|
func exportSliceIn(s []byte) bool {
|
|
return len(s) == cap(s)
|
|
}
|
|
|
|
//export exportSliceOut
|
|
func exportSliceOut() []byte {
|
|
return []byte{1}
|
|
}
|
|
|
|
//export exportSliceInOut
|
|
func exportSliceInOut(s []byte) []byte {
|
|
return s
|
|
}
|
|
|
|
// issue 3775
|
|
|
|
func init() {
|
|
if runtime.GOOS == "android" {
|
|
return
|
|
}
|
|
// Same as test3775 but run during init so that
|
|
// there are two levels of internal runtime lock
|
|
// (1 for init, 1 for cgo).
|
|
// This would have been broken by CL 11663043.
|
|
C.lockOSThreadC()
|
|
}
|
|
|
|
func test3775(t *testing.T) {
|
|
if runtime.GOOS == "android" {
|
|
return
|
|
}
|
|
// Used to panic because of the UnlockOSThread below.
|
|
C.lockOSThreadC()
|
|
}
|
|
|
|
//export lockOSThreadCallback
|
|
func lockOSThreadCallback() {
|
|
runtime.LockOSThread()
|
|
runtime.UnlockOSThread()
|
|
go C.usleep(10000)
|
|
runtime.Gosched()
|
|
}
|
|
|
|
// issue 4054 part 2 - part 1 in test.go
|
|
|
|
var issue4054b = []int{C.A, C.B, C.C, C.D, C.E, C.F, C.G, C.H, C.II, C.J}
|
|
|
|
//export issue5548FromC
|
|
func issue5548FromC(s string, i int) int {
|
|
if len(s) == 4 && s == "test" && i == 42 {
|
|
return 12345
|
|
}
|
|
println("got", len(s), i)
|
|
return 9876
|
|
}
|
|
|
|
func test5548(t *testing.T) {
|
|
if x := C.issue5548_in_c(); x != 12345 {
|
|
t.Errorf("issue5548_in_c = %d, want %d", x, 12345)
|
|
}
|
|
}
|
|
|
|
// issue 6833
|
|
|
|
//export GoIssue6833Func
|
|
func GoIssue6833Func(aui uint, aui64 uint64) uint64 {
|
|
return aui64 + uint64(aui)
|
|
}
|
|
|
|
func test6833(t *testing.T) {
|
|
ui := 7
|
|
ull := uint64(0x4000300020001000)
|
|
v := uint64(C.issue6833Func(C.uint(ui), C.ulonglong(ull)))
|
|
exp := uint64(ui) + ull
|
|
if v != exp {
|
|
t.Errorf("issue6833Func() returns %x, expected %x", v, exp)
|
|
}
|
|
}
|
|
|
|
// issue 6907
|
|
|
|
const CString = "C string"
|
|
|
|
//export CheckIssue6907Go
|
|
func CheckIssue6907Go(s string) C.int {
|
|
if s == CString {
|
|
return 1
|
|
}
|
|
return 0
|
|
}
|
|
|
|
func test6907Go(t *testing.T) {
|
|
if got := C.CheckIssue6907C(CString); got != 1 {
|
|
t.Errorf("C.CheckIssue6907C() == %d, want %d", got, 1)
|
|
}
|
|
}
|
|
|
|
// issue 7665
|
|
|
|
var bad7665 unsafe.Pointer = C.f7665
|
|
var good7665 uintptr = uintptr(C.f7665)
|
|
|
|
func test7665(t *testing.T) {
|
|
if bad7665 == nil || uintptr(bad7665) != good7665 {
|
|
t.Errorf("ptrs = %p, %#x, want same non-nil pointer", bad7665, good7665)
|
|
}
|
|
}
|
|
|
|
// issue 7978
|
|
|
|
var issue7978sync uint32
|
|
|
|
func issue7978check(t *testing.T, wantFunc string, badFunc string, depth int) {
|
|
runtime.GC()
|
|
buf := make([]byte, 65536)
|
|
trace := string(buf[:runtime.Stack(buf, true)])
|
|
for _, goroutine := range strings.Split(trace, "\n\n") {
|
|
if strings.Contains(goroutine, "test.issue7978go") {
|
|
trace := strings.Split(goroutine, "\n")
|
|
// look for the expected function in the stack
|
|
for i := 0; i < depth; i++ {
|
|
if badFunc != "" && strings.Contains(trace[1+2*i], badFunc) {
|
|
t.Errorf("bad stack: found %s in the stack:\n%s", badFunc, goroutine)
|
|
return
|
|
}
|
|
if strings.Contains(trace[1+2*i], wantFunc) {
|
|
return
|
|
}
|
|
}
|
|
t.Errorf("bad stack: didn't find %s in the stack:\n%s", wantFunc, goroutine)
|
|
return
|
|
}
|
|
}
|
|
t.Errorf("bad stack: goroutine not found. Full stack dump:\n%s", trace)
|
|
}
|
|
|
|
func issue7978wait(store uint32, wait uint32) {
|
|
if store != 0 {
|
|
atomic.StoreUint32(&issue7978sync, store)
|
|
}
|
|
for atomic.LoadUint32(&issue7978sync) != wait {
|
|
runtime.Gosched()
|
|
}
|
|
}
|
|
|
|
//export issue7978cb
|
|
func issue7978cb() {
|
|
// Force a stack growth from the callback to put extra
|
|
// pressure on the runtime. See issue #17785.
|
|
growStack(64)
|
|
issue7978wait(3, 4)
|
|
}
|
|
|
|
func growStack(n int) int {
|
|
var buf [128]int
|
|
if n == 0 {
|
|
return 0
|
|
}
|
|
return buf[growStack(n-1)]
|
|
}
|
|
|
|
func issue7978go() {
|
|
C.issue7978c((*C.uint32_t)(&issue7978sync))
|
|
issue7978wait(7, 8)
|
|
}
|
|
|
|
func test7978(t *testing.T) {
|
|
if runtime.Compiler == "gccgo" {
|
|
t.Skip("gccgo can not do stack traces of C code")
|
|
}
|
|
debug.SetTraceback("2")
|
|
issue7978sync = 0
|
|
go issue7978go()
|
|
// test in c code, before callback
|
|
issue7978wait(0, 1)
|
|
issue7978check(t, "_Cfunc_issue7978c(", "", 1)
|
|
// test in go code, during callback
|
|
issue7978wait(2, 3)
|
|
issue7978check(t, "test.issue7978cb(", "test.issue7978go", 3)
|
|
// test in c code, after callback
|
|
issue7978wait(4, 5)
|
|
issue7978check(t, "_Cfunc_issue7978c(", "_cgoexpwrap", 1)
|
|
// test in go code, after return from cgo
|
|
issue7978wait(6, 7)
|
|
issue7978check(t, "test.issue7978go(", "", 3)
|
|
atomic.StoreUint32(&issue7978sync, 8)
|
|
}
|
|
|
|
// issue 8331 part 2
|
|
|
|
var issue8331Var C.issue8331
|
|
|
|
// issue 8945
|
|
|
|
//export Test8945
|
|
func Test8945() {
|
|
_ = C.func8945
|
|
}
|
|
|
|
// issue 20910
|
|
|
|
//export multi
|
|
func multi() (*C.char, C.int) {
|
|
return C.CString("multi"), 0
|
|
}
|
|
|
|
func test20910(t *testing.T) {
|
|
C.callMulti()
|
|
}
|
|
|
|
// issue 28772 part 2
|
|
|
|
const issue28772Constant2 = C.issue28772Constant2
|
|
|
|
// issue 31891
|
|
|
|
//export useIssue31891A
|
|
func useIssue31891A(c *C.Issue31891A) {}
|
|
|
|
//export useIssue31891B
|
|
func useIssue31891B(c *C.Issue31891B) {}
|
|
|
|
func test31891(t *testing.T) {
|
|
C.callIssue31891()
|
|
}
|
|
|
|
// issue 37033, check if cgo.Handle works properly
|
|
|
|
var issue37033 = 42
|
|
|
|
//export GoFunc37033
|
|
func GoFunc37033(handle C.uintptr_t) {
|
|
h := cgo.Handle(handle)
|
|
ch := h.Value().(chan int)
|
|
ch <- issue37033
|
|
}
|
|
|
|
// issue 38408
|
|
// A typedef pointer can be used as the element type.
|
|
// No runtime test; just make sure it compiles.
|
|
var _ C.PIssue38408 = &C.Issue38408{i: 1}
|
|
|
|
// issue 49633, example use of cgo.Handle with void*
|
|
|
|
type data49633 struct {
|
|
msg string
|
|
}
|
|
|
|
//export GoFunc49633
|
|
func GoFunc49633(context unsafe.Pointer) {
|
|
h := *(*cgo.Handle)(context)
|
|
v := h.Value().(*data49633)
|
|
v.msg = "hello"
|
|
}
|
|
|
|
func test49633(t *testing.T) {
|
|
v := &data49633{}
|
|
h := cgo.NewHandle(v)
|
|
defer h.Delete()
|
|
C.cfunc49633(unsafe.Pointer(&h))
|
|
if v.msg != "hello" {
|
|
t.Errorf("msg = %q, want 'hello'", v.msg)
|
|
}
|
|
}
|