mirror of
https://github.com/golang/go
synced 2024-11-19 08:44:39 -07:00
f895b43688
This removes much of the AST logic out of main.go, and makes it easier to build custom vet binaries The trade-off in this change is for flexibility. There's very little change in the per-check files, a lot less code in main.go (specifically the AST walking logic has shrunk), and it makes it much easier to build custom vet binaries simply by dropping new source files in the directory. LGTM=josharian, r R=r, josharian, kamil.kisiel CC=golang-codereviews https://golang.org/cl/83400043
43 lines
1.0 KiB
Go
43 lines
1.0 KiB
Go
// Copyright 2010 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// This file contains the test for canonical struct tags.
|
|
|
|
package main
|
|
|
|
import (
|
|
"go/ast"
|
|
"reflect"
|
|
"strconv"
|
|
)
|
|
|
|
func init() {
|
|
register("structtags",
|
|
"check that struct field tags have canonical format",
|
|
checkCanonicalFieldTag,
|
|
field)
|
|
}
|
|
|
|
// checkCanonicalFieldTag checks a struct field tag.
|
|
func checkCanonicalFieldTag(f *File, node ast.Node) {
|
|
field := node.(*ast.Field)
|
|
if field.Tag == nil {
|
|
return
|
|
}
|
|
|
|
tag, err := strconv.Unquote(field.Tag.Value)
|
|
if err != nil {
|
|
f.Badf(field.Pos(), "unable to read struct tag %s", field.Tag.Value)
|
|
return
|
|
}
|
|
|
|
// Check tag for validity by appending
|
|
// new key:value to end and checking that
|
|
// the tag parsing code can find it.
|
|
if reflect.StructTag(tag+` _gofix:"_magic"`).Get("_gofix") != "_magic" {
|
|
f.Badf(field.Pos(), "struct field tag %s not compatible with reflect.StructTag.Get", field.Tag.Value)
|
|
return
|
|
}
|
|
}
|