mirror of
https://github.com/golang/go
synced 2024-11-18 14:24:44 -07:00
7da5f193b7
This CL introduces two vet checks. Statistics and code below are from a recent 50mb corpus of public code.
1. Check for redundant conjunctions and disjunctions. This check caught 26 instances, of which 20 were clearly copy/paste bugs and 6 appeared to be mere duplication. A typical example:
if xResolution < 0 || xResolution < 0 {
panic("SetSize(): width < 0 || height < 0")
}
2. Check for expressions of the form 'x != c1 || x != c2' or 'x == c1 && x == c2', with c1 and c2 constant expressions. This check caught 16 instances, of which all were bugs. A typical example:
if rf.uri.Scheme != "http" || rf.uri.Scheme != "ftp" {
rf.uri.Scheme = "file"
}
Fixes golang/go#7622.
LGTM=rsc, r
R=golang-codereviews, jscrockett01, r, gri, rsc
CC=golang-codereviews
https://golang.org/cl/98120043
114 lines
4.7 KiB
Go
114 lines
4.7 KiB
Go
// Copyright 2014 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// This file contains tests for the bool checker.
|
|
|
|
package testdata
|
|
|
|
import "io"
|
|
|
|
func RatherStupidConditions() {
|
|
var f, g func() int
|
|
if f() == 0 || f() == 0 { // OK f might have side effects
|
|
}
|
|
if v, w := f(), g(); v == w || v == w { // ERROR "redundant or: v == w || v == w"
|
|
}
|
|
_ = f == nil || f == nil // ERROR "redundant or: f == nil || f == nil"
|
|
|
|
_ = i == byte(1) || i == byte(1) // TODO conversions are treated as if they may have side effects
|
|
|
|
var c chan int
|
|
_ = 0 == <-c || 0 == <-c // OK subsequent receives may yield different values
|
|
for i, j := <-c, <-c; i == j || i == j; i, j = <-c, <-c { // ERROR "redundant or: i == j || i == j"
|
|
}
|
|
|
|
var i, j, k int
|
|
_ = i+1 == 1 || i+1 == 1 // ERROR "redundant or: i\+1 == 1 || i\+1 == 1"
|
|
_ = i == 1 || j+1 == i || i == 1 // ERROR "redundant or: i == 1 || i == 1"
|
|
|
|
_ = i == 1 || i == 1 || f() == 1 // ERROR "redundant or: i == 1 || i == 1"
|
|
_ = i == 1 || f() == 1 || i == 1 // OK f may alter i as a side effect
|
|
_ = f() == 1 || i == 1 || i == 1 // ERROR "redundant or: i == 1 || i == 1"
|
|
|
|
// Test partition edge cases
|
|
_ = f() == 1 || i == 1 || i == 1 || j == 1 // ERROR "redundant or: i == 1 || i == 1"
|
|
_ = f() == 1 || j == 1 || i == 1 || i == 1 // ERROR "redundant or: i == 1 || i == 1"
|
|
_ = i == 1 || f() == 1 || i == 1 || i == 1 // ERROR "redundant or: i == 1 || i == 1"
|
|
_ = i == 1 || i == 1 || f() == 1 || i == 1 // ERROR "redundant or: i == 1 || i == 1"
|
|
_ = i == 1 || i == 1 || j == 1 || f() == 1 // ERROR "redundant or: i == 1 || i == 1"
|
|
_ = j == 1 || i == 1 || i == 1 || f() == 1 // ERROR "redundant or: i == 1 || i == 1"
|
|
_ = i == 1 || f() == 1 || f() == 1 || i == 1
|
|
|
|
_ = i == 1 || (i == 1 || i == 2) // ERROR "redundant or: i == 1 || i == 1"
|
|
_ = i == 1 || (f() == 1 || i == 1) // OK f may alter i as a side effect
|
|
_ = i == 1 || (i == 1 || f() == 1) // ERROR "redundant or: i == 1 || i == 1"
|
|
_ = i == 1 || (i == 2 || (i == 1 || i == 3)) // ERROR "redundant or: i == 1 || i == 1"
|
|
|
|
var a, b bool
|
|
_ = i == 1 || (a || (i == 1 || b)) // ERROR "redundant or: i == 1 || i == 1"
|
|
|
|
// Check that all redundant ors are flagged
|
|
_ = j == 0 ||
|
|
i == 1 ||
|
|
f() == 1 ||
|
|
j == 0 || // ERROR "redundant or: j == 0 || j == 0"
|
|
i == 1 || // ERROR "redundant or: i == 1 || i == 1"
|
|
i == 1 || // ERROR "redundant or: i == 1 || i == 1"
|
|
i == 1 ||
|
|
j == 0 ||
|
|
k == 0
|
|
|
|
_ = i == 1*2*3 || i == 1*2*3 // ERROR "redundant or: i == 1\*2\*3 || i == 1\*2\*3"
|
|
|
|
// These test that redundant, suspect expressions do not trigger multiple errors.
|
|
_ = i != 0 || i != 0 // ERROR "redundant or: i != 0 || i != 0"
|
|
_ = i == 0 && i == 0 // ERROR "redundant and: i == 0 && i == 0"
|
|
|
|
// and is dual to or; check the basics and
|
|
// let the or tests pull the rest of the weight.
|
|
_ = 0 != <-c && 0 != <-c // OK subsequent receives may yield different values
|
|
_ = f() != 0 && f() != 0 // OK f might have side effects
|
|
_ = f != nil && f != nil // ERROR "redundant and: f != nil && f != nil"
|
|
_ = i != 1 && i != 1 && f() != 1 // ERROR "redundant and: i != 1 && i != 1"
|
|
_ = i != 1 && f() != 1 && i != 1 // OK f may alter i as a side effect
|
|
_ = f() != 1 && i != 1 && i != 1 // ERROR "redundant and: i != 1 && i != 1"
|
|
}
|
|
|
|
func RoyallySuspectConditions() {
|
|
var i, j int
|
|
|
|
_ = i == 0 || i == 1 // OK
|
|
_ = i != 0 || i != 1 // ERROR "suspect or: i != 0 || i != 1"
|
|
_ = i != 0 || 1 != i // ERROR "suspect or: i != 0 || 1 != i"
|
|
_ = 0 != i || 1 != i // ERROR "suspect or: 0 != i || 1 != i"
|
|
_ = 0 != i || i != 1 // ERROR "suspect or: 0 != i || i != 1"
|
|
|
|
_ = (0 != i) || i != 1 // ERROR "suspect or: 0 != i || i != 1"
|
|
|
|
_ = i+3 != 7 || j+5 == 0 || i+3 != 9 // ERROR "suspect or: i\+3 != 7 || i\+3 != 9"
|
|
|
|
_ = i != 0 || j == 0 || i != 1 // ERROR "suspect or: i != 0 || i != 1"
|
|
|
|
_ = i != 0 || i != 1<<4 // ERROR "suspect or: i != 0 || i != 1<<4"
|
|
|
|
_ = i != 0 || j != 0
|
|
_ = 0 != i || 0 != j
|
|
|
|
var s string
|
|
_ = s != "one" || s != "the other" // ERROR "suspect or: s != .one. || s != .the other."
|
|
|
|
_ = "et" != "alii" || "et" != "cetera" // ERROR "suspect or: .et. != .alii. || .et. != .cetera."
|
|
_ = "me gustas" != "tu" || "le gustas" != "tu" // OK we could catch this case, but it's not worth the code
|
|
|
|
var err error
|
|
_ = err != nil || err != io.EOF // TODO catch this case?
|
|
|
|
// Sanity check and.
|
|
_ = i != 0 && i != 1 // OK
|
|
_ = i == 0 && i == 1 // ERROR "suspect and: i == 0 && i == 1"
|
|
_ = i == 0 && 1 == i // ERROR "suspect and: i == 0 && 1 == i"
|
|
_ = 0 == i && 1 == i // ERROR "suspect and: 0 == i && 1 == i"
|
|
_ = 0 == i && i == 1 // ERROR "suspect and: 0 == i && i == 1"
|
|
}
|