mirror of
https://github.com/golang/go
synced 2024-10-01 12:28:37 -06:00
7baacfbe02
Now we will offer function literal completions when we know the
expected type is a function. For example:
sort.Slice(someSlice, <>)
will offer the completion "func(...) {}" which if selected will
insert:
func(i, j int) bool {<>}
I opted to use an abbreviated label "func(...) {}" because function
signatures can be quite long/verbose with all the type names in there.
The only interesting challenge is how to handle signatures that don't
name the parameters. For example,
func HandleFunc(pattern string, handler func(ResponseWriter, *Request)) {
does not name the "ResponseWriter" and "Request" parameters. I went
with a minimal effort approach where we try abbreviating the type
names, so the literal completion item for "handler" would look like:
func(<rw> ResponseWriter, <r> *Request) {<>}
where <> denote placeholders. The user can tab through quickly if they
like the abbreviations, otherwise they can rename them.
For unnamed types or if the abbreviation would duplicate a previous
abbreviation, we fall back to "_" as the parameter name. The user will
have to rename the parameter before they can use it.
One side effect of this is that we cannot support function literal
completions with unnamed parameters unless the user has enabled
snippet placeholders.
Change-Id: Ic0ec81e85cd8de79bff73314e80e722f10f8c84c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/193699
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
|
||
|---|---|---|
| .. | ||
| analysis.go | ||
| completion_format.go | ||
| completion_literal.go | ||
| completion_snippet.go | ||
| completion.go | ||
| deep_completion.go | ||
| diagnostics_test.go | ||
| diagnostics.go | ||
| enums.go | ||
| errors.go | ||
| folding_range.go | ||
| format.go | ||
| highlight.go | ||
| hover.go | ||
| identifier.go | ||
| imports_test.go | ||
| imports.go | ||
| options.go | ||
| references.go | ||
| rename_check.go | ||
| rename.go | ||
| signature_help.go | ||
| source_test.go | ||
| suggested_fix.go | ||
| symbols.go | ||
| util.go | ||
| view.go | ||