1
0
mirror of https://github.com/golang/go synced 2024-11-23 00:30:07 -07:00
go/src
Matthew Dempsky ab9aaf46ee cmd/compile/internal/syntax: add PosBase.Trimmed
With types2, some syntax.PosBases need to be constructed from export
data, which must only contain "trimmed" filenames (i.e., that they've
already been made absolute and undergone -trimpath processing).
However, it's not safe to apply trimming to a filename multiple times,
and in general we can't distinguish trimmed from untrimmed filenames.

This CL resolves this by adding a PosBase.Trimmed boolean so we can
distinguish whether the associated filename has been trimmed yet. This
is a bit hacky, but is the least bad solution I've come up with so
far.

This unblocks enabling -G=3 by default.

Change-Id: I7383becfb704680a36f7603e3246af38b21f100b
Reviewed-on: https://go-review.googlesource.com/c/go/+/343731
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Matthew Dempsky <mdempsky@google.com>
Trust: Dan Scales <danscales@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
2021-08-20 19:44:02 +00:00
..
archive archive/zip: prevent preallocation check from overflowing 2021-08-20 16:49:35 +00:00
bufio
builtin
bytes
cmd cmd/compile/internal/syntax: add PosBase.Trimmed 2021-08-20 19:44:02 +00:00
compress
container
context
crypto crypto/rand, internal/syscall/unix: don't use getentropy on iOS 2021-08-20 16:44:10 +00:00
database/sql
debug
embed
encoding
errors
expvar
flag
fmt
go go/types: change Checker.verify to return an error 2021-08-20 18:45:25 +00:00
hash
html
image
index/suffixarray
internal crypto/rand, internal/syscall/unix: don't use getentropy on iOS 2021-08-20 16:44:10 +00:00
io io: unexport internal methods 2021-08-19 09:11:02 +00:00
log
math all: fix typos 2021-08-17 13:54:10 +00:00
mime
net net/http: fix typo in header.go 2021-08-20 18:55:57 +00:00
os os/exec: re-enable LookPathTest/16 2021-08-12 15:58:41 +00:00
path path/filepath: change IsAbs to treat \\host\share as an absolute path 2021-08-18 08:26:44 +00:00
plugin
reflect reflect: add test for invalid conversion 2021-08-19 15:09:47 +00:00
regexp
runtime syscall: add SyscallN 2021-08-19 17:30:19 +00:00
sort
strconv all: fix typos 2021-08-17 13:54:10 +00:00
strings
sync sync/atomic: fix documentation for CompareAndSwap 2021-08-14 16:56:14 +00:00
syscall syscall: add SyscallN 2021-08-19 17:30:19 +00:00
testdata
testing testing/fstest: allow specifying file for "." in MapFS 2021-08-16 22:27:47 +00:00
text text/scanner: use Go convention in Position doc comment 2021-07-18 21:00:03 +00:00
time time: update current time comment 2021-08-16 17:24:37 +00:00
unicode
unsafe
vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod
go.sum
make.bash src/make.*: make --no-clean flag a no-op that prints a warning 2021-08-11 22:07:50 +00:00
make.bat src/make.*: make --no-clean flag a no-op that prints a warning 2021-08-11 22:07:50 +00:00
Make.dist
make.rc src/make.*: make --no-clean flag a no-op that prints a warning 2021-08-11 22:07:50 +00:00
race.bash src: simplify race.bash checking condition 2021-08-17 01:49:12 +00:00
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.