mirror of
https://github.com/golang/go
synced 2024-10-01 11:28:34 -06:00
f66ef90017
Completion often fails when the completion prefix happens to be a
keyword. We previously tried to fix this with AST surgery, but
often the accidental keyword is not apparent looking at the AST.
For example:
chan<>
foo()
parses as CallExpr{Fun: ChanType{Value: Ident{"foo"}}} with very few
hints that something is wrong, and:
default
foo()
is completely omitted from the AST.
Rather than look in the AST, we now instead manually look for a
keyword token that contains the completion position. If we find one,
we treat that as our surrounding identifier.
Updates golang/go#34332.
Change-Id: I68ed0dd905848c0eae61f39ecb8b73adb1e72746
Reviewed-on: https://go-review.googlesource.com/c/tools/+/216961
Run-TryBot: Muir Manders <muir@mnd.rs>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
26 lines
543 B
Plaintext
26 lines
543 B
Plaintext
-- summary --
|
|
CompletionsCount = 226
|
|
CompletionSnippetCount = 66
|
|
UnimportedCompletionsCount = 9
|
|
DeepCompletionsCount = 5
|
|
FuzzyCompletionsCount = 8
|
|
RankedCompletionsCount = 83
|
|
CaseSensitiveCompletionsCount = 4
|
|
DiagnosticsCount = 38
|
|
FoldingRangesCount = 2
|
|
FormatCount = 6
|
|
ImportCount = 7
|
|
SuggestedFixCount = 1
|
|
DefinitionsCount = 45
|
|
TypeDefinitionsCount = 2
|
|
HighlightsCount = 52
|
|
ReferencesCount = 8
|
|
RenamesCount = 23
|
|
PrepareRenamesCount = 7
|
|
SymbolsCount = 3
|
|
WorkspaceSymbolsCount = 2
|
|
SignaturesCount = 23
|
|
LinksCount = 8
|
|
ImplementationsCount = 5
|
|
|