1
0
mirror of https://github.com/golang/go synced 2024-11-18 10:14:45 -07:00
go/src
Erik Pellizzon f6436c60e4 hash/crc32: remove redundant code
Merge the CRC32 Update and Write functions using an unexported function, to avoid duplication of code and make it more readable.
The only difference between them is the check of the initialization of the IEEE table, and a boolean value specifies that.

Throughout the crc32.go file, in the switches the default value is inserted inside the switch statement, this change uniforms the style of the MakeTable function, making it like the other pieces of code.

Change-Id: I3889f6c6671210c82f0d7250cea67907bccf3ce7
GitHub-Last-Rev: b8777ee213
GitHub-Pull-Request: golang/go#55044
Reviewed-on: https://go-review.googlesource.com/c/go/+/430456
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Jenny Rakoczy <jenny@golang.org>
Auto-Submit: Jenny Rakoczy <jenny@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Ian Lance Taylor <iant@google.com>
2022-09-15 21:07:21 +00:00
..
archive
bufio
builtin
bytes
cmd cmd/compile: make encoding/binary appends cheaper to inline 2022-09-15 21:05:02 +00:00
compress compress/flate: update NewReader documentation 2022-09-15 20:02:32 +00:00
container
context
crypto all: move //go:build lines below copyright notice 2022-09-14 14:17:04 +00:00
database/sql database: convert Tx.done to atomic type 2022-09-08 15:52:57 +00:00
debug debug/elf: define additional PPC64 ELFv2 relocations 2022-09-08 13:31:46 +00:00
embed
encoding
errors
expvar
flag
fmt
go runtime/race: introduce subarch versioning of race syso 2022-09-15 14:08:12 +00:00
hash hash/crc32: remove redundant code 2022-09-15 21:07:21 +00:00
html
image
index/suffixarray
internal internal/syscall/unix: remove superfluous var declarations in {Unlink,Open}at 2022-09-15 21:04:12 +00:00
io
log
math
mime
net net/http/httputil: forward 1xx responses in ReverseProxy 2022-09-14 23:59:32 +00:00
os os: add a test case of copying a file itself via io.Copy 2022-09-09 15:34:46 +00:00
path path/filepath: document that WalkDir uses OS paths 2022-09-14 14:19:13 +00:00
plugin
reflect reflect: move benchmarks to its own file 2022-09-13 17:41:16 +00:00
regexp
runtime runtime: optimise memclrNoHeapPointers on riscv64 2022-09-15 19:29:39 +00:00
sort
strconv strconv: remove redundant type conversion 2022-09-09 00:28:56 +00:00
strings strings: reuse the input string for Repeat count of 1 2022-09-14 14:56:07 +00:00
sync sync: convert RWMutex.{readerCount,readerWait} to atomic type 2022-09-09 18:28:35 +00:00
syscall syscall: use fcntl F_DUP2FD_CLOEXEC in forkAndExecInChild on solaris 2022-09-15 21:07:18 +00:00
testdata
testing testing: use strings.Builder 2022-09-07 07:03:10 +00:00
text text/template: fixed typo in a nested template definition 2022-09-15 21:05:40 +00:00
time time: optimize Parse for RFC3339 and RFC3339Nano 2022-09-13 17:35:58 +00:00
unicode
unsafe
vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod
go.sum
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.