1
0
mirror of https://github.com/golang/go synced 2024-11-23 03:20:03 -07:00
go/src
Matthew Dempsky f58c6cccc4 cmd/compile: fix reproducible build of aliased generic types
Due to a missing "&& !alias" check, the unified linker was treating
type aliases the same as defined types for the purpose of exporting
method bodies. The methods will get exported anyway alongside the
aliased type, so this mistake is normally harmless.

However, if multiple type aliases instantiated the same generic type
but with different type arguments, this could result in the
same (generic) method body being exported multiple times under
different symbol names. Further, because bodies aren't expected to be
exported multiple times, we were sorting them simply based on index.
And consequently, the sort wasn't total and is sensitive to the map
iteration order used while ranging over linker.bodies.

The fix is simply to add the missing "&& !alias" check, so that we
don't end up with duplicate bodies in the first place.

Thanks rsc@ for providing a minimal repro case.

Fixes #59571.

Change-Id: Iaa55968cc7110b601e2f0f9b620901c2d55f7014
Reviewed-on: https://go-review.googlesource.com/c/go/+/484155
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
2023-04-12 20:54:38 +00:00
..
archive archive/zip: return ErrInsecurePath for unsafe paths by OpenReader 2023-04-05 15:11:02 +00:00
arena
bufio
builtin
bytes all: fix misuses of "a" vs "an" 2023-04-04 14:20:53 +00:00
cmd cmd/compile: fix reproducible build of aliased generic types 2023-04-12 20:54:38 +00:00
compress
container
context context: clean up test files 2023-04-05 17:18:14 +00:00
crypto crypto: add wasip1 support 2023-04-11 20:54:07 +00:00
database/sql database/sql,testing/quick: use reflect.Value.SetZero 2023-04-04 07:16:34 +00:00
debug all: add wasip1 support 2023-04-11 20:56:32 +00:00
embed embed: implement openFile.ReadAt 2023-04-12 20:00:50 +00:00
encoding encoding/xml: use reflect.Value.Grow 2023-04-07 19:49:28 +00:00
errors errors: improve the godoc for Join and Unwrap 2023-03-30 23:49:50 +00:00
expvar
flag flag: add BoolFunc; FlagSet.BoolFunc 2023-03-16 16:44:21 +00:00
fmt
go log,log/slog: get correct source line when slog calls log 2023-04-12 18:33:50 +00:00
hash all: replace leading spaces with tabs in assembly 2023-03-23 20:52:57 +00:00
html all: re-run stringer 2023-04-11 20:24:07 +00:00
image
index/suffixarray all: fix misuses of "a" vs "an" 2023-04-04 14:20:53 +00:00
internal cmd/internal/sys, cmd/dist, misc/cgo/testcshared: enable c-shared feature and test on loong64 2023-04-12 20:06:37 +00:00
io all: add wasip1 support 2023-04-11 20:56:32 +00:00
log log/slog: catch panics in LogValue 2023-04-12 20:35:18 +00:00
maps
math all: re-run stringer 2023-04-11 20:24:07 +00:00
mime all: add wasip1 support 2023-04-11 20:56:32 +00:00
net net/http: avoid leaking writer goroutines in tests 2023-04-12 16:04:39 +00:00
os syscall: implement Fchdir on Windows 2023-04-12 09:13:54 +00:00
path all: add wasip1 support 2023-04-11 20:56:32 +00:00
plugin
reflect reflect: remove typedmemmovepartial as it is unused 2023-04-10 18:58:50 +00:00
regexp regexp: add Regexp.TextMarshaler/TextUnmarshaler 2023-04-12 20:03:09 +00:00
runtime runtime: cleanup ppc64le/linux library startup code 2023-04-12 20:52:19 +00:00
slices slices: add DeleteFunc 2023-04-07 22:25:51 +00:00
sort
strconv all: add a few links in package godocs 2023-03-25 10:16:23 +00:00
strings
sync sync: implement OnceFunc, OnceValue, and OnceValues 2023-03-31 20:01:17 +00:00
syscall syscall: implement Fchdir on Windows 2023-04-12 09:13:54 +00:00
testdata
testing all: add wasip1 support 2023-04-11 20:56:32 +00:00
text all: add a few links in package godocs 2023-03-25 10:16:23 +00:00
time time: add wasip1 support 2023-04-11 20:56:10 +00:00
unicode
unsafe
vendor all: update vendored golang.org/x/net 2023-04-11 22:42:18 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored golang.org/x/net 2023-04-11 22:42:18 +00:00
go.sum all: update vendored golang.org/x/net 2023-04-11 22:42:18 +00:00
make.bash
make.bat cmd/dist: add -distpack flag to build distribution archives 2023-04-11 21:29:13 +00:00
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash run.bash: drop 'export GOROOT' and its obsolete comment 2023-03-30 15:55:17 +00:00
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.