1
0
mirror of https://github.com/golang/go synced 2024-10-01 03:08:33 -06:00
go/internal/lsp/cache
Rebecca Stambler f53864d0db internal/lsp: remove command-line-arguments as a workspace package
If a package starts out as command-line-arguments, and then becomes
"valid" (i.e., gets a package declaration), we shouldn't continue to try
to diagnose "command-line-arguments". We should remove
"command-line-arguments" from workspace packages any time its metadata
is invalidated (assuming it may get added back if a file= query produces
it again).

Include the relevant regression test.

Fixes golang/go#37978

Change-Id: I7fc51edeb58007b4b4a163336cbeb752a53da322
Reviewed-on: https://go-review.googlesource.com/c/tools/+/225317
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-25 20:31:30 +00:00
..
analysis.go internal/telemetry: add type safe tag keys 2020-03-18 13:29:43 +00:00
cache.go internal/lsp: move the debug.Instance onto the Context 2020-03-03 22:54:53 +00:00
check.go internal/telemetry: add type safe tag keys 2020-03-18 13:29:43 +00:00
debug.go internal/lsp/lsprpc: add a handshake between forwarder and remote 2020-02-24 22:51:04 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
external.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
load.go internal/lsp: print view-specific environment 2020-03-24 20:15:47 +00:00
mod.go internal/lsp: fix nil pointer in 'go mod why' logic 2020-03-24 16:11:17 +00:00
parse.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
pkg.go internal/lsp: add module versions from "go list" to pkg.go.dev links 2020-02-19 19:55:21 +00:00
session.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
snapshot.go internal/lsp: remove command-line-arguments as a workspace package 2020-03-25 20:31:30 +00:00
view.go internal/lsp: print view-specific environment 2020-03-24 20:15:47 +00:00