mirror of
https://github.com/golang/go
synced 2024-11-18 21:54:49 -07:00
9a0fabac01
While experimenting with different static analysis on x/tools, I noticed that there are many actionable diagnostics found by staticcheck. Fix the ones that were not false positives. Change-Id: I0b68cf1f636b57b557db879fad84fff9b7237a89 Reviewed-on: https://go-review.googlesource.com/c/tools/+/222248 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
59 lines
1.5 KiB
Go
59 lines
1.5 KiB
Go
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package mod
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"golang.org/x/tools/internal/lsp/cache"
|
|
"golang.org/x/tools/internal/lsp/tests"
|
|
"golang.org/x/tools/internal/span"
|
|
"golang.org/x/tools/internal/testenv"
|
|
)
|
|
|
|
func TestMain(m *testing.M) {
|
|
testenv.ExitIfSmallMachine()
|
|
os.Exit(m.Run())
|
|
}
|
|
|
|
func TestModfileRemainsUnchanged(t *testing.T) {
|
|
ctx := tests.Context(t)
|
|
cache := cache.New(ctx, nil)
|
|
session := cache.NewSession(ctx)
|
|
options := tests.DefaultOptions()
|
|
options.TempModfile = true
|
|
options.Env = append(os.Environ(), "GOPACKAGESDRIVER=off", "GOROOT=")
|
|
|
|
// Make sure to copy the test directory to a temporary directory so we do not
|
|
// modify the test code or add go.sum files when we run the tests.
|
|
folder, err := tests.CopyFolderToTempDir(filepath.Join("testdata", "unchanged"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(folder)
|
|
|
|
before, err := ioutil.ReadFile(filepath.Join(folder, "go.mod"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
_, snapshot, err := session.NewView(ctx, "diagnostics_test", span.URIFromPath(folder), options)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, t := snapshot.View().ModFiles(); t == "" {
|
|
return
|
|
}
|
|
after, err := ioutil.ReadFile(filepath.Join(folder, "go.mod"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if string(before) != string(after) {
|
|
t.Errorf("the real go.mod file was changed even when tempModfile=true")
|
|
}
|
|
}
|