mirror of
https://github.com/golang/go
synced 2024-11-12 08:20:22 -07:00
e410a527b2
This change is the same as CL #9345 which was reverted, except for a small bug fix. The only change is to the body of sendDirect and its callsite. Also added a test. The problem was during a channel send operation. The target of the send was a sleeping goroutine waiting to receive. We basically do: 1) Read the destination pointer out of the sudog structure 2) Copy the value we're sending to that destination pointer Unfortunately, the previous change had a goroutine suspend point between 1 & 2 (the call to sendDirect). At that point the destination goroutine's stack could be copied (shrunk). The pointer we read in step 1 is no longer valid for step 2. Fixed by not allowing any suspension points between 1 & 2. I suspect the old code worked correctly basically by accident. Fixes #13169 The original 9345: This change removes the retry mechanism we use for buffered channels. Instead, any sender waking up a receiver or vice versa completes the full protocol with its counterpart. This means the counterpart does not need to relock the channel when it wakes up. (Currently buffered channels need to relock on wakeup.) For sends on a channel with waiting receivers, this change replaces two copies (sender->queue, queue->receiver) with one (sender->receiver). For receives on channels with a waiting sender, two copies are still required. This change unifies to a large degree the algorithm for buffered and unbuffered channels, simplifying the overall implementation. Fixes #11506 Change-Id: I57dfa3fc219cffa4d48301ee15fe5479299efa09 Reviewed-on: https://go-review.googlesource.com/16740 Reviewed-by: Ian Lance Taylor <iant@golang.org>
50 lines
704 B
Go
50 lines
704 B
Go
// run
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
type T struct {
|
|
a, b, c int
|
|
}
|
|
|
|
func usestack() {
|
|
usestack1(32)
|
|
}
|
|
func usestack1(d int) byte {
|
|
if d == 0 {
|
|
return 0
|
|
}
|
|
var b [1024]byte
|
|
usestack1(d - 1)
|
|
return b[3]
|
|
}
|
|
|
|
const n = 100000
|
|
|
|
func main() {
|
|
c := make(chan interface{})
|
|
done := make(chan bool)
|
|
|
|
for i := 0; i < 10; i++ {
|
|
go func() {
|
|
for j := 0; j < n; j++ {
|
|
c <- new(T)
|
|
}
|
|
done <- true
|
|
}()
|
|
go func() {
|
|
for j := 0; j < n; j++ {
|
|
_ = (<-c).(*T)
|
|
usestack()
|
|
}
|
|
done <- true
|
|
}()
|
|
}
|
|
for i := 0; i < 20; i++ {
|
|
<-done
|
|
}
|
|
}
|