f375844342
I've noticed for a while that there is some duplicated and some useful information being put out in -W=3 mode after the comment marker (besides the position). dumpNodeHeader puts out a comment marker '#' before putting out the position of a node (which is for almost all nodes). Therefore, we shouldn't print out anything on the same line after calling dumpNodeHeader(). But we happen to be putting out a duplicate type of the node in some cases. Also, we put out the Sym() associate with the node after dumpNodeHeader(). So, I got rid of the duplicate type print-out, and moved the print-out of n.Sym() to be inside dumpNodeHeader() before the position information. Also, moved the tc flag to be right after the type information, which seems like it makes more sense. Change-Id: I05210fbf9f3b2d8e3b73fc0ceab26a7bce5dc104 Reviewed-on: https://go-review.googlesource.com/c/go/+/354355 Run-TryBot: Dan Scales <danscales@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Dan Scales <danscales@google.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> |
||
---|---|---|
.github | ||
api | ||
doc | ||
lib/time | ||
misc | ||
src | ||
test | ||
.gitattributes | ||
.gitignore | ||
AUTHORS | ||
codereview.cfg | ||
CONTRIBUTING.md | ||
CONTRIBUTORS | ||
LICENSE | ||
PATENTS | ||
README.md | ||
SECURITY.md |
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.