mirror of
https://github.com/golang/go
synced 2024-11-05 14:56:10 -07:00
f2c07d7d8e
The gopls daemon had different default logging behavior than the sidecar gopls: by default, the daemon was started with -logfile=auto. Additionally, because most logs are reflected back to the forwarder, the actual daemon logs have very little (if any) information. This means that if you simply start gopls with -remote=auto, you'll get a single logfile named /tmp/gopls-<pid>.log, which is mostly empty. This is not a delightful experience. Fix this via several improvements: + Log lifecycle events in the Daemon, to give the log a purpose. + Give the daemon a new default log location: /tmp/gopls-daemon-<pid>.log. + Don't pass -logfile=auto to the daemon by default. Fixes golang/go#40105 Change-Id: I5e91ea98b4968c512bce76a596bbae441f461a66 Reviewed-on: https://go-review.googlesource.com/c/tools/+/241440 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> |
||
|---|---|---|
| .. | ||
| acme.md | ||
| analyzers.md | ||
| atom.md | ||
| command-line.md | ||
| contributing.md | ||
| daemon.md | ||
| design.md | ||
| emacs.md | ||
| faq.md | ||
| implementation.md | ||
| integrating.md | ||
| settings.md | ||
| status.md | ||
| subl.md | ||
| troubleshooting.md | ||
| user.md | ||
| vim.md | ||
| vscode.md | ||