mirror of
https://github.com/golang/go
synced 2024-11-14 08:50:22 -07:00
91e782106e
The current -asan option does not print where the error occurred. The reason is that the current implementation calls incorrect asan runtime functions, which do not pass sp and pc where asan runtime functions are called, and report the stack trace from the native code. But asan runtime functions are called from cgo on a separated stack, so it cannot dump the Go stack trace correctly. The correct asan runtime function we should call is __asan_report_error, which will pass sp and pc, and report where the error occurred correctly. This patch fixes this issue. Add the test cases. Fixes #50362 Change-Id: I12ee1d46c7ae069ddef3d23f2fe86e112db60045 Reviewed-on: https://go-review.googlesource.com/c/go/+/374395 Trust: Fannie Zhang <Fannie.Zhang@arm.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
29 lines
500 B
Go
29 lines
500 B
Go
// Copyright 2021 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
/*
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
|
|
int *p;
|
|
int* test() {
|
|
p = (int *)malloc(2 * sizeof(int));
|
|
free(p);
|
|
return p;
|
|
}
|
|
*/
|
|
import "C"
|
|
import "fmt"
|
|
|
|
func main() {
|
|
// C passes Go an invalid pointer.
|
|
a := C.test()
|
|
// Use after free
|
|
*a = 2 // BOOM
|
|
// We shouldn't get here; asan should stop us first.
|
|
fmt.Println(*a)
|
|
}
|