1
0
mirror of https://github.com/golang/go synced 2024-11-18 17:14:45 -07:00
go/internal/lsp/source
Muir Manders f26c0dd982 internal/lsp/source: improve unimported package member ranking
Untyped members from unimported packages are scored the same as typed
members from unimported packages. We depended on the unimported
package relevance to rank the probably-more-relevant typed members
higher. However, there are some unrelated score penalties that can
only be applied to typed candidates, so the untyped candidates ended
up being ranked higher. Fix by increasing the relevance coefficient so
the relevance score overpowers other less important scoring
adjustments.

Fixes golang/go#38104.

Change-Id: Ie43f769a41511f9cc3747ce6936130be7a29cd31
Reviewed-on: https://go-review.googlesource.com/c/tools/+/231238
Run-TryBot: Muir Manders <muir@mnd.rs>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-04-30 22:11:53 +00:00
..
code_lens.go x/tools/gopls: run go generate through CodeLens 2020-03-17 04:34:34 +00:00
comment_test.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
comment.go internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
completion_builtin.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
completion_format.go internal/lsp: handle different package names in signature help 2020-04-27 20:59:12 +00:00
completion_keywords.go internal/lsp/source: offer loop keyword completions in range stmt 2020-03-12 04:57:24 +00:00
completion_labels.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
completion_literal.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
completion_snippet.go internal/lsp: merge completion options into source.Options 2020-01-13 20:09:44 +00:00
completion_statements.go internal/lsp/source: offer completion "if err != nil { return err }" 2020-03-10 21:06:53 +00:00
completion.go internal/lsp/source: improve unimported package member ranking 2020-04-30 22:11:53 +00:00
deep_completion.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
diagnostics.go Revert "internal/lsp: hide analysis diagnostics from generated files" 2020-04-30 19:28:56 +00:00
folding_range.go internal/lsp/cache: add file contents to ParseGoHandle 2020-02-13 05:05:14 +00:00
format_test.go internal/lsp/source: trim file very carefully 2020-01-17 20:34:13 +00:00
format.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
highlight.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
hover.go internal/lsp: handle hover documentation for package declarations 2020-04-29 20:57:41 +00:00
identifier.go internal/lsp: handle hover documentation for package declarations 2020-04-29 20:57:41 +00:00
implementation.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
options.go Revert "internal/lsp: hide analysis diagnostics from generated files" 2020-04-30 19:28:56 +00:00
references.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
rename_check.go internal/lsp/source: remove unused parameters from functions 2020-03-27 18:57:18 +00:00
rename.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
signature_help.go internal/lsp: handle hover documentation for package declarations 2020-04-29 20:57:41 +00:00
source_test.go internal/lsp: fix imports issue with duplicate package decl 2020-04-16 06:17:24 +00:00
symbols.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
types_format.go internal/lsp: handle hover documentation for package declarations 2020-04-29 20:57:41 +00:00
util.go internal/lsp: refactor code for formatting signatures 2020-04-22 20:52:58 +00:00
view.go internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
workspace_symbol.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00