Muir Manders f217c98fae internal/lsp: fix completion insertion ... The insertion range for completion items was not right. The range's end was 1 before the start. Fix by taking into account the length of the prefix when generating the range start and end. Now instead of a "prefix", we track the completion's "surrounding". This is basically the start and end of the abutting identifier along with the cursor position. When we insert the completion text, we overwrite the entire identifier, not just the prefix. This fixes postfix completion like completing "foo.<>Bar" to "foo.BarBaz". Fixes golang/go#32078 Fixes golang/go#32057 Change-Id: I9d065a413ff9a6e20ae662ff93ad0092c2007c1d GitHub-Last-Rev: af5ab4d60566bf0589d9a712c80d75280178cba9 GitHub-Pull-Request: golang/tools#103 Reviewed-on: https://go-review.googlesource.com/c/tools/+/177757 Run-TryBot: Ian Cottrell <iancottrell@google.com> Reviewed-by: Ian Cottrell <iancottrell@google.com>		2019-05-17 18:32:58 +00:00
..
analyzer	internal/lsp: fix badly formatted error messages from go vet	2019-04-16 19:41:54 +00:00
anon	internal/lsp: add additional tests for completion	2018-12-19 22:27:14 +00:00
bad	internal/lsp: adding the test suite to the source package	2019-05-10 20:20:41 +00:00
badstmt	internal/lsp: handle completion after defer, go statements	2019-04-24 22:01:01 +00:00
bar	internal/lsp: fix composite literal completion	2019-05-13 22:24:33 +00:00
basiclit	internal/lsp: suppress more completions in comments and literals	2019-04-24 20:52:08 +00:00
baz	internal/lsp: suppress more completions in comments and literals	2019-04-24 20:52:08 +00:00
builtins	internal/lsp: support builtin types without hardcoding	2019-05-01 04:50:30 +00:00
cast	internal/lsp: add more testdata for completion and diagnostics	2018-11-20 06:06:34 +00:00
channel	internal/lsp: handle more expected type cases	2019-05-16 16:26:11 +00:00
comments	internal/lsp: suppress more completions in comments and literals	2019-04-24 20:52:08 +00:00
complit	internal/lsp: fix composite literal completion	2019-05-13 22:24:33 +00:00
constant	internal/lsp: remove constant value from label and add tests	2019-05-15 19:19:14 +00:00
errors	internal/lsp: add additional tests for completion	2018-12-19 22:27:14 +00:00
foo	internal/lsp: add definition support for packages	2019-05-10 15:10:30 +00:00
format	internal/lsp: switch golden files to use txtar	2019-05-08 14:59:27 +00:00
func_rank	internal/lsp: handle more expected type cases	2019-05-16 16:26:11 +00:00
godef	internal/lsp: support definitions and hover for builtins	2019-05-17 00:35:10 +00:00
good	internal/lsp: adding the test suite to the source package	2019-05-10 20:20:41 +00:00
highlights	internal/lsp: add support for document highlight	2019-03-26 19:08:20 +00:00
importedcomplit	internal/lsp: fix composite literal completion	2019-05-13 22:24:33 +00:00
index	internal/lsp: handle more expected type cases	2019-05-16 16:26:11 +00:00
links	internal/lsp: add document link handling for import paths to godoc	2019-05-03 18:56:57 +00:00
nested_complit	internal/lsp: improve composite literal completion	2019-04-23 22:28:03 +00:00
nodisk	internal/lsp: a cleaner way of doing overlays	2019-04-17 21:35:05 +00:00
noparse	internal/lsp: connect basic analysis functionality	2019-02-06 21:48:25 +00:00
noparse_format	internal/lsp: switch golden files to use txtar	2019-05-08 14:59:27 +00:00
rank	internal/lsp: handle more expected type cases	2019-05-16 16:26:11 +00:00
selector	internal/lsp: add more testdata for completion and diagnostics	2018-11-20 06:06:34 +00:00
signature	internal/lsp: use builtin package for signature help	2019-05-15 13:46:40 +00:00
snippets	internal/lsp: fix completion insertion	2019-05-17 18:32:58 +00:00
symbols	internal/lsp: make interface methods children of the interface symbol	2019-04-24 02:46:01 +00:00
testy	internal/lsp: connect basic analysis functionality	2019-02-06 21:48:25 +00:00
types	internal/lsp: add more testdata for completion and diagnostics	2018-11-20 06:06:34 +00:00